D7146: [RFC] grep: add config option to grep PWD by default

mharbison72 added a comment. I lean towards searching the whole repo by default, for the reasons that Jordi listed, especially consistency with other hg commands. I almost never `hg grep` from the command line, and typically search in TortoiseHg instead. But there, I always want it to

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added inline comments. INLINE COMMENTS > commands.py:6774 > +if not revs and not change: > +# Avoid loading obsmarkers if we're accessing only the working copy > +# parent (which will never be hidden). Are you using the evolve extension. If so you should -already-

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. In D7144#105039 , @marmoute wrote: > I have a couple of questions: > > - Can we get performance number with about without this patch ? (to gauge the relative gain) Will get that later (I have ~2 weeks

D7144: status: use unfiltered repo if we're getting status of working copy

pulkit added a comment. I am +1 on this idea. I see @marmoute has some concerns around extensions wrapping, once they are addressed, I will push it once the freeze ends. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL

D7149: export: use unfiltered repo if we're exporting the working copy parent

marmoute added a comment. Do you have performance number for this? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7149/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7149 To: martinvonz, #hg-reviewers Cc: marmoute, mercurial-devel

D7148: annotate: use unfiltered repo if we're annotating the working copy

marmoute added a comment. Do you have performance number for this ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7148/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7148 To: martinvonz, #hg-reviewers Cc: marmoute, mercurial-devel

D7147: diff: use unfiltered repo if we're diffing the working copy

marmoute added a comment. Do you have performance number for this ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7147/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7147 To: martinvonz, #hg-reviewers Cc: marmoute, mercurial-devel

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added a comment. I have a couple of questions: - Can we get performance number with about without this patch ? (to gauge the relative gain) - This could cause issue to extensions, can we abtract the unfiltering though a function so that extension can rewrap it ? REPOSITORY

D7149: export: use unfiltered repo if we're exporting the working copy parent

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Same reasoning as in the previous patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7149 AFFECTED FILES

D7148: annotate: use unfiltered repo if we're annotating the working copy

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Same reasoning as in the previous patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7148 AFFECTED FILES

D7147: diff: use unfiltered repo if we're diffing the working copy

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Same reasoning as in the previous patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7147 AFFECTED FILES

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz updated this revision to Diff 17367. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7144?vs=17356=17367 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7144 AFFECTED

D7145: status: move initialization closer together

martinvonz updated this revision to Diff 17366. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7145?vs=17357=17366 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7145/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7145 AFFECTED

D7146: [RFC] grep: add config option to grep PWD by default

durin42 added a comment. (Note that post-5.2 is probably too late to make this tweak, so there's some urgency in this discussion.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7146/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7146 To:

D7146: [RFC] grep: add config option to grep PWD by default

durin42 added a comment. Huh, this behavior of `git grep` surprises me, but not _that_ much. We do already print PWD-relative paths if `tweakdefaults` is active, right? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7146/new/ REVISION DETAIL

D7146: [RFC] grep: add config option to grep PWD by default

jeffpc added a comment. I'm the instigator of the IRC discussion, so I'll summarize my reasoning here as well. Based on years of working on various sw projects, I've concluded that about 90% of the time I want to grep $PWD and the remaining 10% of the time I want to grep the whole

D7146: [RFC] grep: add config option to grep PWD by default

JordiGH added a comment. I will repeat my position as stated on IRC. I am against this change because, 1. it's inconsistent with shelve, commit, addremove, status, diff and all other operations that by default work on the entire repo 2. it's difficult to go from this proposed default

D7146: [RFC] grep: add config option to grep PWD by default

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is motivated by a disscussion on IRC. TODO: need to add tests, register config option and add docs. Tests are not ran on this yet. REPOSITORY rHG

mercurial@43316: 3 new changesets (3 on stable)

3 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/8676a8b2d20a changeset: 43314:8676a8b2d20a branch: stable user:Gregory Szorc date:Mon Oct 21 19:25:06 2019 -0700 summary: contrib: install Python 2.7.17 and 3.7.5 in Windows

Re: [PATCH] grep: warn on censored revisions instead of erroring out

On Tue, 2019-10-22 at 10:39 +0900, Yuya Nishihara wrote: > On Mon, 21 Oct 2019 16:10:58 -0400, Jordi Gutiérrez Hermoso wrote: > > # HG changeset patch > > # User Jordi Gutiérrez Hermoso > > # Date 1571688404 14400 > > # Mon Oct 21 16:06:44 2019 -0400 > > # Node ID

[PATCH 1 of 2 V2] grep: warn on censored revisions instead of erroring out

# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1571752600 14400 # Tue Oct 22 09:56:40 2019 -0400 # Node ID 386e0a956ae57a95d62330c95497d7460761f3fd # Parent d782cce137fd1d50cccfecf8ccb17a623fde8800 grep: warn on censored revisions instead of erroring out We need most of the

[PATCH 2 of 2 V2] censor: document that some commands simply ignore censored data

# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1571752908 14400 # Tue Oct 22 10:01:48 2019 -0400 # Node ID 2bf40680a6362c44c183f17572f24d6ec086a3c6 # Parent 386e0a956ae57a95d62330c95497d7460761f3fd censor: document that some commands simply ignore censored data I can't see a

mercurial@43313: 4 new changesets (4 on stable)

4 new changesets (4 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7574ccd87200 changeset: 43310:7574ccd87200 branch: stable user:Denis Laxalde date:Mon Oct 21 10:59:54 2019 +0200 summary: packaging: upgrade Debian packaging to build with Python 3

Re: [PATCH 7 of 7] rust-cpython: mark all PyLeaked methods as unsafe

On Tue, 22 Oct 2019 14:43:53 +0200, Raphaël Gomès wrote: > On 10/22/19 10:11 AM, Yuya Nishihara wrote: > > diff --git a/rust/hg-cpython/src/ref_sharing.rs > > b/rust/hg-cpython/src/ref_sharing.rs > > --- a/rust/hg-cpython/src/ref_sharing.rs > > +++ b/rust/hg-cpython/src/ref_sharing.rs > > @@

Re: [PATCH 7 of 7] rust-cpython: mark all PyLeaked methods as unsafe

Nice series as always, everything makes sense to me. I will try to dogfood the new API a little bit more in the near future. On 10/22/19 10:17 AM, Yuya Nishihara wrote: On Tue, 22 Oct 2019 17:11:58 +0900, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1571727874

Re: [PATCH 3 of 3 STABLE] packaging: upgrade packages distributed with Windows installers

On Mon, 21 Oct 2019 22:52:16 -0700, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1571712810 25200 > # Mon Oct 21 19:53:30 2019 -0700 > # Branch stable > # Node ID e97ffa5511bae5577fb53cf72c8b3e2545d54c30 > # Parent 6a442f5632bf4e2c2f4ae4b6c5de914a741f0167 >

Re: [PATCH 7 of 7] rust-cpython: mark all PyLeaked methods as unsafe

On 10/22/19 10:11 AM, Yuya Nishihara wrote: Anyway, this seems not an easy issue, so it's probably better to leave the current interface as unsafe, and get broader comments while upstreaming this feature. Yes, this is unfortunate indeed. I'm all for starting the upstreaming process soon as I

Re: [PATCH 7 of 7] rust-cpython: mark all PyLeaked methods as unsafe

On Tue, 22 Oct 2019 17:11:58 +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1571727874 -32400 > # Tue Oct 22 16:04:34 2019 +0900 > # Node ID 779af7c0979780d03451dd7cfe303e8dc64c6576 > # Parent 29399437267567957a97dc9d924704ca748e3cec > rust-cpython:

[PATCH 7 of 7] rust-cpython: mark all PyLeaked methods as unsafe

# HG changeset patch # User Yuya Nishihara # Date 1571727874 -32400 # Tue Oct 22 16:04:34 2019 +0900 # Node ID 779af7c0979780d03451dd7cfe303e8dc64c6576 # Parent 29399437267567957a97dc9d924704ca748e3cec rust-cpython: mark all PyLeaked methods as unsafe Unfortunately, these methods can be

[PATCH 5 of 7] rust-cpython: inline PySharedState::leak_immutable() and PyLeaked::new()

# HG changeset patch # User Yuya Nishihara # Date 1571471314 -32400 # Sat Oct 19 16:48:34 2019 +0900 # Node ID 253a5f9f8ed37f696073bcfc9be87bf5fddbfd57 # Parent e842b9628b92f587a8be0cfb03bb9be5ac095494 rust-cpython: inline PySharedState::leak_immutable() and PyLeaked::new() For the same

[PATCH 6 of 7] rust-cpython: make PySharedRef::try_borrow_mut() return BorrowMutError

# HG changeset patch # User Yuya Nishihara # Date 1571472088 -32400 # Sat Oct 19 17:01:28 2019 +0900 # Node ID 29399437267567957a97dc9d924704ca748e3cec # Parent 253a5f9f8ed37f696073bcfc9be87bf5fddbfd57 rust-cpython: make PySharedRef::try_borrow_mut() return BorrowMutError As I said, it

[PATCH 3 of 7] rust-cpython: add panicking version of borrow_mut() and use it

# HG changeset patch # User Yuya Nishihara # Date 1570890845 -32400 # Sat Oct 12 23:34:05 2019 +0900 # Node ID 09d7cbe828f5dc1512e0e903be2c7b832a2c5834 # Parent 60f38cb20db37d6114eeaaf8b07d9f0724b64a01 rust-cpython: add panicking version of borrow_mut() and use it The original borrow_mut()

[PATCH 4 of 7] rust-cpython: inline PySharedState::try_borrow_mut()

# HG changeset patch # User Yuya Nishihara # Date 1571470442 -32400 # Sat Oct 19 16:34:02 2019 +0900 # Node ID e842b9628b92f587a8be0cfb03bb9be5ac095494 # Parent 09d7cbe828f5dc1512e0e903be2c7b832a2c5834 rust-cpython: inline PySharedState::try_borrow_mut() Since the core borrowing/leaking

[PATCH 2 of 7] rust-cpython: make sure PySharedRef::borrow_mut() never panics

# HG changeset patch # User Yuya Nishihara # Date 1569054434 -32400 # Sat Sep 21 17:27:14 2019 +0900 # Node ID 60f38cb20db37d6114eeaaf8b07d9f0724b64a01 # Parent 5114ca405279d3bcc29b0c784d48d4cc4bc18481 rust-cpython: make sure PySharedRef::borrow_mut() never panics Since it returns a

[PATCH 1 of 7] rust-cpython: remove useless wrappers from PyLeaked, just move by map()

# HG changeset patch # User Yuya Nishihara # Date 1571711923 -32400 # Tue Oct 22 11:38:43 2019 +0900 # Node ID 5114ca405279d3bcc29b0c784d48d4cc4bc18481 # Parent 8d5489b048b77debe66b63b9df0804327edcd862 rust-cpython: remove useless wrappers from PyLeaked, just move by map() While Option was

mercurial@43309: new changeset (1 on stable)

New changeset (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b4b1131187c4 changeset: 43309:b4b1131187c4 branch: stable bookmark:@ tag: tip user:Denis Laxalde date:Mon Oct 21 11:26:41 2019 +0200 summary: py3: decode bytes before

[PATCH 3 of 3 STABLE] packaging: upgrade packages distributed with Windows installers

# HG changeset patch # User Gregory Szorc # Date 1571712810 25200 # Mon Oct 21 19:53:30 2019 -0700 # Branch stable # Node ID e97ffa5511bae5577fb53cf72c8b3e2545d54c30 # Parent 6a442f5632bf4e2c2f4ae4b6c5de914a741f0167 packaging: upgrade packages distributed with Windows installers We like to

[PATCH 2 of 3 STABLE] automation: install Python 2.7.17, 3.7.5, and PyPy 7.2.0

# HG changeset patch # User Gregory Szorc # Date 1571711303 25200 # Mon Oct 21 19:28:23 2019 -0700 # Branch stable # Node ID 6a442f5632bf4e2c2f4ae4b6c5de914a741f0167 # Parent 4646f3df342969d29fca59c594b010d88493936b automation: install Python 2.7.17, 3.7.5, and PyPy 7.2.0 These were all