Re: [PATCH 7 of 7 stable] packaging: fix buildrpm whitespace

2019-10-30 Thread Mads Kiilerich
On 10/30/19 9:14 PM, Augie Fackler wrote: On Mon, Oct 28, 2019 at 12:37:15AM +0100, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1572203819 -3600 # Sun Oct 27 20:16:59 2019 +0100 # Branch stable # Node ID c84f1465c44ebc539b803b876206712e0ebd78b4 # Parent 8c18adc

D7151: setup: allow py3 install without env vars

2019-10-30 Thread Kwan (Ian Moody)
Closed by commit rHG3733533c22a4: setup: allow py3 install without env vars (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LA

D7152: phabricator: use True primitive instead of b'true' for phabupdate actions

2019-10-30 Thread Kwan (Ian Moody)
Closed by commit rHGe57bf37eaeb5: phabricator: use True primitive instead of b'true' for phabupdate actions (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7180: tests: fix typo "includfe"

2019-10-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7180 AFFECTED FILES tests/test-match.py CHANGE DETAILS diff --git a/tests/test-match.py b/tests/te

D7144: status: use unfiltered repo if we're getting status of working copy

2019-10-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7144#105248 , @mharbison72 wrote: > The comment about maybe affecting extensions made me think of df463ca0adef . I never figured out

[PATCH 3 of 3 STABLE] mail: black wants to add this blank line

2019-10-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1572467958 14400 # Wed Oct 30 16:39:18 2019 -0400 # Branch stable # Node ID 8ab6c4d652ee5ec4ec3e386261067a236385a53f # Parent 4ec0fed0eeeb1e8c1a7cd7041325d4733e26016a mail: black wants to add this blank line I can't figure out how this got ov

[PATCH 1 of 3 STABLE] contrib: fix up example fix configuration for our move to released black

2019-10-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1572466659 14400 # Wed Oct 30 16:17:39 2019 -0400 # Branch stable # Node ID 0dc1b2cc8e1784b059728c9d9decaf58a50937ae # Parent 2278f79e85e96a5ca389f77c47d92a3dc9348443 contrib: fix up example fix configuration for our move to released black di

[PATCH 2 of 3 STABLE] hghave: verify we have a black that is new enough for our format

2019-10-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1572467385 14400 # Wed Oct 30 16:29:45 2019 -0400 # Branch stable # Node ID 4ec0fed0eeeb1e8c1a7cd7041325d4733e26016a # Parent 0dc1b2cc8e1784b059728c9d9decaf58a50937ae hghave: verify we have a black that is new enough for our format We require

Re: [PATCH 3 of 3 STABLE] formatting: drop `grey`, our custom black version

2019-10-30 Thread Augie Fackler
On Tue, Oct 29, 2019 at 12:08:58PM +0100, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1572343645 -3600 > # Tue Oct 29 11:07:25 2019 +0100 > # Branch stable > # Node ID 17c367aaedbc1f72e6d5b19fb1de8828a1dca3ab > # Parent 0e9acc6539a0d23b2a7428ad86cc4fa7

Re: [PATCH 2 of 2 STABLE V3] py3: fix patchbomb to accept non-ASCII header value for email preview

2019-10-30 Thread Augie Fackler
On Wed, Oct 30, 2019 at 10:02:23PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1572439788 -32400 > # Wed Oct 30 21:49:48 2019 +0900 > # Branch stable > # Node ID 3b53b4da70668d5abd27993778fe2da0606aca45 > # Parent e7add06518eeebeb236a97ab051bb55e95c59

Re: [PATCH 7 of 7 stable] packaging: fix buildrpm whitespace

2019-10-30 Thread Augie Fackler
On Mon, Oct 28, 2019 at 12:37:15AM +0100, Mads Kiilerich wrote: > # HG changeset patch > # User Mads Kiilerich > # Date 1572203819 -3600 > # Sun Oct 27 20:16:59 2019 +0100 > # Branch stable > # Node ID c84f1465c44ebc539b803b876206712e0ebd78b4 > # Parent 8c18adcd0177f3ca35f7f20f52f27f5a13ac9f

D7144: status: use unfiltered repo if we're getting status of working copy

2019-10-30 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D7144#105048 , @martinvonz wrote: > In D7144#105039 , @marmoute wrote: > >> I have a couple of questions: >> >> […] >> >> - This could cause issue to

D7176: rebase: allow rebasing obsolete commit without successor

2019-10-30 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute added subscribers: khanchi97, marmoute. That is not necessarly True, If the changeset is pruned, but successors of a public changeset, rebasing it would create phase-divergence. @khanchi97 fixed similar cases in September. Overall, we should migrate the

Re: [PATCH 2 of 2 STABLE V3] py3: fix patchbomb to accept non-ASCII header value for email preview

2019-10-30 Thread Denis Laxalde
Yuya Nishihara a écrit : > # HG changeset patch > # User Yuya Nishihara > # Date 1572439788 -32400 > # Wed Oct 30 21:49:48 2019 +0900 > # Branch stable > # Node ID 3b53b4da70668d5abd27993778fe2da0606aca45 > # Parent e7add06518eeebeb236a97ab051bb55e95c591b8 > py3: fix patchbomb to accept non-

Re: [PATCH 2 of 2 STABLE] py3: use native strings when forming email headers in patchbomb

2019-10-30 Thread Denis Laxalde
Yuya Nishihara a écrit : > > Nevertheless, I still think this change here is worth. I'm fine if it > > goes into default or if it waits after the release. Just let me know the > > plan. > > I also want to remove this TODO, but I don't think inserting many > strfromlocal()s is the best way to do th

D7179: revset: simplify checkstatus() by using any()

2019-10-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7179 AFFECTED FILES mercurial/revset.py CHANGE DETAILS diff --git a/mercurial/revset.py b/mercuria

D7178: [RFC] rust-matchers: add `Matcher` trait and implement `AlwaysMatcher`

2019-10-30 Thread kevincox (Kevin Cox)
kevincox added a comment. I see a lot of the functions are here to give optimization hints. In order to make someone non-familiar with the code able to understand it each method should state the contracts that it is making. I am having a really hard time reconciling how the different functio

[PATCH 2 of 2 STABLE V3] py3: fix patchbomb to accept non-ASCII header value for email preview

2019-10-30 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1572439788 -32400 # Wed Oct 30 21:49:48 2019 +0900 # Branch stable # Node ID 3b53b4da70668d5abd27993778fe2da0606aca45 # Parent e7add06518eeebeb236a97ab051bb55e95c591b8 py3: fix patchbomb to accept non-ASCII header value for email preview Sin

[PATCH 1 of 2 STABLE V3] tests: check patchbomb with a non-ascii commit message

2019-10-30 Thread Yuya Nishihara
# HG changeset patch # User Denis Laxalde # Date 1571998245 -7200 # Fri Oct 25 12:10:45 2019 +0200 # Branch stable # Node ID e7add06518eeebeb236a97ab051bb55e95c591b8 # Parent 8fda98a6842709c26b61747c7420b28cd874755e tests: check patchbomb with a non-ascii commit message This fails on Python

D7178: [RFC] rust-matchers: add `Matcher` trait and implement `AlwaysMatcher`

2019-10-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. martinvonz added subscribers: spectral, martinvonz. INLINE COMMENTS > matchers.rs:19-22 > +Recursive, > +Empty, > +Set(HashSet), // Should we implement a `NonEmptyHashSet`? > +This, Could you add a comment explaining what each value means? (I *t