D7321: revlog: deal with nodemap deletion within the index

martinvonz added a comment. In D7321#107839 , @marmoute wrote: > In D7321#107805 , @martinvonz wrote: > >> I get a traceback from `test-copytrace-heuristics.t` with this patch. > > Well… I d

D7362: revlog: deprecate direct `nodemap` access

marmoute updated this revision to Diff 17863. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7362?vs=17785&id=17863 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7362/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7362 AFFECTED FILE

D7359: perf: make `perfphasesremote` use the new `index.has_node` api

marmoute updated this revision to Diff 17860. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7359?vs=17782&id=17860 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7359/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7359 AFFECTED FILE

D7360: perf: make `perfrevlogindex` use the new `index.rev` api if available

marmoute updated this revision to Diff 17861. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7360?vs=17783&id=17861 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7360/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7360 AFFECTED FILE

D7361: revlog: drop special hack in the `nodemap` property

marmoute updated this revision to Diff 17862. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7361?vs=17784&id=17862 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7361/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7361 AFFECTED FILE

D7358: perf: make `perfnodemap` use the new `index.get_rev` api if available

marmoute updated this revision to Diff 17859. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7358?vs=17781&id=17859 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7358/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7358 AFFECTED FILE

D7354: index: use `index.get_rev` in `histedit.processreplacement`

marmoute updated this revision to Diff 17855. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7354?vs=1&id=17855 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7354/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7354 AFFECTED FILE

D7355: index: use `index.has_node` in `phabricator.getoldnodedrevmap`

marmoute updated this revision to Diff 17856. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7355?vs=17778&id=17856 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7355/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7355 AFFECTED FILE

D7356: index: use `index.has_node` in `infinitypush`

marmoute updated this revision to Diff 17857. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7356?vs=17779&id=17857 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7356/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7356 AFFECTED FILE

D7357: index: use `index.get_rev` in `remotefilelog`

marmoute updated this revision to Diff 17858. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7357?vs=17780&id=17858 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7357/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7357 AFFECTED FILE

D7353: index: use `index.get_rev` in `histedit.adjustreplacementsfrommarkers`

marmoute updated this revision to Diff 17854. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7353?vs=17776&id=17854 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7353 AFFECTED FILE

D7352: index: use `index.has_node` in `histedit.cleanupnode`

marmoute updated this revision to Diff 17853. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7352?vs=17775&id=17853 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7352/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7352 AFFECTED FILE

D7351: index: use `index.has_node` in `histedit._finishhistedit

marmoute updated this revision to Diff 17852. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7351?vs=17774&id=17852 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7351/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7351 AFFECTED FILE

D7350: index: use `index.get_rev` in `rebase._computeobsoletenotrebased`

marmoute updated this revision to Diff 17851. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7350?vs=17773&id=17851 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7350/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7350 AFFECTED FILE

D7347: index: use `index.get_rev` in `exchange._pullapplyphases`

marmoute updated this revision to Diff 17849. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7347?vs=17770&id=17849 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7347/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7347 AFFECTED FILE

D7346: index: use `index.has_node` in `exchange._pulldiscoverychangegroup`

marmoute updated this revision to Diff 17848. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7346?vs=17769&id=17848 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7346/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7346 AFFECTED FILE

D7349: index: use `index.get_rev` in `rebase.successorrevs`

marmoute updated this revision to Diff 17850. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7349?vs=17772&id=17850 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7349/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7349 AFFECTED FILE

D7345: index: use `index.rev` in `exchange.fallbackheads`

marmoute updated this revision to Diff 17847. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7345?vs=17768&id=17847 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7345/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7345 AFFECTED FILE

D7340: index: use `index.rev` in `bundlerepo.bundlerevlog`

marmoute updated this revision to Diff 17846. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7340?vs=17763&id=17846 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7340/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7340 AFFECTED FILE

D7329: index: use `index.has_node` in `repo._rollback`

marmoute updated this revision to Diff 17842. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7329?vs=17752&id=17842 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7329/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7329 AFFECTED FILE

D7339: index: use `index.has_node` in `bundlerepo.bundlerevlog`

marmoute updated this revision to Diff 17845. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7339?vs=17762&id=17845 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7339/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7339 AFFECTED FILE

D7336: index: use `index.get_rev` in `obsolete._computephasedivergentset`

marmoute updated this revision to Diff 17843. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7336?vs=17759&id=17843 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7336/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7336 AFFECTED FILE

D7337: index: use `index.get_rev` in `repoview.pinnedrevs`

marmoute marked an inline comment as done. marmoute updated this revision to Diff 17844. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7337?vs=17760&id=17844 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7337/new/ REVISION DETAIL https://

D7327: index: use `index.get_rev` in `localrepo.known`

marmoute updated this revision to Diff 17840. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7327?vs=17748&id=17840 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7327/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7327 AFFECTED FILE

D7328: index: use `index.has_node` in `revlog.addgroup`

marmoute updated this revision to Diff 17841. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7328?vs=17751&id=17841 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7328/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7328 AFFECTED FILE

D7326: index: add a `get_rev` method (API)

marmoute updated this revision to Diff 17839. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7326?vs=17823&id=17839 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7326/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7326 AFFECTED FILE

D7322: index: add a `has_node` method (API)

marmoute updated this revision to Diff 17835. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7322?vs=17820&id=17835 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7322/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7322 AFFECTED FILE

D7325: index: use `index.rev` in `revlog.rev`

marmoute updated this revision to Diff 17838. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7325?vs=17746&id=17838 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7325/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7325 AFFECTED FILE

D7324: index: add a `rev` method (API)

marmoute updated this revision to Diff 17837. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7324?vs=17822&id=17837 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7324/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7324 AFFECTED FILE

D7321: revlog: deal with nodemap deletion within the index

marmoute updated this revision to Diff 17834. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7321?vs=17738&id=17834 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7321/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7321 AFFECTED FILE

D7323: index: use `index.has_node` in `revlog.addrevision`

marmoute updated this revision to Diff 17836. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7323?vs=17744&id=17836 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7323/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7323 AFFECTED FILE

D7321: revlog: deal with nodemap deletion within the index

marmoute added a comment. In D7321#107805 , @martinvonz wrote: > I get a traceback from `test-copytrace-heuristics.t` with this patch. Well… I don't. Can you share some details? How are you running your tests? REPOSITORY rHG Mercurial

[PATCH 3 of 4] bookmarks: use changectx instead of remembering hex of hidden revision

# HG changeset patch # User Yuya Nishihara # Date 1573271040 -32400 # Sat Nov 09 12:44:00 2019 +0900 # Node ID 3e4a888ce13ae2737ef1facc3d1b00ed6f295e1a # Parent 2562eaf1bb72faf1b2383ef651f63be39b875e4f bookmarks: use changectx instead of remembering hex of hidden revision It should be bette

[PATCH 4 of 4] bookmarks: accept explicit -r 'wdir()' when adding new bookmarks (issue6218)

# HG changeset patch # User Yuya Nishihara # Date 1573271756 -32400 # Sat Nov 09 12:55:56 2019 +0900 # Node ID 295870673214e9b41425066559402618893ccd36 # Parent 3e4a888ce13ae2737ef1facc3d1b00ed6f295e1a bookmarks: accept explicit -r 'wdir()' when adding new bookmarks (issue6218) Even though

[PATCH 2 of 4] bookmarks: resolve target revision out of the bookmarks loop

# HG changeset patch # User Yuya Nishihara # Date 1573270340 -32400 # Sat Nov 09 12:32:20 2019 +0900 # Node ID 2562eaf1bb72faf1b2383ef651f63be39b875e4f # Parent a5d3b2b0f3ddcb858e5d6416d571fa0e8870a6dd bookmarks: resolve target revision out of the bookmarks loop The target revision doesn't

[PATCH 1 of 4] bookmarks: fix handling of multiple bookmarks with one to be deactivated

# HG changeset patch # User Yuya Nishihara # Date 1573268990 -32400 # Sat Nov 09 12:09:50 2019 +0900 # Node ID a5d3b2b0f3ddcb858e5d6416d571fa0e8870a6dd # Parent 67e15214213b46f483bb2827a522d46b3142e61f bookmarks: fix handling of multiple bookmarks with one to be deactivated Before, "hg book

mercurial@43504: new changeset

New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/a78a65c33b5a changeset: 43504:a78a65c33b5a bookmark:@ tag: tip user:Ian Moody date:Fri Oct 18 07:20:26 2019 +0100 summary: phabricator: use context manager form of progress in uploadchunks --

mercurial@43503: 3 new changesets

3 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b2f95f9d3588 changeset: 43501:b2f95f9d3588 user:Martin von Zweigbergk date:Thu Nov 07 03:46:48 2019 -0800 summary: fix: replace str() by b'%d' for formatting integer https://www.mercurial-scm.org/repo/

Re: [PATCH 3 of 3] histedit: render a rolled up description using the proper roll colours

On Thu, 07 Nov 2019 15:31:48 -0500, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1572477597 14400 > # Wed Oct 30 19:19:57 2019 -0400 > # Node ID 4d0d2d692de029b4838d8fc12a48004749db9480 > # Parent 47446180a5ee16af1c90bb20a8dca92fa9d5f794 > h

Re: [PATCH 1 of 3] histeditrule: split __str__ property into prefix and desc

On Thu, 07 Nov 2019 15:31:46 -0500, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1572478029 14400 > # Wed Oct 30 19:27:09 2019 -0400 > # Node ID 45aea2365bcb5f89d20bb1907d75175246da3d05 > # Parent ab9b0a20b9e6b7f1f16f643486ff20a6d44ca2d5 > h

D7311: utils: move the `dirs` definition in pathutil (API)

Closed by commit rHGe170e425c88d: utils: move the `dirs` definition in pathutil (API) (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT http

D7320: revlog: clean up the node of all revision stripped in the C code

Closed by commit rHG67e15214213b: revlog: clean up the node of all revision stripped in the C code (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7319: revlog: move nodemap update within the index code

Closed by commit rHGe04e21262f15: revlog: move nodemap update within the index code (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7319?vs=17735&id=17832 CHA

D7318: revlog: deprecate the _nodecache attribute (API)

Closed by commit rHGda4afbbbe44a: revlog: deprecate the _nodecache attribute (API) (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7318?vs=17734&id=17831 CHAN

D7317: revlog: access the nodemap through the index

Closed by commit rHG0c3e9ddb9f54: revlog: access the nodemap through the index (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7317?vs=17733&id=17830 CHANGES

D7314: revlog: no longer return the nodemap after parsing

Closed by commit rHG3d6507e78672: revlog: no longer return the nodemap after parsing (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7314?vs=17730&id=17827 CH

D7315: revlog: clarify which version use the older API in perf

Closed by commit rHGa94d8b95853c: revlog: clarify which version use the older API in perf (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7315?vs=17731&id=1782

D7316: revlog: return the nodemap as the nodecache

Closed by commit rHGc72464ccd3ca: revlog: return the nodemap as the nodecache (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7316?vs=17732&id=17829 CHANGES S

D7313: revlog: move the nodemap into the index object (for pure)

Closed by commit rHGcf5985770fdb: revlog: move the nodemap into the index object (for pure) (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercuri

D7312: revlog: introduce an explicit NodeMap class for pure code

Closed by commit rHG2385a4e0010e: revlog: introduce an explicit NodeMap class for pure code (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7312?vs=17728&id=17

D7321: revlog: deal with nodemap deletion within the index

martinvonz added a comment. I get a traceback from `test-copytrace-heuristics.t` with this patch. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7321/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7321 To: marmoute, indygreg, #hg-reviewers Cc:

D7166: packaging: ship all help .txt files on WiX

martinvonz added a comment. I get this test failure from this commit: @@ -223,11 +223,6 @@ $ ( testrepohgenv; "$PYTHON" wixxml.py help ) Not installed: -help/common.txt -help/hg-ssh.8.txt -help/hg.1.txt -help/hgignore.5.txt -hel

D7168: packaging: install .rc files to hgrc.d

martinvonz added a comment. In D7168#107789 , @mharbison72 wrote: > In D7168#107707 , @martinvonz wrote: > >> In D7168#105270 , @indygreg wrote: >

D7311: utils: move the `dirs` definition in pathutil (API)

martinvonz added a comment. FYI, I had to resolve some conflicts with Augie's recent patches for removing r'' prefixes and for consecutive slashes. I'm pretty sure I did it right, but take a look if you want. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.

D7311: utils: move the `dirs` definition in pathutil (API)

martinvonz added inline comments. INLINE COMMENTS > util.py:3494-3499 > def finddirs(path): > pos = path.rfind(b'/') > while pos != -1: > yield path[:pos] > pos = path.rfind(b'/', 0, pos) > yield b'' Could you follow up with a patch to move this one as well? RE

D7321: revlog: deal with nodemap deletion within the index

martinvonz added a comment. I think our comments up to here have been addressed (I'm pretty confident that the `start + 1` thing is correct), so I'll queue this part. The only thing left on the rest of the series is the module policy thing I just sent a comment about on the next patch. REPO

D7322: index: add a `has_node` method (API)

martinvonz added a comment. I think this needs to update the version number in `mercurial/cext/parsers.c` and in `mercurial/policy.py`. That will make hg fall back to pure code if it doesn't find the right version of the C code, making updating across this commit easier. REPOSITORY rHG Me

D7311: utils: move the `dirs` definition in pathutil (API)

marmoute edited the summary of this revision. marmoute retitled this revision from "utils: move the `dirs` definition in a dedicated module (API)" to "utils: move the `dirs` definition in pathutil (API)". marmoute updated this revision to Diff 17821. REPOSITORY rHG Mercurial CHANGES SINCE LAS

D7326: index: add a `get_rev` method (API)

marmoute updated this revision to Diff 17823. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7326?vs=17747&id=17823 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7326/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7326 AFFECTED FILE

D7324: index: add a `rev` method (API)

marmoute updated this revision to Diff 17822. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7324?vs=17745&id=17822 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7324/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7324 AFFECTED FILE

D7168: packaging: install .rc files to hgrc.d

mharbison72 added a comment. mharbison72 accepted this revision. In D7168#107707 , @martinvonz wrote: > In D7168#105270 , @indygreg wrote: > >> In D7168#105269

D7311: utils: move the `dirs` definition in a dedicated module (API)

martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in dirstateutil.py:14 > It explicitly mention dirstate and manifest. Both are scm related context. That's easy to fix, though. Just replace "dirstate or manifest" by "set of file paths". REPOSITORY rHG Mercurial CHANGES SINC

D7311: utils: move the `dirs` definition in a dedicated module (API)

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in dirstateutil.py:14 > But how is `dirs` not scm-agnostic? Oh, you mean the ugly `skip` thing? Can > we see if we can just remove that instead (move it outside of the class)? It explicitly mention dirstate and manifest. Both ar

D7325: index: use `index.rev` in `revlog.rev`

marmoute added a comment. marmoute requested review of this revision. See my answer in D7324 , I am keeping the same exception that previously raised for now. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7325/new

D7324: index: add a `rev` method (API)

marmoute added a comment. marmoute requested review of this revision. In D7324#107591 , @indygreg wrote: > The code is fine. But since I've already left a number of comments on this series, I thought I'd ask about raising a better exception th

D7322: index: add a `has_node` method (API)

marmoute updated this revision to Diff 17820. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7322?vs=17743&id=17820 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7322/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7322 AFFECTED FILE

D7322: index: add a `has_node` method (API)

marmoute added inline comments. INLINE COMMENTS > indygreg wrote in revlog.c:2071 > `index_contains()` can return `-1` in many cases (including invalid input), > which will cast to `True`. So this implementation needs improved. Good catch ! updating the patch. REPOSITORY rHG Mercurial CHANG

D7321: revlog: deal with nodemap deletion within the index

marmoute added a comment. marmoute requested review of this revision. regarding xrange: Same feedback as for D7313 , this is a non performance critical section since this is about `pure`. regarding the sentinel value: The revision we access during de

D7320: revlog: clean up the node of all revision stripped in the C code

marmoute added a comment. marmoute requested review of this revision. In D7320#107577 , @indygreg wrote: > The first element in the index is a sentinel entry for `nullid`. I suspect the `+1` here is meant to ignore that sentinel. The comment f

D7311: utils: move the `dirs` definition in a dedicated module (API)

martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in dirstateutil.py:14 > I feel like `pathutil.py` is mostly scm agnostic and I would rather keep it > this way. But how is `dirs` not scm-agnostic? Oh, you mean the ugly `skip` thing? Can we see if we can just remove that inste

D7313: revlog: move the nodemap into the index object (for pure)

marmoute added a comment. In D7313#107559 , @indygreg wrote: > This seems OK to me aside from the use of `range()`, which we don't want since `len()` can be massive and this could create perf problems on Python 2. I am not too convinced b

D7311: utils: move the `dirs` definition in a dedicated module (API)

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in dirstateutil.py:14 > Is `pathutil.py` an appropriate home for this instead of creating a new file? I feel like `pathutil.py` is mostly scm agnostic and I would rather keep it this way. REPOSITORY rHG Mercurial CHANGES SIN

D7337: index: use `index.get_rev` in `repoview.pinnedrevs`

marmoute added inline comments. marmoute marked 2 inline comments as done. INLINE COMMENTS > indygreg wrote in repoview.py:64 > Nevermind. This `get_rev()` can return `None`. Yeah, it is simpler to filter out None at the end than to do a lookup before adding to the set. REPOSITORY rHG Mercur

D7165: packaging: stop installing i18n files

Closed by commit rHGb7db6302af1f: packaging: stop installing i18n files (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LA

D7167: packaging: install contrib/mq.el on WiX

Closed by commit rHGb65fd2b43e0a: packaging: install contrib/mq.el on WiX (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D7166: packaging: ship all help .txt files on WiX

Closed by commit rHGe7896eaca05f: packaging: ship all help .txt files on WiX (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SIN

D7164: packaging: install hgk as hgk.tcl

Closed by commit rHG9f5eba23495f: packaging: install hgk as hgk.tcl (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST U

D7156: packaging: consolidate CLI functionality into packaging.py

Closed by commit rHGf2ef4f9367cb: packaging: consolidate CLI functionality into packaging.py (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT

D7163: packaging: add logo-droplets.svg

Closed by commit rHG29083459825b: packaging: add logo-droplets.svg (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST UP

D7161: packaging: always pass VERSION into Inno invocation

Closed by commit rHGcf5eaf24577f: packaging: always pass VERSION into Inno invocation (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CH

D7162: packaging: install documentation to doc/ directory

Closed by commit rHG6e1ca6d43ada: packaging: install documentation to doc/ directory (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHA

D7160: packaging: remove hg.exe.local file

Closed by commit rHGe8ab29e57d40: packaging: remove hg.exe.local file (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7159: packaging: stage installed files for Inno

Closed by commit rHGd2ea31a2546d: packaging: stage installed files for Inno (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINC

D7157: packaging: install and run Inno files in a build directory

Closed by commit rHG876a3dd74c8c: packaging: install and run Inno files in a build directory (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercur

D7158: packaging: process Inno Setup files with Jinja2

Closed by commit rHG04b862675439: packaging: process Inno Setup files with Jinja2 (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGE

D7155: packaging: clean up excess packages for Inno

Closed by commit rHG738909683719: packaging: clean up excess packages for Inno (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES S

D7168: packaging: install .rc files to hgrc.d

martinvonz added a comment. In D7168#105270 , @indygreg wrote: > In D7168#105269 , @mharbison72 wrote: > >> Is it a good idea to encourage people to modify the installation directory? I though

D7366: revlog: delete references to deleted nullid sentinel value

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We stopped keeping the nullid in the index in 781b2720d2ac (index: don't include

D7173: packaging: stage files and dynamically generate WiX installer

indygreg updated this revision to Diff 17805. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7173?vs=17406&id=17805 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7173/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7

D7173: packaging: stage files and dynamically generate WiX installer

indygreg added a comment. indygreg abandoned this revision. This has conflicts on rebase. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7173/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7173 To: indygreg, #hg-reviewers Cc: mercurial-devel _

D7154: tests: run black on run-tests.py

indygreg added a comment. indygreg abandoned this revision. This refactor landed elsewhere. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7154/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7154 To: indygreg, #hg-reviewers Cc: mercurial-devel

D7365: unshelve: correct help string; unshelve does not accept file list

Closed by commit rHGe0dcfdd1731b: unshelve: correct help string; unshelve does not accept file list (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7365?vs=178

D7364: repoview: use class literal for creating filteredchangelog

Closed by commit rHGd1b8fcc38991: repoview: use class literal for creating filteredchangelog (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7364?vs=17801&id

D7320: revlog: clean up the node of all revision stripped in the C code

martinvonz added a comment. In D7320#107577 , @indygreg wrote: > The first element in the index is a sentinel entry for `nullid`. I suspect the `+1` here is meant to ignore that sentinel. The comment for this function clearly calls out this b

D7365: unshelve: correct help string; unshelve does not accept file list

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The non-option arguments to `hg unshelve` are interpreted as the name of the shelve to unshelve, not the list of files to unshelve. While that functionality wo

D7337: index: use `index.get_rev` in `repoview.pinnedrevs`

This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > indygreg wrote in repoview.py:64 > Why was `pinned.discard(None)` added? Nevermind. This `get_rev()` can return `None`. REPOSITORY rHG Mercurial CHANGES SINCE L

D7342: index: use `index.has_node` in `tags.findglobaltags`

This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > tags.py:198 > +assert repo.changelog.index.has_node( > +head > ), b"tag cache returned bogus head %s" % short(head) `repo.changelog` in

D7337: index: use `index.get_rev` in `repoview.pinnedrevs`

indygreg added inline comments. INLINE COMMENTS > repoview.py:64 > +pinned.update(rev(t[0]) for t in tags.values()) > +pinned.discard(None) > return pinned Why was `pinned.discard(None)` added? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-s

mercurial@43500: 5 new changesets

5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/2ade00f3b03b changeset: 43496:2ade00f3b03b user:Augie Fackler date:Wed Nov 06 14:48:34 2019 -0500 summary: encoding: add comment-based type hints for pytype https://www.mercurial-scm.org/repo/hg/rev/6d

mercurial@43495: new changeset

New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/daade078f1f0 changeset: 43495:daade078f1f0 bookmark:@ tag: tip parent: 43494:5d40317d42b7 parent: 43460:be0f77fd274d user:Yuya Nishihara date:Fri Nov 08 23:26:50 2019 +0900 summary: m

  1   2   3   >