[Bug 6229] New: Incorrect version in hg-evolve package with Python 3

2019-11-24 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6229 Bug ID: 6229 Summary: Incorrect version in hg-evolve package with Python 3 Product: Mercurial Version: unspecified Hardware: PC OS: All Status: UNCONFIRMED

D7516: webutil: add missing argument to join()

2019-11-24 Thread mharbison72 (Matt Harbison)
Closed by commit rHG371765e775a2: webutil: add missing argument to join() (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7516: webutil: add missing argument to join()

2019-11-24 Thread yuja (Yuya Nishihara)
yuja added a comment. > It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It also might be a WIP, given the comment in `join()`. @yuja? `{sessionvars}` (with no `%template`) would crash without this change. Queued,

Re: D7516: webutil: add missing argument to join()

2019-11-24 Thread Yuya Nishihara
> It could be, since I didn’t see any callers either (but wasn’t sure if > there was templater magic in play here). It also might be a WIP, given the > comment in `join()`. @yuja? `{sessionvars}` (with no `%template`) would crash without this change. Queued, thanks.

D7516: webutil: add missing argument to join()

2019-11-24 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. mharbison72 added a subscriber: yuja. In D7516#110537 , @dlax wrote: > Looks like dead code It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It

D7517: filemerge: byteify the open() mode

2019-11-24 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7517#110547 , @dlax wrote: >> This is actually pycompat.open(), so it need bytes. > > I don't understand why this is needed. The default value for "mode" as bytes comes from a407f9009392

D7517: filemerge: byteify the open() mode

2019-11-24 Thread dlax (Denis Laxalde)
dlax added a comment. > This is actually pycompat.open(), so it need bytes. I don't understand why this is needed. The default value for "mode" as bytes comes from a407f9009392 , but I don't understand the

D7502: changectx: mark parent of changesets as non filtered

2019-11-24 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18387. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7502?vs=18367=18387 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7502/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7502 AFFECTED FILES

D7492: localrepo: also fastpath access to working copy parents when possible

2019-11-24 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18382. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7492?vs=18365=18382 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7492/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7492 AFFECTED FILES

D7501: changectx: use unfiltered changelog to walk ancestors in annotate

2019-11-24 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18386. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7501?vs=18366=18386 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7501 AFFECTED FILES

D7498: localrepo: also fast past the parents of working copies parents

2019-11-24 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18385. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7498?vs=18361=18385 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7498/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7498 AFFECTED FILES

D7495: localrepo: recognize trivial request for '.'

2019-11-24 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18384. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7495?vs=18360=18384 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7495/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7495 AFFECTED FILES

D7494: localrepo: fastpath access to "."

2019-11-24 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 18383. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7494?vs=18359=18383 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7494/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7494 AFFECTED FILES

D7481: localrepo: recognize trivial "null" queries in `anyrev`

2019-11-24 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D7481#110524 , @yuja wrote: >> +if specs == [b'null']: >> +return revset.baseset([nullrev]) > > This breaks `--config revsetalias.null=`. Nobody would care, but > I don't know why we're

D7516: webutil: add missing argument to join()

2019-11-24 Thread dlax (Denis Laxalde)
dlax added a comment. dlax accepted this revision. Looks like dead code REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7516/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7516 To: mharbison72, #hg-reviewers, dlax Cc: dlax, mercurial-devel