D7544: subrepo: use pycompat.open directly instead of importing open from pycompat

spectral added a comment. In D7544#110954 , @mharbison72 wrote: > I don't think this is correct, because `open` is imported from `pycompat` at the top of the file, and that will `sysstr()` the mode. But this does seem confusing- see D7517

D7544: subrepo: use pycompat.open directly instead of importing open from pycompat

spectral retitled this revision from "py3: remove incorrect b prefix on second argument to open in subrepo.py" to "subrepo: use pycompat.open directly instead of importing open from pycompat". spectral updated this revision to Diff 18468. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE h

D7545: py3: make a pycompat.osdevnull, use it in extdiff

mharbison72 added a comment. mharbison72 accepted this revision. LGTM REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7545/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7545 To: spectral, #hg-reviewers, mharbison72 Cc: mharbison72, mercurial-d

D7544: py3: remove incorrect b prefix on second argument to open in subrepo.py

mharbison72 added a comment. I don't think this is correct, because `open` is imported from `pycompat` at the top of the file, and that will `sysstr()` the mode. But this does seem confusing- see D7517 . REPOSITORY rHG Mercurial CHANGES SINCE LAST AC

D7545: py3: make a pycompat.osdevnull, use it in extdiff

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7545 AFFECTED FILES hgext/extdiff.py mercurial/pycompat.py tests/test-extdiff.t

D7544: py3: remove incorrect b prefix on second argument to open in subrepo.py

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7544 AFFECTED FILES mercurial/subrepo.py CHANGE DETAILS diff --git a/mercurial/sub

mercurial@43786: 49 new changesets (11 on stable)

49 new changesets (11 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/558f7585afcb changeset: 43738:558f7585afcb branch: stable user:Julien Cristau date:Fri Nov 29 18:49:59 2019 +0100 summary: test: don't put $BINDIR in $PATH for test-merge-tools.t h

D7542: mail: don't complain about a multi-word email.method

jcristau added a comment. jcristau planned changes to this revision. doh. Right you are. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7542/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7542 To: jcristau, #hg-reviewers Cc: yuja, mercurial-d

D7542: mail: don't complain about a multi-word email.method

yuja added a comment. > +command = procutil.shellsplit(method) > +if not (command and procutil.findexe(command[0])): This condition is correct, but `command[0]` would raise IndexError if `not command`. Maybe we'll need a helper function that does `shellsplit()` and

Re: D7542: mail: don't complain about a multi-word email.method

> +command = procutil.shellsplit(method) > +if not (command and procutil.findexe(command[0])): This condition is correct, but `command[0]` would raise IndexError if `not command`. Maybe we'll need a helper function that does `shellsplit()` and returns `command[0]` or `b''`. > -

[Bug 6235] New: hg pull hglib error

https://bz.mercurial-scm.org/show_bug.cgi?id=6235 Bug ID: 6235 Summary: hg pull hglib error Product: Mercurial Version: 5.2 Hardware: PC OS: Windows Status: UNCONFIRMED Severity: feature Priority