D7570: match: resolve filesets against the passed `cwd`, not the current one

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7570#111295 , @yuja wrote: >> if listsubrepos: >> for subpath in ctx.substate: >> >> - sm = ctx.sub(subpath).matchfileset(pat, badfn=badfn) >> >> +sm = ctx.sub(subpath).matchf

D7570: match: resolve filesets against the passed `cwd`, not the current one

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 18596. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7570?vs=18508&id=18596 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7570/new/ REVISION DETAIL https://phab.mercurial-scm.org/

D7570: match: resolve filesets against the passed `cwd`, not the current one

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. martinvonz added a subscriber: hooper. INLINE COMMENTS > mharbison72 wrote in test-fix.t:1336-1342 > I found a couple of things surprising here: > > 1. `.::` doesn't include fixing wdir() > 2. `.` isn't updated unless `-w` is specified > 3. `-w` doesn't alter `w

D7601: fuzz: fix test-fuzz-targets.t to run with python3

2019-12-10 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7601 AFFECTED FILES contrib/fuzz/dirstate_corpus.py contrib/fuzz/mpatch_corpus.py

D7600: fuzz: add a seed corpus for the dirs fuzzer

2019-12-10 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I was hoping to trigger an asan violation under Python 3 that some internal tests at Google found, but for some reason that's beyond me I can't seem to manage.

D7599: fuzz: clean up production of seed corpora

2019-12-10 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was getting out of hand. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7599 AFFECTED FILES contr

D7593: status: split morestatus data loading from display

2019-12-10 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. In D7593#111733 , @martinvonz wrote: > In D7593#111728 , @rdamazio wrote: > >> In D7593#111696 , @pulkit wrote: >> >>>

D7598: py3: fix a bytes vs str issue in remotefilelog extension

2019-12-10 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7598 AFFECTED FILES hgext/remotefilelog/fileserverclient.py CHANGE DETAILS diff --

D7597: dirs: fix out-of-bounds access in Py3

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The hack for mutating Python's variable-length integers that was ported to py3 in cb3048746dae

[PATCH 1 of 2] crecord: repurpose "a" key to toggle all selections (BC)

2019-12-10 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576015329 18000 # Tue Dec 10 17:02:09 2019 -0500 # Node ID bd10bc4bdb994b875040c0c58f1c341df66ddd46 # Parent ce088b38f92b6d480df2072dc45fb068443758dd crecord: repurpose "a" key to toggle all selections (BC) I really don't like "a".

[PATCH 2 of 2] crecord: remove toggleamend

2019-12-10 Thread Jordi Gutiérrez Hermoso
# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576015629 18000 # Tue Dec 10 17:07:09 2019 -0500 # Node ID fa825ca77328e397df683a91c8beeca7060bf726 # Parent bd10bc4bdb994b875040c0c58f1c341df66ddd46 crecord: remove toggleamend Previous commit removed its only calling site. diff

D7528: rust-matchers: add `FileMatcher` implementation

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > matchers.rs:129-132 > +/// assert_eq!(true, matcher.matches(HgPath::new(b"a.txt"))); > +/// assert_eq!(false, matcher.matches(HgPath::new(b"b.txt"))); > +/// assert_eq!(false, matcher.matches(HgPath::new(b"main.c"))); > +/// assert_eq!(true, mat

D7507: phabricator: add a "phabstatus" template keyword

2019-12-10 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18590. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7507?vs=18321&id=18590 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7507/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7507

D7506: phabricator: add a "phabstatus" show view

2019-12-10 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18589. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18338&id=18589 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7506

D7531: rust-matchers: add support for `explicitmatcher` in `dirstate.status`

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Did you mean s/explicitmatcher/exactmatcher/ in the description? Also, I thought you called it FileMatcher instead. What's the difference? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7531/new/ REVISION DETAIL https://p

D7118: rust-dirstatemap: remove additional lookups in traverse

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. What's the state of this patch? The description makes it sound like it's a Rust patch, but it only modifies Python code. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7118/new/ REVISION DETAIL https://phab.mercurial-scm.

D7595: status: outputting structured unfinished-operation information

2019-12-10 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 18588. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7595?vs=18562&id=18588 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7595/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7

D7593: status: split morestatus data loading from display

2019-12-10 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 18586. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7593?vs=18560&id=18586 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7593/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7

D7594: status: add template/json data about whether a file has unresolved conflicts

2019-12-10 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 18587. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7594?vs=18561&id=18587 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7594/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7

D7593: status: split morestatus data loading from display

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7593#111728 , @rdamazio wrote: > In D7593#111696 , @pulkit wrote: > >> I pushed @martinvonz D7591 , so these need to be reb

D7593: status: split morestatus data loading from display

2019-12-10 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. Just phabsended after a rebase onto hg-committed, let me know if that's not what you expected. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7593/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7593

D7593: status: split morestatus data loading from display

2019-12-10 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. In D7593#111696 , @pulkit wrote: > I pushed @martinvonz D7591 , so these need to be rebased. Thanks! Are you asking me to do something, or are you going to? This supersedes

D7595: status: outputting structured unfinished-operation information

2019-12-10 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added inline comments. INLINE COMMENTS > pulkit wrote in configitems.py:247 > IMO the whole morestatus functionality is already behind a config option, so > lets not have a config option just for that. > > But I am not sure whether this change is a BC or not. I believe @yuja might > h

D7526: rust-hg-path: add method to get part of a path relative to a prefix

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > hg_path.rs:438 > +let base = HgPath::new(b""); > +assert_eq!(Some(path), path.relative_to(base)); > + The argument order here feels backwards. I know some frameworks (like Java's JUnit) put the expected value first, but the def

D7579: tests: add test for Rust formatting

2019-12-10 Thread Raphaël Gomès
Alphare added a comment. In D7579#111704 , @durin42 wrote: > What are we depending on in the rustfmt settings that's nightly behavior? wrap_comments = true error_on_line_overflow = true Both depend on nightly. I can live wi

mercurial@43818: new changeset

2019-12-10 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/ce088b38f92b changeset: 43818:ce088b38f92b bookmark:@ tag: tip user:Gregory Szorc date:Sat Dec 07 13:06:25 2019 -0800 summary: rust: run rustfmt -- Repository URL: https://www.mercurial-scm.o

D7527: rust-matchers: add doctests for `AlwaysMatcher`

2019-12-10 Thread Raphaël Gomès
Closed by commit rHG542c8b277261: rust-matchers: add doctests for `AlwaysMatcher` (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7527?vs=18403&id=18585 CHANGE

D7526: rust-hg-path: add method to get part of a path relative to a prefix

2019-12-10 Thread Raphaël Gomès
Closed by commit rHG4f1543a2f5c3: rust-hg-path: add method to get part of a path relative to a prefix (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7526?vs=18

D7525: rust-matchers: improve `Matcher` trait ergonomics

2019-12-10 Thread Raphaël Gomès
Closed by commit rHG1bb4e9b02984: rust-matchers: improve `Matcher` trait ergonomics (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7525?vs=18401&id=18583 CHAN

D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible

2019-12-10 Thread Raphaël Gomès
Closed by commit rHG088ba9d94079: rust-dirs-multiset: use `AsRef` instead of concrete types when possible (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7524?v

D7505: logcmdutil: call _exthook() in changesettemplater

2019-12-10 Thread dlax (Denis Laxalde)
Closed by commit rHG6331a6fc3304: logcmdutil: call _exthook() in changesettemplater (authored by dlax). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7505?vs=18312&id=18581 CHANGES

D7513: phabricator: fix processing of tags/desc in getoldnodedrevmap()

2019-12-10 Thread dlax (Denis Laxalde)
Closed by commit rHG16b607e9f714: phabricator: fix processing of tags/desc in getoldnodedrevmap() (authored by dlax). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7513?vs=18339&id=

D7579: tests: add test for Rust formatting

2019-12-10 Thread durin42 (Augie Fackler)
durin42 added a comment. What are we depending on in the rustfmt settings that's nightly behavior? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7579/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7579 To: indygreg, #hg-reviewers, Alphare, pu

D7506: phabricator: add a "phabstatus" show view

2019-12-10 Thread pulkit (Pulkit Goyal)
This revision now requires changes to proceed. pulkit added a comment. pulkit requested changes to this revision. `test-check-module-imports.t` says hi! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL https://phab.mercurial-s

D7593: status: split morestatus data loading from display

2019-12-10 Thread pulkit (Pulkit Goyal)
pulkit added a comment. pulkit added a subscriber: martinvonz. I pushed @martinvonz D7591 , so these need to be rebased. Thanks! REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7593/new/ REVISION

D7116: rust-performance: introduce FastHashMap type alias for HashMap

2019-12-10 Thread Raphaël Gomès
Closed by commit rHG5ac243a92e37: rust-performance: introduce FastHashMap type alias for HashMap (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mer

D7557: annotate: describe --skip as taking a revset

2019-12-10 Thread durin42 (Augie Fackler)
Closed by commit rHGa6483107a07a: annotate: describe --skip as taking a revset (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7557?vs=18495&id=18575 CHANGES S

D7578: rust: run rustfmt

2019-12-10 Thread indygreg (Gregory Szorc)
Closed by commit rHGce088b38f92b: rust: run rustfmt (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7578?vs=18538&id=18569 CHANGES SINCE LAST ACTION https://

D7596: tests: replace [[]] bashism with portable [] invocation

2019-12-10 Thread durin42 (Augie Fackler)
Closed by commit rHG36444dddaeb4: tests: replace [[]] bashism with portable [] invocation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7596?vs=18568&id=18579

D7523: rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf`

2019-12-10 Thread Raphaël Gomès
Closed by commit rHGc27e688fcdc3: rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf` (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7523?vs=18421&i

D7541: mail: use procutil.shellsplit instead of bytes.split to parse command

2019-12-10 Thread jcristau (Julien Cristau)
Closed by commit rHG8f26dd09aa78: mail: use procutil.shellsplit instead of bytes.split to parse command (authored by jcristau). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7541?vs

D7571: automation: use latest Windows AMI as base

2019-12-10 Thread indygreg (Gregory Szorc)
Closed by commit rHG3d53f9cc73ab: automation: use latest Windows AMI as base (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7571?vs=18520&id=18574 CHANGES SI

D7579: tests: add test for Rust formatting

2019-12-10 Thread indygreg (Gregory Szorc)
Closed by commit rHGe8a3bbffdc7d: tests: add test for Rust formatting (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7579?vs=18539&id=18570 CHANGES SINCE LAS

D7572: tests: stabilize test-extdiff.t on Windows

2019-12-10 Thread mharbison72 (Matt Harbison)
Closed by commit rHGfb03cd716f50: tests: stabilize test-extdiff.t on Windows (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7572?vs=18521&id=18573 CHANGES

D7591: status: remove pointless filtering by alwaysmatcher in morestatus

2019-12-10 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG072b745936f1: status: remove pointless filtering by alwaysmatcher in morestatus (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7591?vs=1

D7583: exchange: fix an attempt to format a list into bytes

2019-12-10 Thread mharbison72 (Matt Harbison)
Closed by commit rHGea97cd64c500: exchange: fix an attempt to format a list into bytes (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7583?vs=18548&id=1857

D7596: tests: replace [[]] bashism with portable [] invocation

2019-12-10 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In this case nothing fancy is required. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7596 AFFECTED FILES tests/test-amend.t CHA

D7530: rust-dirstate-status: update bridge for new rust version of `dirstate.status`

2019-12-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 18567. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7530?vs=18406&id=18567 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7530/new/ REVISION DETAIL https://phab.mercurial-scm.org/D75

D7116: rust-performance: introduce FastHashMap type alias for HashMap

2019-12-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 18563. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7116?vs=18039&id=18563 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7116/new/ REVISION DETAIL https://phab.mercurial-scm.org/D71

D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible

2019-12-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 18566. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7524?vs=18400&id=18566 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7524/new/ REVISION DETAIL https://phab.mercurial-scm.org/D75

D7119: rust-dirstatemap: remove additional lookup in dirstate.matches

2019-12-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 18565. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7119?vs=18041&id=18565 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7119/new/ REVISION DETAIL https://phab.mercurial-scm.org/D71

D7118: rust-dirstatemap: remove additional lookups in traverse

2019-12-10 Thread Raphaël Gomès
Alphare updated this revision to Diff 18564. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7118?vs=18040&id=18564 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7118/new/ REVISION DETAIL https://phab.mercurial-scm.org/D71

D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible

2019-12-10 Thread pulkit (Pulkit Goyal)
pulkit added a comment. This one fails to apply on default. Skipping pushing this and it's accepted children. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7524/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7524 To: Alphar

Heptapod 0.7.0 released

2019-12-10 Thread Georges Racinet
We're glad to announce the release of Heptapod 0.7.0 on Docker Hub [1]. This is an abridged version, the full announcement can be read on the Heptapod website [2]. Deploying this version performs several significative data migrations. Care must be applied to backup all data before upgrading.

D7595: status: outputting structured unfinished-operation information

2019-12-10 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. pulkit added subscribers: yuja, pulkit. INLINE COMMENTS > configitems.py:247 > coreconfigitem( > +b'commands', b'status.morestatus-item', default=False, > +) IMO the whole morestatus functionality is already behind a config option, so lets not have a config op

mercurial@43817: 11 new changesets

2019-12-10 Thread Mercurial Commits
11 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c78f8f0720cc changeset: 43807:c78f8f0720cc user:Augie Fackler date:Fri Dec 06 15:30:29 2019 -0500 summary: fuzz: fix an unused result on getcwd() in pyutil https://www.mercurial-scm.org/repo/hg/rev/54