D7726: commitablectx: fix the default phase

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The code was ignoring the config option. Since the config option will control the actual phase of the committed result, we better take it in account early. REPOS

D7705: phases: make the working directory consistently a draft

marmoute added a comment. In D7705#113667 , @rdamazio wrote: > In D7705#113383 , @marmoute wrote: > >> The working copy is not necessarly draft phase. For example, it will be secret is the work

D7727: rebase: make sure pruning does not confuse rebase (issue6180)

khanchi97 created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, if a user is rebasing a stack of commits and hit a conflict in between and decided to drop that commit (t

D7728: rebase: add test to demonstrate issue6180

khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It will be fixed in next patch. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7728 AFFECTED FILES tests/test-

D7729: py3: new attempt at fixing logging of traceback in remotefilelog

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY D7598 tried and seems to have failed because traceback.format_stack() returns a list, not a string. REPOSITORY rHG Me

D7727: rebase: make sure pruning does not confuse rebase (issue6180)

khanchi97 added a comment. khanchi97 abandoned this revision. abandoing because I phabsent them in reverse order and it got messed up saying 'Graph cycle detected' REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7727/new/ REVISION DETAIL https://phab

D7730: rebase: make sure pruning does not confuse rebase (issue6180)

khanchi97 created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, if a user is rebasing a stack of commits and hit a conflict in between and decided to drop that commit (t

D7657: rust-index: handle `MixedIndex` in `pyindex_to_graph`

marmoute updated this revision to Diff 18941. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7657?vs=18890&id=18941 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7657/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7657 AFFECTED FILE

D7656: rust-index: make it possible to clone the struct referencing the C index

marmoute updated this revision to Diff 18940. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7656?vs=18889&id=18940 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7656/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7656 AFFECTED FILE

D7658: rust-index: expose a method to retrieve the C index

marmoute updated this revision to Diff 18942. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7658?vs=18891&id=18942 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7658/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7658 AFFECTED FILE

D7660: rust-index: add a `experimental.rust.index` option to use the wrapper

marmoute updated this revision to Diff 18943. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7660?vs=18706&id=18943 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7660/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7660 AFFECTED FILE

D7726: commitablectx: fix the default phase

Closed by commit rHGbbcf78c4ff90: commitablectx: fix the default phase (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAS

D7716: rust-discovery: partial switch to typestate pattern

This revision now requires changes to proceed. martinvonz added a comment. martinvonz requested changes to this revision. Did you consider encoding the state in a type parameter to `PartialDiscovery`? I think that would make the call sites simpler. See the last variation on http://cliffle.com

D7725: match: don't util.normpath() cwd

Closed by commit rHG8a81fa44f7bb: match: don't util.normpath() cwd (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7724: tests: convert the `root` arg of matchmod.match() to local path separators

Closed by commit rHG8f67735344ae: tests: convert the `root` arg of matchmod.match() to local path separators (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPO

D7731: tests: fix failing doctest in match.py by adding dummy auditor

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It was failing with "OSError: [Errno 13] Permission denied: '/root/sub'". It has been failing since 8b1a9ba375e5

D7732: convert: refactor authormap into separate function for outside use

joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7732 AFFECTED FILES hgext/convert/convcmd.py CHANGE DETAILS diff --git a

D7733: hgext: initial version of fastexport extension

joerg.sonnenberger created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7733 AFFECTED FILES hgext/fastexport.py tests/test-fastexport.

D7705: phases: make the working directory consistently a draft

rdamazio added a comment. > commitablectx code seems wrong here. I am sending a patch. Sure. Let me know if your patch is going to somehow cover the use case I'm trying to address here, or what else you'd like me to do with this patch (is it just a matter of adding more tests here to acc

D7705: phases: make the working directory consistently a draft

marmoute added a comment. I simply sent this. If am I following your changeset right, we should have `wdir()` match `draft()` or `secret()` according to the projected phase (config + parent) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7705/new/ RE

D7734: narrow: move `testedwith` after module imports

mharbison72 created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY PyCharm flagged this as a PEP 8 violation, for module level imports not being at the to

D7735: cleanup: drop unused import from pywatchman

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7735 AFFECTED FILES hgext/fsmonitor/pywatchman/capabilities.

D7736: ancestor: drop an unused local variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7736 AFFECTED FILES mercurial/ancestor.py CHANGE DETAILS d

D7737: ancestor: drop another unused variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Also caught by PyCharm. The only time this is used is immediately after another assignment below this. REPOSITORY rHG Mercurial REVISION DETAIL https:/

D7738: bugzilla: drop an unused variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7738 AFFECTED FILES hgext/bugzilla.py CHANGE DETAILS diff

D7739: changegroup: drop an unused variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. The variable is assigned again below before it is used. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7739

D7741: githelp: drop unused variable assignments

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7741 AFFECTED FILES hgext/githelp.py CHANGE DETAILS diff -

D7740: debug: drop unused variable assignments

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7740 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAI

D7742: perf: fix the time measurement for pathcopies relative to p2

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY PyCharm flagged this as unused. But it seems more likely that it was intended to reset the time for the p2 path. REPOSITORY rHG Mercurial REVISION DETAIL

D7743: perf: drop an unnecessary `pass`

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7743 AFFECTED FILES contrib/perf.py CHANGE DETAILS diff --git a/contrib/perf.py b/contrib/perf.py

D7744: perf: drop an unused variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. A different formatter is created below in `_displaystats()`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D

D7745: polib: drop an unused local function

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7745 AFFECTED FILES i18n/polib.py CHANGE DETAILS diff --gi

D7746: rebase: drop an unused variable assignment

mharbison72 created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7746 AFFECTED FILES hge

D7748: hgweb: drop an unused variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7748 AFFECTED FILES mercurial/hgweb/webcommands.py CHANGE D

D7747: revlog: drop an unused variable assignment

mharbison72 created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7747 AFFECTED FILES mercu

D7734: narrow: move `testedwith` after module imports

Closed by commit rHGf91834ecfdfd: narrow: move `testedwith` after module imports (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHAN

D7735: cleanup: drop unused import from pywatchman

Closed by commit rHG6c201f0d17b1: cleanup: drop unused import from pywatchman (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7736: ancestor: drop an unused local variable assignment

Closed by commit rHG5ce6daa67658: ancestor: drop an unused local variable assignment (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7737: ancestor: drop another unused variable assignment

Closed by commit rHG68b09ebf1c13: ancestor: drop another unused variable assignment (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial C

D7738: bugzilla: drop an unused variable assignment

Closed by commit rHG3194cc8c8de0: bugzilla: drop an unused variable assignment (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGE

D7739: changegroup: drop an unused variable assignment

Closed by commit rHG6d2b5c4efdae: changegroup: drop an unused variable assignment (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHA

D7741: githelp: drop unused variable assignments

Closed by commit rHGca5bd34c597b: githelp: drop unused variable assignments (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES S

D7740: debug: drop unused variable assignments

Closed by commit rHG7a2c49a3cbae: debug: drop unused variable assignments (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SIN

D7742: perf: fix the time measurement for pathcopies relative to p2

Closed by commit rHGa2ad5aeedfdf: perf: fix the time measurement for pathcopies relative to p2 (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG M

D7743: perf: drop an unnecessary `pass`

Closed by commit rHG2bbb2f556ecf: perf: drop an unnecessary `pass` (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7744: perf: drop an unused variable assignment

Closed by commit rHG943e34522b37: perf: drop an unused variable assignment (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SI

D7745: polib: drop an unused local function

Closed by commit rHG04e0e0e73892: polib: drop an unused local function (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D7748: hgweb: drop an unused variable assignment

Closed by commit rHG3e4294aa7944: hgweb: drop an unused variable assignment (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES S

D7746: rebase: drop an unused variable assignment

Closed by commit rHGbd88407edc0e: rebase: drop an unused variable assignment (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7747: revlog: drop an unused variable assignment

Closed by commit rHGbdb357161d7a: revlog: drop an unused variable assignment (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7749: shelve: drop an unused variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm. This stopped being used in a3b285882724 . REPOSITORY rHG Merc

D7750: run-tests: ensure the script exits when it fails to change directories

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by PyCharm as an unused variable assignment. This regressed in c496e8c14b9e

D7716: rust-discovery: partial switch to typestate pattern

gracinet added a comment. @martinvonz yes, I've thinked of it after I made this one, but somehow I thought this was enough for a first try. Yes, we could have `PartialDiscovery`, and `PartialDiscovery`, with `Start` being a pure marker, and `Computed` actually holding the undecided s

D7716: rust-discovery: partial switch to typestate pattern

martinvonz added a comment. In D7716#114043 , @gracinet wrote: > @martinvonz yes, I've thinked of it after I made this one, but somehow I thought this was enough for a first try. It seems like it would be a lot of churn to take this patch

D7705: phases: make the working directory consistently a draft

rdamazio added a comment. In D7705#113845 , @marmoute wrote: > I simply sent this. If am I following your changeset right, we should have `wdir()` match `draft()` or `secret()` according to the projected phase (config + parent) I don't u

D7752: fsmonitor: drop an unused local variable

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7752 AFFECTED FILES hgext/fsmonitor/pywatchman/capabilities

D7751: absorb: avoid using a list comprehension to fill a list with fixed values

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm as an unused assignment for the variable in the list. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7751 AFF

D7754: hgweb: delete local variable instead of setting it to `None`

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous code was flagged by PyCharm as an unused variable assignment. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7754 A

D7756: fsmonitor: drop an unused local variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7756 AFFECTED FILES hgext/fsmonitor/pywatchman/pybser.py C

D7757: fastannotate: drop unused local variable assignments

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7757 AFFECTED FILES hgext/fastannotate/support.py CHANGE D

D7758: tests: drop unused local variable assignments in remotefilelog

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7758 AFFECTED FILES tests/test-remotefilelog-datapack.py

D7760: tests: drop unused local variable assignments in linelog

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7760 AFFECTED FILES tests/test-linelog.py CHANGE DETAILS

D7761: hgweb: delete a local variable instead of setting to `None`

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous code was flagged by PyCharm as an unused variable assignment. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7761 A

D7759: ui: delete local variables instead of setting to `None`

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous code was flagged by PyCharm as an unused variable assignment. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7759 A

D7755: mq: drop an unused variable assignment

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm. This variable is the index of a `for` loop below. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7755 AFFEC

D7753: annotate: avoid using a list comprehension to fill a list with fixed values

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm as an unused assignment for the variable in the list. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7753 AFF

D7763: tests: avoid using a list comprehension to fill a list with fixed values

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm as an unused assignment for the variable in the list. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7763 AFF

D7762: histedit: avoid using a list comprehension to fill a list with fixed values

mharbison72 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flagged by PyCharm as an unused assignment for the variable in the list. REPOSITORY rHG Mercurial REVISION DETAIL https:/

D7764: revset: drop some unused code in the `remote` revset

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY PyCharm flagged the `revs = [..]` as an unused assignment. But then neither `revs` nor `checkout` is used, and I can't see where `hg.addbranchrevs()` has ex