D8429: upgrade: support the --quiet flag

mharbison72 added a comment. mharbison72 accepted this revision. I think it might make sense to make some of these messages `note()` or `debug()`, but this is still an improvement. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8429/new/ REVISION DETA

D8439: make: drop the `-c` arg to `install` in the documentation makefile

mharbison72 added a comment. In D8439#125864 , @mharbison72 wrote: > This helps it get further, but then it dies with messages like: > > find: cycle detected for /lib/secure/32/ > find: cycle detected for /lib/crypto/32/ > find: c

D8439: make: drop the `-c` arg to `install` in the documentation makefile

mharbison72 added a comment. This helps it get further, but then it dies with messages like: find: cycle detected for /lib/secure/32/ find: cycle detected for /lib/crypto/32/ find: cycle detected for /lib/32/ ... install: hg-ssh.8 was not found anywhere! find: cycle d

D8439: make: drop the `-c` arg to `install` in the documentation makefile

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This arg caused `gmake install` on OpenIndiana 2019.10 (illumos) fail with: install: The -c, -f, -n options each require a directory following! instal

D8435: modified A

mharbison72 added a comment. mharbison72 abandoned this revision. This was to generate tests. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8435/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8435 To: mharbison72, #hg-reviewers Cc: mercurial-

D8434: modified 1

mharbison72 added a comment. mharbison72 abandoned this revision. This was to generate tests. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8434/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8434 To: mharbison72, #hg-reviewers Cc: mercurial-

D8433: modified 2

mharbison72 added a comment. mharbison72 abandoned this revision. This was to generate tests. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8433/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8433 To: mharbison72, #hg-reviewers Cc: mercurial-

D8438: phabricator: restack any new orphans created by phabsend (issue6045)

mharbison72 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, posting a new review for a non head commit would orphan the head. The general case is any descendant of the selected revisions got orphaned if

D8436: phabricator: avoid creating unstable children within the review stack

mharbison72 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The instability occurred when rebasing something that has already been submitted onto something that hasn't, and then resubmitting the stack. Or as the

D8437: phabricator: prevent posting obsolete commits

mharbison72 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't see why this would be useful in the first place. But I had a coworker submit a single commit that was not a branch head, and the result was to o

D8435: modified A

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8435 AFFECTED FILES file1.txt CHANGE DETAILS diff --git a/file1.txt b/file1.txt

D8434: modified 1

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8434 AFFECTED FILES file1.txt CHANGE DETAILS diff --git a/file1.txt b/file1.txt

D8433: modified 2

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8433 AFFECTED FILES file1.txt CHANGE DETAILS diff --git a/file1.txt b/file1.txt

[Bug 6301] New: hg in crashes with "KeyError: 'topics'"

https://bz.mercurial-scm.org/show_bug.cgi?id=6301 Bug ID: 6301 Summary: hg in crashes with "KeyError: 'topics'" Product: Mercurial Version: 5.3rc0 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: bug

D8425: wait-on-file: don't quote arithmetic argument

mharbison72 added a comment. mharbison72 accepted this revision. I couldn't reproduce the problem on 10.14 with or without this. But I can confirm that it appears to fix the issue on MSYS. --- g:/Users/test/projects/hg-default-x86_64/Win7_x86_64_hg_tests/build/tests/test-persistent-no

D8432: dirstate: convert _checkexec to a bool when calling rustmod.status

marmoute added a comment. That looks valid, but can we get a fix the assignment too ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8432/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8432 To: mplamann, #hg-reviewers Cc: marmoute, mercurial-d

D8432: dirstate: convert _checkexec to a bool when calling rustmod.status

mplamann created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY posix.checkexec can return True, False, or None. The rust status implementation expects a boolean, so convert to bool before passing _checkexec into rust. REPO

D8430: nodemap: teach `hg debugformat` about the persistent nodemap option

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have a new requirement, we should display it. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8430 AFFECTED FIL

D8431: upgrade: support upgrade and downgrade from persistent nodemap

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The requirements is not recognised and dealt with and the associated files properly handled. The persistent nodemap should be ready for usage in the field no

D8429: upgrade: support the --quiet flag

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The command is currently very verbose with a various bit of output being time sensitive or randomized. The make invocation bulky and hard to match in the test.

D8428: upgrade: clearly list optimisation

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This make the command operation clearer. And this will before necessary to have a short version of this information with the next changesets, teaching `hg debu

D8427: upgrade: properly filter action depending on planned work

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The `determineactions` function filters out deficiency that are not scheduled to be fixed by the target repository configuration. However it only did so for re

D8426: wait-on-file: use proper variable in math

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This seems better and safer to be explicit. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8426 AFFECTED FILES

D8425: wait-on-file: don't quote arithmetic argument

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is unnecessary and Mac OS X choke on them. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8425 AFFECTED FILE

D8178: heptapod-ci: also run tests for chg on python 2

marmoute added a comment. I wanted to make it accepted, but apparently I am flag as owner… So this looks good to me. As followup we could have the same for pure and rust (probably starting with manual triggering to avoid CI load explosion). What's the latest of having this for python

mercurial@44712: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/637eb7f7559b changeset: 44711:637eb7f7559b user:Yuya Nishihara date:Wed Apr 15 19:24:21 2020 +0900 summary: revset: remove explicit sort() from unstable() https://www.mercurial-scm.org/repo/hg/rev/a825

Re: [PATCH] templatekw: cache mergestate even if merge is not ongoing

queued, thanks > On Apr 15, 2020, at 10:39, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1586959915 -32400 > # Wed Apr 15 23:11:55 2020 +0900 > # Node ID 5b857d88bc5e391ff928ac253c42248784527b4e > # Parent f9735a7cf54beb15dd252042df17cb620556b103 > templ

Re: [PATCH] revset: remove explicit sort() from unstable()

queued, thanks > On Apr 15, 2020, at 09:47, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1586946261 -32400 > # Wed Apr 15 19:24:21 2020 +0900 > # Node ID f9735a7cf54beb15dd252042df17cb620556b103 > # Parent f0d88d20654ba1bc6a3c42c6dd06cc366142879d > revse

mercurial@44710: 19 new changesets (1 on stable)

19 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/539490756a72 changeset: 44692:539490756a72 branch: stable parent: 44667:b561f3a68e41 user:Alexander Pyhalov date:Mon Apr 13 16:30:13 2020 +0300 summary: setup: link osutil.so to

D8394: revset: implement a simple 'foo#generations' expression

Closed by commit rHGeca82eb9d777: revset: implement a simple 'foo#generations' expression (authored by av6). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHA

D8393: revset: rename generationsrel() to generationssubrel()

Closed by commit rHG8859de3e83dc: revset: rename generationsrel() to generationssubrel() (authored by av6). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHAN

D8424: manifest: fix missing `el` on an `elif` spotted by yuya

Alphare added a comment. Alphare accepted this revision. Alphare added subscribers: yuja, Alphare. Ouch, missed that. Thanks @yuja. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8424/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8424 To: dur

D8424: manifest: fix missing `el` on an `elif` spotted by yuya

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This can be amended into 2db2e9e5 . REPOSITORY rHG Mercurial BRANCH default REVIS

[PATCH] templatekw: cache mergestate even if merge is not ongoing

# HG changeset patch # User Yuya Nishihara # Date 1586959915 -32400 # Wed Apr 15 23:11:55 2020 +0900 # Node ID 5b857d88bc5e391ff928ac253c42248784527b4e # Parent f9735a7cf54beb15dd252042df17cb620556b103 templatekw: cache mergestate even if merge is not ongoing While playing with eBPF, I noti

[PATCH] revset: remove explicit sort() from unstable()

# HG changeset patch # User Yuya Nishihara # Date 1586946261 -32400 # Wed Apr 15 19:24:21 2020 +0900 # Node ID f9735a7cf54beb15dd252042df17cb620556b103 # Parent f0d88d20654ba1bc6a3c42c6dd06cc366142879d revset: remove explicit sort() from unstable() The instability should be dealt with by ba

[Bug 6300] New: hg status lists .hg symlink with rust extension (BC)

https://bz.mercurial-scm.org/show_bug.cgi?id=6300 Bug ID: 6300 Summary: hg status lists .hg symlink with rust extension (BC) Product: Mercurial Version: default branch Hardware: PC OS: Other Status: UNCONFIRMED

D8418: nodemap: drop the 'exp-' prefix for internal opener option

marmoute updated this revision to Diff 21095. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8418?vs=21066&id=21095 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8418/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8414: nodemap: add a new mode option, with an optional "warn" value

marmoute updated this revision to Diff 21092. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8414?vs=21062&id=21092 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8414/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8411: nodemap: also warm manifest nodemap with other caches

marmoute updated this revision to Diff 21091. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8411?vs=21059&id=21091 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8411/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8415: nodemap: add a new mode value, "strict"

marmoute updated this revision to Diff 21093. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8415?vs=21063&id=21093 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8415/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8416: nodemap: move on disk file to version 1

marmoute updated this revision to Diff 21094. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8416?vs=21064&id=21094 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8416/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8410: nodemap: also use persistent nodemap for manifest

marmoute updated this revision to Diff 21090. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8410?vs=21058&id=21090 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8410/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8408: nodemap: skip persistent nodemap warming for revlog not using it

marmoute updated this revision to Diff 21089. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8408?vs=21056&id=21089 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8408/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8414: nodemap: add a new mode option, with an optional "warn" value

marmoute added inline comments. INLINE COMMENTS > pulkit wrote in configitems.py:684 > another minor nit: since the config section is `experimental`, we can skip > the `exp-` prefix. This matcht he pattern used above. In addition the `exp-` prefix make sense here` the feature is (was) in a sta

mercurial@44691: new changeset

New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/48b99af7b4b3 changeset: 44691:48b99af7b4b3 bookmark:@ tag: tip user:Matt Harbison date:Mon Apr 13 01:19:09 2020 -0400 summary: revset: import `unstable()` from the evolve extension -- Reposit

D8372: manifest: remove a final 40-byte assumption from pure-python parser

yuja added a comment. > diff --git a/mercurial/manifest.py b/mercurial/manifest.py > > - a/mercurial/manifest.py > > +++ b/mercurial/manifest.py > @@ -57,7 +57,10 @@ > > raise ValueError(b'Manifest lines not in sorted order.') > prev = l > f, n = l.split(b'\0') >

Re: D8372: manifest: remove a final 40-byte assumption from pure-python parser

> diff --git a/mercurial/manifest.py b/mercurial/manifest.py > --- a/mercurial/manifest.py > +++ b/mercurial/manifest.py > @@ -57,7 +57,10 @@ > raise ValueError(b'Manifest lines not in sorted order.') > prev = l > f, n = l.split(b'\0') > -if len(n) > 40: > +