D8815: dirstate: isolate node len dependency for the pure version

2020-07-24 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When switching to a 256bit hash function, this still needs adjustment, but concentrates the change in one place. REPOSITORY rHG Mercurial BRANCH

D8814: tests: make check-py3-compat.py actually load the specified files correctly

2020-07-24 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For most uses, this change is essentially a no-op, as this script is generally only run by test-check-py3-compat.t, which will already put `$TESTDIR/..` in `$

D8813: tests: make test-install.t work on debian systems

2020-07-24 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Debian systems, at least as of their version of python3.8 on my machine, have rewritten some logic in ensurepip to make it not use the wheels in pip._bundled,

D8812: tests: virtualenv is only used on py2, rename and conditionalize

2020-07-24 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If I have I have the Debian `python3-virtualenv` package installed on my machine, the import succeeds but then I receive an AttributeError because the package

D8811: morestatus: mention --stop even if not using --verbose

2020-07-24 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8811 AFFECTED FILES mercurial/state.py tests/test-absorb-unfinished.t tests/te

D8810: templater: handle None returned from templatedir()

2020-07-24 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY My recent 91aa9bba3dc9 (templater: make templatepaths() return a single path, o

D8809: templater: reuse check for both "map-cmdline." and ""

2020-07-24 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We had two callers of `templatepath()` that did the same test for both "map-cmdline." and "", so let's move that into `templatepath()` so we can reuse it. I

D8808: fix: update documentation to reflect preference for --source over --rev

2020-07-24 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I should have updated the documentation in 5205b46bd887 (fix: add a -s option t

[PATCH 10 of 11] commitctx: gather more preparation code within the lock context

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595541503 -7200 # Thu Jul 23 23:58:23 2020 +0200 # Node ID 8c926a9ea89ea18ba068fd59314b73d7f6f7db27 # Parent 8bd4fa80f2550e94ab3592ae6543649bf8af5449 # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 07 of 11] commitctx: treat `filesadded` more like `filesremoved`

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595538480 -7200 # Thu Jul 23 23:08:00 2020 +0200 # Node ID aa121e67dfaa9d793dcd375c16f91d21060f22fb # Parent 4eeff7ebf46eb591767ca79fbceb447b2d3ca17d # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 08 of 11] commitctx: extract all the manual logic to process the files

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595521545 -7200 # Thu Jul 23 18:25:45 2020 +0200 # Node ID 59f2136c091bc68c96fb56e7618128b77b62194e # Parent aa121e67dfaa9d793dcd375c16f91d21060f22fb # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 09 of 11] commitctx: move a special case about files earlier

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595540459 -7200 # Thu Jul 23 23:40:59 2020 +0200 # Node ID 8bd4fa80f2550e94ab3592ae6543649bf8af5449 # Parent 59f2136c091bc68c96fb56e7618128b77b62194e # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 06 of 11] commitctx: move `writechangesetcopy` business at the end a code section

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595537909 -7200 # Thu Jul 23 22:58:29 2020 +0200 # Node ID 4eeff7ebf46eb591767ca79fbceb447b2d3ca17d # Parent 87553bac39d2fec8dd7b23b44152ec89bcb2f74d # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 11 of 11] commitctx: extract all the file preparation logic in a new function

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595541151 -7200 # Thu Jul 23 23:52:31 2020 +0200 # Node ID 68263067cc8120b2f6434ed282147966b67e7214 # Parent 8c926a9ea89ea18ba068fd59314b73d7f6f7db27 # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 04 of 11] commitctx: no longer use the `writecopiesto` variable in the function

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595531010 -7200 # Thu Jul 23 21:03:30 2020 +0200 # Node ID 93c606831026b6c9644ad84a89204a2338a8aa03 # Parent 113fcffb030358b64b4cf7331bbde2e85758ab27 # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 05 of 11] commitctx: move copy meta config reading in a dedicated function

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595531382 -7200 # Thu Jul 23 21:09:42 2020 +0200 # Node ID 87553bac39d2fec8dd7b23b44152ec89bcb2f74d # Parent 93c606831026b6c9644ad84a89204a2338a8aa03 # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 02 of 11] commitctx: stop using weakref proxy for transaction

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595587952 -7200 # Fri Jul 24 12:52:32 2020 +0200 # Node ID 76a585b26acdaf884e1c40252e351b1d45cbbcf1 # Parent 2727e91ffa6e9063bd9c29671b5008cfef22dd97 # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 03 of 11] commitctx: extract the function that commit a new manifest

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595509101 -7200 # Thu Jul 23 14:58:21 2020 +0200 # Node ID 113fcffb030358b64b4cf7331bbde2e85758ab27 # Parent 76a585b26acdaf884e1c40252e351b1d45cbbcf1 # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 01 of 11] commitctx: document the None return for "touched" value

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595427033 -7200 # Wed Jul 22 16:10:33 2020 +0200 # Node ID 2727e91ffa6e9063bd9c29671b5008cfef22dd97 # Parent 4ccd5ec565c2baaa1d598b20a7ea14d3c4fd39dc # EXP-Topic commitctx-cleanup-2 # Available At https://foss.heptapod.net/octobus/mercuri

[PATCH 5 of 5 STABLE REGRESSION V2] push: test for checks preventing publishing obsolete changeset

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595514630 -7200 # Thu Jul 23 16:30:30 2020 +0200 # Branch stable # Node ID e741ef8d1b76060f6c49fbef0082efe19246cde7 # Parent 099d3b7cfef487b42c408c54345cdccb5cf9be98 # EXP-Topic push-obscheck # Available At https://foss.heptapod.net/octob

[PATCH 3 of 5 STABLE REGRESSION V2] push: another test for checks preventing pushing orphaness to a server

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595514389 -7200 # Thu Jul 23 16:26:29 2020 +0200 # Branch stable # Node ID 89ef8e19853e11c106653add49bd33dda246be3c # Parent ac128543063466eae7d6c9c8859154360580879a # EXP-Topic push-obscheck # Available At https://foss.heptapod.net/octob

[PATCH 4 of 5 STABLE REGRESSION V2] push: test for checks preventing publishing obsolete changeset

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595514555 -7200 # Thu Jul 23 16:29:15 2020 +0200 # Branch stable # Node ID 099d3b7cfef487b42c408c54345cdccb5cf9be98 # Parent 89ef8e19853e11c106653add49bd33dda246be3c # EXP-Topic push-obscheck # Available At https://foss.heptapod.net/octob

[PATCH 2 of 5 STABLE REGRESSION V2] push: test the checks preventing pushing orphaness to a server

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595514223 -7200 # Thu Jul 23 16:23:43 2020 +0200 # Branch stable # Node ID ac128543063466eae7d6c9c8859154360580879a # Parent 69b4a3b9262e822047bb143b864687b27cfbd00e # EXP-Topic push-obscheck # Available At https://foss.heptapod.net/octob

[PATCH 1 of 5 STABLE REGRESSION V2] exchange: backout changeset c26335fa4225

2020-07-24 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1595516276 -7200 # Thu Jul 23 16:57:56 2020 +0200 # Branch stable # Node ID 69b4a3b9262e822047bb143b864687b27cfbd00e # Parent fc54f52779dd6c9523e9cc4de8a6e61e62e75bd8 # EXP-Topic push-obscheck # Available At https://foss.heptapod.net/octob

Re: [PATCH 1 of 5 STABLE REGRESSION] exchange: backout changeset c26335fa4225

2020-07-24 Thread Manuel Jacob
On 2020-07-24 14:31, Pierre-Yves David wrote: On 7/24/20 2:25 PM, Manuel Jacob wrote: On 2020-07-24 14:07, Pierre-Yves David wrote: On 7/24/20 8:19 AM, Manuel Jacob wrote: Overall, I’m fine to backout this for now and solve the problem during the Mercurial 5.6 development cycle. Thanks, let

Re: [PATCH 1 of 5 STABLE REGRESSION] exchange: backout changeset c26335fa4225

2020-07-24 Thread Pierre-Yves David
On 7/24/20 2:25 PM, Manuel Jacob wrote: On 2020-07-24 14:07, Pierre-Yves David wrote: On 7/24/20 8:19 AM, Manuel Jacob wrote: Overall, I’m fine to backout this for now and solve the problem during the Mercurial 5.6 development cycle. Thanks, let do that. I still think that this check is no

Re: [PATCH 1 of 5 STABLE REGRESSION] exchange: backout changeset c26335fa4225

2020-07-24 Thread Manuel Jacob
On 2020-07-24 14:07, Pierre-Yves David wrote: On 7/24/20 8:19 AM, Manuel Jacob wrote: Overall, I’m fine to backout this for now and solve the problem during the Mercurial 5.6 development cycle. Thanks, let do that. I still think that this check is not the right place for preventing the cases

Re: [PATCH 1 of 5 STABLE REGRESSION] exchange: backout changeset c26335fa4225

2020-07-24 Thread Pierre-Yves David
On 7/24/20 8:19 AM, Manuel Jacob wrote: Overall, I’m fine to backout this for now and solve the problem during the Mercurial 5.6 development cycle. Thanks, let do that. I still think that this check is not the right place for preventing the cases you were raising. The message refers to chan

Re: [PATCH] [RFC] tests: sleep for a second to let ui get flushed

2020-07-24 Thread Pierre-Yves David
Solving race condition with sleep usually just make test slower while pushing the race further down the road. Can you think of a way to fix this with some explicit synchronisation? On 7/23/20 11:01 PM, Pulkit Goyal wrote: # HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1

Re: [PATCH 1 of 5 STABLE REGRESSION] exchange: backout changeset c26335fa4225

2020-07-24 Thread Manuel Jacob
On 2020-07-24 10:17, Pulkit Goyal wrote: I see that tests are added later in series which are related to this change. Can you put them before this backout patch to demonstrate what was broken and this patch fixing them. Will be much easier to review and have a discussion. Without the backout, a

Re: [PATCH 1 of 5 STABLE REGRESSION] exchange: backout changeset c26335fa4225

2020-07-24 Thread Pierre-Yves David
I cannot really put them earlier, because early failure is ruining the rest of the test. However I can post meaningful diff of the change if that helps you. (You can also pull the change, reverse the backout and look at them if you want). On 7/24/20 10:17 AM, Pulkit Goyal wrote: I see that te

Re: [PATCH 1 of 5 STABLE REGRESSION] exchange: backout changeset c26335fa4225

2020-07-24 Thread Pulkit Goyal
I see that tests are added later in series which are related to this change. Can you put them before this backout patch to demonstrate what was broken and this patch fixing them. Will be much easier to review and have a discussion. On Fri, Jul 24, 2020 at 11:49 AM Manuel Jacob wrote: > > Overall,

[Bug 6386] New: metaedit should trigger evolve --all

2020-07-24 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6386 Bug ID: 6386 Summary: metaedit should trigger evolve --all Product: Mercurial Version: default branch Hardware: PC OS: Linux Status: UNCONFIRMED Severity:

Re: [PATCH] [RFC] tests: sleep for a second to let ui get flushed

2020-07-24 Thread Pulkit Goyal
On Fri, Jul 24, 2020 at 9:08 AM Yuya Nishihara wrote: > > On Fri, 24 Jul 2020 02:31:14 +0530, Pulkit Goyal wrote: > > # HG changeset patch > > # User Pulkit Goyal <7895pul...@gmail.com> > > # Date 1595538045 -19800 > > # Fri Jul 24 02:30:45 2020 +0530 > > # Node ID ebb1da08c3163efac7bcfe0947c

[Bug 6385] New: commit with a default topic name

2020-07-24 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6385 Bug ID: 6385 Summary: commit with a default topic name Product: Mercurial Version: default branch Hardware: PC OS: Linux Status: UNCONFIRMED Severity: feat

[Bug 6384] New: largefiles breaks topics over ssh transport

2020-07-24 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6384 Bug ID: 6384 Summary: largefiles breaks topics over ssh transport Product: Mercurial Version: 5.4.2 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: bu

Re: [PATCH] tests: glob 'mercurial.error' in test-phases.t

2020-07-24 Thread Manuel Jacob
On 2020-07-24 05:17, Yuya Nishihara wrote: On Fri, 24 Jul 2020 00:51:22 +0530, Pulkit Goyal wrote: # HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1595532057 -19800 # Fri Jul 24 00:50:57 2020 +0530 # Node ID f5621c1f45bb0f27793406917ac677cb6cacbe42 # Parent 4ccd5ec56