[Bug 6578] New: Developing an Employee Recruitment Plan

2021-08-21 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6578 Bug ID: 6578 Summary: Developing an Employee Recruitment Plan Product: Mercurial project Version: unspecified Hardware: PC OS: Windows Status: UNCONFIRMED

D11330: dirstate-item: add dedicated "legacy" constructor for `addfile` case

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This way the internal details of how a DirstateItem is encoded is encapsulated within the DirstateItem. This will finally give use some latitude to change the

D11332: dirstatemap: also discard item from sets

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This seems more consistent to do that. I don't think any test was actually barking about it, but the code feels a bit more robust now. REPOSITORY rHG

D11331: dirstatemap: drop unused internal constant definition

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All that logic now moved within the DirstateItem itself, so we can finally drop this implementation details from the "higher" level. REPOSITORY rHG

D11329: dirstatemap: use the default code to handle "merged" case

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This simplify the conditionnal a bit since most of it is handled by the common code. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11328: dirstatemap: use the default code to handle "added" case

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This one is very easy too. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11328 AFFECTED FILES

D11327: dirstatemap: use the default code to handle "removed" case

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This one is very easy. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11327 AFFECTED FILES

D11326: dirstatemap: use the default code to handle "clean-p2" case

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This simplify the conditionnal a bit since most of it is handled by the common code. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11325: dirstatemap: use the default code to handle "p2-tracked" case

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We juste have to do minor value adjustement and the default code will do the rest. This kind of change highglight that "clean_p2" is probably not the right

D11324: dirstatemap: use the default code to handle "possibly_dirty" case

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This case is quite simple too REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11324 AFFECTED FILES

D11323: dirstatemap: use the default code to handle normal entry

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This case is quite simple. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11323 AFFECTED FILES

D11315: dirstatemap: replace `removefile` by an explicit `entry.set_untracked()`

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All the other caller goes through `reset_state`, so we can safely have an explicit method on `DirstateItem` object. This means that all the logic to preserve

D11320: dirstate-item: feed more information to `__init__`

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Instead of processing the "rich" value at the `dirstatemap` level, we can now directly pass them to the DirstateItem object. This will make the object free to

D11322: dirstatemap: conclude `reset_state` with logic using the new __init__

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now the DirstateItem can deal with most of the logic related to its initialization, our goal is to migrate the function to a more "unified" way were minimal

D11321: dirstatemap: temporarily return early in `reset_state`

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are about to migrate `addfile` to the new `DirstateItem__init__` and having these early return will the new series of patches to be clearer. REPOSITORY

D11319: rust-dirstatemap: temporarily use `from_v1_data` in `addfile`

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are about to change the `__init__` for `DirstateItem`. To make the transition easier, we move existing caller to `DirstateItem.from_v1_data`. The Rust

D11318: dirstatemap: temporarily use `from_v1_data` in `addfile`

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are about to change the `__init__` for `DirstateItem`. To make the transition easier, we move existing caller to `DirstateItem.from_v1_data`. REPOSITORY

D11317: dirstate-item: fix the declaration of the Cext `from_v1_meth`

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This method is apparently not called from anywhere since the declaration was garbage. We will start calling it in the next changeset. REPOSITORY rHG

D11316: dirstate-item: fix Cext declaration of dm_nonnormal and dm_otherparent

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These are property, not method. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11316 AFFECTED FILES

D11314: dirstate: forward `remove` call to newer `API`

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The `_remove` method was only called in the deprecated `remove` function. We merge the two and express it in terms of call to new API methods. REPOSITORY

D11313: dirstate: directly call the dirstatemap in `set_untracked`

2021-08-21 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This function is only called in two places: the deprecated "remove" method and in the new `set_untracked` method. So we simply inline the appropriate