D12481: debuglock: ignore ENOENT error when unlocking

2022-04-06 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is consistent with the main `lock.release` code. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D12481 AFFEC

D12480: run-tests: introduce "forward-slash" version of everything on windows

2022-04-06 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This should be useful for some shell invocation. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D12480 AFFECTED F

D12479: tests-racy-mutation: pass the editor through config instead of env variable

2022-04-06 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY On Windows msys seems to do awful mangling of the environment variable content that confuses everything to the death. Going through the config works fine, so

D12478: rust-dirstatemap: add unit tests

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These were missing and have already proven valuable since they have found two bugs (fixed in previous patches). There may be other behavior to test, but thi

D12477: rust: add `Debug` trait to a bunch of structs

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is useful when... debugging. Right now the output is not in the most readable state it could be, but this is very low effort and is good enough for now. W

D12476: rust-dirstatemap: use `&HgPath` instead of `HgPathBuf` in `copy_map_insert`

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY No reason to require an owned path here. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12476 AFFECTED FILES r

D12475: rust-dirstatemap: use `DirstateEntry::tracked` directly

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY `state()` is a legacy API that will be removed at some point, let's use the newer API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://p

D12473: rust-dirstatemap: remove `set_dirstate_entry`/`set_entry` methods

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These methods were needed crutches before the Rust implementation caught up to Python. Calling `set_entry` (whether from Python or Rust) was dangerous since it

D12474: rust-cpython: remove unused API to `drop_entry_and_copy_source`

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not used anywhere anymore and its use cases are covered by the new API REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercur

D12472: rust-dirstatemap: implement part of the `setparents` logic

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The Python code does many round-trip calls to the Rust dirstatemap when copy information needs to be dropped in `setparents`. This may result in improved pe

D12471: dirstate-item: add missing bit of docstring

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12471 AFFECTED FILES mercurial/pure/parsers.py CHANGE DETAILS diff --git a/mercur

D12470: dirstatemap: move `_dirs_incr` and `_dirs_decr` methods out of the common

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY They are only used by the Python implementation now REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12470 AFFECTE

D12469: dirstatemap: move `_refresh_entry` out of the common methods

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is only used in the Python implementation now REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12469 AFFECTED

D12468: dirstatemap: move `_drop_entry` out of the common methods

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Only the Python implementation uses it. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12468 AFFECTED FILES me

D12467: rust-dirstatemap: remove `_drop_entry`

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not used anywhere anymore REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12467 AFFECTED FILES mercuria

D12466: rust-dirstatemap: remove `__settitem__`

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not used anywhere now. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12466 AFFECTED FILES mercurial/d

D12464: rust-distatemap: remove `addfile` API

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All of its users have been migrated to the new API REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12464 AFFECTED

D12465: rust-dirstatemap: remove unused `_refresh_entry` implementation

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was only used in the newer APIs, all of which have been rewritten in Rust REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercur

D12463: rust-dirstatemap: remove `removefile` API

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Its callers have been migrated to the newer dirstate API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12463 A

D12462: rhg: use the new `set_clean` API

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12462 AFFECTED FILES rust/rhg/src/commands/status.rs CHANGE DETAILS diff --git a/

D12460: rust-dirstatemap: add `set_untracked` method

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new API that Python has already migrated to REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12460 AFF

D12461: dirstatemap: move `set_untracked` out of the common methods

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY There is a dedicated Rust implementation now REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12461 AFFECTED FILES

D12458: rust-dirstatemap: add `set_possibly_dirty` method

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new API that Python has already migrated to. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12458 AF

D12459: dirstatemap: move `set_possibly_dirty` out of the common methods

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY There exists now a dedicated Rust implementation REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12459 AFFECTED F

D12457: dirstatemap: move `set_clean` out of common methods

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This now has a dedicated Rust implementation REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12457 AFFECTED FILES

D12456: rust-dirstatemap: add `set_clean` method

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new dirstate API that has already been moved to in Python. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.

D12453: rust-dirstatemap: add Rust implementation of `reset_state`

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new API which has already been defined in Python REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12453

D12455: dirstatemap: remove `_insert_entry`

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was needed as a compatibility layer for the Python and Rust implementations, but it is not called from anywhere in Rust anymore. The two remaining call

D12454: dirstatemap: move `reset_state` out of common methods

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now that we have a Rust implementation, we defer to that accordingly. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.o

D12452: rust-dirstate: introduce intermediate struct for dirstate-v2 data

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is passed often as a long tuple that is not easy to know the form of, so we refactor everything in this struct. This also renames `wdir_tracked` to fol

D12451: dirstatemap: remove unused parameter from `reset_state`

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This has no callers using it and is not used inside the method itself. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.

D12450: dirstatemap: move `set_tracked` out of common methods and plug in Rust

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We now have a Rust-specific implementation of this method, it is no longer shared between both implementations. REPOSITORY rHG Mercurial BRANCH default RE

D12449: rust-dirstatemap: add `set_tracked` method

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new dirstate API that has already been moved to in Python. It will be used in place of the old `addfile`/`removefile` one. REPOSITORY rHG Mercuria

D12447: dirstate: remove v1_* methods from Python/C/Rust shared API

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These methods are used for v1 parsing by their respective implementations, but do not need to be shared between them. REPOSITORY rHG Mercurial BRANCH defau

D12448: rust-dirstate: don't return a state for untracked entries

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This `state` API is a remnant of the former API and is slated for removal at some point. Any caller of this function will expect an entry that is tracked in th

D12446: rust-dirstate-entry: fix typo in panic message

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12446 AFFECTED FILES rust/hg-core/src/dirstate/entry.rs CHANGE DETAILS diff --git

D12445: test-issue660: add dirstate-v2 variant

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It's basically a dirstate test, so it makes sense to test out the new version. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercur

D12444: test-issue660: test inside a repository, not the test dir

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This causes an issue with a temporary file showing up in test output when adding a dirstate-v2 variant of this test. REPOSITORY rHG Mercurial BRANCH defaul

D12443: dirstate: fix some typos in docstrings

2022-04-06 Thread Raphaël Gomès
Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I was passing by and they've been bothering me. :) REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12443 AFFECTED

mercurial-devel | Failed pipeline for branch/default | e50245ee

2022-04-06 Thread Heptapod
Pipeline #47044 has failed! Project: mercurial-devel ( https://foss.heptapod.net/mercurial/mercurial-devel ) Branch: branch/default ( https://foss.heptapod.net/mercurial/mercurial-devel/-/commits/branch/default ) Commit: e50245ee ( https://foss.heptapod.net/mercurial/mercurial-devel/-/commit/

mercurial-devel | Failed pipeline for branch/default | 1457b779

2022-04-06 Thread Heptapod
Pipeline #47032 has failed! Project: mercurial-devel ( https://foss.heptapod.net/mercurial/mercurial-devel ) Branch: branch/default ( https://foss.heptapod.net/mercurial/mercurial-devel/-/commits/branch/default ) Commit: 1457b779 ( https://foss.heptapod.net/mercurial/mercurial-devel/-/commit/

mercurial@49009: 4 new changesets (3 on stable)

2022-04-06 Thread Mercurial Commits
4 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/5bd6bcd31dd1 changeset: 49006:5bd6bcd31dd1 branch: stable tag: 6.1.1 parent: 49004:9dcfd1d05e6e user:Raphaël Gomès date:Tue Apr 05 17:11:36 2022 +0200 summary: relnotes:

mercurial-devel | Failed pipeline for branch/default | 69250921

2022-04-06 Thread Heptapod
Pipeline #47030 has failed! Project: mercurial-devel ( https://foss.heptapod.net/mercurial/mercurial-devel ) Branch: branch/default ( https://foss.heptapod.net/mercurial/mercurial-devel/-/commits/branch/default ) Commit: 69250921 ( https://foss.heptapod.net/mercurial/mercurial-devel/-/commit/