Re: Discussion about Mercurial 4.8 Sprint

2018-06-06 Thread Kevin Bullock
> On Jun 5, 2018, at 23:02, Sean Farley wrote: > > Hello everyone! > > I want to bring up a discussion about the next location for the sprint. > In my recent travels, I talked with ~10 people who expressed some > reservations about being able to make the next sprint if it is held in > Japan.

Re: [PATCH STABLE] hgweb: prevent triggering dummy href="#" handler

2018-05-03 Thread Kevin Bullock
> On May 3, 2018, at 00:51, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1525326205 -32400 > # Thu May 03 14:43:25 2018 +0900 > # Branch stable > # Node ID 387af9e5df701db8e6d411a7fde6c946ebcc59b3 > # Parent

D3437: paper: don't register click handlers with inline javascript (issue5812)

2018-05-02 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3437 To: indygreg, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D3436: hgweb: allow Content-Security-Policy header on 304 responses (issue5844)

2018-05-02 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3436 To: indygreg, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

[PATCH 4 of 4 accept-scripts] land: fix JSON error when no accepted changes to land

2018-05-02 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbull...@ringworld.org> # Date 1525292842 18000 # Wed May 02 15:27:22 2018 -0500 # Node ID bafcc443cd52382c574822bd4fef2f83141b10e1 # Parent 335d45810dd93321242e7c329cf6d603a3aa7516 land: fix JSON error when no accepted changes to land diff

[PATCH 3 of 4 accept-scripts] land: extract a function to determine accepted ranges

2018-05-02 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbull...@ringworld.org> # Date 1525292536 18000 # Wed May 02 15:22:16 2018 -0500 # Node ID 335d45810dd93321242e7c329cf6d603a3aa7516 # Parent 1e166e3e0bd6bd0fed28a8e8b9961ff3e517bef7 land: extract a function to determine accepted ranges

[PATCH 2 of 4 accept-scripts] land: turn three identical function calls into one variable

2018-05-02 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbull...@ringworld.org> # Date 1525292391 18000 # Wed May 02 15:19:51 2018 -0500 # Node ID 1e166e3e0bd6bd0fed28a8e8b9961ff3e517bef7 # Parent 138a6f224f8529ecdc69daac026684ee0892eb5e land: turn three identical function calls into one variable

[PATCH 1 of 4 accept-scripts] land: add test demonstrating JSON error on empty revset

2018-05-02 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbull...@ringworld.org> # Date 1525291788 18000 # Wed May 02 15:09:48 2018 -0500 # Node ID 138a6f224f8529ecdc69daac026684ee0892eb5e # Parent 214aea0ce91528a7b22ba34ab991c43963872d23 land: add test demonstrating JSON error on empty revset diff

Re: [PATCH accept-scripts V2] land: fix bug we see when we merge, rather than rebase

2018-04-30 Thread Kevin Bullock
> On Apr 27, 2018, at 13:04, Augie Fackler wrote: > > # HG changeset patch > # User Augie Fackler > # Date 1524713796 14400 > # Wed Apr 25 23:36:36 2018 -0400 > # Node ID 214aea0ce91528a7b22ba34ab991c43963872d23 > # Parent

Re: [PATCH accept-scripts] land: fix bug we see when we merge, rather than rebase

2018-04-27 Thread Kevin Bullock
> On Apr 26, 2018, at 10:59, Augie Fackler wrote: > > # HG changeset patch > # User Augie Fackler > # Date 1524713796 14400 > # Wed Apr 25 23:36:36 2018 -0400 > # Node ID c8dd55d63f9e56d62db3ff1e1b0a8fef228fd19f > # Parent

D2668: rebase: introduce support for automatically rebasing orphan changes

2018-04-18 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added a comment. This revision now requires changes to proceed. Looks like a couple unresolved comments on _possibledestination, plus one nitpick. I think we can clean those things up easily and then land this though. INLINE COMMENTS >

Re: [PATCH] filemerge: support passing python script to custom merge-tools

2018-04-18 Thread Kevin Bullock
> On Apr 18, 2018, at 08:32, Tom Hindle wrote: > > # HG changeset patch > # User hindlemail > # Date 1523988043 21600 > # Tue Apr 17 12:00:43 2018 -0600 > # Node ID 701f7b1145cb8105428141c22260c89d6b942bef > # Parent

Re: [PATCH] log: fix crash on empty revision with --copies switch

2018-04-18 Thread Kevin Bullock
> On Apr 13, 2018, at 23:19, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1523630707 -32400 > # Fri Apr 13 23:45:07 2018 +0900 > # Node ID 775ad61e04e28c49c78c7936d88826a3df024781 > # Parent

Re: [PATCH] fix: use templater to substitute values in command string

2018-04-18 Thread Kevin Bullock
> On Apr 14, 2018, at 00:25, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1523633439 -32400 > # Sat Apr 14 00:30:39 2018 +0900 > # Node ID c11220384fc8e9bea55193401835a60d241c372f > # Parent

Re: [PATCH 4 of 4] logcmdutil: pass formatter to jsonchangeset as argument

2018-04-18 Thread Kevin Bullock
> On Apr 13, 2018, at 23:21, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1523628432 -32400 > # Fri Apr 13 23:07:12 2018 +0900 > # Node ID 611a3c98d1b68836b5725a0d97c0ae1f0b3677f6 > # Parent

Re: Code freeze in effect

2018-04-18 Thread Kevin Bullock
Thank you for correcting my mistake :) This should've gone to -devel to start with. pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和 Kevin R. Bullock > On Apr 18, 2018, at 03:02, Pulkit Goyal <7895pul...@gmail.com> wrote: > > > -- Forwarded message ------ >

Re: [PATCH] lock: block signal interrupt while making a lock file

2018-03-04 Thread Kevin Bullock
> On Mar 4, 2018, at 11:48, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1520138979 18000 > # Sat Mar 03 23:49:39 2018 -0500 > # Node ID 8ff5f6277e204df49b3426a144375db11b41b38d > # Parent

[PATCH] dispatch: don't clamp the range of the exit code twice

2018-03-03 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1520121770 18000 # Sat Mar 03 19:02:50 2018 -0500 # Node ID 53daf5db6dada7eade4de6d4c328b78feb0425cf # Parent c1af0dc644d4c109efee03786aca819a8ac7775c dispatch: don't clamp the range of the exit code

[PATCH] py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1

2018-03-02 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1520023077 18000 # Fri Mar 02 15:37:57 2018 -0500 # Node ID 71a83808184245c86280ede647e18e6cc7945594 # Parent dfcf589a4031211a67bab022e0a1b414f364bc39 py3: bail on ratcheting tests forward on 3.6.0 and

D2394: histedit: make histedit's commands accept revsets (issue5746)

2018-02-23 Thread krbullock (Kevin Bullock)
krbullock added a comment. Oh sorry, I see you're already on the case. Carry on! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: krbullock, rishabhmadan96, mercurial-devel

D2394: histedit: make histedit's commands accept revsets (issue5746)

2018-02-23 Thread krbullock (Kevin Bullock)
krbullock added a comment. Can we get some test coverage on this? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: krbullock, rishabhmadan96, mercurial-devel ___

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

2018-02-14 Thread krbullock (Kevin Bullock)
krbullock added a comment. @durin42 Go for it REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1808 To: spectral, #hg-reviewers, krbullock Cc: durin42, krbullock, mercurial-devel ___ Mercurial-devel mailing list

Re: FYI: Mercurial 4.6 sprint is March 2nd-4th at Google's Cambridge, MA office

2018-02-07 Thread Kevin Bullock
> On Feb 6, 2018, at 09:01, Augie Fackler wrote: > > https://www.mercurial-scm.org/wiki/4.6sprint has all the details, and I'll > fill in more as I have them. > > Sorry for not doing the usual planning routine on this, but time got away > from us and we decided to make some

D2057: translate base85.c into rust code

2018-02-07 Thread krbullock (Kevin Bullock)
krbullock added a comment. What would be the advantage of taking this? Since we already have the C implementation, it's not likely to gain us any performance. On the other hand, it might make a good test case for integrating Rust and Python, finding the right API boundaries and

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

2018-02-06 Thread krbullock (Kevin Bullock)
krbullock accepted this revision as: krbullock. krbullock added a comment. This LGTM now. I think the executable as interpreted by shlex, but without the added flags, gives enough signal for the user to figure out what might be wrong without confusing things. REPOSITORY rHG Mercurial

Re: Ideas and mentors for GSoC 2018.

2018-01-17 Thread Kevin Bullock
> On Jan 16, 2018, at 16:13, Jordi Gutiérrez Hermoso wrote: > > On Wed, 2018-01-17 at 01:01 +0530, Pulkit Goyal wrote: > >> Also, if you have sometime available during the summers and >> interested to mentor a student in the program, it will be great. >> Please let me know.

D1591: visibility: improve the message when accessing filtered obsolete rev

2018-01-04 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added a comment. This revision now requires changes to proceed. This has new failures in test-obshistory.t and test-directaccess.t, can you rebase? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1591 To:

D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo

2018-01-04 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Queued, thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1809 To: spectral, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

2018-01-04 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > debugcommands.py:1212 > fm.write('editor', _("checking commit editor... (%s)\n"), editor) > -cmdpath =

D1729: githelp: don't reference 3rd party commands for `git show`

2018-01-04 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > githelp.py:883 > +cmd = Command('status') > cmd['--change'] = 'tip' > else: I don't think `tip` is correct here,

D1591: visibility: improve the message when accessing filtered obsolete rev

2018-01-04 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. Queued, thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1591 To: lothiraldan, #hg-reviewers, durin42, pulkit, krbullock Cc: krbullock, pulkit, durin42, mercurial-devel

D1745: rebase: don't take out a dirstate guard for in-memory rebase

2017-12-22 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Sure, queued. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1745 To: phillco, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

Re: [PATCH 7 of 7] lfs: only hardlink between the usercache and local store if the blob verifies

2017-12-21 Thread Kevin Bullock
> On Dec 21, 2017, at 14:39, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date 1513883619 18000 > # Thu Dec 21 14:13:39 2017 -0500 > # Node ID 909f1310d199e4b5f542e1e72b07f2bf992dd7a7 > # Parent

Re: [PATCH 3 of 7] lfs: add note messages indicating what store holds the lfs blob

2017-12-21 Thread Kevin Bullock
> On Dec 21, 2017, at 14:39, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date 1513724024 18000 > # Tue Dec 19 17:53:44 2017 -0500 > # Node ID 1a68987ba0c3fa2494a8fae8321cddd0876efd7f > # Parent

Re: [PATCH 4 of 4] templater: look up symbols/resources as if they were separated (issue5699)

2017-12-21 Thread Kevin Bullock
> On Dec 21, 2017, at 09:08, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1513862259 -32400 > # Thu Dec 21 22:17:39 2017 +0900 > # Node ID 9d50cfedc380d05dfbe0ed8b9360603b61b3c601 > # Parent

D1720: debug: add newlines at the end of three locations that appear to need it

2017-12-21 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Sure, queued. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1720 To: spectral, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D1719: debug: remove an 'if ui.debug()' that is not doing anything

2017-12-21 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Seems reasonable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1719 To: spectral, #hg-reviewers, krbullock Cc: krbullock, quark, mercurial-devel

D1591: visibility: improve the message when accessing filtered obsolete rev

2017-12-21 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added a comment. This revision now requires changes to proceed. One nit, otherwise looks nice! INLINE COMMENTS > obsutil.py:780 > +else: > +return 'superseed_split' > + These should be 'superseded' and

D1718: worker: handle interrupt on windows

2017-12-18 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Whoops, queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1718 To: wlis, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D1717: lfs: fix committing deleted files caused by e0a1b9ee93cd

2017-12-18 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Queued per Matt's review, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1717 To: quark, #hg-reviewers, mharbison72, krbullock Cc: krbullock,

D1713: tests: update expected output of svn encoding test

2017-12-18 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. LGTM, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1713 To: durin42, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

Re: [PATCH 2 of 2 STABLE] diff: disable diff.noprefix option for diffstat (issue5759)

2017-12-18 Thread Kevin Bullock
> On Dec 18, 2017, at 09:52, Kevin Bullock <kbullock+mercur...@ringworld.org> > wrote: > >> On Dec 17, 2017, at 05:50, Yuya Nishihara <y...@tcha.org> wrote: >> >> # HG changeset patch >> # User Yuya Nishihara <y...@tcha.org> >> # Date 1

Re: [PATCH 2 of 2 STABLE] diff: disable diff.noprefix option for diffstat (issue5759)

2017-12-18 Thread Kevin Bullock
> On Dec 17, 2017, at 05:50, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1513503785 -32400 > # Sun Dec 17 18:43:05 2017 +0900 > # Branch stable > # Node ID 21f4da606ff71e45725bd35db1982e3b02b7127c > # Parent

D1710: tests: test-pathconflicts-merge.t requires symlinks

2017-12-15 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. LGTM, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1710 To: durin42, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

Re: D1698: copies: group wdir-handling in one place

2017-12-15 Thread Kevin Bullock
> On Dec 15, 2017, at 10:41, martinvonz (Martin von Zweigbergk) > wrote: > > martinvonz added inline comments. > > INLINE COMMENTS > >> krbullock wrote in copies.py:206 >> Post-queue nitpick: unnecessary `else:`. > > Feel free to update Fixed in-flight,

D1698: copies: group wdir-handling in one place

2017-12-15 Thread krbullock (Kevin Bullock)
krbullock added inline comments. INLINE COMMENTS > copies.py:206 > +return _chain(a, b, cm, _dirstatecopies(b, match)) > +else: > +return _committedforwardcopies(a, b, match) Post-queue nitpick: unnecessary `else:`. REPOSITORY rHG Mercurial REVISION DETAIL

D1691: debugdiscovery: drop reference to invalid --branch option

2017-12-15 Thread krbullock (Kevin Bullock)
krbullock added inline comments. INLINE COMMENTS > debugcommands.py:747 > opts = pycompat.byteskwargs(opts) > -remoteurl, branches = hg.parseurl(ui.expandpath(remoteurl), > - opts.get('branch')) > +remoteurl, branches =

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

2017-12-14 Thread Kevin Bullock
> On Dec 14, 2017, at 22:55, Martin von Zweigbergk > wrote: > > Could you point me to the build output? https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1361/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio > Do you also know which shell is used by it?

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

2017-12-14 Thread Kevin Bullock
> On Dec 13, 2017, at 12:28, Martin von Zweigbergk via Mercurial-devel > wrote: > > I think the problem is in this line from the test (that you changed): > > $ echo " saved backup bundle to \$TESTTMP\foo.hg" >> test-failure.t > > The '\' there probably

Re: That pesky windows run-tests failure on the buildbot

2017-12-14 Thread Kevin Bullock
> On Dec 14, 2017, at 11:14, Matt Harbison wrote: > > >> On Dec 13, 2017, at 7:02 PM, Matt Harbison wrote: > >> I wonder if an upper case path is leaking through buildbot somehow. I >> lowercased the driver letter 'basedir' in buildbot.tac, and

D1617: rebase: extract _assignworkingcopy

2017-12-08 Thread krbullock (Kevin Bullock)
krbullock added inline comments. INLINE COMMENTS > rebase.py:393 > +def _performrebase(self, tr): > +self._assignworkingcopy() > +repo, ui = self.repo, self.ui Rather than having this method spookily set self.wctx, why not make `_assignworkingcopy` _return_ the wctx (and

D1607: remotenames: rename related file and storage dir to logexchange

2017-12-08 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added a comment. This revision now requires changes to proceed. This doesn't apply cleanly. Can you rebase? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1607 To: pulkit, #hg-reviewers, krbullock Cc:

D1457: workers: don't use backgroundfilecloser in threads

2017-12-08 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added a comment. This revision now requires changes to proceed. Looks okay to me except for Augie's nit. @indygreg ? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1457 To: wlis, #hg-reviewers, indygreg,

Re: [PATCH 1 of 2] cat: record the current behavior of wildcard matches in subrepos

2017-12-07 Thread Kevin Bullock
> On Dec 7, 2017, at 07:43, Yuya Nishihara <y...@tcha.org> wrote: > > On Wed, 6 Dec 2017 11:26:13 -0600, Kevin Bullock wrote: >>> On Dec 4, 2017, at 08:47, Yuya Nishihara <y...@tcha.org> wrote: >>> >>> On Sun, 03 Dec 2017 12:55:36 -0500, Matt H

D1605: tests: remove {a..h} bashism from remotenames

2017-12-06 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1605 To: durin42, #hg-reviewers, pulkit, krbullock Cc: krbullock, pulkit, mercurial-devel

Re: [PATCH 1 of 2] cat: record the current behavior of wildcard matches in subrepos

2017-12-06 Thread Kevin Bullock
> On Dec 4, 2017, at 08:47, Yuya Nishihara wrote: > > On Sun, 03 Dec 2017 12:55:36 -0500, Matt Harbison wrote: > >> This is as good a place as any to ask- when do we follow through on the >> Subrepo Grand Plan? [1] It seems that the long term plan was to always >> recurse by

Re: [PATCH 2 of 2 STABLE V2] dispatch: add HGPLAIN=+strictflags to restrict early parsing of global options

2017-12-01 Thread Kevin Bullock
> On Nov 24, 2017, at 09:58, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1511443023 -32400 > # Thu Nov 23 22:17:03 2017 +0900 > # Branch stable > # Node ID 54e6e3b35ea5a96d2d822ac23d44b4d105178c05 > # Parent

D1063: rebase: enable multidest by default

2017-11-22 Thread krbullock (Kevin Bullock)
krbullock added a comment. @quark @martinvonz Ping REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1063 To: quark, #hg-reviewers, durin42 Cc: krbullock, dlax, martinvonz, durin42, mercurial-devel ___ Mercurial-devel

Re: DNS manipulation for SPF and DMARC

2017-11-06 Thread Kevin Bullock
> On Nov 6, 2017, at 14:31, Augie Fackler wrote: > > Okay, given that, let's do this for now: > > mercurial-scm.org. IN TXT "v=spf1 a mx ~all" > # rua = "aggregate data reporting address" > # ruf = "forensic data reporting address" > # fo = "failure option" -> 1 means "report

Re: test-convert-bzr-directories.t fails

2017-11-03 Thread Kevin Bullock
> On Nov 2, 2017, at 23:30, timeless wrote: > > Mercurial Distributed SCM (version 4.4+11-7ebf850d3166+20171103) > Bazaar 2.5.1 -- a free distributed version-control tool I've seen the same failure on gcc112, which also has bzr 2.5.1. The Linux buildworker has bzr

Re: [PATCH v2] run-tests: $TESTDIR can be something else than $PWD

2017-11-03 Thread Kevin Bullock
> On Nov 3, 2017, at 10:27, Kevin Bullock <kbullock+mercur...@ringworld.org> > wrote: > >> On Nov 3, 2017, at 02:40, matthieu.laneuvi...@octobus.net wrote: >> >> # HG changeset patch >> # User Matthieu Laneuville <matthieu.laneuvi...@octobus.net> >

Re: [PATCH STABLE] pathutil: use util.pathto() to calculate relative cwd in canonpath()

2017-11-03 Thread Kevin Bullock
> On Nov 2, 2017, at 20:16, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date 1509669331 14400 > # Thu Nov 02 20:35:31 2017 -0400 > # Branch stable > # Node ID 7d799a9800793cb5f1c10ce7269c31e1c7b1285a > # Parent

Re: [PATCH v2] run-tests: $TESTDIR can be something else than $PWD

2017-11-03 Thread Kevin Bullock
> On Nov 3, 2017, at 02:40, matthieu.laneuvi...@octobus.net wrote: > > # HG changeset patch > # User Matthieu Laneuville > # Date 1501648065 -32400 > # Wed Aug 02 13:27:45 2017 +0900 > # Node ID 753f33aed3c6b3fc4d02f5235b1468450ee41fab > # Parent

Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns

2017-11-01 Thread Kevin Bullock
(remove other mailing lists from cc) > On Nov 1, 2017, at 15:24, Joe Perches wrote: > > On Wed, 2017-11-01 at 16:05 -0400, Augie Fackler wrote: >> Actually, I'd recommend `hg files` over `hg manifest` by a wide margin. > > why? > > hg files -R prefixes all the output > hg

[PATCH STABLE] internals: update test-help.t for config registrar copy-edit

2017-11-01 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1509568462 18000 # Wed Nov 01 15:34:22 2017 -0500 # Branch stable # Node ID 05ebb553bd0358619bb79e0b0a77527915940b4c # Parent fb7f58daca4826b6c294766308214e09cf4d6c26 internals: update test-help.t for

Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns

2017-11-01 Thread Kevin Bullock
(remove other mailing lists from cc) > On Nov 1, 2017, at 15:05, Augie Fackler wrote: > >> On Nov 1, 2017, at 13:11, Tom Saeger wrote: >> >> On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote: >>> (add mercurial-devel and xen-devel to cc's)

[PATCH STABLE] internals: copy-edit "register" -> "registrar" in configitem docs

2017-11-01 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1509560648 18000 # Wed Nov 01 13:24:08 2017 -0500 # Branch stable # Node ID fe304d17c0d495febfb1324fb25118570d7a0778 # Parent ff2110eadbfa92d4e5d54c8b6068969583aa54ee internals: copy-edit &qu

D1224: merge: cache unknown dir checks

2017-10-24 Thread krbullock (Kevin Bullock)
krbullock added a comment. Code LGTM, but I haven't done any performance testing on this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1224 To: mbthomas, #hg-reviewers Cc: krbullock, mercurial-devel ___

D1224: merge: cache unknown dir checks

2017-10-24 Thread krbullock (Kevin Bullock)
krbullock added a comment. If this mitigates or fixes issue5716, please mention it in the summary line. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1224 To: mbthomas, #hg-reviewers Cc: krbullock, mercurial-devel

Re: [PATCH] commands: be more uniform in an "hg update" error message

2017-10-23 Thread Kevin Bullock
> On Oct 23, 2017, at 16:07, muxator via Mercurial-devel > wrote: > > # HG changeset patch > # User muxator > # Date 1508791524 -7200 > # Mon Oct 23 22:45:24 2017 +0200 > # Branch stable > # Node ID

Re: [PATCH] update: in the description update() in merge.py, mention the long options explicitly

2017-10-23 Thread Kevin Bullock
> On Oct 23, 2017, at 22:26, Kevin Bullock <kbullock+mercur...@ringworld.org> > wrote: > >> On Oct 23, 2017, at 17:03, muxator <a@inwind.it> wrote: >> >>> On 10/23/2017 11:56 PM, Kevin Bullock wrote: >>>> On Oct 23, 2017, at 16:

Re: [PATCH] update: in the description update() in merge.py, mention the long options explicitly

2017-10-23 Thread Kevin Bullock
> On Oct 23, 2017, at 17:03, muxator <a@inwind.it> wrote: > >> On 10/23/2017 11:56 PM, Kevin Bullock wrote: >>> On Oct 23, 2017, at 16:07, muxator via Mercurial-devel >>> <mercurial-devel@mercurial-scm.org> wrote: >>> >>> # HG cha

[PATCH STABLE] packaging: update book URL in Mac and Windows READMEs

2017-10-23 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1508525691 18000 # Fri Oct 20 13:54:51 2017 -0500 # Branch stable # Node ID a1573e7daf038763fcd96669b797be72ad4447b0 # Parent 27481162780894fb82e4b2f679f967a3a86cbc3b packaging: update book URL

[PATCH 2 of 2 STABLE] setup: filter out devel-warn messages from system hg

2017-10-23 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1508814839 18000 # Mon Oct 23 22:13:59 2017 -0500 # Branch stable # Node ID adc50614340e952d8e98f5948d35b7bf632c2232 # Parent f13a8d056d6ebf490e65096391fdcd5916197f48 setup: filter out devel-warn me

[PATCH 1 of 2 STABLE] setup: remove duplicate assignment of HGRCPATH

2017-10-23 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1508812259 18000 # Mon Oct 23 21:30:59 2017 -0500 # Branch stable # Node ID f13a8d056d6ebf490e65096391fdcd5916197f48 # Parent 27481162780894fb82e4b2f679f967a3a86cbc3b setup: remove duplicate assi

Re: [PATCH] update: in the description update() in merge.py, mention the long options explicitly

2017-10-23 Thread Kevin Bullock
> On Oct 23, 2017, at 16:07, muxator via Mercurial-devel > wrote: > > # HG changeset patch > # User muxator > # Date 1507152154 -7200 > # Wed Oct 04 23:22:34 2017 +0200 > # Branch stable > # Node ID

Re: [PATCH STABLE] help: do not abort topicmatch() because of unimportable extensions

2017-10-20 Thread Kevin Bullock
> On Oct 20, 2017, at 10:19, Yuya Nishihara <y...@tcha.org> wrote: > > On Fri, 20 Oct 2017 10:07:03 -0500, Kevin Bullock wrote: >> (+junw) >> >>> On Oct 20, 2017, at 10:06, Kevin Bullock <kbullock+mercur...@ringworld.org> >>> wrote: >

D1201: dirstate: clean up when restoring identical backups

2017-10-20 Thread krbullock (Kevin Bullock)
krbullock added subscribers: durham, krbullock. krbullock accepted this revision as: krbullock. krbullock added a comment. LGTM but I'd like someone with more familiarity with dirstate to have a look too. Maybe @durham ? REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH STABLE] configitems: register 'email.to' and 'patchbomb.to'

2017-10-20 Thread Kevin Bullock
> On Oct 20, 2017, at 08:37, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1508505909 -32400 > # Fri Oct 20 22:25:09 2017 +0900 > # Branch stable > # Node ID 6480af4400d186915db437332f906d0b0cfc4b72 > # Parent

Re: [PATCH STABLE] help: do not abort topicmatch() because of unimportable extensions

2017-10-20 Thread Kevin Bullock
(+junw) > On Oct 20, 2017, at 10:06, Kevin Bullock <kbullock+mercur...@ringworld.org> > wrote: > >> On Oct 20, 2017, at 08:24, Yuya Nishihara <y...@tcha.org> wrote: >> >> # HG changeset patch >> # User Yuya Nishihara <y...@tcha.org> >&g

Re: [PATCH STABLE] help: do not abort topicmatch() because of unimportable extensions

2017-10-20 Thread Kevin Bullock
> On Oct 20, 2017, at 08:24, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1501942537 -32400 > # Sat Aug 05 23:15:37 2017 +0900 > # Branch stable > # Node ID cd3e41ae547b07c03bd05ee0fef23ca27504383b > # Parent

Re: [PATCH] phases: bring phase index information back into the hook data

2017-10-19 Thread Kevin Bullock
> On Oct 19, 2017, at 05:10, Boris Feld wrote: > > # HG changeset patch > # User Boris Feld > # Date 1508406933 -7200 > # Thu Oct 19 11:55:33 2017 +0200 > # Node ID 667730ee4a87977f86b22cf0d66f959990753fdb > # Parent

D1191: obsfate: makes successorsetverb takes the markers as argument

2017-10-19 Thread krbullock (Kevin Bullock)
krbullock added a comment. Deferring this until after 4.4, because the added `markers` argument isn't used yet. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1191 To: lothiraldan, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D932: filemerge: introduce functions to halt merge flow

2017-10-19 Thread krbullock (Kevin Bullock)
krbullock added a subscriber: yuja. krbullock added inline comments. INLINE COMMENTS > ryanmce wrote in filemerge.py:755-756 > I followed the pattern seen elsewhere in this file. > > If you just hit enter, you do get the default, though. > > I can follow-up with a patch to fix all of these

Re: [PATCH follow-up] exchange: propagate the subfunctions return

2017-10-19 Thread Kevin Bullock
> On Oct 19, 2017, at 15:48, Boris Feld wrote: > > # HG changeset patch > # User Boris Feld > # Date 1508442614 -7200 > # Thu Oct 19 21:50:14 2017 +0200 > # Node ID 204165f5fc88a88ad45d5d8de1fd4631efb72166 > # Parent

Code freeze has begun for 4.4

2017-10-19 Thread Kevin Bullock
The code freeze rules now apply: http://www.mercurial-scm.org/wiki/TimeBasedReleasePlan#Code_Freeze Committers, please update to stable (or @) today. We haven't cut 4.4-rc yet because of some lingering bugs that Augie, Martin, and I are actively working to fix, but stay tuned. pacem in terris

Re: [PATCH 5 of 5] log: add an assertion about fctx not being None in patch.diff()

2017-10-19 Thread Kevin Bullock
> On Oct 19, 2017, at 08:51, Denis Laxalde wrote: > > # HG changeset patch > # User Denis Laxalde > # Date 1508418393 -7200 > # Thu Oct 19 15:06:33 2017 +0200 > # Node ID e2b8b1cb1eaf17739d7af35479b853214daad35d > # Parent

Re: [PATCH] build: build deb/rpm independently on config/extensions in the host system

2017-10-19 Thread Kevin Bullock
> On Oct 19, 2017, at 13:46, muxator via Mercurial-devel > wrote: > > # HG changeset patch > # User muxator > # Date 1508273168 -7200 > # Tue Oct 17 22:46:08 2017 +0200 > # Node ID 08cf9bb1776828f6b4fca94bc3252e1b195ecf48 > # Parent

D1191: obsfate: makes successorsetverb takes the markers as argument

2017-10-19 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > templater.py:1011 > """Compute obsfate related information based on successors > (EXPERIMENTAL)""" > -if len(args) != 1: > +if len(args)

D1140: localrepo: add a pinnedrevs attribute

2017-10-19 Thread krbullock (Kevin Bullock)
krbullock added a comment. We're dropping this stack from 4.4 because it caused unexpected behavior changes in python-hglib (https://buildbot.mercurial-scm.org/builders/python-hglib/builds/654) and elsewhere. Seems to stem from recomputing from the same set on repeated calls to

D1196: tests: add some (?) output lines to catch "helpful" output from Solaris diff

2017-10-19 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1196 To: durin42, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

Re: [PATCH] phases: pass phase names to hooks instead of internal values

2017-10-18 Thread Kevin Bullock
> On Oct 18, 2017, at 12:38, Kevin Bullock <kbullock+mercur...@ringworld.org> > wrote: > > # HG changeset patch > # User Kevin Bullock <kbullock+mercur...@ringworld.org> > # Date 1508347193 18000 > # Wed Oct 18 12:19:53 2017 -0500 > # Node ID b4e1

[PATCH] phases: pass phase names to hooks instead of internal values

2017-10-18 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1508347193 18000 # Wed Oct 18 12:19:53 2017 -0500 # Node ID b4e14b2c20b220153ae4f192a4332d40308d4d18 # Parent 2a098c601e7151bde89aa7ee4c555fc6679756dc phases: pass phase names to hooks instead of in

Re: [PATCH] phases: pass phase names to hooks instead of internal values

2017-10-18 Thread Kevin Bullock
> On Oct 18, 2017, at 12:21, Kevin Bullock <kbullock+mercur...@ringworld.org> > wrote: > > # HG changeset patch > # User Kevin Bullock <kbullock+mercur...@ringworld.org> > # Date 1508347193 18000 > # Wed Oct 18 12:19:53 2017 -0500 > # Node ID 60e2

[PATCH] phases: pass phase names to hooks instead of internal values

2017-10-18 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock <kbullock+mercur...@ringworld.org> # Date 1508347193 18000 # Wed Oct 18 12:19:53 2017 -0500 # Node ID 60e2895bf784f13ceeccb185e0527ba4508bd9cb # Parent 2a098c601e7151bde89aa7ee4c555fc6679756dc phases: pass phase names to hooks instead of in

Re: [PATCH 1 of 2] configitems: do not directly match generic items

2017-10-18 Thread Kevin Bullock
> On Oct 18, 2017, at 09:04, Boris Feld wrote: > > # HG changeset patch > # User Boris Feld > # Date 1508322368 -7200 > # Wed Oct 18 12:26:08 2017 +0200 > # Node ID a3110a4c8aa98ebd9fc26702eb81b9366edf7335 > # Parent

Re: [PATCH follow-up] obsfate: fix obsfate_printer with empty date list

2017-10-18 Thread Kevin Bullock
> On Oct 18, 2017, at 09:35, Boris Feld wrote: > > # HG changeset patch > # User Boris Feld > # Date 1508333931 -7200 > # Wed Oct 18 15:38:51 2017 +0200 > # Node ID 328ec528162a716ef61877de1982860b67973afa > # Parent

Re: [PATCH 3 of 4 V2] phase: add a dedicated txnclose-phase hook

2017-10-18 Thread Kevin Bullock
> On Oct 14, 2017, at 10:46, Boris Feld wrote: > > # HG changeset patch > # User Boris Feld > # Date 1507477846 -7200 > # Sun Oct 08 17:50:46 2017 +0200 > # Node ID 06eeae1828afe149886e18e6b4fc8180a3803fdb > # Parent

Re: [PATCH v2] transaction-summary: show the range of new revisions upon pull/unbundle (BC)

2017-10-13 Thread Kevin Bullock
> On Oct 13, 2017, at 11:07, Augie Fackler <r...@durin42.com> wrote: > > On Fri, Oct 13, 2017 at 09:10:52AM +0200, Denis Laxalde wrote: >> Kevin Bullock a écrit : >>>> On Oct 12, 2017, at 03:13, Denis Laxalde <de...@laxalde.org> wrote: >>>>

Re: [PATCH v2] transaction-summary: show the range of new revisions upon pull/unbundle (BC)

2017-10-12 Thread Kevin Bullock
> On Oct 12, 2017, at 03:13, Denis Laxalde wrote: > > # HG changeset patch > # User Denis Laxalde > # Date 1507793990 -7200 > # Thu Oct 12 09:39:50 2017 +0200 > # Node ID 48cca33a1b611c82a2bd72a2f72b80f321604f42 > # Parent

  1   2   3   >