[PATCH evolve-ext] evolve: fix the way evolve checks whether dirstate.write has arguments

# HG changeset patch # User Kostia Balytskyi # Date 1474560467 25200 # Thu Sep 22 09:07:47 2016 -0700 # Branch stable # Node ID ac125f907dfe8f85d0c2771b3f71eaec788d9ea0 # Parent 8f902ec9ed9a296d92c2c2df1536af8c44b5321c evolve: fix the way evolve checks whether dirstate.write has arguments

[PATCH evolve-ext] evolve: fix test breaks related to double->single quote changes

# HG changeset patch # User Kostia Balytskyi # Date 1474560930 25200 # Thu Sep 22 09:15:30 2016 -0700 # Branch stable # Node ID bc4c9029017b8dbc35d4bb47b9be23f2c85ca121 # Parent ac125f907dfe8f85d0c2771b3f71eaec788d9ea0 evolve: fix test breaks related to double->single quote changes d

[PATCH remotenames-ext] tests: fix failures related to double->single quote changes

# HG changeset patch # User Kostia Balytskyi # Date 1474562531 25200 # Thu Sep 22 09:42:11 2016 -0700 # Node ID 3aa5c4dbf5086615dbbe42b0d2d9fd5ca0488cf1 # Parent 7a6c5ff76f225c8ebe9baef9d5ef753da915aa8b tests: fix failures related to double->single quote changes diff --git a/tests/t

[PATCH remotenames-ext] bookmarks: adopt the formatter isplain method

# HG changeset patch # User Kostia Balytskyi # Date 1475508913 25200 # Mon Oct 03 08:35:13 2016 -0700 # Node ID bc204ce8544ee98aed0119cbf5eec6a3618bf0db # Parent e4c0713ea86204b900a2e1cce238f61e4bef2062 bookmarks: adopt the formatter isplain method Main hg repo changed the way formatter is

[PATCH remotenames-ext] tests: adjust tests to respect negation in cmd flags

# HG changeset patch # User Kostia Balytskyi # Date 1475505045 25200 # Mon Oct 03 07:30:45 2016 -0700 # Node ID e4c0713ea86204b900a2e1cce238f61e4bef2062 # Parent 3aa5c4dbf5086615dbbe42b0d2d9fd5ca0488cf1 tests: adjust tests to respect negation in cmd flags diff --git a/tests/test

Re: [PATCH remotenames-ext] bookmarks: adopt the formatter isplain method

On 10/3/16, 5:29 PM, "Mercurial-devel on behalf of Kevin Bullock" wrote: > On Oct 3, 2016, at 10:48, Kostia Balytskyi wrote: > > # HG changeset patch > # User Kostia Balytskyi > # Date 1475508913 25200 > # Mon Oct 03 08:35:1

[PATCH evolve-ext] tests: adjust tests to respect cmd flag negation from core

# HG changeset patch # User Kostia Balytskyi # Date 1475575213 25200 # Tue Oct 04 03:00:13 2016 -0700 # Branch stable # Node ID 322d537de6654e211c2f10e5c55d974fdc0c90b2 # Parent 8f902ec9ed9a296d92c2c2df1536af8c44b5321c tests: adjust tests to respect cmd flag negation from core diff --git a

[PATCH 4 of 8 shelve-ext] shelve: move mutableancestors to not be a closure

# HG changeset patch # User Kostia Balytskyi # Date 1478527237 28800 # Mon Nov 07 06:00:37 2016 -0800 # Node ID 391086e9759e7787fbf8eb2b78202bfc2267245c # Parent b75505c45921802d9480f1629fca4fdd7f9394d3 shelve: move mutableancestors to not be a closure diff --git a/hgext/shelve.py b/hgext

[PATCH 7 of 8 shelve-ext] shelve: move actual created commit shelving to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478543425 28800 # Mon Nov 07 10:30:25 2016 -0800 # Node ID 914e385828e4597d1e1ae0a97d8cd24a32d8e029 # Parent 31ef2cba32928a93982ea6adea2d189030ce18bf shelve: move actual created commit shelving to a separate function Currently, this

[PATCH 2 of 8 shelve-ext] shelve: move shelve name generation to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478527237 28800 # Mon Nov 07 06:00:37 2016 -0800 # Node ID 334f462a1c345e5fa453ea641281ef9713789718 # Parent b2d851fac63c8e12605948c7d182f86974b5096c shelve: move shelve name generation to a separate function diff --git a/hgext/shelve.py

[PATCH 3 of 8 shelve-ext] shelve: move argument processing out of the locked code

# HG changeset patch # User Kostia Balytskyi # Date 1478527237 28800 # Mon Nov 07 06:00:37 2016 -0800 # Node ID b75505c45921802d9480f1629fca4fdd7f9394d3 # Parent 334f462a1c345e5fa453ea641281ef9713789718 shelve: move argument processing out of the locked code diff --git a/hgext/shelve.py b

[PATCH 6 of 8 shelve-ext] shelve: move 'nothing changed' messaging to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478543425 28800 # Mon Nov 07 10:30:25 2016 -0800 # Node ID 31ef2cba32928a93982ea6adea2d189030ce18bf # Parent 30a215efa288dea9294407037ed962d9ec466b23 shelve: move 'nothing changed' messaging to a separate function diff --g

[PATCH 8 of 8 shelve-ext] shelve: move unknown files handling to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478543425 28800 # Mon Nov 07 10:30:25 2016 -0800 # Node ID 3a015218113bab2d079327c89609796392d37652 # Parent 914e385828e4597d1e1ae0a97d8cd24a32d8e029 shelve: move unknown files handling to a separate function diff --git a/hgext/shelve.py

[PATCH 1 of 8 shelve-ext] shelve: move possible shelve file extensions to a single place

# HG changeset patch # User Kostia Balytskyi # Date 1478529210 28800 # Mon Nov 07 06:33:30 2016 -0800 # Node ID b2d851fac63c8e12605948c7d182f86974b5096c # Parent d500ddae7494772e5eb867fccc6876f5f0c21dac shelve: move possible shelve file extensions to a single place This and a couple of

[PATCH 5 of 8 shelve-ext] shelve: move commitfunc creation to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478605764 28800 # Tue Nov 08 03:49:24 2016 -0800 # Node ID 30a215efa288dea9294407037ed962d9ec466b23 # Parent 391086e9759e7787fbf8eb2b78202bfc2267245c shelve: move commitfunc creation to a separate function diff --git a/hgext/shelve.py b

Re: [PATCH 1 of 8 shelve-ext] shelve: move possible shelve file extensions to a single place

I have already found some bugs in these refactorings, which surface themselves when I am trying to add obsolescence-based shelve. I will fix those and send a v2. In a meantime, any comments are very welcome. On 11/8/16, 1:51 PM, "Mercurial-devel on behalf of Kostia Balytskyi" wrote:

Re: [PATCH 2 of 8 shelve-ext] shelve: move shelve name generation to a separate function

On 11/9/16, 10:01 AM, "Durham Goode" wrote: On 11/8/16 1:51 PM, Kostia Balytskyi wrote: > # HG changeset patch > # User Kostia Balytskyi > # Date 1478527237 28800 > # Mon Nov 07 06:00:37 2016 -0800 > # Node ID 334f462a1c345e5

Re: [PATCH 3 of 8 shelve-ext] shelve: move argument processing out of the locked code

On 11/9/16, 10:04 AM, "Durham Goode" wrote: On 11/8/16 1:51 PM, Kostia Balytskyi wrote: > # HG changeset patch > # User Kostia Balytskyi > # Date 1478527237 28800 > # Mon Nov 07 06:00:37 2016 -0800 > # Node ID b75505c45921802

[PATCH 5 of 8 shelve-ext v2] shelve: move 'nothing changed' messaging to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478777581 28800 # Thu Nov 10 03:33:01 2016 -0800 # Node ID 455f00c4d332ae42498a4089aa4a54f135c802ed # Parent 5e827a6196fe903c16123068ce8b312e5840ae57 shelve: move 'nothing changed' messaging to a separate function This has not

[PATCH 3 of 8 shelve-ext v2] shelve: move mutableancestors to not be a closure

# HG changeset patch # User Kostia Balytskyi # Date 1478777047 28800 # Thu Nov 10 03:24:07 2016 -0800 # Node ID 98fdb6cda2b2cb38435560134c52a4ebb8859b45 # Parent dc50b5aa86a26417f3f6dee97ea762da3d891f1d shelve: move mutableancestors to not be a closure There's no value in it be

[PATCH 7 of 8 shelve-ext v2] shelve: move unknown files handling to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478776828 28800 # Thu Nov 10 03:20:28 2016 -0800 # Node ID d77543b3c0f6cd8dfc00be6060ef93743d98eeeb # Parent f2a82865a03b0f36478fae50f60b00aa64d806c2 shelve: move unknown files handling to a separate function This change has nothing to

[PATCH 4 of 8 shelve-ext v2] shelve: move commitfunc creation to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478777191 28800 # Thu Nov 10 03:26:31 2016 -0800 # Node ID 5e827a6196fe903c16123068ce8b312e5840ae57 # Parent 98fdb6cda2b2cb38435560134c52a4ebb8859b45 shelve: move commitfunc creation to a separate function Special commitfuncs are created

[PATCH 1 of 8 shelve-ext v2] shelve: move possible shelve file extensions to a single place

# HG changeset patch # User Kostia Balytskyi # Date 1478776040 28800 # Thu Nov 10 03:07:20 2016 -0800 # Node ID ee1dc341d44f9408bdf960eb5a97abf1a1c69930 # Parent 494d5cec0b07653a6b5dec768dea92ffa987 shelve: move possible shelve file extensions to a single place This and a couple of

[PATCH 2 of 8 shelve-ext v2] shelve: move shelve name generation to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478776975 28800 # Thu Nov 10 03:22:55 2016 -0800 # Node ID dc50b5aa86a26417f3f6dee97ea762da3d891f1d # Parent ee1dc341d44f9408bdf960eb5a97abf1a1c69930 shelve: move shelve name generation to a separate function This has nothing to do with

[PATCH 6 of 8 shelve-ext v2] shelve: move actual created commit shelving to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478776040 28800 # Thu Nov 10 03:07:20 2016 -0800 # Node ID f2a82865a03b0f36478fae50f60b00aa64d806c2 # Parent 455f00c4d332ae42498a4089aa4a54f135c802ed shelve: move actual created commit shelving to a separate function Currently, this

[PATCH 8 of 8 shelve-ext v2] shelve: move shelve-finishing logic to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478776541 28800 # Thu Nov 10 03:15:41 2016 -0800 # Node ID 2188194ca1ee86953855e0d2fb9396ec18636ed9 # Parent d77543b3c0f6cd8dfc00be6060ef93743d98eeeb shelve: move shelve-finishing logic to a separate function With future obs-based shelve

Re: [PATCH] rebase: update _rebaseset inside transaction

This looks good to me. On 11/10/16, 11:56 AM, "Mercurial-devel on behalf of Durham Goode" wrote: # HG changeset patch # User Durham Goode # Date 1478778918 28800 # Thu Nov 10 03:55:18 2016 -0800 # Node ID f3bfa374cea66cd5bf17645ccb6eef60c4d8a5aa # Parent 3fd53cc1

[PATCH 3 of 5 shelve-ext] shelve: move rebasing logic to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478804230 28800 # Thu Nov 10 10:57:10 2016 -0800 # Node ID 36d052f32bf4efe1f17b8cf3cf022b1f032298f2 # Parent bce5daba05f23d87b3231c7dd28014f881b4de32 shelve: move rebasing logic to a separate function Rebasing restored shelved commit

[PATCH 5 of 5 shelve-ext] shelve: move unshelve-finishing logic to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478876487 28800 # Fri Nov 11 07:01:27 2016 -0800 # Node ID c34ee36f4e7fe6b04ea1b4e2f032e995fe65d6c5 # Parent dce4581dcae386c3d3b420911350d176c0423520 shelve: move unshelve-finishing logic to a separate function Finishing unshelve

[PATCH 2 of 5 shelve-ext] shelve: move commit restoration logic to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478803866 28800 # Thu Nov 10 10:51:06 2016 -0800 # Node ID bce5daba05f23d87b3231c7dd28014f881b4de32 # Parent 45dbc9a803375958310bced301227b02802372b0 shelve: move commit restoration logic to a separate function diff --git a/hgext

[PATCH 1 of 5 shelve-ext] shelve: move temporary commit creation to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1479036952 28800 # Sun Nov 13 03:35:52 2016 -0800 # Node ID 45dbc9a803375958310bced301227b02802372b0 # Parent 2188194ca1ee86953855e0d2fb9396ec18636ed9 shelve: move temporary commit creation to a separate function Committing working copy

[PATCH 4 of 5 shelve-ext] shelve: move file-forgetting logic to a separate function

# HG changeset patch # User Kostia Balytskyi # Date 1478804559 28800 # Thu Nov 10 11:02:39 2016 -0800 # Node ID dce4581dcae386c3d3b420911350d176c0423520 # Parent 36d052f32bf4efe1f17b8cf3cf022b1f032298f2 shelve: move file-forgetting logic to a separate function This is just a readability

[PATCH] conflicts: make spacing consistent in conflict markers

# HG changeset patch # User Kostia Balytskyi # Date 1479598897 28800 # Sat Nov 19 15:41:37 2016 -0800 # Node ID 5f03a63d6def1cf3c34fa7f8979c34151a9ba660 # Parent 0c3a8b6239db2c0d6a0e9ddea2266445bca2d440 conflicts: make spacing consistent in conflict markers The way default marker template

Re: [PATCH 1 of 5 shelve-ext] shelve: move temporary commit creation to a separate function

On 11/19/16, 10:02 AM, "Yuya Nishihara" wrote: On Sun, 13 Nov 2016 03:39:34 -0800, Kostia Balytskyi wrote: > # HG changeset patch > # User Kostia Balytskyi > # Date 1479036952 28800 > # Sun Nov 13 03:35:52 2016

[PATCH RFC] ui: add configoverride context manager

# HG changeset patch # User Kostia Balytskyi # Date 1479658212 28800 # Sun Nov 20 08:10:12 2016 -0800 # Node ID b226d57bafe182f379b144ec4f6374fedfc124ef # Parent 141b0d27e9e1e846215ead5314237536efc1a185 ui: add configoverride context manager I feel like this idea might've been disc

[PATCH v2] ui: add configoverride context manager

# HG changeset patch # User Kostia Balytskyi # Date 1479774146 28800 # Mon Nov 21 16:22:26 2016 -0800 # Node ID a7c57b059190f02a450667411d92d9a4862f6375 # Parent 141b0d27e9e1e846215ead5314237536efc1a185 ui: add configoverride context manager I feel like this idea might've been disc

[PATCH shelve-ext] shelve: make --keep option survive user intevention (issue5431)

# HG changeset patch # User Kostia Balytskyi # Date 1479926825 28800 # Wed Nov 23 10:47:05 2016 -0800 # Node ID 90b1e0d3e7daaf489428e0b9028cd7b32f37ea70 # Parent db897ddf3a8ebb8df9556ce97de11f6380a9ef0b shelve: make --keep option survive user intevention (issue5431) Currently if user runs

[PATCH shelve-ext v2] shelve: make --keep option survive user intevention (issue5431)

# HG changeset patch # User Kostia Balytskyi # Date 1479941932 28800 # Wed Nov 23 14:58:52 2016 -0800 # Node ID 00a022e44b62cb9340dfac94096b14f77407cefb # Parent db897ddf3a8ebb8df9556ce97de11f6380a9ef0b shelve: make --keep option survive user intevention (issue5431) Currently if user runs

Re: [PATCH] ui: use try..finally in configoverride

On 11/27/16, 9:10 AM, "Mercurial-devel on behalf of Yuya Nishihara" wrote: On Sat, 26 Nov 2016 09:14:46 -0800, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1480180481 28800 > # Sat Nov 26 09:14:41 2016 -0800 > # Node ID ace32ef8bb5a166

Re: [PATCH 2 of 2] formatter: add overview of API and example as doctest

I like this and previous patch, but if the purpose of this one is to provide examlpes to developers, should we maybe also include debugformatter? On 11/27/16, 1:45 PM, "Mercurial-devel on behalf of Yuya Nishihara" wrote: # HG changeset patch # User Yuya Nishihara # Date 1477116131

[PATCH shelve-ext] shelve: fix use of unexpected working dirs in test-shelve.t

# HG changeset patch # User Kostia Balytskyi # Date 1480421465 28800 # Tue Nov 29 04:11:05 2016 -0800 # Node ID b4e28d31201c6af4c677c53b42c140b3cfb3d352 # Parent 6d69c3708cf3b9a70403c3d3cb3c44ff1e8faf53 shelve: fix use of unexpected working dirs in test-shelve.t Fixing some clowniness

[PATCH 09 of 10 shelve-ext] shelve: add obs-based unshelve functionality

# HG changeset patch # User Kostia Balytskyi # Date 1480431173 28800 # Tue Nov 29 06:52:53 2016 -0800 # Node ID 533d99eca3bf11c4aac869674e0abb16b74ed670 # Parent 85c9c651887915733feb3d385866955741f28ec0 shelve: add obs-based unshelve functionality Obsolescense-based unshelve works as

[PATCH 04 of 10 shelve-ext] shelve: move node-pruning functionality to be member of shelvedstate

# HG changeset patch # User Kostia Balytskyi # Date 1480425731 28800 # Tue Nov 29 05:22:11 2016 -0800 # Node ID 4166a4cfdc14629e169f12e83607b065887594b7 # Parent 93bb69fa1f1abbe0a42455ad8df691fdf29b2e3a shelve: move node-pruning functionality to be member of shelvedstate Node-pruning can

[PATCH 05 of 10 shelve-ext] shelve: add a function to check whether obs-based shelve is enabled

# HG changeset patch # User Kostia Balytskyi # Date 1480426659 28800 # Tue Nov 29 05:37:39 2016 -0800 # Node ID 7f225df4c58b4f62a7883f95349cdb9e9c86e15e # Parent 4166a4cfdc14629e169f12e83607b065887594b7 shelve: add a function to check whether obs-based shelve is enabled A central place to

[PATCH 02 of 10 shelve-ext] shelve: add an ability to write json to a new type of shelve files

# HG changeset patch # User Kostia Balytskyi # Date 1480426193 28800 # Tue Nov 29 05:29:53 2016 -0800 # Node ID 37119e028c699d9fabd220086e08c754827e709f # Parent f6f0ab3f7b0ea0e05cfdcd7afd4994ea21988fd9 shelve: add an ability to write json to a new type of shelve files Obsolescense-based

[PATCH 08 of 10 shelve-ext] shelve: migrate config overrides to ui.configoverride

# HG changeset patch # User Kostia Balytskyi # Date 1480427488 28800 # Tue Nov 29 05:51:28 2016 -0800 # Node ID 85c9c651887915733feb3d385866955741f28ec0 # Parent bcf8d603cc8b678f875ceca24dd2b14eda09bce7 shelve: migrate config overrides to ui.configoverride This patch also makes ui.quiet

[PATCH 01 of 10 shelve-ext] shelve: move patch extension to a string constant

# HG changeset patch # User Kostia Balytskyi # Date 1480432803 28800 # Tue Nov 29 07:20:03 2016 -0800 # Node ID f6f0ab3f7b0ea0e05cfdcd7afd4994ea21988fd9 # Parent 64b55bffc1c059eb4c11ca195b561ca8a287f59e shelve: move patch extension to a string constant We are using 'name + &q

[PATCH 03 of 10 shelve-ext] shelve: rename stripnodes to nodestoprune

# HG changeset patch # User Kostia Balytskyi # Date 1480425731 28800 # Tue Nov 29 05:22:11 2016 -0800 # Node ID 93bb69fa1f1abbe0a42455ad8df691fdf29b2e3a # Parent 37119e028c699d9fabd220086e08c754827e709f shelve: rename stripnodes to nodestoprune Since we are introducing obs-based shelve, we

[PATCH 06 of 10 shelve-ext] shelve: add obs-based shelve functionality

# HG changeset patch # User Kostia Balytskyi # Date 1480427179 28800 # Tue Nov 29 05:46:19 2016 -0800 # Node ID d1356cbb72cfe91a2b427098c66bc00937912d79 # Parent 7f225df4c58b4f62a7883f95349cdb9e9c86e15e shelve: add obs-based shelve functionality Obsolescense-based shelve works in a

[PATCH 07 of 10 shelve-ext] shelve: add shelve type saving and loading

# HG changeset patch # User Kostia Balytskyi # Date 1480425731 28800 # Tue Nov 29 05:22:11 2016 -0800 # Node ID bcf8d603cc8b678f875ceca24dd2b14eda09bce7 # Parent d1356cbb72cfe91a2b427098c66bc00937912d79 shelve: add shelve type saving and loading We need shelve type to be stored in .hg

[PATCH 10 of 10 shelve-ext] shelve: add logic to preserve active bookmarks

# HG changeset patch # User Kostia Balytskyi # Date 1480431519 28800 # Tue Nov 29 06:58:39 2016 -0800 # Node ID 5c55e23c067998adf36b9a2c6eb028ba1a7fc643 # Parent 533d99eca3bf11c4aac869674e0abb16b74ed670 shelve: add logic to preserve active bookmarks This adds an explicit active-bookmark

Re: mercurial@30541: 92 new changesets

736f01a710 changeset: 30453:2e736f01a710 user: Kostia Balytskyi date:Sun Nov 13 03:35:52 2016 -0800 summary: shelve: move temporary commit creation to a separate function http://selenic.com/repo/hg//rev/672026aece64 changeset: 30454:672026aece64 user:

Re: [PATCH evolve-ext] wireproto: chunking and compression is forthwith to be handled by hgweb

This looks good to me, although I would maybe perform a more thorough check than just catching a TypeError. For example, something like check: if “v1compressible” in wireproto.streamres.__init__.__code__.co_varnames: pass this arg else: don’t pass it On 11/29/16, 4:10 PM,

Re: [PATCH 02 of 10 shelve-ext] shelve: add an ability to write json to a new type of shelve files

On 11/29/16, 3:55 PM, "Jun Wu" wrote: Excerpts from Kostia Balytskyi's message of 2016-11-29 07:22:56 -0800: > # HG changeset patch > # User Kostia Balytskyi > # Date 1480426193 28800 > # Tue Nov 29 05:29:53

Re: [PATCH V2] evolve: improve error message if unstable changes are disallowed

Shouldn’t we mention the config in a hint message? On 11/25/16, 12:28 PM, "Mercurial-devel on behalf of Mateusz Kwapich" wrote: LGTM, I suppose that timeless may also want to review it before it's queued. Excerpts from Pulkit Goyal's message of 2016-11-24 23:13:48 +0530: >

Re: [PATCH V2 evolve-ext] wireproto: chunking and compression is forthwith to be handled by hgweb

This looks good to me. On 11/30/16, 11:26 AM, "Mercurial-devel on behalf of Martijn Pieters" wrote: # HG changeset patch # User Martijn Pieters # Date 1480504675 0 # Wed Nov 30 11:17:55 2016 + # Node ID 5bfbd771d6348b10edabfbd2c61f412bb66c87ae # Parent cb2bac

Re: [PATCH 09 of 10 shelve-ext] shelve: add obs-based unshelve functionality

From: Martin von Zweigbergk Date: Wednesday, November 30, 2016 at 6:24 AM To: Kostia Balytskyi , "mercurial-devel@mercurial-scm.org" Subject: Re: [PATCH 09 of 10 shelve-ext] shelve: add obs-based unshelve functionality On Tue, Nov 29, 2016, 08:23 Kostia Balytskyi mailto:ikos

Re: [PATCH 09 of 10 shelve-ext] shelve: add obs-based unshelve functionality

Replying one more time to make stuff readable. On 11/30/16 1:46 PM, Kostia Balytskyi wrote: From: Martin von Zweigbergk <mailto:martinv...@google.com> Date: Wednesday, November 30, 2016 at 6:24 AM To: Kostia Balytskyi <mailto:ikos...@fb.com>, "mercurial-devel@

Re: [PATCH 1 of 2] tests: use cp -R instead of cp -r

Good catch! On 11/30/16 5:34 PM, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1480526736 0 > # Wed Nov 30 17:25:36 2016 + > # Node ID a4f46a03e5f8e33f32c36326c6b14b84d9cb03b4 > # Parent 9e29d4e4e08b5996adda49cdd0b497d89e2b16ee > # Available At https://bitbucket.org/quar

Re: [PATCH 09 of 10 shelve-ext] shelve: add obs-based unshelve functionality

On 11/29/16 4:26 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-11-29 07:23:03 -0800: >> # HG changeset patch >> # User Kostia Balytskyi >> # Date 1480431173 28800 >> # Tue Nov 29 06:52:53 2016 -0800 >> # Node ID 533d99eca3bf11

[PATCH RFC] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1480808065 28800 # Sat Dec 03 15:34:25 2016 -0800 # Node ID c4312906ef7d06dc3be1575ee5cde574b915c9c4 # Parent 715232cf9182f904d5153862a1ec4905faaeee6e scmutil: add a simple key-value file helper The purpose of the added class is to serve

[PATCH RFC v2] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1480967781 28800 # Mon Dec 05 11:56:21 2016 -0800 # Node ID eceaa3ab833141da00291a236a20ca0be0b4b3b0 # Parent 243ecbd4f5c9f452275d4435866359cf84dc03ff scmutil: add a simple key-value file helper The purpose of the added class is to serve

Re: [PATCH] chgserver: call "load" for new ui objects

LGTM. On 12/5/16 9:37 PM, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1480973795 0 > # Mon Dec 05 21:36:35 2016 + > # Node ID b1877dc4bd741a4855c3fda0d473e5d821f5c4e2 > # Parent 2463b16bbd3710b619e0e948651db9948341f990 > # Available At https://bitbucket.org/quark-zju/h

Re: [PATCH RFC] scmutil: add a simple key-value file helper

On 12/5/16 9:54 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-03 15:37:55 -0800: >> # HG changeset patch >> # User Kostia Balytskyi >> # Date 1480808065 28800 >> # Sat Dec 03 15:34:25 2016 -0800 >> # Node ID c4312906ef7d06

[PATCH RFC v3] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1480978778 28800 # Mon Dec 05 14:59:38 2016 -0800 # Node ID bdc49209b0b926214e865f9a98ea987866f64d68 # Parent 243ecbd4f5c9f452275d4435866359cf84dc03ff scmutil: add a simple key-value file helper The purpose of the added class is to serve

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

On 12/6/16 1:04 PM, Yuya Nishihara wrote: > On Mon, 5 Dec 2016 15:03:35 -0800, Kostia Balytskyi wrote: >> # HG changeset patch >> # User Kostia Balytskyi >> # Date 1480978778 28800 >> # Mon Dec 05 14:59:38 2016 -0800 >> # Node ID bdc49209b0b926214e8

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

On 12/6/16 1:28 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 13:22:40 +: >> On 12/6/16 1:04 PM, Yuya Nishihara wrote: >>> On Mon, 5 Dec 2016 15:03:35 -0800, Kostia Balytskyi wrote: >>>> # HG changeset patch >>>>

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

On 12/6/16 1:48 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 13:39:31 +: >> Hm, I don't see how upper/lower-case instead of explicit boolean flag >> handles that... > I didn't realize the issue either, before Yuya's reply. > >> But to answer your question: >> 1.

[PATCH RFC v5] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1481032921 28800 # Tue Dec 06 06:02:01 2016 -0800 # Node ID 79336a94b7709f8680fd6975c39bac41759ec6f4 # Parent 243ecbd4f5c9f452275d4435866359cf84dc03ff scmutil: add a simple key-value file helper The purpose of the added class is to serve

[PATCH RFC v4] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1481032446 28800 # Tue Dec 06 05:54:06 2016 -0800 # Node ID 008bf4590cd2bed2329ad5eb8f2ad3e2bd121f2d # Parent 243ecbd4f5c9f452275d4435866359cf84dc03ff scmutil: add a simple key-value file helper The purpose of the added class is to serve

Re: [PATCH RFC v4] scmutil: add a simple key-value file helper

Please disregard v4, see v5. On 12/6/16 2:01 PM, Kostia Balytskyi wrote: > # HG changeset patch > # User Kostia Balytskyi > # Date 1481032446 28800 > # Tue Dec 06 05:54:06 2016 -0800 > # Node ID 008bf4590cd2bed2329ad5eb8f2ad3e2bd121f2d > # Parent 243ecbd4f5c9f452275d44

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

On 12/6/16 2:08 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 13:54:02 +: >> This is what happens if you don't inherit the class or don't override >> the empty KEYS list in the inherited class. > If KEYS is used to verify existence, how about just making it a list

[PATCH RFC v6] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1481034715 28800 # Tue Dec 06 06:31:55 2016 -0800 # Node ID 99bf22661062bb7d28ece67d94ebf421e3440731 # Parent 243ecbd4f5c9f452275d4435866359cf84dc03ff scmutil: add a simple key-value file helper The purpose of the added class is to serve

Re: [PATCH 2 of 2] localrepo: use ProgrammingError

Both patches look good to me. On 12/6/16 5:13 PM, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1481043999 0 > # Tue Dec 06 17:06:39 2016 + > # Node ID 5197933cb8b90a976be3d298b5f51b154fd8e733 > # Parent 67bcd43e64ca03f486a817fccf38e83020b06793 > # Available At https://b

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

On 12/6/16 2:45 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 14:30:18 +: >> On 12/6/16 2:08 PM, Jun Wu wrote: >>> Excerpts from Kostia Balytskyi's message of 2016-12-06 13:54:02 +: This is what happens if you don't inherit the class or don't override >>>

[PATCH RFC v7] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1481060343 28800 # Tue Dec 06 13:39:03 2016 -0800 # Node ID 211cfe5a24d18218720c38a601dfb2b88373b59a # Parent 831d29deed083618bddc2fade7d2a6fe297c896d scmutil: add a simple key-value file helper The purpose of the added class is to serve

Re: [PATCH RFC v7] scmutil: add a simple key-value file helper

On 12/6/16 9:53 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 13:41:07 -0800: >> class CorruptedState(Exception): >> """error raised when a command is not able to read its state from >> file""" >> + >> +class MissingRequiredKeyInFileException(Exception): >> +

Re: [PATCH 1 of 6 v2] [convert] Use convert_revision for P4 imports

On 12/7/16 9:30 PM, David Soria Parra wrote: > # HG changeset patch > # User David Soria Parra > # Date 1480895549 28800 > # Sun Dec 04 15:52:29 2016 -0800 > # Node ID ade3103f5cf939007ca73af5e9e5853643dc8264 > # Parent 48bf03a8f718f870256f79cbdf10550ca92c7f25 > [convert] Use convert_revisio

Re: [PATCH 4 of 6 v3] convert: Parse perforce changes when needed, not in the constructor

On 12/7/16 9:51 PM, David Soria Parra wrote: > # HG changeset patch > # User David Soria Parra > # Date 1481139471 28800 > # Wed Dec 07 11:37:51 2016 -0800 > # Node ID e3c34b2fafd7ce1a78d23e35888a33ef10629fbf > # Parent 897be730ab884aa8f7373a34eeb6a288cc1dabc7 > convert: Parse perforce cha

Re: [PATCH 6 of 6 v3] convert: Create commits from revmap list if needed

On 12/7/16 9:51 PM, David Soria Parra wrote: > # HG changeset patch > # User David Soria Parra > # Date 1481143876 28800 > # Wed Dec 07 12:51:16 2016 -0800 > # Node ID 109de539306c5bc49d38d6f1c802c4a8d092b485 > # Parent be68e4436851b7e20f3b8cb34666418f5840dd66 > convert: Create commits from

Re: [PATCH 6 of 6 v3] convert: Create commits from revmap list if needed

On 12/8/16 12:18 AM, David Soria Parra wrote: > On Wed, Dec 07, 2016 at 10:23:08PM +0000, Kostia Balytskyi wrote: >> On 12/7/16 9:51 PM, David Soria Parra wrote: >>> # HG changeset patch >>> # User David Soria Parra >>> # Date 1481143876 28800 >&

Re: [PATCH 6 of 8 v4] convert: do not provide head revisions if we have no changests to import

On 12/14/16 9:46 AM, David Soria Parra wrote: > # HG changeset patch > # User David Soria Parra > # Date 1481694598 28800 > # Tue Dec 13 21:49:58 2016 -0800 > # Node ID c6c26e238617600d0523b44a9043d17f963f9eda > # Parent 4b9d267d2a05970d9320b83f8bf29ec99f8ab40f > convert: do not provide he

Re: [PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

On 12/14/16 9:46 AM, David Soria Parra wrote: > # HG changeset patch > # User David Soria Parra > # Date 1481704712 28800 > # Wed Dec 14 00:38:32 2016 -0800 > # Node ID eb4a6df3de20deb31e681aa7eba408dc352440c3 > # Parent 26ec2474ab06fdaf1aca034c54309245ded267b0 > convert: return commit obj

Re: [PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

Other than the nit below, this series LGTM. On 12/14/16 4:53 PM, Kostia Balytskyi wrote: > > On 12/14/16 9:46 AM, David Soria Parra wrote: >> # HG changeset patch >> # User David Soria Parra >> # Date 1481704712 28800 >> # Wed Dec 14 00

[PATCH RFC v8] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1481734993 28800 # Wed Dec 14 09:03:13 2016 -0800 # Node ID 0973a68a3dcdfb7154e8ab27b7bb7028e97dd516 # Parent 95b076f5ddee5ab7bd208b8c2f42121ce9907129 scmutil: add a simple key-value file helper The purpose of the added class is to serve

Re: [PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

On 12/14/16 5:55 PM, David Soria Parra wrote: > On Wed, Dec 14, 2016 at 04:53:24PM +0000, Kostia Balytskyi wrote: >> >> On 12/14/16 9:46 AM, David Soria Parra wrote: >>> # HG changeset patch >>> # User David Soria Parra >>> # Date 1481704712 28800

Re: [PATCH RFC v7] scmutil: add a simple key-value file helper

On 12/15/16 4:49 PM, Augie Fackler wrote: > On Wed, Dec 14, 2016 at 03:17:42AM +0100, Pierre-Yves David wrote: >> >> On 12/06/2016 10:53 PM, Jun Wu wrote: >>> Excerpts from Kostia Balytskyi's message of 2016-12-06 13:41:07 -0800: class CorruptedState(Exception): """error raised whe

Re: [PATCH RFC v8] scmutil: add a simple key-value file helper

On 12/16/2016 6:45 PM, Augie Fackler wrote: > On Fri, Dec 16, 2016 at 1:35 PM, Augie Fackler wrote: >>> scmutil: add a simple key-value file helper >>> >> At this point, I think I'd like to see obs-shelve too. Is there a >> place I can do that? > (Specifically: before we do a resend of this, I'd

[PATCH v9 RFC] scmutil: add a simple key-value file helper

# HG changeset patch # User Kostia Balytskyi # Date 1484824655 28800 # Thu Jan 19 03:17:35 2017 -0800 # Node ID 19a449c91ef14e691cf1347748473e0094fedc86 # Parent 9f264adbe75bfae8551dc0e6e0fce8d43fc7b43a scmutil: add a simple key-value file helper The purpose of the added class is to serve

[PATCH 01 of 10 shelve-ext v2] shelve: add an ability to write key-val data to a new type of shelve files

# HG changeset patch # User Kostia Balytskyi # Date 1484835841 28800 # Thu Jan 19 06:24:01 2017 -0800 # Node ID d904df83e9ead56f65104e10d765c0157d647401 # Parent 19a449c91ef14e691cf1347748473e0094fedc86 shelve: add an ability to write key-val data to a new type of shelve files Obsolescense

[PATCH 10 of 10 shelve-ext v2] shelve: disable inhibit for shelving period

# HG changeset patch # User Kostia Balytskyi # Date 1484838335 28800 # Thu Jan 19 07:05:35 2017 -0800 # Node ID 6a7e7659886d35dfdc4d7d5efb3ef8479ae35367 # Parent 088c9191d662d5c0003310119c51540926a815f7 shelve: disable inhibit for shelving period While shelving, we're creating a new c

[PATCH 07 of 10 shelve-ext v2] shelve: migrate config overrides to ui.configoverride

# HG changeset patch # User Kostia Balytskyi # Date 1484740179 28800 # Wed Jan 18 03:49:39 2017 -0800 # Node ID abdf9565fdce15604ea4abf013cb7c98a11f70ca # Parent 149fc6d767ce3502528b43b0e209eb411dd6e842 shelve: migrate config overrides to ui.configoverride This patch also makes ui.quiet

[PATCH 05 of 10 shelve-ext v2] shelve: add obs-based shelve functionality

# HG changeset patch # User Kostia Balytskyi # Date 1484740179 28800 # Wed Jan 18 03:49:39 2017 -0800 # Node ID 44425c4e86b2589184e23bed798999c15788b54b # Parent ceb709491816f84789b77a18bfcab15eaa9860fe shelve: add obs-based shelve functionality Obsolescense-based shelve works in a

[PATCH 09 of 10 shelve-ext v2] shelve: add logic to preserve active bookmarks

# HG changeset patch # User Kostia Balytskyi # Date 1484740179 28800 # Wed Jan 18 03:49:39 2017 -0800 # Node ID 088c9191d662d5c0003310119c51540926a815f7 # Parent 94a237a046059ef246aacb2c3ad809c9f0bdbe70 shelve: add logic to preserve active bookmarks This adds an explicit active-bookmark

[PATCH 08 of 10 shelve-ext v2] shelve: add obs-based unshelve functionality

# HG changeset patch # User Kostia Balytskyi # Date 1484835394 28800 # Thu Jan 19 06:16:34 2017 -0800 # Node ID 94a237a046059ef246aacb2c3ad809c9f0bdbe70 # Parent abdf9565fdce15604ea4abf013cb7c98a11f70ca shelve: add obs-based unshelve functionality Obsolescense-based unshelve works as

[PATCH 04 of 10 shelve-ext v2] shelve: add a function to check whether obs-based shelve is enabled

# HG changeset patch # User Kostia Balytskyi # Date 1484740179 28800 # Wed Jan 18 03:49:39 2017 -0800 # Node ID ceb709491816f84789b77a18bfcab15eaa9860fe # Parent 249273f6db8bf0fdfbbf36bcbd9e3553e5715212 shelve: add a function to check whether obs-based shelve is enabled A central place to

[PATCH 03 of 10 shelve-ext v2] shelve: move node-pruning functionality to be member of shelvedstate

# HG changeset patch # User Kostia Balytskyi # Date 1484740179 28800 # Wed Jan 18 03:49:39 2017 -0800 # Node ID 249273f6db8bf0fdfbbf36bcbd9e3553e5715212 # Parent 155f97b77a4866075fa709daa3bef6dac9108e81 shelve: move node-pruning functionality to be member of shelvedstate Node-pruning can

[PATCH 06 of 10 shelve-ext v2] shelve: add shelve type saving and loading

# HG changeset patch # User Kostia Balytskyi # Date 1484740179 28800 # Wed Jan 18 03:49:39 2017 -0800 # Node ID 149fc6d767ce3502528b43b0e209eb411dd6e842 # Parent 44425c4e86b2589184e23bed798999c15788b54b shelve: add shelve type saving and loading We need shelve type to be stored in .hg

[PATCH 02 of 10 shelve-ext v2] shelve: rename stripnodes to nodestoprune

# HG changeset patch # User Kostia Balytskyi # Date 1484740179 28800 # Wed Jan 18 03:49:39 2017 -0800 # Node ID 155f97b77a4866075fa709daa3bef6dac9108e81 # Parent d904df83e9ead56f65104e10d765c0157d647401 shelve: rename stripnodes to nodestoprune Since we are introducing obs-based shelve, we

[PATCH shelve-ext] shelve: make unshelve not crash when there are missing files (issue4176)

# HG changeset patch # User Kostia Balytskyi # Date 1484848120 28800 # Thu Jan 19 09:48:40 2017 -0800 # Node ID 2a1e998e369d2c5dc828ba805beceb15459746cd # Parent 9f264adbe75bfae8551dc0e6e0fce8d43fc7b43a shelve: make unshelve not crash when there are missing files (issue4176) This patch

  1   2   3   >