D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o)

spectral added a comment. Since this touches `hg show work` test output, I've added indygreg as an explicit reviewer. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4363 To: spectral, #hg-reviewers, indygreg Cc: mercurial-devel _

D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o)

spectral added a comment. In https://phab.mercurial-scm.org/D4363#67015, @martinvonz wrote: > In https://phab.mercurial-scm.org/D4363#67012, @martinvonz wrote: > > > Can we have a test for this? > > > Oh, sorry, there are updated tests (my browser tab was stale when I reviewed t

D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o~)

spectral updated this revision to Diff 10540. spectral edited the summary of this revision. spectral retitled this revision from "log: respect graphshorten on terminal nodes (collapsing o-~ to just o)" to "log: respect graphshorten on terminal nodes (collapsing o-~ to just o~)". REPOSITORY rHG

D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o~)

spectral added a comment. In https://phab.mercurial-scm.org/D4363#67017, @martinvonz wrote: > In https://phab.mercurial-scm.org/D4363#67016, @spectral wrote: > > > In https://phab.mercurial-scm.org/D4363#67015, @martinvonz wrote: > > > > > In https://phab.mercurial-scm.org/D4363#67

D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o~)

spectral updated this revision to Diff 10541. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4363?vs=10540&id=10541 REVISION DETAIL https://phab.mercurial-scm.org/D4363 AFFECTED FILES mercurial/graphmod.py tests/test-logexchange.t tests/test-show-

D4364: match: document that visitchildrenset might return files

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY At least when using includematcher, and probably most matchers, we do not know if a/b/f refers to a file 'f' in a/b, or a subdirectory 'f' in a/b, so most match

D4365: match: make exactmatcher.visitchildrenset return file children as well

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, if we had an exactmatcher like ['foo.txt', 'a/bar.txt', 'a/b/c/baz.txt'], we'd get back the following data: '.': {'a'} 'a': {'b'} 'a/b

D4367: treemanifest: attempt to avoid loading all lazily-loaded subdirs in _isempty

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4367 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git a/mercurial/manifest.py b/mercur

D4369: treemanifest: avoid loading everything just to get their nodeid

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4369 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git a/mercurial/manifest.py b/mercur

D4366: treemanifest: introduce lazy loading of subdirs

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY An earlier patch series made it so that what to load was up to the calling code, which works fine until manifests are copied - when they're copied, they're loa

D4368: treemanifest: avoid unnecessary copies/processing when using alwaysmatcher

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4368 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git a/mercurial/manifest.py b/mercur

D4371: treemanifest: use visitchildrenset when doing a walk

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For this series, starting at 'introduce lazy loading of subdirs' and ending with this commit, we get the following timing numbers, using roughly the same metho

D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4370 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git a/mercurial/manifest.py b/mercur

D4364: match: document that visitchildrenset might return files

This revision was automatically updated to reflect the committed changes. Closed by commit rHG27946fca8a05: match: document that visitchildrenset might return files (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4364?

D4365: match: make exactmatcher.visitchildrenset return file children as well

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc9a3f7f5c023: match: make exactmatcher.visitchildrenset return file children as well (authored by spectral, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4365?vs=10543&id=1056

D4284: copies: correctly skip directories that have already been considered

spectral added inline comments. INLINE COMMENTS > jpsugar wrote in copies.py:615 > Maybe do this after the debug loop to avoid an un-pretty output? I personally have no preference, but had been trying to make this an unobservable difference, whereas that is technically observable (though I doub

D4284: copies: correctly skip directories that have already been considered

This revision was automatically updated to reflect the committed changes. Closed by commit rHGeebd591803ab: copies: correctly skip directories that have already been considered (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-sc

D4366: treemanifest: introduce lazy loading of subdirs

spectral planned changes to this revision. spectral added a comment. In https://phab.mercurial-scm.org/D4366#67144, @indygreg wrote: > I'm not sure how I feel about so many methods having the `if dir in self._lazydirs: self._loadlazy(dir)` pattern. > > On one hand, action at a distanc

D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o~)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3c4b2e880273: log: respect graphshorten on terminal nodes (collapsing o-~ to just o~) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial

D4361: zsh_completion: complete hg files

spectral accepted this revision. spectral added a comment. (Accept conditional on fixing/documenting the difference I noticed) INLINE COMMENTS > zsh_completion:636 > + _arguments -s -S : $_hg_global_opts $_hg_pat_opts $_hg_subrepos_opts \ > + '(--rev -r)'{-r+,--rev=}'[search the repository

D4362: zsh_completion: complete merge tools for -t/--tool

spectral accepted this revision. spectral added inline comments. INLINE COMMENTS > zsh_completion:292 > + _describe -t internal_tools 'internal merge tools' _hg_internal_merge_tools > + external_tools=(${(f)"$(_hg_cmd showconfig merge-tools | cut -d . -f 2)"}) > + (( $#external_tools )) && _de

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

spectral added a comment. Would it make sense to combine this into one hg invocation? I think it wouldn't be that hard (hmm, not as trivial as I thought, but.. not the worst thing ever? :)) allheads=(${(f)"$(_hg_cmd log -r 'sort(head(), -rev)' --template '{ifcontains(rev, revset(\".\

D4428: zsh_completion: complete shelve and unshelve

spectral added a comment. (Not marking accepted, though I'm fine with it going in as is, so that we get a chance to answer the questions before it lands) INLINE COMMENTS > zsh_completion:1272 > + > + _arguments -s -S : $_hg_global_opts $_hg_pat_opts \ > + '(--addremove -A)'{-A,--addremove}

D5112: graphmod: remove support for graph lines mixing parent/grandparent styles (BC)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2e97640c598e: graphmod: remove support for graph lines mixing parent/grandparent styles (BC) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.me

D6407: relnotes: mention removed support for mixed log graph lines

spectral accepted this revision. spectral added inline comments. INLINE COMMENTS > next:25 > + `experimental.graphstyle.grandparent = 3.` would use `!` for the > + first three lines of the graph and then `.`. This is now longer > + supported. s/now/no REPOSITORY rHG Mercurial REVISION

D6451: verify: use self._err not self.err, it changed in 7eaf4b1ac2a3

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6451 AFFECTED FILES mercurial/verify.py CHANGE DETAILS diff --git a/mercurial/verify.py b/mercurial/

D6452: tests: make run-tests exit non-zero if there are "errors"

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, if there was an error such as a broken .t file that caused run-tests.py to encounter an exception during parsing, the test would be considered in an

D6451: verify: use self._err not self.err, it changed in 7eaf4b1ac2a3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG91452f62dd53: verify: use self._err not self.err, it changed in 7eaf4b1ac2a3 (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/

D6452: tests: make run-tests exit non-zero if there are "errors"

This revision was automatically updated to reflect the committed changes. Closed by commit rHG15d5a2de44aa: tests: make run-tests exit non-zero if there are "errors" (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6452

D5768: subrepo: bytes/str cleanups on Git support

spectral updated this revision to Diff 15303. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5768?vs=13626&id=15303 REVISION DETAIL https://phab.mercurial-scm.org/D5768 AFFECTED FILES contrib/python3-whitelist mercurial/subrepo.py CHANGE DETAILS d

D6463: commit: add test showing that commit --amend --no-edit still shows editor

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6463 AFFECTED FILES tests/test-commit-amend.t CHANGE DETAILS diff --git a/tests/test-commit-amend.t

D5772: hg: raise Abort on invalid path

spectral updated this revision to Diff 15304. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5772?vs=13637&id=15304 REVISION DETAIL https://phab.mercurial-scm.org/D5772 AFFECTED FILES mercurial/hg.py mercurial/ui.py tests/test-remotefilelog-gc.t

D6464: commit: respect --no-edit in combination with --amend

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6464 AFFECTED FILES mercurial/cmdutil.py tests/test-commit-amend.t CHANGE DETAILS diff --git a/tes

D5768: subrepo: bytes/str cleanups on Git support

spectral added a comment. Oops. A typo caused me to update this diff, please ignore that. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5768 To: durin42, pulkit, #hg-reviewers Cc: spectral, yuja, mercurial-devel ___ M

D5772: hg: raise Abort on invalid path

spectral added a comment. Oops. A typo caused me to update this diff, please ignore that. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5772 To: indygreg, #hg-reviewers Cc: spectral, martinvonz, yuja, mercurial-devel

D6463: commit: add test showing that commit --amend --no-edit still shows editor

This revision was automatically updated to reflect the committed changes. Closed by commit rHG060ff3396589: commit: add test showing that commit --amend --no-edit still shows editor (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercuri

D6464: commit: respect --no-edit in combination with --amend

This revision was automatically updated to reflect the committed changes. Closed by commit rHG64ed405dd342: commit: respect --no-edit in combination with --amend (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6464?vs=

D6507: rebase: tweak description of inmemory working even w/ dirty working dir

spectral created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of our users was confused because they read this, and then attempted to run `hg rebase` with a dirty working d

D6507: rebase: tweak description of inmemory working even w/ dirty working dir

Closed by commit rHGcda591d2bfe1: rebase: tweak description of inmemory working even w/ dirty working dir (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6563: patch: use a short, fixed-size message for last line of prompt (issue6158)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY See issue6158 and the previous commit for examples of what might go wrong if we have some combinations of readline version and terminal and need to wrap the li

D6562: filemerge: make last line of prompts <40 english chars (issue6158)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I've chosen <40 as the target so that other languages that may have a 2x blowup in character count can still have a chance to fit into an 80 column screen.

D6573: prompt: add develwarn about last line of prompt >45 chars (issue6158)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6573 AFFECTED FILES mercurial/ui.py CHANGE DETAILS diff --git a/mercurial/ui.py b/mercurial/ui.py --

D6571: largefiles: make last line of prompts <40 english chars (issue6158)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6571 AFFECTED FILES hgext/largefiles/overrides.py tests/test-largefiles-misc.t tests/test-largefil

D6572: subrepos: make last line of prompts <40 english chars (issue6158)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6572 AFFECTED FILES mercurial/subrepo.py mercurial/subrepoutil.py tests/test-largefiles-update.t

D6562: filemerge: make last line of prompts <40 english chars (issue6158)

spectral added a comment. In D6562#95775 , @durin42 wrote: > I like this, but could I get you to add a patch 3 that introduces a develwarn for this? Done, and it found a couple other cases, but I'm not sure I like it (D6573

D6562: filemerge: make last line of prompts <40 english chars (issue6158)

spectral added a comment. Ah, a question: should this be lowercasing the first character of things? I think I copied this from somewhere where it did have an uppercase letter, but I wasn't consistent in my application of the leading uppercase letter. REPOSITORY rHG Mercurial CHANGES SINCE

D6574: zsh: enable completion support for chg as well

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When verifying this change, you may need to clear/rebuild the completion cache; I did this by deleting the ~/.zcompdump file and then starting a new shell. REPO

D6574: zsh: enable completion support for chg as well

Closed by commit rHG0c0e54bcea9b: zsh: enable completion support for chg as well (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6574?vs=15657&id=15678 CHANGE

D6563: patch: use a short, fixed-size message for last line of prompt (issue6158)

Closed by commit rHGf802a75da585: patch: use a short, fixed-size message for last line of prompt (issue6158) (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSIT

D6562: filemerge: make last line of prompts <40 english chars (issue6158)

Closed by commit rHG4764e8436b2a: filemerge: make last line of prompts <40 english chars (issue6158) (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rH

D6617: crecord: stop using test-only "X" as alternative for "c"

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6617 AFFECTED FILES mercurial/crecord.py tests/test-commit-interactive-curses.t CHANGE DETAILS dif

D6619: crecord: fix if -> elif when handling key presses

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This shouldn't actually change any behavior, I only noticed it since I started using KEY_UP in tests, and it was complaining when it got down to the ^L handler

D6618: crecord: add "x" alias for space, remove test-only "TOGGLE" alias

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6618 AFFECTED FILES mercurial/crecord.py tests/test-commit-interactive-curses.t CHANGE DETAILS dif

D6620: crecord: make KEY_ENTER usable in tests (by not updating UI)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6620 AFFECTED FILES mercurial/crecord.py CHANGE DETAILS diff --git a/mercurial/crecord.py b/mercuria

D6621: crecord: provide 'X' as a range-select mechanism

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6621 AFFECTED FILES mercurial/crecord.py tests/test-commit-interactive-curses.t CHANGE DETAILS dif

D6622: relnotes: document new range-select mechanism in crecord

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6622 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git a/relnotes/next b/relnotes/next --- a/re

D6617: crecord: stop using test-only "X" as alternative for "c"

Closed by commit rHG756326d54761: crecord: stop using test-only "X" as alternative for "c" (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6617?vs=15809&id=158

D6618: crecord: add "x" alias for space, remove test-only "TOGGLE" alias

Closed by commit rHG75fd9421440b: crecord: add "x" alias for space, remove test-only "TOGGLE" alias (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6618?vs=158

D6619: crecord: fix if -> elif when handling key presses

Closed by commit rHG3be6ff55095b: crecord: fix if -> elif when handling key presses (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6619?vs=15811&id=15820 CHA

D6620: crecord: make KEY_ENTER usable in tests (by not updating UI)

Closed by commit rHGcd4f1b7c3192: crecord: make KEY_ENTER usable in tests (by not updating UI) (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6620?vs=15812&id

D6621: crecord: provide 'X' as a range-select mechanism

Closed by commit rHG9ac1a5a4a64f: crecord: provide 'X' as a range-select mechanism (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6621?vs=15813&id=15822 CHAN

D6622: relnotes: document new range-select mechanism in crecord

Closed by commit rHG9f73620a65fe: relnotes: document new range-select mechanism in crecord (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6622?vs=15815&id=158

D6571: largefiles: make last line of prompts <40 english chars (issue6158)

Closed by commit rHG421fdf30c37c: largefiles: make last line of prompts <40 english chars (issue6158) (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY r

D6572: subrepos: make last line of prompts <40 english chars (issue6158)

Closed by commit rHGf6540aba8e3e: subrepos: make last line of prompts <40 english chars (issue6158) (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6711: branchheads: store wdir-dependent caches in wcache (issue6181)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, all branch2-* caches were stored in .hg/cache, which is shared across repos when using `hg share`. This can cause cache thrashing when the repos are

D6710: branchmap: properly refresh/warm all branchmap caches

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The comment about 'served' refreshing all the others only applies when served is the head of the branchmap cache subsets. This was already no longer the case (

D6710: branchmap: properly refresh/warm all branchmap caches

spectral added a comment. spectral planned changes to this revision. Needs some test updates. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6710/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6710 To: spectral, #hg-reviewers Cc: mercurial-dev

D6711: branchheads: store wdir-dependent caches in wcache (issue6181)

spectral updated this revision to Diff 16130. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6711?vs=16116&id=16130 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6711/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6711 AFFECTED FILE

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

spectral edited the summary of this revision. spectral retitled this revision from "branchmap: properly refresh/warm all branchmap caches" to "branchmap: explicitly warm+write all subsets of the branchmap caches". spectral marked an inline comment as done. spectral updated this revision to Diff 1

D6719: branchmap: refresh all "heads" of the branchmap subsets

spectral created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The comment about 'served' refreshing all the others only applies when served is the head of the branchmap cache subsets. This

D6711: branchheads: store wdir-dependent caches in wcache (issue6181)

spectral added a comment. In D6711#98248 , @marmoute wrote: > The change looks good to me, However we probably want to introduce a new filter level 'wdir-independent-visible' to ensure we a good branchcache cache in .hg/cache that most share ca

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

spectral added inline comments. INLINE COMMENTS > marmoute wrote in localrepo.py:2224 > Why the explicite write here ? We don't seems to need it for the previous > section. Is this because if the cache of the previous subset is valid, the > write would be skipped ? > If so, consider clarifying

D6719: branchmap: refresh all "heads" of the branchmap subsets

spectral added a comment. spectral added a reviewer: marmoute. Adding marmoute as explicit reviewer. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6719/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6719 To: spectral, durin42, #hg-reviewers,

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

spectral added a comment. In D6710#98322 , @marmoute wrote: > Forcing this write seems like a good idea. Having it in its own > changeset seems like a good idea (and please add a comment about forcing > the write). I've split the 'full

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

Closed by commit rHGcdf0e9523de1: branchmap: explicitly warm+write all subsets of the branchmap caches (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6710?vs=

D5785: blackbox: take regex patterns for blackbox.track

spectral added a comment. spectral abandoned this revision. https://www.mercurial-scm.org/repo/hg/rev/56132ebd14c6 Added blackbox.ignore, which is probably sufficient. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D5785/new/ REVISION DETAIL https://

D5786: blackbox: support blackbox.notrack regex patterns to exclude tracking events

spectral added a comment. spectral abandoned this revision. https://www.mercurial-scm.org/repo/hg/rev/56132ebd14c6 added blackbox.ignore, which is basically what this was doing. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D5786/new/ REVISION DETAIL

D6767: split: handle partial commit of copies when doing split or record

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When using split or record, using either interface (text or curses), selecting portions of the file to be committed/recorded did not work; the entire file was

D6768: split: handle partial commit of renames when doing split or record (issue5723)

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When using split or record, using either interface (text or curses), selecting portions of the file to be committed/recorded did not work; the entire file was

D6767: split: handle partial commit of copies when doing split or record

Closed by commit rHG1fd530b1e1cf: split: handle partial commit of copies when doing split or record (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6768: split: handle partial commit of renames when doing split or record (issue5723)

Closed by commit rHG3cf091843b4f: split: handle partial commit of renames when doing split or record (issue5723) (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REP

D6711: branchheads: store wdir-dependent caches in wcache (issue6181)

spectral added a comment. spectral planned changes to this revision. I'm not sure what the current state of this is, but I don't want it lingering in the review queue while I'm not actively working on it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D

D6789: check-code: allow command substitution with $(command)

spectral added a comment. This shouldn't be about the user's chosen shell, though, right? This is about the `/bin/sh` implementation, which you wouldn't/can't replace with fish, so I think it won't bother users that use fish, just distros with really old implementations of /bin/sh. REPOSITO

D6865: osutil: allow disabling setprocname via a define passed to the compiler

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In some situations, we run a custom python launcher that appears to not set up Py_GetArgcArgv correctly. We then proceed to promptly crash when we attempt to de

D6866: osutil: tolerate Py_GetArgcArgv not being set up properly

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6866 AFFECTED FILES mercurial/cext/osutil.c CHANGE DETAILS diff --git a/mercurial/cext/osutil.c b/me

D6867: transaction: detect an attempt to truncate-to-extend on playback, raise error

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On some networked filesystems, writes can have delayed finalization/confirmation and write races can occur such that a remote modification will "win" and modif

D6865: osutil: allow disabling setprocname via a define passed to the compiler

Closed by commit rHG460f8bf58020: osutil: allow disabling setprocname via a define passed to the compiler (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6867: transaction: detect an attempt to truncate-to-extend on playback, raise error

Closed by commit rHG8502f76dbfd7: transaction: detect an attempt to truncate-to-extend on playback, raise error (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPO

D6866: osutil: tolerate Py_GetArgcArgv not being set up properly

Closed by commit rHGd6227c6c0814: osutil: tolerate Py_GetArgcArgv not being set up properly (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercuri

D6956: unfinishedstate: suggested `hg update .` (including `.`) to complete update

spectral added inline comments. INLINE COMMENTS > state.py:204 > cmdhint=_("use 'hg update' to get a consistent checkout"), > -statushint=_("To continue:hg update") > +statushint=_("To continue:hg update .") > ) I wonder if it would be possible to portably quote the `.` so

D6989: push: support config option to require revs be specified when running push

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6989 AFFECTED FILES mercurial/commands.py mercurial/configitems.py mercurial/help/config.txt tes

D6989: push: support config option to require revs be specified when running push

spectral added a comment. In D6989#102437 , @indygreg wrote: > Question: should this checking be performed in `exchange.push` or at the command layer? > (I'm not sure of the answer.) I think where it is makes sense - I'd be wary of push

D7023: tests: fix test-archive to specify feature as py38, not py-38

spectral created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7023 AFFECTED FILES tests/hghave.py tests/test-archive.t CHANGE DETAILS diff --git a/tes

D7024: destutil: add mechanism to specify ambiguous destination on rebase and merge

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've seen some confusion where users specify -t, thinking it means target, and are confused when it says to explicitly specify a revision/destination: they fe

D7023: hghave: document format for version feature checks as , no dots

spectral edited the summary of this revision. spectral retitled this revision from "tests: fix test-archive to specify feature as py38, not py-38" to "hghave: document format for version feature checks as , no dots". spectral updated this revision to Diff 16974. REPOSITORY rHG Mercurial CHANG

D7023: hghave: document format for version feature checks as , no dots

Closed by commit rHG37af48031d6f: hghave: document format for version feature checks as , no dots (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7

D7024: destutil: provide hint on rebase+merge for how to specify destination/rev

spectral added a comment. In D7024#103055 , @pulkit wrote: > IIUC, you mean `unambiguous` instead of `ambiguous` in the commit message? Re-reading I am confused. Updated the message, see if this works better? REPOSITORY rHG Mercurial C

D7024: destutil: provide hint on rebase+merge for how to specify destination/rev

Closed by commit rHGbff942299ca9: destutil: provide hint on rebase+merge for how to specify destination/rev (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D702

D7028: cleanup: join string literals that are already on one line

spectral added a comment. spectral accepted this revision. Some slightly disappointing loss of clarity where we had originally had something like: foo(b'abc\n' b'def') and this became `foo('abc\n' b'def')`, which is now `foo('abc\ndef')`: I liked the newlines ending the st

D6989: push: support config option to require revs be specified when running push

spectral updated this revision to Diff 17011. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6989?vs=16859&id=17011 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6989/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6989 AFFECTED FILE

<    1   2   3   4   5   6   7   >