D10415: identify: use `get_unique_pull_path`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The command only support a single destination. We use the associated API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10414: bundle: support multiple destinations

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY `hg outgoing` and `hg push` now support multiple destination. We do the same for `hg bundle`. Various other commands needs this kind of behavior and it would

D10417: clone: use `get_clone_path_usage`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY "Surprisingly", the new API is well suited for `hg clone` too. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10413: lfs: use the new APIs

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The part of the lfs store that requires a destination cannot operate on multiple destination (yet). So we move them to the dedicated APIs. REPOSITORY rHG

D10410: transplant: use `get_unique_pull_path`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The command does not support multiple destination (yet). REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10410

D10411: remotefilelog: use the right expandpath in to expand `~`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Given the context where path is most likely a file system path, I suspect that the initial author confused ui.expandpath and util.expandpath (a proxy for

D10412: fastannotate: use `get_unique_pull_path`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The code does not support multiple destination yet, so lets move it to the dedicated API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10408: histedit: use `get_unique_push_path`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Same as for `pathbomb`, this code does not support multiple destinations yet. It might in the future, probably with code put

D10409: relink: use `get_unique_pull_path`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The code does not support multiple destination and will probably never do so. So lets use the dedicated API for this case. REPOSITORY rHG Mercurial BRANCH

D10402: mq: use the new `get_clone_path` to get the remote url

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We stop using `ui.expandpath` to use a function with a more defined semantic. This will help us to make it an option to point [paths] entry to multiple

D10405: patchbomb: use `get_unique_pull_path`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The patchbomb code does not support multiple destinations yet. It would not be too hard to implemented since `hg outgoing` does. However that is a bit too

D10407: get_unique_push_path

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10407 AFFECTED FILES mercurial/utils/urlutil.py CHANGE DETAILS diff --git

D10406: fetch: use `get_unique_pull_path` to retrieve the path

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The fetch command does not support multiple destination, so we use the new dedicated API for that. REPOSITORY rHG Mercurial BRANCH default REVISION

D10404: narrow: use `get_unique_pull_path`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The narrow's `tracked` command does not support multiple destination, lets use the

D10403: urlutil: add a new `get_unique_pull_path`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This function is dedicated to call that needs a single destination. Currently most caller actually need that since few actually support multiple destinations

D10401: urlutil: add a `get_clone_path` function

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We add a new function with a semantic focussed on `clone` operation (so without an existing repository). I am not certain the return type is the best, but

D10394: run-test: make it clearer why we terminating process

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The --verbose log wer only talking about process termination. Now we have more information about why. REPOSITORY rHG Mercurial BRANCH default REVISION

D10397: test-lfs: fix expected output

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not covered by the CI and was broken. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10397 AFFECTED

D10396: test-lfs: avoid a bashism when spawning the server

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For zsh, this &> call is read as "& >", this spin the process without redirection. As a result the server grab stdout, which does not get closed at the end

D10395: test-lfs: avoid pagination

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Otherwise, the pagination can trigger in when running the test with --debug, blocking the test execution for no good reason. REPOSITORY rHG Mercurial

D10392: incoming: use `urlutil.get_pull_paths`

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Lets use the new method to increase code reuse. However I did not implement support for multiple source yet. It would be possible create multiple temporary

D10393: outgoing: use `get_push_paths` in the revset too

2021-04-14 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The revsets now use the same code as everyone and is ready for entry in `[paths]` pointing to multiple entries. REPOSITORY rHG Mercurial BRANCH default

D10391: outgoing: accept multiple destinations

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This align the behavior of `hg outgoing` with the one of `hg incoming`. In addition this prepare the introduction of having simple `path` resolve to multiple

D10390: outgoing: pass subrepo path using function argument instead of abssource hack

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is clearer, remove the needs for the `repo._subtoppath` hack and will make our live easier when making `outgoing` accept multiple destinations. We

D10385: push-dests: move the code around missing default dest inside `get_push_paths`

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This function has a clear semantic and moving the code dealing with this inside it will help reduce duplication. REPOSITORY rHG Mercurial BRANCH default

D10383: outgoing: merge the code handling --graph with the main one

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The --graph code had its own copy of the logic. With the previous reorganisation of the code, we can now merge it with the main code, reducing fragile

D10384: push-dests: rework the handling of default value

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This new core is more straightforward and doing this early will make the next changeset simpler. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10382: outgoing: move filtering logic in its own function

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This move code dedicated to a single purpose together and make the main code simpler. Right when we are getting ready to make it more complex :-D REPOSITORY

D10380: outgoing: remove some early return

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Since 066b8d8f75b8 , the push command accept multiple destination. However `hg

D10381: outgoing: make `recurse` a real function

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If we want to use this in a loop, we need to be able to pass argument. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10378: urlutil: add a `get_pull_paths` to perform the pull destination logic

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As is this changeset does not change anything. However having an official empty point will help unifying the logic and encapsulate the details and update the

D10379: infinitepush: use the new function to determine push destination

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Since 066b8d8f75b8 , the push command accept multiple destination. `infinitepush`

D10377: urlutil: add a `get_push_paths` to perform the push destination logic

2021-04-13 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As is this changeset does not change anything. However having an official empty point will help unifying the logic and encapsulate the details and update the

Re: development heads up: push/pull improvements

2021-04-13 Thread Pierre-Yves David
On 4/13/21 3:03 AM, Manuel Jacob wrote: On 17/03/2021 16.05, Pierre-Yves David wrote: Hello everyone, I have been working on improvements to push and pull. The core goal can be summarized as: * make it simpler to push/pull to multiple destinations * make it simpler to control default

D10374: urlutil: extract `url` related code from `util` into the new module

2021-04-12 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added subscribers: mercurial-patches, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The new module is well fitting for this new code.

D10375: urlutil: extract `parseurl` from `hg` into the new module

2021-04-12 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The new module is well fitting for this new code. And

D10372: help: document the `path://` url scheme

2021-04-12 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If we want people to use it, we need to document it. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10372

D10373: urlutil: extract `path` related code into a new module

2021-04-12 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY They are a lot of code related to url and path handling scattering into various large module. To consolidate the code before doing more change (for defining

D10371: help: point to `hg help urls` in `hg help config.paths`

2021-04-12 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This seems useful to point at what people can put as value for these config. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10356: config: add an experimental option to list all known config

2021-04-09 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY That option is not ready for prime-time, hence the `exp-` prefix. However, this is a good base to start going toward completion. This is also quite useful for

D10338: persistent-nodemap: disable it for test-wireproto-content-redirects.t

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not relevant for the test and this will avoid a lot of variations. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10337: persistent-nodemap: disable it for test-wireproto-command-capabilities.t

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not relevant for the test and this will avoid a lot of variations. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10336: persistent-nodemap: disable it unconditionally for test-wireproto-caching.t

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not relevant for the test and this will avoid a lot of variations. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10335: persistent-nodemap: disable it unconditionally for test-ssh-proto-unbundle.t

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not relevant for the test and this will avoid a lot of variations. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10334: persistent-nodemap: disable it unconditionally for test-ssh-proto.t

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not relevant for the test and this will avoid a lot of variations. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10333: persistent-nodemap: disable it unconditionally for test-share-safe.t

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not relevant for the test and this will avoid a lot of variations. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10332: persistent-nodemap: disable it unconditionally for test-http-protocol.t

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not relevant for the test and this will avoid a lot of variations. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10331: persistent-nodemap: disable it unconditionally for test-http-bad-server.t

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not relevant for the test and this will avoid a lot of variations REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10327: clang-format: run the formatter on mercurial/cext/revlog.c

2021-04-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This fix `test-check-clang-format.t` that has been complaining for a while. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10326: revlog-compression: use zstd by default (if available)

2021-04-07 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As see in changeset bb271ec2fbfb , zstd is 20% to

D10325: revlog-compression: fix computation of engine availability

2021-04-07 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We don't just need the engine to be define, we need it to be available and able to do be used for revlog compression. Without this change, `zstd` could be

D10324: rhg: make rhg recognise it support zstd compression for revlogs

2021-04-07 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It already did, but was not aware of it. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10324 AFFECTED FILES

D10323: test: explicitly use zlib compression in tests/test-share-safe.t

2021-04-07 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We need the implicit value to be explicit until we can change the default in some case. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10322: test: explicitly use zlib compression in tests/test-upgrade-repo.t

2021-04-07 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We need the implicit value to be explicit until we can change the default in some case. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10321: test: explicitly use zlib compression in tests/test-repo-compengines.t

2021-04-07 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We need the implicit value to be explicit until we can change the default in some case. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10315: store: also return some information about the type of file `walk` found

2021-04-06 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We start returning of 4th information in the `store.walk` return tuple: the type of the

D10316: upgrade: take advantage of the new information returned by `store.walk`

2021-04-06 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Before this change the upgrade code had to analyse filename to process them directly. Lets keep that logic private to the store and more to a more robust

D10317: upgrade: do not hardcore revlog extension

2021-04-06 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This logic already lives inside the `store` module. So lets reuse it instead. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10314: store: drop the `filefilter` argument to `_walk`

2021-04-06 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY No code use it anywhere. Dropping it will help replacing the function with something with a more precise semantic. REPOSITORY rHG Mercurial BRANCH

D10313: store: document the `walk` method

2021-04-06 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10313 AFFECTED FILES mercurial/store.py CHANGE DETAILS diff --git

D10309: revlog: replace revlog._io.size with a new revlog.index.entry_size

2021-04-05 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The `revlogio` class is mostly a relic from the past. Once in charge of the full revlog related Input/Output code, that

D10308: rust: bump rust-cpython version to 0.5.2

2021-04-05 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY we need a newer version to define "property" on Rust defined object. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10306: revlog: move the "index header" struct inside revlog.utils.constants

2021-04-05 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The struct was previous called "version", but this is actually "version" + "flags". So header seems like a better name.

D10305: revlog: move the details of revlog "v2" index inside revlog.utils.constants

2021-04-05 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY the revlog module is quite large and this kind of format information would handy for other module. So let us start to

D10304: revlog: move the details of revlog "v1" index inside revlog.utils.constants

2021-04-05 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The revlog module is quite large and this kind of format information would handy for other module. So let us start to

D10307: revlog: directly use the Struct object for related operation

2021-04-05 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The Struct object has all the piece we needs, so no need to duplicate information on the revlog itself. REPOSITORY rHG Mercurial BRANCH default REVISION

D10303: revlog: move the details of revlog "v0" index inside revlog.utils.constants

2021-04-05 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY the revlog module is quite large and this kind of format information would handy for other module. So let us start to

D10302: revlog: add some comment in the header sections

2021-04-05 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are about to add more content so let us organise the existing content first. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10284: re2: feed unicode string to re2 module when necessary

2021-03-28 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY My previous test were using the `pyre2` Python project, that wrap the Google RE2 library in python as a `re2` module and accept bytes as input. However the

D10282: heptapod-ci: add jobs to test Mercurial using re2

2021-03-28 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY They are multiple library providing a re2 module and they were broken with 5.7, so we add some (smaller) job to test them using new images. REPOSITORY rHG

D10281: test: enforce master to be the default branch in test

2021-03-28 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Newer git issue a message about this. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10264: path: forbid chaining `path://` definitions

2021-03-24 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY To have `path://xxx` referencing paths that use `path://` too, we need to analyze dependencies to initialize them in the right order (and to detect cycle).

D10265: path: error out if the `path://` reference point to an unknown path

2021-03-24 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10265 AFFECTED FILES mercurial/ui.py tests/test-paths.t CHANGE DETAILS diff

D10263: path: introduce a `path://` syntax to reference other path name

2021-03-24 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This make it easier for a path to reuse the same location of another path with different parameter. This is useful to create path "alias" with common config

D10262: path: extract sub-option logic into its own method

2021-03-24 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We will need to re-use this logic for `path://` so we first extract it into its own method. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10261: path: extract the path validation logic into its own submethod

2021-03-24 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We will need to re-use this logic for `path://` so we first extract it into its own method. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10260: path: move handling of "default" (*) suboptions value inside __init__

2021-03-24 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY With the introduction of `path://` scheme the handling of default value will need to be subtler. We do simple code movement first to clarify the future

D10233: setdiscovery: add a discovery.grow-sample.dynamic option

2021-03-17 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The current discovery dynamically adapt to complex situations. This make is quick effective, but also harder so study the effect of other improvements in such

D10231: debugdiscovery: document relevant config option

2021-03-17 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These config option are here for people to experiment with it. So lets document them in the command that is used for experimentation. REPOSITORY rHG

D10232: setdiscovery: rearrange code deciding if we will grow the sample

2021-03-17 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The new code is clearer and will make the next update simpler. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10230: revset: introduce a `nodefromfile` revset

2021-03-17 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I though we had one, but actually we don't seem to. So here is a revset to reuse a list of node previously stored. REPOSITORY rHG Mercurial BRANCH

development heads up: push/pull improvements

2021-03-17 Thread Pierre-Yves David
these flag, so I CCed him on this email. This work is not my primary focus, but hope to make enough progress to have most of it completed by the 5.8 freeze, in one month. Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel

D10228: perf-util: add an helper revset to use the same spec as the case search script

2021-03-16 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This make result of the searcher script easier to use. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10228

D10227: debugdiscovery: add missing byte string marker to some help text

2021-03-16 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is causing crash when using --help. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10227 AFFECTED FILES

D10224: debugdiscovery: also integrate the discovery output in the json one

2021-03-15 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We add a way for formatter to informs code that free output is unwanted, and we incorporate it in the json output. REPOSITORY rHG Mercurial BRANCH

D10223: debugdiscovery: add support for Json output

2021-03-15 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY They are some pre-output that will be impractical, I'll take care of it in the next changeset. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D10222: perf-helper: add a new sampling revset based on anti-chain

2021-03-15 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY See inline documentation for details. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10222 AFFECTED FILES

D10225: perf-helpers: add a search-discovery-case script

2021-03-15 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This a small script I built to look for interesting discovery case. It is fairly basic but could be useful in various situation so lets put it in the main

D10221: perf-helper: add a small extension with revsets to select repository subset

2021-03-15 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Playing with discovery requires building interesting case. To do this we need revsets to try to generate them. We start with a quite simple one. See

D10220: copies: distinct between merged and touched files during upgrade

2021-03-15 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This a filenode being different between p1, p2 and result does not necessarily means a merges happens. For example p2 could be a strict newer version of p1,

D10219: copies: detect files as `touched/salvaged` if they only existed on one side

2021-03-15 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The file cannot be merged if there was content to merge on the other side. So the previous record was wrong. In the general case, the file existed only on

D10218: test-copies: show some wrong ChangedFiles upgrade

2021-03-15 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For file present only on one side and touched during merge, the upgrade code confused them as "merged". However they should be either "touched", or

D10162: ui: pass a `ui` objec to `paths.getpath`

2021-03-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I want to introduce more path's suboption and make it possible to default value for them. Processing theses suboption might result in warning and we need a ui

D10163: paths: add a `*` special path to define default sub option

2021-03-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10163 AFFECTED FILES mercurial/ui.py tests/test-default-push.t CHANGE DETAILS

D10161: push: allow to specify multiple destinations

2021-03-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I end up needing that on a regular basis and it turn out to be very simple to implement. See documentation and test for details. REPOSITORY rHG Mercurial

D10159: pull: allow to specify multiple sources

2021-03-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I end up needing that on a regular basis and it turn out to be very simple to implement. See documentation and test for details. REPOSITORY rHG Mercurial

D10160: push: indent the some part of the command

2021-03-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY That code will be put in a loop in the next changeset, pre-indenting make the next change clearer. REPOSITORY rHG Mercurial BRANCH default REVISION

D10157: command: clarify `postincoming` return and that return handling

2021-03-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The command should return None or a return code. The previous code was returning boolean directly relying on the fact that `True → 1` and `False → 0`. This is

D10158: pull: pre-indent a part of the function

2021-03-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are about to run it in a loop, so lets pre-indent it to clarify the actual change in the next changesets. REPOSITORY rHG Mercurial BRANCH default

D10155: tests: rename `test-pull` to `test-pull-network.t`

2021-03-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If is mostly about ssh and http interaction so lets avoid confusion with a generic `hg pull` test REPOSITORY rHG Mercurial BRANCH default REVISION

<    6   7   8   9   10   11   12   13   14   15   >