[PATCH 3 of 6] rebase: move dest check down below other flag parsings

2017-03-28 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490736312 25200 # Tue Mar 28 14:25:12 2017 -0700 # Node ID 409a87200f6b079c9bfe1e85fd0715822346c402 # Parent 976b28021f29ad7686ea57fb0fdff4bd17798a71 rebase: move dest check down below other flag parsings diff --git a/hgext/rebase.py b/hgext

[PATCH 4 of 6] rebase: allow destination-free continue and abort (issue5513)

2017-03-28 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490735056 25200 # Tue Mar 28 14:04:16 2017 -0700 # Node ID ac6634fab80b59ba48958ca03289c4434e9483c4 # Parent 409a87200f6b079c9bfe1e85fd0715822346c402 rebase: allow destination-free continue and abort (issue5513) diff --git a/hgext/rebase.py

[PATCH 2 of 6] rebase: test to show brokenness with requiredest

2017-03-28 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490734179 25200 # Tue Mar 28 13:49:39 2017 -0700 # Node ID 976b28021f29ad7686ea57fb0fdff4bd17798a71 # Parent a10ea0843904718f724cfb1bd3c3db143c794921 rebase: test to show brokenness with requiredest As shown in issue5513, --continue is

Re: [PATCH 1 of 7 V2] tags: extract fnode retrieval in its own function

2017-03-28 Thread Ryan McElroy
On 3/28/17 1:03 PM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490673691 -7200 # Tue Mar 28 06:01:31 2017 +0200 # Node ID a710d3c24acd544408fe77243102325514f5f697 # Parent e6fd7930cf0b37710e379de37b7d87d5c1ea5dc9 # EXP-Topic tags tags: extract fnode retr

Re: [PATCH] worker: flush ui buffers before running the worker

2017-03-28 Thread Ryan McElroy
On 3/28/17 6:22 PM, David Soria Parra wrote: # HG changeset patch # User David Soria Parra # Date 1490721698 25200 # Tue Mar 28 10:21:38 2017 -0700 # Node ID b89199982355728a3741edf5518c72ccc52ee33c # Parent 331cc4433efe0d897bb16ad4ff08a3fbe850869b worker: flush ui buffers before running t

Re: [PATCH 1 of 5] repair: use ProgrammingError

2017-03-28 Thread Ryan McElroy
On 3/27/17 2:11 PM, Augie Fackler wrote: On Mon, Mar 27, 2017 at 09:18:55AM +0200, Pierre-Yves David wrote: Sure, that seems like a good idea. Can you see to it ? It's a good idea, but I feel like the name "ProgrammingError" alone provides some clue as to what's going on, and the migration is g

Re: [PATCH 1 of 7] tags: extract fnode retrieval in its own function

2017-03-28 Thread Ryan McElroy
On 3/28/17 12:29 PM, Pierre-Yves David wrote: On 03/28/2017 11:51 AM, Ryan McElroy wrote: On 3/28/17 7:16 AM, Pierre-Yves David wrote: […] +def _getfnodes(ui, repo, nodes): +"""return fnode for .hgtags in a list of node This comment doesn't quite parse for me

Re: [PATCH 1 of 7] tags: extract fnode retrieval in its own function

2017-03-28 Thread Ryan McElroy
Overall series mostly looks good to me, but there are enough grammar changes and a few questions to be addressed that I think a v2 would be worth it. I'll mark as changes requested in patchwork for now. On 3/28/17 10:51 AM, Ryan McElroy wrote: On 3/28/17 7:16 AM, Pierre-Yves David

Re: [PATCH 7 of 7] tags: extract filenode filtering in it own function

2017-03-28 Thread Ryan McElroy
On 3/28/17 7:17 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490675008 -7200 # Tue Mar 28 06:23:28 2017 +0200 # Node ID dd6a04d26b611ac8d192f868daba734622e97528 # Parent 3d8a09214760799868b472b97e964e88f7ec8fd5 # EXP-Topic tags tags: extract filenode f

Re: [PATCH 6 of 7] tags: extract tags computation from fnodes in its own function

2017-03-28 Thread Ryan McElroy
On 3/28/17 7:17 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490674092 -7200 # Tue Mar 28 06:08:12 2017 +0200 # Node ID 3d8a09214760799868b472b97e964e88f7ec8fd5 # Parent d5c70d5f7de740d3fa946318998f0f0c1204e4eb # EXP-Topic tags tags: extract tags compu

Re: [PATCH 5 of 7] tags: only return 'alltags' in 'findglobaltags'

2017-03-28 Thread Ryan McElroy
On 3/28/17 7:17 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490679683 -7200 # Tue Mar 28 07:41:23 2017 +0200 # Node ID d5c70d5f7de740d3fa946318998f0f0c1204e4eb # Parent e49ee337ec51b64e440585d44e6c7df736164e98 # EXP-Topic tags tags: only return 'allta

Re: [PATCH 4 of 7] tags: make argument 'tagtype' optional in '_updatetags'

2017-03-28 Thread Ryan McElroy
On 3/28/17 7:16 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490679550 -7200 # Tue Mar 28 07:39:10 2017 +0200 # Node ID e49ee337ec51b64e440585d44e6c7df736164e98 # Parent f0c93dd8d018c9f6828c97be8ccb80dbfca694b8 # EXP-Topic tags tags: make argument 'tag

Re: [PATCH 3 of 7] tags: reorder argument of '_updatetags'

2017-03-28 Thread Ryan McElroy
On 3/28/17 7:16 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490679490 -7200 # Tue Mar 28 07:38:10 2017 +0200 # Node ID f0c93dd8d018c9f6828c97be8ccb80dbfca694b8 # Parent 147b98bfa4afbaf608d9e1f5227a48a46e386ea4 # EXP-Topic tags tags: reorder argument o

Re: [PATCH 2 of 7] tags: do not feed dictionaries to 'findglobaltags'

2017-03-28 Thread Ryan McElroy
On 3/28/17 7:16 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490674429 -7200 # Tue Mar 28 06:13:49 2017 +0200 # Node ID 147b98bfa4afbaf608d9e1f5227a48a46e386ea4 # Parent 1e77e505e7bacf59d1200714dc92e827523d7301 # EXP-Topic tags tags: do not feed dictio

Re: [PATCH 1 of 7] tags: extract fnode retrieval in its own function

2017-03-28 Thread Ryan McElroy
On 3/28/17 7:16 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490673691 -7200 # Tue Mar 28 06:01:31 2017 +0200 # Node ID 1e77e505e7bacf59d1200714dc92e827523d7301 # Parent e6fd7930cf0b37710e379de37b7d87d5c1ea5dc9 # EXP-Topic tags tags: extract fnode retr

Re: [PATCH 07 of 10 V5] rcutil: let environ override system configs (BC)

2017-03-28 Thread Ryan McElroy
On 3/27/17 7:02 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1490589217 25200 # Sun Mar 26 21:33:37 2017 -0700 # Node ID 38572bb2cffd815526a727bc6f3aacdca2902f4f # Parent 9b0aa30bf151b6c0e999b017fd328e29440bd447 rcutil: let environ override system configs (BC) Small nits i

Re: [PATCH 10 of 10 V5] pager: do not read from environment variable

2017-03-28 Thread Ryan McElroy
On 3/27/17 7:02 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1490589827 25200 # Sun Mar 26 21:43:47 2017 -0700 # Node ID 5641b83eff817bdb0d7adeb24c7383653ef15617 # Parent a354f13a30b93943635224fcd90f43019241e23e pager: do not read from environment variable This series look

Re: [PATCH] metadataonlyctx: speed up sanity check

2017-03-27 Thread Ryan McElroy
(cc Mateusz) On 3/26/17 8:32 PM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1490556395 25200 # Sun Mar 26 12:26:35 2017 -0700 # Node ID 2793d297600133bb83a5d2f5a46bfa3fadd037ab # Parent b6766d75404fb8c5d26af016caa76f44b47ce156 metadataonlyctx: speed up sanity check Previousl

Re: [PATCH 01 of 11 V2] scmutil: add a method to convert environment variables to config items

2017-03-25 Thread Ryan McElroy
On 3/25/17 4:16 AM, Yuya Nishihara wrote: On Wed, 22 Mar 2017 08:52:32 -0700, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-22 11:16:40 +: This function is fine, but scmutil feels like the wrong place for it. Why is it not in config.py? This same question applies to patch

Re: [PATCH 2 of 2] rebase: don't require destination if commands.rebase.requiredest=False

2017-03-25 Thread Ryan McElroy
On 3/25/17 4:52 AM, Yuya Nishihara wrote: On Fri, 24 Mar 2017 18:49:14 -0700, Jun Wu wrote: This looks good to me. Thanks for the fix! Excerpts from Martin von Zweigbergk's message of 2017-03-24 16:35:08 -0700: # HG changeset patch # User Martin von Zweigbergk # Date 1490397610 25200 #

Re: [PATCH 2 of 2 V2] show: new extension for displaying various repository data

2017-03-25 Thread Ryan McElroy
On 3/25/17 5:22 AM, Yuya Nishihara wrote: On Thu, 23 Mar 2017 11:38:45 -0400, Augie Fackler wrote: On Thu, Mar 23, 2017 at 12:16:16AM +0900, Yuya Nishihara wrote: On Tue, 21 Mar 2017 23:52:42 -0700, Gregory Szorc wrote: On Tue, Mar 21, 2017 at 11:49 PM, Gregory Szorc wrote: # HG changeset

Re: [PATCH] findrenames: sort files not by object id but by path for stable result

2017-03-25 Thread Ryan McElroy
On 3/23/17 2:00 PM, Yuya Nishihara wrote: On Wed, 22 Mar 2017 16:14:01 +, Ryan McElroy wrote: On 3/22/17 1:48 PM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1426413536 -32400 # Sun Mar 15 18:58:56 2015 +0900 # Node ID

Re: [PATCH] help: format ``commands`` heading correctly

2017-03-23 Thread Ryan McElroy
On 3/22/17 11:37 PM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1490225813 25200 # Wed Mar 22 16:36:53 2017 -0700 # Node ID cd99f61579194767aaa958a29d8de88e639d1578 # Parent 55c6788c54e2faf80ec14f2b0844bfe429012bc3 help: format

Re: [PATCH] fancyopts: making config defaults actually override defaults

2017-03-23 Thread Ryan McElroy
On 3/22/17 6:51 PM, Martin von Zweigbergk wrote: On Wed, Mar 22, 2017 at 10:14 AM, Rodrigo Damazio wrote: On Wed, Mar 22, 2017 at 3:50 AM, Ryan McElroy wrote: Rodrigo: for some reason, patchwork thinks you are Martin. Any idea why? https://urldefense.proofpoint.com/v2/url?u=https

Re: [PATCH V2] checkheads: extract obsolete post processing in its own function

2017-03-23 Thread Ryan McElroy
On 3/22/17 4:31 PM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490135413 -3600 # Tue Mar 21 23:30:13 2017 +0100 # Node ID 72c820f77671d4495d96e7aeeba9237573dbce85 # Parent 66c3ae6d886cae0e3a3cff6a0058e2d2a866fd9d # EXP-Topic checkheads The checkheads fu

Re: [PATCH 2 of 2 V2] status: support commands.status.relative config

2017-03-23 Thread Ryan McElroy
On 3/22/17 4:25 PM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1490143844 25200 # Tue Mar 21 17:50:44 2017 -0700 # Node ID 32fb4dfa78cb43ac9d6b42dcd9e8735bf02cefe4 # Parent 1ed5ec882c49934a16428fc72e7a366f39747cc5 status: suppo

Re: [PATCH 07 of 11 V2] ui: use scmutil.rccomponents to load configs (BC)

2017-03-22 Thread Ryan McElroy
On 3/22/17 4:01 PM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-22 11:37:00 +: On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489462886 25200 # Mon Mar 13 20:41:26 2017 -0700 # Node ID add83f47bf3a51edbd58aa0fb6e571d186bdae6e # Parent d

Re: [PATCH] doc: fix short underline which causes make -C doc to fail

2017-03-22 Thread Ryan McElroy
On 3/22/17 3:59 PM, Kostia Balytskyi wrote: # HG changeset patch # User Kostia Balytskyi # Date 1490198110 25200 # Wed Mar 22 08:55:10 2017 -0700 # Node ID 86383b66465bd7122bb5380047c6e87c888d8227 # Parent f808c796dfd2c6e4e6990c73a838320512aafeca doc: fix short underline which causes make

Re: [PATCH 1 of 2 V2] formatter: reserve _ prefixed keys as internal and don't render

2017-03-22 Thread Ryan McElroy
On 3/22/17 2:55 PM, Yuya Nishihara wrote: On Tue, 21 Mar 2017 23:49:25 -0700, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1490164306 25200 # Tue Mar 21 23:31:46 2017 -0700 # Node ID ae796e23fd42b036352b298f570af8949c2db2d9 # Parent 102f291807c92864a2231e5e925d6cd

Re: [PATCH] findrenames: sort files not by object id but by path for stable result

2017-03-22 Thread Ryan McElroy
On 3/22/17 1:48 PM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1426413536 -32400 # Sun Mar 15 18:58:56 2015 +0900 # Node ID 425379e72e817b6c79e955173b015b9a0fe090e9 # Parent 102f291807c92864a2231e5e925d6cd64783bb59 findrenames: sort files not by object id but b

Re: [PATCH 2 of 2 V2] show: new extension for displaying various repository data

2017-03-22 Thread Ryan McElroy
On 3/22/17 6:49 AM, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1490165337 25200 # Tue Mar 21 23:48:57 2017 -0700 # Node ID 80ca2bee4a06887f918e3328b3f005e4c1cb1ab1 # Parent ae796e23fd42b036352b298f570af8949c2db2d9 show: new extension for displaying various reposi

Re: [PATCH] show: new extension for displaying various repository data

2017-03-22 Thread Ryan McElroy
On 3/22/17 7:29 AM, Sean Farley wrote: Yuya Nishihara writes: On Sun, 12 Mar 2017 21:38:00 -0700, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1489378362 25200 # Sun Mar 12 21:12:42 2017 -0700 # Node ID d30057d358076cbe7d632cd573095af97543f932 # Parent 1c3352

Re: [PATCH 11 of 11 V2] pager: do not read from environment variable

2017-03-22 Thread Ryan McElroy
On 3/22/17 7:51 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489456112 25200 # Mon Mar 13 18:48:32 2017 -0700 # Node ID d2b34be3b64a6ca60644576b806e5b7172d524cc # Parent 713d562d0a2426c8658675a66158e6c412ae9dcc pager: do not read from environment variable Overall, I'm a b

Re: [PATCH 08 of 11 V2] config: list environment variables in debug output

2017-03-22 Thread Ryan McElroy
On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489455351 25200 # Mon Mar 13 18:35:51 2017 -0700 # Node ID 23b2b1ed59763e5e676f06a4ac4f6bf567874220 # Parent add83f47bf3a51edbd58aa0fb6e571d186bdae6e # Available At https://urldefense.proofpoint.com/v2/url?u=http

Re: [PATCH 07 of 11 V2] ui: use scmutil.rccomponents to load configs (BC)

2017-03-22 Thread Ryan McElroy
On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489462886 25200 # Mon Mar 13 20:41:26 2017 -0700 # Node ID add83f47bf3a51edbd58aa0fb6e571d186bdae6e # Parent df768455486ff51b4047fd3a8dfbef158516d2aa ui: use scmutil.rccomponents to load configs (BC) This is BC b

Re: [PATCH 05 of 11 V2] scmutil: extract path reading function from rccomponents

2017-03-22 Thread Ryan McElroy
On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1490168676 25200 # Wed Mar 22 00:44:36 2017 -0700 # Node ID c18d9f3e0dac6d1676bd58617477c64953be96a3 # Parent 75f661b31640a914dd513d42b2ce1389c9b61c0a # Available At https://urldefense.proofpoint.com/v2/url?u=http

Re: [PATCH 01 of 11 V2] scmutil: add a method to convert environment variables to config items

2017-03-22 Thread Ryan McElroy
On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489449998 25200 # Mon Mar 13 17:06:38 2017 -0700 # Node ID fa1618118c0603dafd8b7afbeab0e95f3e4307b0 # Parent 102f291807c92864a2231e5e925d6cd64783bb59 # Available At https://urldefense.proofpoint.com/v2/url?u=http

Re: [PATCH] fancyopts: making config defaults actually override defaults

2017-03-22 Thread Ryan McElroy
Rodrigo: for some reason, patchwork thinks you are Martin. Any idea why? https://patchwork.mercurial-scm.org/patch/19133/ On 3/14/17 10:16 PM, Rodrigo Damazio via Mercurial-devel wrote: On Tue, Mar 14, 2017 at 12:50 PM, David Soria Parra mailto:d...@experimentalworks.net>> wrote: On Sat,

Re: [PATCH 2 of 2] rebase: ignore commands.rebase.requiredest if HGPLAIN=1

2017-03-22 Thread Ryan McElroy
On 3/22/17 4:27 AM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1490156812 25200 # Tue Mar 21 21:26:52 2017 -0700 # Node ID 23f767fb3142615597c4d3c2d5b4404e6c10f57a # Parent 2558f3d814f50681641fff9815d30129de2ab5ad rebase: ignor

Re: [PATCH 7 of 7] tests: add a test case verifying that mq respects --no-git option

2017-03-22 Thread Ryan McElroy
FYI, there's a discussion going on about the "correct" behavior on the issue tracker: https://bz.mercurial-scm.org/show_bug.cgi?id=5510 On 3/21/17 8:30 PM, Ryan McElroy wrote: Overall this series looks good to me, except for this last patch. See inline comments. For now, I

Re: [PATCH] status: support commands.status.relative config

2017-03-22 Thread Ryan McElroy
I'm +100 on this patch. We've been doing this in tweakdefaults for ages. Everyone loves it. On 3/22/17 4:35 AM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1490143844 25200 # Tue Mar 21 17:50:44 2017 -0700 # Node ID e0e123324f2

Re: [PATCH] checkheads: extract obsolete post processing in its own function

2017-03-22 Thread Ryan McElroy
On 3/21/17 10:42 PM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490135413 -3600 # Tue Mar 21 23:30:13 2017 +0100 # Node ID 787354f0d60eccda66ba0de4db8e6e47897acc7c # Parent 66c3ae6d886cae0e3a3cff6a0058e2d2a866fd9d # EXP-Topic checkheads # Available At h

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

2017-03-21 Thread Ryan McElroy
On 3/21/17 7:34 PM, Jun Wu wrote: Excerpts from Phillip Cohen's message of 2017-03-21 12:21:33 -0700: Have you actually tried if "commandname" is the command name after resolving alias? It is, for command aliases. For example `hg sf` will correctly return `absorb`. "sf" is unambiguous becaus

Re: [PATCH 7 of 7] tests: add a test case verifying that mq respects --no-git option

2017-03-21 Thread Ryan McElroy
Overall this series looks good to me, except for this last patch. See inline comments. For now, I'd take the rest of this series if we're okay with the BC break, and just drop this patch while we figure out the mq stuff. On 3/21/17 5:08 PM, Alexander Fomin wrote: # HG changeset patch # User A

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

2017-03-21 Thread Ryan McElroy
On 3/21/17 6:50 PM, Jun Wu wrote: Excerpts from Augie Fackler's message of 2017-03-21 14:35:43 -0400: On Mon, Mar 20, 2017 at 12:39:11PM +0000, Ryan McElroy wrote: Overall, I like the functionality this series adds, but I'm less convinced on the specific implementation. Adding mor

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

2017-03-21 Thread Ryan McElroy
On 3/21/17 4:40 PM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 12:39:11 +: Overall, I like the functionality this series adds, but I'm less convinced on the specific implementation. Adding more stuff to the junkyard that is the "ui" class doesn't feel awesome, and I'm c

Re: [PATCH 6 of 6] osutil: export a "getfstype" method

2017-03-21 Thread Ryan McElroy
On 3/21/17 12:04 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1490052852 25200 # Mon Mar 20 16:34:12 2017 -0700 # Node ID c8693bc1191b3ac1af0a67e97068777b13cfa672 # Parent f710d54d1985975d7d37aa58e9d5740ebdcf5b7b osutil: export a "getfstype" method This patch exports the "g

Re: [PATCH 1 of 6] setup: split "hasfunction" to test arbitrary code

2017-03-21 Thread Ryan McElroy
On 3/21/17 12:04 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 149004 25200 # Mon Mar 20 15:28:08 2017 -0700 # Node ID 272f2d2a56cad143c899d4beb4b36610f68e6310 # Parent 44c591f634584c721778c5a77edeb04cd919ac43 # Available At https://urldefense.proofpoint.com/v2/url?u=htt

Re: [PATCH] extensions: formalize concept of experimental extensions

2017-03-21 Thread Ryan McElroy
On 3/15/17 1:10 PM, Yuya Nishihara wrote: On Tue, 14 Mar 2017 08:45:44 -0700, Jun Wu wrote: Excerpts from Yuya Nishihara's message of 2017-03-13 19:02:06 -0700: How about :allowbeta = True ? Old clients will try to load "True" as an extension. Ah, good catch. So it looks like this approach

Re: [PATCH evolve-ext] tests: add glob for Windows

2017-03-21 Thread Ryan McElroy
On 3/17/17 3:32 AM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1489720627 14400 # Thu Mar 16 23:17:07 2017 -0400 # Node ID ab5c2bef148bfb60e1956a55de4b7ba00ebe1817 # Parent 6a3248558b6929378450b572bb27406afe703ffd tests: add glob for Windows This looks good to

Re: [PATCH evolve-ext] checks: correct the shebang line filtering for python files

2017-03-21 Thread Ryan McElroy
On 3/17/17 1:38 AM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1489713417 14400 # Thu Mar 16 21:16:57 2017 -0400 # Node ID 6a3248558b6929378450b572bb27406afe703ffd # Parent e9d5f54765a27e09d35f48dda23db7e6f5b8320a checks: correct the shebang line filtering for py

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

2017-03-21 Thread Ryan McElroy
On 3/21/17 4:40 PM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 12:39:11 +: Overall, I like the functionality this series adds, but I'm less convinced on the specific implementation. Adding more stuff to the junkyard that is the "ui" class doesn't feel awesome, and I'm c

Re: [PATCH 01 of 11] util: add tryunlink function

2017-03-21 Thread Ryan McElroy
Argh, I missed --flag v2 on this series. Apologies. I also split this from the previous three patches because they are actually unrelated cleanups. On 3/21/17 1:54 PM, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700

[PATCH 09 of 11] server: use tryunlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 684d201e116b65e6dff5f9494de064591da57b07 # Parent 35955261dc137fbaa70240b3f8b63326e769d1d6 server: use tryunlink diff --git a/mercurial/server.py b/mercurial/server.py --- a

[PATCH 11 of 11] localrepo: use tryunlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID f5d46850f168c1dab9d46688e900a22d5ddac05b # Parent ba24c5cdac8654da7d0d510e3643226e69cef187 localrepo: use tryunlink diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py --- a

[PATCH 08 of 11] dirstate: use tryunlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 35955261dc137fbaa70240b3f8b63326e769d1d6 # Parent f0a1b3da14aebe21bb2e5c6f8f9c65e6d2704d28 dirstate: use tryunlink diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py --- a

[PATCH 10 of 11] vfs: use tryunlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID ba24c5cdac8654da7d0d510e3643226e69cef187 # Parent 684d201e116b65e6dff5f9494de064591da57b07 vfs: use tryunlink diff --git a/mercurial/vfs.py b/mercurial/vfs.py --- a/mercurial/vfs.py

[PATCH 05 of 11] bookmarks: use tryunlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 18b77e381c09564f56dafc5d2b0ec6ae826139ba # Parent aa0458baf1599d8dc4c35d48609bd64141c38a09 bookmarks: use tryunlink diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py --- a

[PATCH 07 of 11] debug: use tryunlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID f0a1b3da14aebe21bb2e5c6f8f9c65e6d2704d28 # Parent 425d04205b98881e04a4f2aa6444a3305cfa51ee debug: use tryunlink diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py

[PATCH 03 of 11] vfs: add tryunlink method

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 05060c142764cd34c9ad16127bd1b562f9548bd7 # Parent 6652e6d191c677f1188252f1bb4e3e7e88bfcf1c vfs: add tryunlink method Thoughout hg code, we see a pattern of attempting to remove a

[PATCH 06 of 11] chgserver: use tryunlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 425d04205b98881e04a4f2aa6444a3305cfa51ee # Parent 18b77e381c09564f56dafc5d2b0ec6ae826139ba chgserver: use tryunlink diff --git a/mercurial/chgserver.py b/mercurial/chgserver.py --- a

[PATCH 04 of 11] shelve: use tryunlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID aa0458baf1599d8dc4c35d48609bd64141c38a09 # Parent 05060c142764cd34c9ad16127bd1b562f9548bd7 shelve: use tryunlink diff --git a/hgext/shelve.py b/hgext/shelve.py --- a/hgext/shelve.py

[PATCH 02 of 11] util: use tryunlink in unlinkpath

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 6652e6d191c677f1188252f1bb4e3e7e88bfcf1c # Parent 5c9cdd8046845f76e169885ed490a603b911d0d4 util: use tryunlink in unlinkpath We just introduced a func to attempt a file removal

[PATCH 01 of 11] util: add tryunlink function

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 5c9cdd8046845f76e169885ed490a603b911d0d4 # Parent 49de4dfb282e2ad4dc91328ffd7fc396ee92b4a0 util: add tryunlink function Throughout mercurial cdoe, there is a common pattern of

[PATCH 3 of 3 v2] util: unify unlinkpath

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 49de4dfb282e2ad4dc91328ffd7fc396ee92b4a0 # Parent 9fbbf8d286cce1b48b3defc6c50a09596367 util: unify unlinkpath Previously, there were two slightly different versions of unlinkpath

[PATCH 1 of 3 v2] posix: use local reference to unlink

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 281fd76b392c38bd5299198810f85f9e3c2034be # Parent 527a247f114f8af37326805fd6cce923f9ac6453 posix: use local reference to unlink We have a local reference to os.unlink in module scope

[PATCH 2 of 3 v2] posix: use local reference to removedirs

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 9fbbf8d286cce1b48b3defc6c50a09596367 # Parent 281fd76b392c38bd5299198810f85f9e3c2034be posix: use local reference to removedirs We have a local reference to os.removedirs in

[PATCH v2] localrepo: improve vfs documentation

2017-03-21 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490104242 25200 # Tue Mar 21 06:50:42 2017 -0700 # Node ID 99b12351af995446ad4f9d52b3fda0b591611e69 # Parent 527a247f114f8af37326805fd6cce923f9ac6453 localrepo: improve vfs documentation At the beginning of March, I promised Yuya that I

Re: [PATCH 13 of 14] vfs: use unlink

2017-03-21 Thread Ryan McElroy
On 3/21/17 11:30 AM, Ryan McElroy wrote: On 3/21/17 3:28 AM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 19:10:56 -0700: # HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # No

Re: [PATCH 04 of 14] util: add tryunlink function

2017-03-21 Thread Ryan McElroy
On 3/21/17 3:25 AM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 19:10:47 -0700: # HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 6c9e676047b5dc2469cd9c00ca82e9389a287839 # P

Re: [PATCH 13 of 14] vfs: use unlink

2017-03-21 Thread Ryan McElroy
On 3/21/17 3:28 AM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 19:10:56 -0700: # HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 912717e0a0921df8cb8440ce69185850e53788ba # P

Re: [PATCH] localrepo: improve vfs documentation

2017-03-20 Thread Ryan McElroy
On 3/21/17 2:11 AM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 19:07:18 -0700: # HG changeset patch # User Ryan McElroy # Date 1490060600 25200 # Mon Mar 20 18:43:20 2017 -0700 # Node ID 8fbdaf1533bb20cb471679be6ab2dc799fd7e634 # P

Re: [PATCH V2] mq: reject new patch name containing leading/trailing whitespace

2017-03-20 Thread Ryan McElroy
On 3/21/17 2:08 AM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1489977517 -32400 # Mon Mar 20 11:38:37 2017 +0900 # Node ID d50f4ea6fa885c06232c18bd58f7019f2ba3767f # Parent 44c591f634584c721778c5a77edeb04cd919ac43 mq: reject new patch name containing leading/t

[PATCH 14 of 14] localrepo: use tryunlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 15776ed2da3a4bff384d2e2dc0f27f01a1120021 # Parent 912717e0a0921df8cb8440ce69185850e53788ba localrepo: use tryunlink diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py --- a

[PATCH 09 of 14] chgserver: use tryunlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 0007cf40dbeaa03a43649de4b5794dd68a43f948 # Parent 026786cf8915816fcf65dc293d92f04c1f566a91 chgserver: use tryunlink diff --git a/mercurial/chgserver.py b/mercurial/chgserver.py --- a

[PATCH 07 of 14] shelve: use tryunlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 79c8e7ca7cb92d208c4c72454f06f11e6ef99d49 # Parent 640adb7ea3cd568cd046ee55ede19849082595ce shelve: use tryunlink diff --git a/hgext/shelve.py b/hgext/shelve.py --- a/hgext/shelve.py

[PATCH 06 of 14] vfs: add tryunlink method

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 640adb7ea3cd568cd046ee55ede19849082595ce # Parent 2908e421fa11b827f880de73cfa53667cc0635cb vfs: add tryunlink method Thoughout hg code, we see a pattern of attempting to remove a

[PATCH 12 of 14] server: use tryunlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490062175 25200 # Mon Mar 20 19:09:35 2017 -0700 # Node ID f405f3bb1b9686322545a61d2f8df45ff53b4527 # Parent 87d67dea66e7820d59153d74ce7cf4fe809323c9 server: use tryunlink diff --git a/mercurial/server.py b/mercurial/server.py --- a

[PATCH 04 of 14] util: add tryunlink function

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 6c9e676047b5dc2469cd9c00ca82e9389a287839 # Parent d35d6cde9c2e428a7e77f35d2cd745696bec072a util: add tryunlink function Throughout mercurial cdoe, there is a common pattern of

[PATCH 11 of 14] dirstate: use tryunlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 87d67dea66e7820d59153d74ce7cf4fe809323c9 # Parent 3228faef45885c9f931fb88ae3b796d923cde7c2 dirstate: use tryunlink diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py --- a

[PATCH 03 of 14] util: unify unlinkpath

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID d35d6cde9c2e428a7e77f35d2cd745696bec072a # Parent 14339b2761ba49e914ec2be4446e2005ce024e8a util: unify unlinkpath Previously, there were two slightly different versions of unlinkpath

[PATCH 13 of 14] vfs: use unlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 912717e0a0921df8cb8440ce69185850e53788ba # Parent f405f3bb1b9686322545a61d2f8df45ff53b4527 vfs: use unlink diff --git a/mercurial/vfs.py b/mercurial/vfs.py --- a/mercurial/vfs.py

[PATCH 10 of 14] debug: use tryunlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 3228faef45885c9f931fb88ae3b796d923cde7c2 # Parent 0007cf40dbeaa03a43649de4b5794dd68a43f948 debug: use tryunlink diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py

[PATCH 08 of 14] bookmarks: use tryunlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 026786cf8915816fcf65dc293d92f04c1f566a91 # Parent 79c8e7ca7cb92d208c4c72454f06f11e6ef99d49 bookmarks: use tryunlink diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py --- a

[PATCH 05 of 14] util: use tryunlink in unlinkpath

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 2908e421fa11b827f880de73cfa53667cc0635cb # Parent 6c9e676047b5dc2469cd9c00ca82e9389a287839 util: use tryunlink in unlinkpath We just introduced a func to attempt a file removal

[PATCH 02 of 14] posix: use local reference to removedirs

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 14339b2761ba49e914ec2be4446e2005ce024e8a # Parent 9e525e28e3c76792f57355989bdd652f0617541d posix: use local reference to removedirs We have a local reference to os.removedirs in

[PATCH 01 of 14] posix: use local reference to unlink

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 9e525e28e3c76792f57355989bdd652f0617541d # Parent 8fbdaf1533bb20cb471679be6ab2dc799fd7e634 posix: use local reference to unlink We have a local reference to os.unlink in module scope

[PATCH] localrepo: improve vfs documentation

2017-03-20 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1490060600 25200 # Mon Mar 20 18:43:20 2017 -0700 # Node ID 8fbdaf1533bb20cb471679be6ab2dc799fd7e634 # Parent 2dc8b65b19a9d4bd14e8e935a27e29c91be1f6ec localrepo: improve vfs documentation At the beginning of March, I promised Yuya that I

Re: [PATCH 2 of 2 v2] rebase: add flag to require destination

2017-03-20 Thread Ryan McElroy
Any objections here? On 3/16/17 1:55 AM, Ryan McElroy wrote: On 3/14/17 8:26 PM, David Soria Parra wrote: On Tue, Mar 14, 2017 at 05:56:16PM -0700, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1489538624 25200 # Tue Mar 14 17:43:44 2017 -0700 # Node ID

Re: [PATCH 2 of 2] rebase: add flag to require destination

2017-03-20 Thread Ryan McElroy
McElroy wrote: On 3/12/17 5:48 PM, Gregory Szorc wrote: On Sun, Mar 12, 2017 at 12:06 PM, Augie Fackler wrote: On Sat, Mar 11, 2017 at 06:03:13PM -0800, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1489283611 28800 # Sat Mar 11 17:53:31 2017 -0800 # Node ID

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

2017-03-20 Thread Ryan McElroy
Overall, I like the functionality this series adds, but I'm less convinced on the specific implementation. Adding more stuff to the junkyard that is the "ui" class doesn't feel awesome, and I'm concerned with how it will interact with chg and a future direction of ui immutability. I have an a

Re: [PATCH 2 of 3] lock: add ability to store additional metadata on filesytem

2017-03-20 Thread Ryan McElroy
On 3/20/17 7:49 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1489995201 25200 # Mon Mar 20 00:33:21 2017 -0700 # Node ID 1ca023fb02cbe4747e2b5b625866cfa538cbebd3 # Parent 2c1d5a02ec533055f182b0cc1280107fbfb76206 lock: add ability to store additional metadata on files

Re: [PATCH 1 of 3] dispatch: store args and command run on ui

2017-03-20 Thread Ryan McElroy
I think Jun needs to weigh in on this since the ui object is something he's wanted to make immutable for a while and this doesn't seem to help move us in that direction. On 3/20/17 7:49 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1489995201 25200 # Mon Mar 20 00:3

Re: [PATCH] mq: reject new patch name containing leading/trailing whitespaces

2017-03-20 Thread Ryan McElroy
These changes generally look good to me. A few small nit-picks inline. On 3/20/17 8:21 AM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1489977517 -32400 # Mon Mar 20 11:38:37 2017 +0900 # Node ID cede8eaf55e2fe68434c273cfd066512b5ca112e # Parent a369482e964947

Re: [PATCH] graphlog: draw multiple edges towards null node (issue5440)

2017-03-20 Thread Ryan McElroy
On 3/20/17 8:22 AM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1489978255 -32400 # Mon Mar 20 11:50:55 2017 +0900 # Node ID db70a30dde5182e704b02b0e47a79d3ecfafdd49 # Parent cede8eaf55e2fe68434c273cfd066512b5ca112e graphlog: draw multiple edges towards null nod

Re: [PATCH 4 of 4 V3] filemerge: add test cases for corner cases using internal:dumpjson

2017-03-20 Thread Ryan McElroy
Patch 3 looks good to me. In this patch, I'd fold the test additions into the new test case you made in patch 3 -- a separate test for corner cases doesn't really make sense to me. Otherwise, the tests look good to me. Looking forward to the next version of this series which I think will be

Re: [PATCH 2 of 4 V3] merge: add summarizeconflicts()

2017-03-20 Thread Ryan McElroy
Just a few nitpicks inline. On 3/17/17 2:17 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1489716532 25200 # Thu Mar 16 19:08:52 2017 -0700 # Node ID 864def5028681cdffeaf5b440ff4753e1389f453 # Parent ad81d182e88ffd3da20364f18204facf6e7750a3 merge: add summarizeconfl

Re: [PATCH 1 of 4 V3] filemerge: add `summarize()`

2017-03-20 Thread Ryan McElroy
A bunch of comments inline. One more round should do it I think. On 3/17/17 2:17 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1489716177 25200 # Thu Mar 16 19:02:57 2017 -0700 # Node ID ad81d182e88ffd3da20364f18204facf6e7750a3 # Parent 568d80b24b3a3e4e6874ac0d95dde

Re: [PATCH V2] merge: add `internal:dumpjson` tool to `resolve`, which outputs conflict state

2017-03-15 Thread Ryan McElroy
More nits inline to consider since you're looking into a v3 anyway... On 3/15/17 10:48 AM, Durham Goode wrote: On 3/7/17 11:40 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1488915535 28800 # Tue Mar 07 11:38:55 2017 -0800 # Node ID bbce62e3790220f19e7b37160a2f835

[PATCH] tests: properly drop back to root dir in test-status.t

2017-03-15 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1489631180 25200 # Wed Mar 15 19:26:20 2017 -0700 # Node ID c3f9fa00b1d2fccf57f479c81ef69ce9a9282281 # Parent 8d8b783803f43d5e2d86916c39e9554139752fe6 tests: properly drop back to root dir in test-status.t diff --git a/tests/test-status.t b

<    1   2   3   4   5   >