Re: [PATCH] py3: handle os.environ.get() case in module loader

2016-08-17 Thread Siddharth Agarwal
On 8/4/16 20:26, Siddharth Agarwal wrote: I agree with Greg -- this makes things more complicated than necessary. We should just have a helper (e.g. util.environ) that gets assigned to os.environ on py2 and os.environb on py3. (And with possibly different behavior on Windows, similar to

Re: [PATCH] py3: handle os.environ.get() case in module loader

2016-08-17 Thread Siddharth Agarwal
On 8/17/16 10:21, Gregory Szorc wrote: WindowsUTF8Plan has existed for years without any movement. Addressing that will require a massive refactor. Since it isn't on our radar, I think it is out of scope for Python 3 porting work. Can we just use os.environb/bytes paths on Python 3 for now and

[PATCH] merge: remove files with extra actions from merge action list

2016-08-23 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1472000333 25200 # Tue Aug 23 17:58:53 2016 -0700 # Node ID 6cae957b9be33ddd8e9d1246626a8908456b1aef # Parent b1809f5d7630a3fff0fa715bbd30dba0f07672a8 merge: remove files with extra actions from merge action list See the comment for a

Re: [PATCH 3 of 3 v3] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

2016-09-21 Thread Siddharth Agarwal
On 9/21/16 12:09, timeless wrote: # HG changeset patch # User timeless # Date 1474429683 0 # Wed Sep 21 03:48:03 2016 + # Node ID 0070696439eab002f6dd32bcb40eb671daff800a # Parent adb54fd7d90f0ca607432ed7ae884da55ec427de # Available At https://bitbucket.org/timeless/mercurial-crew #

Re: [PATCH 1 of 5] posix: move checkexec test file to .hg/cache

2016-11-29 Thread Siddharth Agarwal
On 11/17/16 10:44, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1479383976 -3600 # Thu Nov 17 12:59:36 2016 +0100 # Node ID 1b5e959ebd859c27b3369124c926a512e222545c # Parent 854190becacb8abecbf5c18a777b02bbc045 posix: move checkexec test file to .hg/cache Th

Re: Better release notes

2017-02-02 Thread Siddharth Agarwal
On 2/2/17 10:53, Gregory Szorc wrote: * Checking in a dedicated file tracking release notes and starting a culture where we update this file accordingly (many open source projects do this) This is a good idea. +1 for a changelog file that explicitly only contains user-facing release notes.

[PATCH] bundle2: fix assertion that 'compression' hasn't been set

2017-02-13 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1487014992 28800 # Mon Feb 13 11:43:12 2017 -0800 # Node ID 130eeba1cccdc63677da88a0f0dabe7fc39f963a # Parent 72f25e17af9d6a206ea374c30f229ae9513f3f23 bundle2: fix assertion that 'compression' hasn't been set `n.lower

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

2017-02-13 Thread Siddharth Agarwal
On 2/13/17 13:03, Jun Wu wrote: I think it could be an extension outside core. I'd say make it a clone-time option, turned off by default, with caveats documented. At FB we ban the situations where flock wouldn't work for scalability reasons anyway. Note that flock requires the file be per

[PATCH] help: fix internals.changegroups

2017-03-01 Thread Siddharth Agarwal
text and fix up a few ambiguities. The document also contains a few additional fixes from Siddharth Agarwal , who used it to build a parser for changegroups in Rust. diff --git a/mercurial/help/internals/changegroups.txt b/mercurial/help/internals/changegroups.txt --- a/mercurial/help/internals

Re: [PATCH stable] fsmonitor: match watchman and local encoding

2017-03-06 Thread Siddharth Agarwal
On 3/6/17 09:50, Olivier Trempe wrote: # HG changeset patch # User Olivier Trempe # Date 1488810111 18000 # Mon Mar 06 09:21:51 2017 -0500 # Branch stable # Node ID c9d3f8d1a57346228f5c3bb749acdff90d37e194 # Parent 6b00c3ecd15b26587de8cca6fab811069cba3b2f fsmonitor: match watchman and loca

Re: Dropping support for Python 2.6 on Windows

2017-03-16 Thread Siddharth Agarwal
On 3/16/17 09:54, Gregory Szorc wrote: There is a brewing discussion about the future of Python 2.6 in Mercurial. I'd like to start with what I think will be an easy proposal: officially dropping support for 2.6 on Windows. Sounds reasonable to me. First, I think dropping 2.6 on Windows doe

bundle2: error parts can exceed length limits and crash the server

2017-04-03 Thread Siddharth Agarwal
While reimplementing bundle2 for our Rust server, I ran into an interesting issue with error parts. Some relevant background: 1. A bundle2 consists of zero or more "parts". 2. Each part has a header, consisting of - a part type - a numeric part id - part parameters 3. Part parameters are (key,

Re: bundle2: error parts can exceed length limits and crash the server

2017-04-03 Thread Siddharth Agarwal
On 4/3/17 20:48, Gregory Szorc wrote: This sounds reasonable to me. This will likely require a new bundle2 part(s) in order to differentiate the behavior of the part. Alternatively, I suppose there could be a bundle2 capability identifying whether the peer understands error messages in paylo

Re: bundle2: error parts can exceed length limits and crash the server

2017-04-03 Thread Siddharth Agarwal
On 4/3/17 20:54, Gregory Szorc wrote: On Mon, Apr 3, 2017 at 8:51 PM, Siddharth Agarwal <mailto:s...@less-broken.com>> wrote: On 4/3/17 20:48, Gregory Szorc wrote: This sounds reasonable to me. This will likely require a new bundle2 part(s) in

[PATCH 3 of 3] bundle2: handle long error params on the unbundling side

2017-04-04 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1491349317 25200 # Tue Apr 04 16:41:57 2017 -0700 # Node ID 0f7eea5bae914c2ec36f004e214a336054287727 # Parent f31d776ec35686693b3521c07a61ade94e567b9a bundle2: handle long error params on the unbundling side As the tests establish, the

[PATCH 1 of 3] bundle2: add separate handling for error part creation

2017-04-04 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1491348154 25200 # Tue Apr 04 16:22:34 2017 -0700 # Node ID 5c84da513a5ff56a973a89631f266c6fcf9b18cd # Parent 04ec317b81280c189fcea33a05c8cbbac3c186b1 bundle2: add separate handling for error part creation This will be used in upcoming

[PATCH 2 of 3] bundle2: use bundleerrorparts for error parts with unbounded parameters

2017-04-04 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1491349293 25200 # Tue Apr 04 16:41:33 2017 -0700 # Node ID f31d776ec35686693b3521c07a61ade94e567b9a # Parent 5c84da513a5ff56a973a89631f266c6fcf9b18cd bundle2: use bundleerrorparts for error parts with unbounded parameters Clients do not

[PATCH 2 of 3 V2] bundle2: use bundleerrorparts for error parts with unbounded parameters

2017-04-04 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1491349293 25200 # Tue Apr 04 16:41:33 2017 -0700 # Node ID 21c811d141254489398a83affa46e066bf2f6b94 # Parent ad6196e3370572b9d0b436ab9d901f26884633f4 bundle2: use bundleerrorparts for error parts with unbounded parameters Clients do not

[PATCH 3 of 3 V2] bundle2: handle long error params on the unbundling side

2017-04-04 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1491349317 25200 # Tue Apr 04 16:41:57 2017 -0700 # Node ID 52572916e2ae57e92d22d718e469a7c0928e8f5e # Parent 21c811d141254489398a83affa46e066bf2f6b94 bundle2: handle long error params on the unbundling side As the tests establish, the

[PATCH 1 of 3 V2] bundle2: add separate handling for error part creation

2017-04-04 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1491348154 25200 # Tue Apr 04 16:22:34 2017 -0700 # Node ID ad6196e3370572b9d0b436ab9d901f26884633f4 # Parent 04ec317b81280c189fcea33a05c8cbbac3c186b1 bundle2: add separate handling for error part creation This will be used in upcoming

Re: [PATCH V2] fsmonitor: match watchman and filesystem encoding

2017-04-05 Thread Siddharth Agarwal
On 4/5/17 08:42, Olivier Trempe wrote: # HG changeset patch # User Olivier Trempe # Date 1488981822 18000 # Wed Mar 08 09:03:42 2017 -0500 # Branch stable # Node ID 2021c3032968bef6b8d1cd7bea5a22996ced994c # Parent 68f263f52d2e3e2798b4f1e55cb665c6b043f93b fsmonitor: match watchman and file

Re: [PATCH V2] fsmonitor: match watchman and filesystem encoding

2017-04-05 Thread Siddharth Agarwal
On 4/5/17 13:30, Olivier Trempe wrote: Absolutely. This will be fixed in V3. I also realize the "import sys" statement was removed 3 months ago. I missed it when rebasing... This will also be fixed in V3. Thanks. In general, do you think you could add a test for the behavior where fsmonitor

Re: [PATCH 2 of 3 V2] bundle2: use bundleerrorparts for error parts with unbounded parameters

2017-04-07 Thread Siddharth Agarwal
On 4/6/17 05:50, Pierre-Yves David wrote: small note: This test seems to be checking the bundle2 format and API more than the target feature. This seems superfluous or at least wrongly located. Could you elaborate about what you mean? There's a wire transmission going on. This is an example

Re: [PATCH 1 of 3 V2] bundle2: add separate handling for error part creation

2017-04-07 Thread Siddharth Agarwal
On 4/6/17 05:50, Pierre-Yves David wrote: While I understand the need for unbounded generic error:Abort, I not sure we should extend this to pushraced and unsupported content one. They have defined enough use case where limiting the message and hint to 255 char seems reasonable (in the exceptio

Re: [PATCH 3 of 3 V2] bundle2: handle long error params on the unbundling side

2017-04-07 Thread Siddharth Agarwal
On 4/6/17 05:50, Pierre-Yves David wrote: On 04/05/2017 05:49 AM, Siddharth Agarwal wrote: # HG changeset patch # User Siddharth Agarwal # Date 1491349317 25200 # Tue Apr 04 16:41:57 2017 -0700 # Node ID 52572916e2ae57e92d22d718e469a7c0928e8f5e # Parent

Mini-sprint at PyCon US?

2017-04-10 Thread Siddharth Agarwal
Hi everyone, PyCon US is in Portland, OR from May 17-25, 2017. Usually a bunch of people from the Mercurial community attend the event -- it would be great if we could get together and do a mini-sprint there. May 22-25 are reserved for sprints, and I was going to be around on the 22nd (my fl

Re: Potential BC changes to sparse before freeze

2017-07-11 Thread Siddharth Agarwal
On 7/11/17 1:17 PM, Martin von Zweigbergk via Mercurial-devel wrote: I think I'm against this. I think it's clearer that excludes trump includes if they appear after. Of course,*I* can continue to write it that way and we can let anyone choose their own order, so it won't really make a differenc

PLEASE SIGN UP: Mercurial 4.4 sprint

2017-07-21 Thread Siddharth Agarwal
Hi everyone, The Mercurial 4.4 sprint is going to be held in Europe some time in September or early October. Please sign up here with your availability: https://www.mercurial-scm.org/wiki/4.4sprint <<< Please get your signups in by **Wednesday, July 26 at 23:59 UTC**. Thanks, Siddharth on

Re: PLEASE SIGN UP: Mercurial 4.4 sprint

2017-07-25 Thread Siddharth Agarwal
On 7/21/17 10:43 AM, Siddharth Agarwal wrote: Hi everyone, The Mercurial 4.4 sprint is going to be held in Europe some time in September or early October. Please sign up here with your availability: Thank you to everyone who's signed up already. Reminder -- please sign up by tomorrow,

Mercurial 4.4 sprint: September 29-October 1 at Facebook Dublin

2017-08-08 Thread Siddharth Agarwal
Hi everyone, I'm happy to announce that the Mercurial 4.4 sprint will be held from September 29-October 1, 2017, at Facebook Dublin in Ireland. For more details and to mark your attendance and suggest topics, please see https://www.mercurial-scm.org/wiki/4.4sprint. Thanks, Siddharth __

The 'attrs' library is now available within Mercurial -- a better namedtuple

2017-10-01 Thread Siddharth Agarwal
Hi everyone -- The attrs library is now available to use within Mercurial as 'mercurial.thirdparty.attrs'. attrs is basically a better version of collections.namedtuple with none of the weird semantics (e.g. you can't compare a tuple and an attr) and no runtime performance cost (especially wi

[PATCH STABLE] histedit: make check for unresolved conflicts explicit (issue5545)

2017-04-20 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1492733888 25200 # Thu Apr 20 17:18:08 2017 -0700 # Node ID f368dbe9671ece414c842f164269e893521e3e5d # Parent ed42e00a5c4ec7a3bebaec699ef934429cdc2ddd histedit: make check for unresolved conflicts explicit (issue5545) Previously, we&#

[PATCH] internals: document that "branches" is a legacy command

2017-05-03 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1493845634 25200 # Wed May 03 14:07:14 2017 -0700 # Node ID 7e90b9553a02ef30fd289736cfb559c83b6766e2 # Parent 8ac7ac714e922fd34abe9f5a16fcf018c8b12abc internals: document that "branches" is a legacy command Modern clients use a

Re: [PATCH] internals: document that "branches" is a legacy command

2017-05-03 Thread Siddharth Agarwal
On 5/3/17 22:07, Siddharth Agarwal wrote: # HG changeset patch # User Siddharth Agarwal # Date 1493845634 25200 # Wed May 03 14:07:14 2017 -0700 # Node ID 7e90b9553a02ef30fd289736cfb559c83b6766e2 # Parent 8ac7ac714e922fd34abe9f5a16fcf018c8b12abc internals: document that "branches&

[PATCH 4 of 4 RFC] clone: add a server-side option to disable full getbundles (pull-based clones)

2017-05-08 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1494301361 25200 # Mon May 08 20:42:41 2017 -0700 # Node ID 68ab508896918ac1d56ae0d2681e39fbf623aa5c # Parent 052bd5cfe3769b10c64a4a39d9734a2740d44e16 clone: add a server-side option to disable full getbundles (pull-based clones) For

[PATCH 2 of 4 RFC] clone: test streaming disabled because client is missing requirement

2017-05-08 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 149429 25200 # Mon May 08 18:47:24 2017 -0700 # Node ID 16696b166a70288f05d9306591d66fdd87c51702 # Parent b433f29233e32d1c1e665b0c04ae0ef356ce0396 clone: test streaming disabled because client is missing requirement Turns out we had

[PATCH 3 of 4 RFC] clone: warn when streaming was requested but couldn't be performed

2017-05-08 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1494298866 25200 # Mon May 08 20:01:06 2017 -0700 # Node ID 052bd5cfe3769b10c64a4a39d9734a2740d44e16 # Parent 16696b166a70288f05d9306591d66fdd87c51702 clone: warn when streaming was requested but couldn't be performed This helps

[PATCH 1 of 4 RFC] bundle2: don't check for whether we can do stream clones

2017-05-08 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1494289851 25200 # Mon May 08 17:30:51 2017 -0700 # Node ID b433f29233e32d1c1e665b0c04ae0ef356ce0396 # Parent 8f1a2b848b52ea7bf3fe2404e3b62924c7aae93f bundle2: don't check for whether we can do stream clones At the moment this isn&#

Re: [PATCH 4 of 4 RFC] clone: add a server-side option to disable full getbundles (pull-based clones)

2017-05-09 Thread Siddharth Agarwal
(I was looking for feedback on both the feature and the wording -- thanks!) On 5/8/17 23:18, Gregory Szorc wrote: My only non-nit concern about this patch is the wording here. Does the average user know what a "pull-based clone" is? But I'm struggling to come up with something obviously better.

[PATCH 1 of 4 V2] bundle2: don't check for whether we can do stream clones

2017-05-11 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1494289851 25200 # Mon May 08 17:30:51 2017 -0700 # Node ID b433f29233e32d1c1e665b0c04ae0ef356ce0396 # Parent 8f1a2b848b52ea7bf3fe2404e3b62924c7aae93f bundle2: don't check for whether we can do stream clones At the moment this isn&#

[PATCH 2 of 4 V2] clone: test streaming disabled because client is missing requirement

2017-05-11 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 149429 25200 # Mon May 08 18:47:24 2017 -0700 # Node ID 16696b166a70288f05d9306591d66fdd87c51702 # Parent b433f29233e32d1c1e665b0c04ae0ef356ce0396 clone: test streaming disabled because client is missing requirement Turns out we had

[PATCH 3 of 4 V2] clone: warn when streaming was requested but couldn't be performed

2017-05-11 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1494298866 25200 # Mon May 08 20:01:06 2017 -0700 # Node ID 052bd5cfe3769b10c64a4a39d9734a2740d44e16 # Parent 16696b166a70288f05d9306591d66fdd87c51702 clone: warn when streaming was requested but couldn't be performed This helps

[PATCH 4 of 4 V2] clone: add a server-side option to disable full getbundles (pull-based clones)

2017-05-11 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1494525005 25200 # Thu May 11 10:50:05 2017 -0700 # Node ID fa570690257581e3197f8730b6522e80d58a3f45 # Parent 052bd5cfe3769b10c64a4a39d9734a2740d44e16 clone: add a server-side option to disable full getbundles (pull-based clones) For

https://www.mercurial-scm.org/downloads doesn't have download links?

2017-05-14 Thread Siddharth Agarwal
A coworker alerted me to this: https://www.mercurial-scm.org/downloads doesn't appear to have any download links. For Windows there should be a link to a TortoiseHg build or the MSI. - Siddharth ___ Mercurial-devel mailing list Mercurial-devel@mercurial-

Re: [PATCH] repair: compress bundles with gzip instead of bzip2 (BC)

2017-05-15 Thread Siddharth Agarwal
On 5/13/17 23:33, Gregory Szorc wrote: I*would* like to change the default to zstd (if available). However, that's a significant BC break and I don't feel comfortable changing it just yet. When we have official zstd revlog support and the repo is using it, I think it makes sense to use zstd for

Minisprint at PyCon US?

2017-05-15 Thread Siddharth Agarwal
PyCon US is happening later this week in Portland, OR. I'm sure some people from the Mercurial community would be attending the main event, and there's some time reserved next week for development sprints, so let's get together! I've put up a wiki page at https://www.mercurial-scm.org/wiki/20

[PATCH 7 of 8 demandimport-py3] init: turn on demandimport for Python 3.6 and above

2017-05-21 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495396261 25200 # Sun May 21 12:51:01 2017 -0700 # Node ID 1bf07f6a0c323a4a842d7e76d14e4e893a2b68ca # Parent 0c781be127ded0349e093e492b507e343bf78676 init: turn on demandimport for Python 3.6 and above This uses the new demandimport

[PATCH 4 of 8 demandimport-py3] check: check modules in hgdemandimport

2017-05-21 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495399466 25200 # Sun May 21 13:44:26 2017 -0700 # Node ID 55240ad4c7fc14d01256df4bbae1d5ef9d609cc6 # Parent 3af6014ae4e910c30de7b9ed16ce0e9130ccc270 check: check modules in hgdemandimport A few places only check modules in mercurial

[PATCH 6 of 8 demandimport-py3] demandimport: add python 3 implementation

2017-05-21 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495394584 25200 # Sun May 21 12:23:04 2017 -0700 # Node ID 0c781be127ded0349e093e492b507e343bf78676 # Parent 24d81489a7dcac5a68b846dca4928c0e22a312a1 demandimport: add python 3 implementation This implementation uses the new importlib

[PATCH 5 of 8 demandimport-py3] demandimport: move ignore list to __init__.py

2017-05-21 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495393853 25200 # Sun May 21 12:10:53 2017 -0700 # Node ID 24d81489a7dcac5a68b846dca4928c0e22a312a1 # Parent 55240ad4c7fc14d01256df4bbae1d5ef9d609cc6 demandimport: move ignore list to __init__.py We're going to use the same ignore

[PATCH 8 of 8 demandimport-py3] python3: allow hgloader to work with lazy loaders

2017-05-21 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495398377 25200 # Sun May 21 13:26:17 2017 -0700 # Node ID 902d8e08f7e5bc6114e2fd9285be6ef75225da9e # Parent 1bf07f6a0c323a4a842d7e76d14e4e893a2b68ca python3: allow hgloader to work with lazy loaders Don't clobber the loader ret

[PATCH 2 of 8 demandimport-py3] import-checker: add a way to directly import certain symbols

2017-05-21 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495393741 25200 # Sun May 21 12:09:01 2017 -0700 # Node ID 2fc0a078b9f1dfa17420b90895d02d4574618c11 # Parent 5e82c2bdd3331c097629feb7108ec6b4975384e7 import-checker: add a way to directly import certain symbols We'll use this fo

[PATCH 3 of 8 demandimport-py3] demandimport: move to separate package

2017-05-21 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495393853 25200 # Sun May 21 12:10:53 2017 -0700 # Node ID 3af6014ae4e910c30de7b9ed16ce0e9130ccc270 # Parent 2fc0a078b9f1dfa17420b90895d02d4574618c11 demandimport: move to separate package In Python 3, demand loading is per-package

[PATCH 1 of 8 demandimport-py3] check-code: allow skipping hasattr check in py3-only code

2017-05-21 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495398882 25200 # Sun May 21 13:34:42 2017 -0700 # Node ID 5e82c2bdd3331c097629feb7108ec6b4975384e7 # Parent c87db79b95079c3fd0032be7a25cd41567ed11cb check-code: allow skipping hasattr check in py3-only code hasattr is safe in Python 3

Re: [PATCH 8 of 8 demandimport-py3] python3: allow hgloader to work with lazy loaders

2017-05-22 Thread Siddharth Agarwal
On 5/21/17 18:26, Gregory Szorc wrote: On Sun, May 21, 2017 at 1:48 PM, Siddharth Agarwal <mailto:s...@fb.com>> wrote: # HG changeset patch # User Siddharth Agarwal mailto:s...@fb.com>> # Date 1495398377 25200 # Sun May 21 13:26:17 2017 -070

[PATCH hyperblame] annotate: allow skipping revs

2017-05-22 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495499248 25200 # Mon May 22 17:27:28 2017 -0700 # Node ID c14a092fcb1184b5961d81620f88de5771e24cea # Parent e8c043375b53b30c4b468687f08323cbeeb452ef annotate: allow skipping revs This is not ready to be landed yet, but several people

Re: [PATCH hyperblame] annotate: allow skipping revs

2017-05-22 Thread Siddharth Agarwal
On 5/22/17 17:27, Siddharth Agarwal wrote: # HG changeset patch # User Siddharth Agarwal # Date 1495499248 25200 # Mon May 22 17:27:28 2017 -0700 # Node ID c14a092fcb1184b5961d81620f88de5771e24cea # Parent e8c043375b53b30c4b468687f08323cbeeb452ef annotate: allow skipping revs This is

[PATCH 1 of 4 hyperblame] annotate: move pair function to top level

2017-05-24 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495672708 25200 # Wed May 24 17:38:28 2017 -0700 # Node ID de6d23b18ea0e4e6eb46b509639c63b2318ac979 # Parent e8c043375b53b30c4b468687f08323cbeeb452ef annotate: move pair function to top level We'll want to make this more complicate

[PATCH 3 of 4 hyperblame] annotate: add core algorithm to skip a rev

2017-05-24 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495678034 25200 # Wed May 24 19:07:14 2017 -0700 # Node ID 134dcc1222e4b992b4a60c44c9b9ed8d10422632 # Parent 0f28e90b0fb95733de10f8d1524c345fe5949315 annotate: add core algorithm to skip a rev The core algorithm is inspired by git hyper

[PATCH 2 of 4 hyperblame] annotate: make pair take all parents to pair against

2017-05-24 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495672808 25200 # Wed May 24 17:40:08 2017 -0700 # Node ID 0f28e90b0fb95733de10f8d1524c345fe5949315 # Parent de6d23b18ea0e4e6eb46b509639c63b2318ac979 annotate: make pair take all parents to pair against In upcoming patches we'll ne

[PATCH 4 of 4 hyperblame] annotate: add a new experimental --skip option to skip revs

2017-05-24 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1495679973 25200 # Wed May 24 19:39:33 2017 -0700 # Node ID 0c6f6c4b027191c30d867fb4eb0005682ea90a76 # Parent 134dcc1222e4b992b4a60c44c9b9ed8d10422632 annotate: add a new experimental --skip option to skip revs This option is most useful

Re: [PATCH 4 of 4 hyperblame] annotate: add a new experimental --skip option to skip revs

2017-05-25 Thread Siddharth Agarwal
On 5/24/17 7:39 PM, Siddharth Agarwal wrote: # HG changeset patch # User Siddharth Agarwal # Date 1495679973 25200 # Wed May 24 19:39:33 2017 -0700 # Node ID 0c6f6c4b027191c30d867fb4eb0005682ea90a76 # Parent 134dcc1222e4b992b4a60c44c9b9ed8d10422632 annotate: add a new experimental --skip

Re: [PATCH 1 of 4 hyperblame] annotate: move pair function to top level

2017-05-25 Thread Siddharth Agarwal
On 5/24/17 7:39 PM, Siddharth Agarwal wrote: # HG changeset patch # User Siddharth Agarwal # Date 1495672708 25200 # Wed May 24 17:38:28 2017 -0700 # Node ID de6d23b18ea0e4e6eb46b509639c63b2318ac979 # Parent e8c043375b53b30c4b468687f08323cbeeb452ef annotate: move pair function to top

Re: [PATCH 4 of 4 hyperblame] annotate: add a new experimental --skip option to skip revs

2017-05-25 Thread Siddharth Agarwal
On 5/25/17 8:19 PM, Gregory Szorc wrote: I could also imagine the inverse of a skip feature: an "include" feature. You could use this to say "only annotate revisions that correspond to tagged revisions" so you could easily see how a file evolved from release to release. Huh, interesting. I h

Re: [PATCH 4 of 4 hyperblame] annotate: add a new experimental --skip option to skip revs

2017-05-26 Thread Siddharth Agarwal
On 5/25/17 10:14 PM, Gregory Szorc wrote: On Thu, May 25, 2017 at 8:24 PM, Siddharth Agarwal mailto:s...@less-broken.com>> wrote: On 5/25/17 8:19 PM, Gregory Szorc wrote: I could also imagine the inverse of a skip feature: an "include" feature. You could

Re: [PATCH 4 of 4 hyperblame] annotate: add a new experimental --skip option to skip revs

2017-05-30 Thread Siddharth Agarwal
On 5/29/17 6:37 AM, Yuya Nishihara wrote: On Sun, 28 May 2017 22:40:47 -0700, Martin von Zweigbergk via Mercurial-devel wrote: On Wed, May 24, 2017 at 7:39 PM, Siddharth Agarwal wrote: # HG changeset patch # User Siddharth Agarwal # Date 1495679973 25200 # Wed May 24 19:39:33 2017

[PATCH] import-checker: add hgdemandimport to local modules

2017-05-31 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496286428 25200 # Wed May 31 20:07:08 2017 -0700 # Node ID 884f32a63e57d5d7ff3fce3d5b6b99c84df8309d # Parent bd3d33c6014f4553c799c0d3236e17b28ffc85e3 import-checker: add hgdemandimport to local modules This fixes test-check-module

[PATCH] rebase: drop unnecessary parentchange call

2017-05-31 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496285164 25200 # Wed May 31 19:46:04 2017 -0700 # Node ID bd3d33c6014f4553c799c0d3236e17b28ffc85e3 # Parent dc0da9829c2972e1c97e07428d6885c1cd4b8f1f rebase: drop unnecessary parentchange call We're calling localrepo.setparents

[PATCH] match: introduce nevermatcher for when no ignore files are present

2017-06-01 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496302852 25200 # Thu Jun 01 00:40:52 2017 -0700 # Node ID 14f332c8fe10c498e7c35bef09e53b8b6c7e5f43 # Parent dbf330cadc5a3c0707c4611f2f4150be13cac02a match: introduce nevermatcher for when no ignore files are present 952017471f93

[PATCH STABLE] status: don't crash if a lookup file disappears

2017-06-02 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496467672 25200 # Fri Jun 02 22:27:52 2017 -0700 # Branch stable # Node ID d39f934da0c80a568486cd8645eb6bbe513f1f03 # Parent 62e42e2897502bcbaa3a57d3301c789309596391 status: don't crash if a lookup file disappears This can happ

Re: [PATCH STABLE] status: don't crash if a lookup file disappears

2017-06-03 Thread Siddharth Agarwal
On 6/3/17 7:26 AM, Yuya Nishihara wrote: On Fri, 2 Jun 2017 22:28:07 -0700, Siddharth Agarwal wrote: # HG changeset patch # User Siddharth Agarwal # Date 1496467672 25200 # Fri Jun 02 22:27:52 2017 -0700 # Branch stable # Node ID d39f934da0c80a568486cd8645eb6bbe513f1f03 # Parent

users repositories?

2017-06-04 Thread Siddharth Agarwal
Apparently there's some space on mercurial-scm.org for user repositories, e.g. https://www.mercurial-scm.org/repo/users/sid0/hg. 1. Could this be documented somewhere? I searched on the wiki for user repositories and didn't see anything. 2. What credentials do I need to get access to it? Than

[PATCH] dirstate: add docstring for invalidate

2017-06-04 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496617730 25200 # Sun Jun 04 16:08:50 2017 -0700 # Node ID 45841cedb603b93803eec37bd7d01456a6b8e812 # Parent 5277d6faabb4f9593a5d33cdab6c4a6191ad856d dirstate: add docstring for invalidate This always confuses me, and we already have a

Re: users repositories?

2017-06-04 Thread Siddharth Agarwal
://h...@mercurial-scm.org/repo/users/sid0/hg but that just hangs. On 06/05/2017 12:05 AM, Siddharth Agarwal wrote: Apparently there's some space on mercurial-scm.org for user repositories, e.g. https://www.mercurial-scm.org/repo/users/sid0/hg. 1. Could this be documented somewhere? I sea

Re: users repositories?

2017-06-04 Thread Siddharth Agarwal
On 6/4/17 4:19 PM, Pierre-Yves David wrote: On 06/05/2017 12:10 AM, Siddharth Agarwal wrote: On 6/4/17 4:07 PM, Pierre-Yves David wrote: About access: This is the users repository that was on David Soria Para machine hosting the clowncopter. Using the same credential should work, I think we

[PATCH 1 of 5] run-tests: factor out xunit write code into another method

2017-06-06 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496779855 25200 # Tue Jun 06 13:10:55 2017 -0700 # Node ID 2d78617dd0b04d927beff7bc8bb2a1329b92ed8e # Parent e696f597d02f971eeed1217096b8f200ddb903d2 run-tests: factor out xunit write code into another method We're going to use

[PATCH 4 of 5] run-tests: install hg after computing tests to run

2017-06-06 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496782613 25200 # Tue Jun 06 13:56:53 2017 -0700 # Node ID 29aaeed22502929559e1e85d8fb0c1ed6433ecba # Parent cd0fe3fedddab358d47d6f34d5c1e596298199bb run-tests: install hg after computing tests to run We're going to add a way to

[PATCH 2 of 5] run-tests: factor out json write code into another method

2017-06-06 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496779855 25200 # Tue Jun 06 13:10:55 2017 -0700 # Node ID 737bb0771ca0bff0673f861c068018c8f606cf7d # Parent 2d78617dd0b04d927beff7bc8bb2a1329b92ed8e run-tests: factor out json write code into another method We're going to use this

[PATCH 3 of 5] run-tests: make time field optional for xunit report

2017-06-06 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496782345 25200 # Tue Jun 06 13:52:25 2017 -0700 # Node ID cd0fe3fedddab358d47d6f34d5c1e596298199bb # Parent 737bb0771ca0bff0673f861c068018c8f606cf7d run-tests: make time field optional for xunit report We're going to use XUnit to

[PATCH 5 of 5] run-tests: add a way to list tests, with JSON and XUnit support

2017-06-06 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496785139 25200 # Tue Jun 06 14:38:59 2017 -0700 # Node ID 5e521dfd40ae206de2f050bd5915f0f52429f971 # Parent 29aaeed22502929559e1e85d8fb0c1ed6433ecba run-tests: add a way to list tests, with JSON and XUnit support Some test runners are

[PATCH 1 of 2] run-tests: wrap failures in an XUnit 'failure' element

2017-06-07 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496875626 25200 # Wed Jun 07 15:47:06 2017 -0700 # Node ID 0bdfd2f0e15b0d4a20ea4d288e0b4e04f37f25b4 # Parent 3210ffcae3d0b2c2a34b0485f7e20c4057ba6953 run-tests: wrap failures in an XUnit 'failure' element This is closer to

[PATCH 2 of 2] run-tests: add information about skipped tests to XUnit output

2017-06-07 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496875626 25200 # Wed Jun 07 15:47:06 2017 -0700 # Node ID 8e05986478080f8eefd5f645166020d7802175e8 # Parent 0bdfd2f0e15b0d4a20ea4d288e0b4e04f37f25b4 run-tests: add information about skipped tests to XUnit output The XUnit spec supports

[PATCH 2 of 5] run-tests: write test times to output dir

2017-06-07 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496892731 25200 # Wed Jun 07 20:32:11 2017 -0700 # Node ID 47a479f6ee522ad1f1d4e72a8d32096000360dc2 # Parent 90d5a9bc558130c69a8eaf58712f26d2530c49af run-tests: write test times to output dir diff --git a/tests/run-tests.py b/tests/run

[PATCH 1 of 5] run-tests: allow specifying an output dir to write .errs to

2017-06-07 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496892608 25200 # Wed Jun 07 20:30:08 2017 -0700 # Node ID 90d5a9bc558130c69a8eaf58712f26d2530c49af # Parent 8fbb4ec8b06c1513fee3299696be8bdc3e505de1 run-tests: allow specifying an output dir to write .errs to I'm trying to us

[PATCH 5 of 5] run-tests: make --restart work with output dir

2017-06-07 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496895444 25200 # Wed Jun 07 21:17:24 2017 -0700 # Node ID 7157ecbb2426689cd8f1133bf7dde2822d68b6a8 # Parent 1403ca58e0bbd50a9a9287915073516db610b3c2 run-tests: make --restart work with output dir diff --git a/tests/run-tests.py b/tests

[PATCH 3 of 5] run-tests: write JSON reports to output dir

2017-06-07 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496893603 25200 # Wed Jun 07 20:46:43 2017 -0700 # Node ID 511ebc1769a9de229c5cca69ef3893bea1f2a63a # Parent 47a479f6ee522ad1f1d4e72a8d32096000360dc2 run-tests: write JSON reports to output dir diff --git a/tests/run-tests.py b/tests

[PATCH 4 of 5] run-tests: output coverage to output dir

2017-06-07 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1496895426 25200 # Wed Jun 07 21:17:06 2017 -0700 # Node ID 1403ca58e0bbd50a9a9287915073516db610b3c2 # Parent 511ebc1769a9de229c5cca69ef3893bea1f2a63a run-tests: output coverage to output dir There do not appear to be any tests for this

Re: [PATCH 7 of 7] context: avoid writing outdated dirstate out (issue5584)

2017-06-09 Thread Siddharth Agarwal
On 6/8/17 9:08 PM, FUJIWARA Katsunori wrote: # HG changeset patch # User FUJIWARA Katsunori # Date 1496981269 -32400 # Fri Jun 09 13:07:49 2017 +0900 # Node ID 664e3e012535c9d161f0ecb95c6dc0bfdfe9c672 # Parent 9b4ff10f9db00ae7d91a28067d6b50655f5f957d context: avoid writing outdated dirstat

[PATCH 3 of 4] test-dirstate-race: ensure that a isn't in the lookup set at the end

2017-06-10 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497128851 25200 # Sat Jun 10 14:07:31 2017 -0700 # Node ID 212b4b3a41a4edf86cdea2057bfa1c4d3f8a923f # Parent a69ae05fa66239c2aecb3673115de82105c8e9c6 test-dirstate-race: ensure that a isn't in the lookup set at the end We'r

[PATCH 4 of 4] filestat: move __init__ to frompath constructor

2017-06-10 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497128994 25200 # Sat Jun 10 14:09:54 2017 -0700 # Node ID 8f558c7b7e5bd4e2a4aee5ba933da74e81b301bb # Parent 212b4b3a41a4edf86cdea2057bfa1c4d3f8a923f filestat: move __init__ to frompath constructor We're going to add a `f

[PATCH 2 of 4] hghave: add test for whether fsmonitor is enabled

2017-06-10 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497128851 25200 # Sat Jun 10 14:07:31 2017 -0700 # Node ID a69ae05fa66239c2aecb3673115de82105c8e9c6 # Parent af12ded5040ae8b5becf5c354aafe19949d93444 hghave: add test for whether fsmonitor is enabled This uses the HGFSMONITOR_TESTS

[PATCH 1 of 4] tests: add a wrapper to run fsmonitor tests

2017-06-10 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497128850 25200 # Sat Jun 10 14:07:30 2017 -0700 # Node ID af12ded5040ae8b5becf5c354aafe19949d93444 # Parent 776d077eb4ef815e08631fb1e7b33375adca3ef1 tests: add a wrapper to run fsmonitor tests This script does a bunch of non-trivial

Re: [PATCH 1 of 4] tests: add a wrapper to run fsmonitor tests

2017-06-11 Thread Siddharth Agarwal
On 6/10/17 7:49 PM, Yuya Nishihara wrote: Perhaps it's better to wait the process termination by proc.communicate() or proc.wait(). Unfortunately, in this case we can't really communicate() to it since it'll keep running unless it is told to shutdown or terminated. One interesting option wo

Re: [PATCH 3 of 4] test-dirstate-race: ensure that a isn't in the lookup set at the end

2017-06-11 Thread Siddharth Agarwal
On 6/11/17 10:21 PM, Martin von Zweigbergk via Mercurial-devel wrote: Doesn't look like it's guaranteed to be unset. Running "run-tests.py -j50 --runs-per-test=50 test-dirstate-race.t" seems to confirm that (2 of 5 failed for me). How do you rely on it in an upcoming patch? Interesting, I'm no

[PATCH] test-dirstate-race: back out changeset c82fa7efcbc8

2017-06-12 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497298209 25200 # Mon Jun 12 13:10:09 2017 -0700 # Node ID 0b9bca3118048ef1d52b27af156c98df8a0fa685 # Parent 6f775d10e83b928c99d5d6a7caa559c79fd925e1 test-dirstate-race: back out changeset c82fa7efcbc8 This is non-deterministic. In any

[PATCH 2 of 5] workingctx: also pass status tuple into poststatusfixup

2017-06-12 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497301003 25200 # Mon Jun 12 13:56:43 2017 -0700 # Node ID 3097d182d5b89ba643e834215dc41e7e34716857 # Parent f9a3b5bd5c5a9e1fdf68f5b0af1675ecfbc7ae7a workingctx: also pass status tuple into poststatusfixup fsmonitor is going to need

[PATCH 3 of 5] workingctx: add a way for extensions to run code at status fixup time

2017-06-12 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497301010 25200 # Mon Jun 12 13:56:50 2017 -0700 # Node ID f4563ba01434aec8b238693721c246fc86a40732 # Parent 3097d182d5b89ba643e834215dc41e7e34716857 workingctx: add a way for extensions to run code at status fixup time Some extensions

[PATCH 5 of 5] fsmonitor: don't write out state if identity has changed (issue5581)

2017-06-12 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497306871 25200 # Mon Jun 12 15:34:31 2017 -0700 # Node ID f515d7f7f13b07aeb39b4ae39ea6222eac01a3f2 # Parent 1b02cda9518bbda5ad4a08bbad5b3c346dbe fsmonitor: don't write out state if identity has changed (issue5581) Inspired b

[PATCH 4 of 5] fsmonitor: write state with wlock held and dirstate unchanged (issue5581)

2017-06-12 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497306871 25200 # Mon Jun 12 15:34:31 2017 -0700 # Node ID 1b02cda9518bbda5ad4a08bbad5b3c346dbe # Parent f4563ba01434aec8b238693721c246fc86a40732 fsmonitor: write state with wlock held and dirstate unchanged (issue5581) This means

[PATCH 1 of 5] workingctx: factor out post-status dirstate fixup

2017-06-12 Thread Siddharth Agarwal
# HG changeset patch # User Siddharth Agarwal # Date 1497300899 25200 # Mon Jun 12 13:54:59 2017 -0700 # Node ID f9a3b5bd5c5a9e1fdf68f5b0af1675ecfbc7ae7a # Parent 0b9bca3118048ef1d52b27af156c98df8a0fa685 workingctx: factor out post-status dirstate fixup We want to allow extensions to be

  1   2   >