D7377: commands: log --line-range is incompatible with --copies

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was (to my surprise) detected by pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7377 AFFECTED FILES

D7297: cleanup: remove now-obsolete wrong-arg-type annotations

durin42 updated this revision to Diff 18067. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7297?vs=17673=18067 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7297/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7297 AFFECTED FILES

D7383: state: add a pytype annotation

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7383 AFFECTED FILES mercurial/state.py CHANGE DETAILS diff --git a/mercurial/state.py

D7382: logcmdutil: add a type annotation

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This wasn't actually required in the end, as there was a real bug found by pytype, but the annotation helped me figure that out. We can drop this patch if

D7378: debugcommands: don't shadow the error module

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7378 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS

D7296: pycompat: kludge around pytype being confused by __new__

Herald added a subscriber: mjpieters. durin42 updated this revision to Diff 18066. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=17672=18066 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL

D7380: encoding: define per-use identity functions only in typechecking mode

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids some unfortunate overhead from my previous iteration. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7380 AFFECTED

D7379: encoding: fix bad type annotation

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This function returns utf-8 in a bytes, not a unicode. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7379 AFFECTED FILES

D7289: branchmap: always copy closednodes to a set

durin42 updated this revision to Diff 18063. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7289?vs=17659=18063 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7289/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7289 AFFECTED FILES

D7257: [RFC] repoview: add a "filter" that just disallows walking to heads

durin42 added a comment. durin42 accepted this revision as: durin42. I'm a big fan of this idea. I'd probably land it if there were some obvious usecases as child patches. :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7257/new/ REVISION DETAIL

D7375: py3: replace "%r" by"'%s'% for py3-compatible (and clearer) quoting in chg

durin42 added a comment. I feel obligated to point out that this will result in different (wrong!) quoting if `path` contains a `'`, but that's also probably fine since it's just a log. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7375/new/

D7166: packaging: ship all help .txt files on WiX

durin42 added a comment. No worries, I'm not sure what went sideways there. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7166/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7166 To: indygreg, #hg-reviewers Cc: durin42, martinvonz,

D7166: packaging: ship all help .txt files on WiX

durin42 added a comment. I re-landed this and tests passed on my workstation when I did so. Let's not drop this again without some additional coordination? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7166/new/ REVISION DETAIL

D7166: packaging: ship all help .txt files on WiX

durin42 added a comment. In D7166#108320 , @indygreg wrote: > This got dropped on committed but Phabricator is confused about its closedstate. Please re-review and land @martinvonz or @durin42. Per Martin's comment, it looks like you had

D7370: fuzz: clean out most of fuzzutil

Closed by commit rHG6f5c352f41b6: fuzz: clean out most of fuzzutil (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7370?vs=18030=18037 CHANGES SINCE LAST

D7369: fuzz: migrate xdiff fuzzer to use FuzzedDataProvider

Closed by commit rHG78df32a8b6f4: fuzz: migrate xdiff fuzzer to use FuzzedDataProvider (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7369?vs=18029=18036

D7367: dirstate: re-blacken file

Closed by commit rHGdc9c570a3818: dirstate: re-blacken file (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7367?vs=18026=18034 CHANGES SINCE LAST ACTION

D7368: fuzz: migrate bdiff fuzzer to use FuzzedDataProvider

Closed by commit rHGdbc39f028c9f: fuzz: migrate bdiff fuzzer to use FuzzedDataProvider (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7368?vs=18028=18035

D7370: fuzz: clean out most of fuzzutil

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's now a header-only setup that just selects absl:: or std:: versions of things as needed, and a logging helper. There's some room for future cleanups here:

D7369: fuzz: migrate xdiff fuzzer to use FuzzedDataProvider

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7369 AFFECTED FILES contrib/fuzz/xdiff.cc CHANGE DETAILS diff --git a/contrib/fuzz/xdiff.cc

D7368: fuzz: migrate bdiff fuzzer to use FuzzedDataProvider

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7368 AFFECTED FILES contrib/fuzz/bdiff.cc CHANGE DETAILS diff --git a/contrib/fuzz/bdiff.cc

D7116: rust-performance: introduce FastHashMap type alias for HashMap

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. It sounds like I expect this to be rebased now that other patches landed. Let me know if that's wrong? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7367: dirstate: re-blacken file

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This got overlooked in landing a recent patch, but it's easy to fix up. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7367

D7173: packaging: stage files and dynamically generate WiX installer

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. LG, but needs rebased. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7173/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7173

D7309: vagrant: update vagrant image to buster from jessie

Closed by commit rHGe182deb551b7: vagrant: update vagrant image to buster from jessie (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7309?vs=17725=17800

D7308: packaging: remove references to debian jessie

Closed by commit rHG6e99ebc0e4b4: packaging: remove references to debian jessie (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7308?vs=17724=17799 CHANGES

D7309: vagrant: update vagrant image to buster from jessie

durin42 added a comment. I believe this was around to let people run tests in a friendly Linux environment more easily? We could probably burn it now that all of {Windows,MacOS,Linux} have good docker support.. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION

D7306: cleanup: remove pointless r-prefixes on single-quoted strings

Closed by commit rHG2fe6121c630a: cleanup: remove pointless r-prefixes on single-quoted strings (authored by durin42). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7306?vs=17722=17798#toc REPOSITORY rHG

D7307: sqlitestore: remove superfluous r-prefixes on strings

Closed by commit rHG0195db644bf3: sqlitestore: remove superfluous r-prefixes on strings (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7307?vs=17723=17797

D7305: cleanup: remove pointless r-prefixes on double-quoted strings

Closed by commit rHG313e3a279828: cleanup: remove pointless r-prefixes on double-quoted strings (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7290: branchmap: pytype is confused about bytestr

Closed by commit rHG1a47fe4bc154: branchmap: pytype is confused about bytestr (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7290?vs=17660=17789 CHANGES

D7283: mail: suppress a pytype error that's just experimentally wrong

Closed by commit rHG3b31ee5388f3: mail: suppress a pytype error thats just experimentally wrong (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7275: encoding: add comment-based type hints for pytype

Closed by commit rHG2ade00f3b03b: encoding: add comment-based type hints for pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7275?vs=17674=17786

D7277: dagparser: suppress some pytype errors around pycompat.bytestring

Closed by commit rHG6d001f452bcb: dagparser: suppress some pytype errors around pycompat.bytestring (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7311: utils: move the `dirs` definition in a dedicated module (API)

durin42 added a comment. In D7311#107177 , @marmoute wrote: > In D7311#107111 , @durin42 wrote: > >> Can you fix up the fuzzer in contrib/fuzz/dirstate.cc? > > I do not understand what need

D7258: makefile: use python3 by default (BC)

durin42 added a comment. In D7258#106949 , @mharbison72 wrote: > This will break Windows by default, because py3 is still named `python.exe`. Alternately, I've been using using `PYTHON="py -3"` to invoke `make`. I'm not sure what we

D7309: vagrant: update vagrant image to buster from jessie

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I honestly have no idea if this works since I don't use vagrant, but looking around online suggests it should work fine. REPOSITORY rHG Mercurial BRANCH

D7308: packaging: remove references to debian jessie

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Jessie is on life support at this point, so let's update the list of releases in the Makefiles. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D7307: sqlitestore: remove superfluous r-prefixes on strings

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I did this file separately because it's a _ton_ of hits and it had some manual reformatting fallout as a result of black squeezing some expressions

D7305: cleanup: remove pointless r-prefixes on double-quoted strings

durin42 created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is only double-quoted strings. I'll do single-quoted strings as a second step. These had existed because our source

D7306: cleanup: remove pointless r-prefixes on single-quoted strings

durin42 created this revision. Herald added a reviewer: indygreg. Herald added subscribers: mercurial-devel, Kwan, mjpieters. Herald added a reviewer: martinvonz. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the promised second step on

D7275: encoding: add comment-based type hints for pytype

durin42 added inline comments. INLINE COMMENTS > indygreg wrote in encoding.py:24 > Am I missing something here? Won't `globals()` always return a dict with > elements? And isn't `typing` only available on Python 3? This is a moderately bonkers way to write `if False` that pyflakes won't

D7296: pycompat: kludge around pytype being confused by __new__

durin42 added a comment. I've filed a bug with the pytype team, I'll report back. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7296 To: durin42, #hg-reviewers Cc: indygreg, mercurial-devel

D7252: dirs: reject consecutive slashes in paths

Closed by commit rHGd14d245c78ed: dirs: reject consecutive slashes in paths (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7252?vs=17620=17709 CHANGES SINCE

D7294: cmdutil: suppress bogus pytype errors

Closed by commit rHG9391784299e9: cmdutil: suppress bogus pytype errors (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7294?vs=17664=17706 CHANGES SINCE LAST

D7291: bundle2: more pytype suppressions around bytestring

Closed by commit rHGea25b4673231: bundle2: more pytype suppressions around bytestring (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7291?vs=17661=17704

D7293: changegroup: suppress pytype error that's wrong

Closed by commit rHG5b5e62c24b2e: changegroup: suppress pytype error thats wrong (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7293?vs=17663=17705 CHANGES

D7292: changegroup: avoid shadowing a set with an int

Closed by commit rHGea0b44255a31: changegroup: avoid shadowing a set with an int (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7292?vs=17662=17703 CHANGES

D7272: pytype: don't warn us about ignored-on-py3 metaclasses

Closed by commit rHG70d42e2ad9b4: pytype: dont warn us about ignored-on-py3 metaclasses (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7272?vs=17642=17689

D7286: match: suppress error about subscripting an exception

Closed by commit rHG6ff196d2553b: match: suppress error about subscripting an exception (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7286?vs=17671=17700

D7288: archival: suppress some incorrect pytype failures

Closed by commit rHGd5bef33ab83c: archival: suppress some incorrect pytype failures (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7288?vs=17658=17702

D7287: simplemerge: disable a pytype error where it's just confused

Closed by commit rHG3b581ad59459: simplemerge: disable a pytype error where its just confused (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7285: vfs: more attribute suppressions

Closed by commit rHGda9ecbb10368: vfs: more attribute suppressions (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7285?vs=17670=17699 CHANGES SINCE LAST

D7284: mdiff: mark diffopts as having dynamic attributes

Closed by commit rHGf2f460cdb4f5: mdiff: mark diffopts as having dynamic attributes (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7284?vs=17654=17698

D7282: vfs: suppress some pytype errors around us using a private attribute

Closed by commit rHGfc19f8ab8199: vfs: suppress some pytype errors around us using a private attribute (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7281: wireprototypes: disable pytype where it's just confused

Closed by commit rHGf5fcf7123a92: wireprototypes: disable pytype where its just confused (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7281?vs=17651=17696

D7279: pvec: add an explicit type hint to help pytype

Closed by commit rHG8e89b6e1e0cd: pvec: add an explicit type hint to help pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7279?vs=17649=17695 CHANGES

D7280: scmposix: another suppression on IOError subscripting

Closed by commit rHG667f56d73ceb: scmposix: another suppression on IOError subscripting (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7280?vs=17650=17694

D7278: procutil: suppress pytype warnings around windows-only attributes

Closed by commit rHG54f4d094bab1: procutil: suppress pytype warnings around windows-only attributes (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7276: posix: add a pytype suppression

Closed by commit rHG147576a4e6a2: posix: add a pytype suppression (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7276?vs=17667=17692 CHANGES SINCE LAST

D7274: color: suppress pytype warning on a windows-only module

Closed by commit rHG949b4d545c90: color: suppress pytype warning on a windows-only module (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7274?vs=17644=17691

D7273: compression: tell pytype to not sweat a missing `zstd` module

Closed by commit rHG9ce76155e0da: compression: tell pytype to not sweat a missing `zstd` module (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7271: linelog: be more careful about types before looking for _target attribute

Closed by commit rHG14e374d4c9ee: linelog: be more careful about types before looking for _target attribute (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7269: hgignore: ignore generated pytype stubs

Closed by commit rHG8492c6293c31: hgignore: ignore generated pytype stubs (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7269?vs=17639=17687 CHANGES SINCE

D7268: hghave: add a check for pytype, Google's Python type checker

Closed by commit rHG32ac4d0b4102: hghave: add a check for pytype, Googles Python type checker (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7270: linelog: suppress annoying pytype warning about an ignored metaclass

Closed by commit rHGacc4047c2194: linelog: suppress annoying pytype warning about an ignored metaclass (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7267: encoding: define local identify functions with explicit type comments

Closed by commit rHG5f2a8dabb0d8: encoding: define local identify functions with explicit type comments (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7266: vfs: add NotImplementedError version of join

Closed by commit rHG8b0fa4de0064: vfs: add NotImplementedError version of join (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7266?vs=17636=17683 CHANGES

D7265: vfs: add a NotImplementedError implementation of __call__

Closed by commit rHGb16912f8c07c: vfs: add a NotImplementedError implementation of __call__ (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7265?vs=17635=17682

D7262: templateutil: fix a missing ABCMeta assignment

Closed by commit rHG3e57809d3251: templateutil: fix a missing ABCMeta assignment (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7262?vs=17632=17679 CHANGES

D7264: vfs: fix erroneous bytes constants

Closed by commit rHG2dcd4e773193: vfs: fix erroneous bytes constants (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7264?vs=17634=17681 CHANGES SINCE LAST

D7263: pvec: migrate to modern integer division

Closed by commit rHG90aac60b6697: pvec: migrate to modern integer division (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7263?vs=17633=17680 CHANGES SINCE

D7260: vfs: another bytes-str confusion on thread name

Closed by commit rHGffd632c224c3: vfs: another bytes-str confusion on thread name (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7260?vs=17630=17677 CHANGES

D7259: statprof: correctly always pass a str as the thread name

Closed by commit rHG5c9daf7df2b4: statprof: correctly always pass a str as the thread name (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7259?vs=17629=17676

D7261: pvec: fix overlooked chr() call

Closed by commit rHG271af23d01a9: pvec: fix overlooked chr() call (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7261?vs=17631=17678 CHANGES SINCE LAST

D7275: encoding: add comment-based type hints for pytype

durin42 updated this revision to Diff 17674. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7275?vs=17666=17674 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7275/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7275 AFFECTED FILES

D7297: cleanup: remove now-obsolete wrong-arg-type annotations

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The preceding commit around bytestr indirection resolved all of these. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7297 AFFECTED

D7296: pycompat: kludge around pytype being confused by __new__

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We add a function's worth of indirection to construction, but in so doing can properly annotate the factory function's types, obviating some annoying messes.

D7286: match: suppress error about subscripting an exception

durin42 updated this revision to Diff 17671. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7286?vs=17656=17671 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7286/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7286 AFFECTED FILES

D7285: vfs: more attribute suppressions

durin42 updated this revision to Diff 17670. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7285?vs=17655=17670 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7285/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7285 AFFECTED FILES

D7282: vfs: suppress some pytype errors around us using a private attribute

durin42 updated this revision to Diff 17669. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7282?vs=17652=17669 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7282/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7282 AFFECTED FILES

D7278: procutil: suppress pytype warnings around windows-only attributes

durin42 updated this revision to Diff 17668. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7278?vs=17648=17668 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7278/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7278 AFFECTED FILES

D7276: posix: add a pytype suppression

durin42 updated this revision to Diff 17667. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7276?vs=17646=17667 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7276/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7276 AFFECTED FILES

D7275: encoding: add comment-based type hints for pytype

durin42 updated this revision to Diff 17666. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7275?vs=17645=17666 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7275/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7275 AFFECTED FILES

D7294: cmdutil: suppress bogus pytype errors

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY pytype seems to handle our subclass of tuple (scmutil.status) especially poorly. We should probably file a bug. REPOSITORY rHG Mercurial REVISION DETAIL

D7295: pytype: add a (very slow) test that executes pytype

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This doesn't actually pass yet, but I wanted to share it early so others can play with pytype. REPOSITORY rHG Mercurial REVISION DETAIL

D7291: bundle2: more pytype suppressions around bytestring

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We clearly need to work around this somehow. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7291 AFFECTED FILES

D7293: changegroup: suppress pytype error that's wrong

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7293 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git a/mercurial/changegroup.py

D7292: changegroup: avoid shadowing a set with an int

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This confuses the heck out of pytype, and I basically agree with it that this shadowing is confusing. There's a chance this causes some memory to be freed

D7272: pytype: don't warn us about ignored-on-py3 metaclasses

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We can remove this when we're Python 3-only, but for now it's just too awkward to deal with and it's harmless. REPOSITORY rHG Mercurial REVISION DETAIL

D7290: branchmap: pytype is confused about bytestr

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7290 AFFECTED FILES mercurial/branchmap.py CHANGE DETAILS diff --git a/mercurial/branchmap.py

D7286: match: suppress error about subscripting an exception

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I get the sense I should file a bug about subscripting Exception subclasses. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7286

D7289: branchmap: always copy closednodes to a set

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids some typechecking problems in other places in this file. I suspect we could also avoid this by adding an explicit type annotation on the __init__

D7288: archival: suppress some incorrect pytype failures

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Again, I suspect some missing coverage in type stubs for the stdlib. I'll revisit these later. REPOSITORY rHG Mercurial REVISION DETAIL

D7287: simplemerge: disable a pytype error where it's just confused

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7287 AFFECTED FILES mercurial/simplemerge.py CHANGE DETAILS diff --git a/mercurial/simplemerge.py

D7285: vfs: more attribute suppressions

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7285 AFFECTED FILES mercurial/vfs.py CHANGE DETAILS diff --git a/mercurial/vfs.py b/mercurial/vfs.py

D7284: mdiff: mark diffopts as having dynamic attributes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This class looks like we could move it to being an attrs and life would be better, but let's do that later. REPOSITORY rHG Mercurial REVISION DETAIL

D7283: mail: suppress a pytype error that's just experimentally wrong

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's probably more correct to pass a str here, but I'm not going to worry about it for now. REPOSITORY rHG Mercurial REVISION DETAIL

D7282: vfs: suppress some pytype errors around us using a private attribute

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Looking at threading._MainThread seems like we're probably a little unsupported, but since this code appears to work on both Python 2 and 3 I'm not going to

D7281: wireprototypes: disable pytype where it's just confused

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY By inspection validnames is always a Set[bytes] here, but for some reason pytype is convinced it's a bytes. Let's disable the error for now. REPOSITORY rHG

<    1   2   3   4   5   6   7   8   9   10   >