D6776: bookmarks: validate changes on push (issue6193) (BC)

durin42 edited the summary of this revision. durin42 retitled this revision from "bookmarks: validate changes on push" to "bookmarks: validate changes on push (issue6193) (BC)". durin42 updated this revision to Diff 16515. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercu

D6776: bookmarks: validate changes on push (issue6193) (BC)

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. I've uploaded my revised version (with the more complete commit message - no other changes) in case that helps. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://p

D6776: bookmarks: validate changes on push

durin42 added a comment. I get a fair number of test failures with this, eg `test-bookmarks-corner-case.t`: --- /usr/local/google/home/augie/hgtest/tests/test-bookmarks-corner-case.t +++ /usr/local/google/home/augie/hgtest/tests/test-bookmarks-corner-case.t.err @@ -178,11 +178,

D6776: bookmarks: validate changes on push

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. Queued this with lots of content added to the commit message. Thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6776/new/ REVISION DETAIL h

D6837: cleanup: fix leakage of dirstate._map to client code

durin42 added a comment. In D6837#100331 , @mharbison72 wrote: >> 2. In lfs, where we deal with standins and mutating status. > > s/lfs/largefiles/? Good catch, fixed. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://ph

D6837: cleanup: fix leakage of dirstate._map to client code

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We already had proper accessors for most of the behavior of dirstate._map that callers cared about exposed in the actual dirstate class as public methods. Sigh.

D6839: idirstate: group private methods and attrs that are in the interface

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes it a little more obvious at a glance what work is left. Fortunately there's not a whole lot left. I suspect the ignore logic is going to be the tricky

D6836: interfaces: introduce an interface for dirstate implementations

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As usual with adding interface definitions, this describes the way things are, not the way we'd like things to be. There are some clear problems in the interface

D6838: idirstate: remove now non-public _map attribute

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6838 AFFECTED FILES mercurial/interfaces/dirstate.py CHANGE DETAILS diff --git a/mercurial/interfaces

D6808: revlog: introduce a `sidedata` method

durin42 added a comment. FWIW I'm +0.5 on this because it seems like a reasonable abstraction and could serve a variety of purposes. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6808/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6808 To: m

D6821: flagprocessors: directly duplicate the deprecated layer back into revlog

durin42 added inline comments. INLINE COMMENTS > remotefilelog.py:311 > +"""deprecated entry point to access flag processors""" > +msg = ('_processflag(...) use the specialized variant') > +util.nouideprecwarn(msg, '5.2', stacklevel=2) I'm not sure what this is telling me

D6814: revlog: add a `sidedata` parameters to addrevision

This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > marmoute wrote in remotefilelog.py:133 > because it can be iterated over as a noop. I agree with Greg: if your intent is "optional iterable of data", the tu

D6732: localrepo: push manifestlog and changelog construction code into store

Closed by commit rHG3df3b139a43d: localrepo: push manifestlog and changelog construction code into store (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6732?vs

D6754: contrib: proof of concept script to build Mac packages without system python

durin42 added a comment. This is a start, but I suspect where we should end up with this is downloading and compiling the whole Python distribution, rather than relying on a virtualenv to be portable? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D675

D6776: bookmarks: validate changes on push

durin42 added a comment. Clarifying I understand: this causes pushing a bookmark to fail in what cases that it currently succeeds? I think it's just the case of: o 2 | o 1 @ o/ 0 when I last pulled, `@` was on 0, and now I'm doing `hg push -B @`, but since my last pull th

D6825: contrib: start building a library for simple hooks

durin42 added a comment. I like where this is going, but I wonder if these specific hooks can be written without being in-process Python hooks. Reason being that Python hooks use the unstable internals of hg and are semi-discouraged if they're avoidable. Thoughts? If you do stick wi

D6732: localrepo: push manifestlog and changelog construction code into store

durin42 updated this revision to Diff 16386. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6732?vs=16226&id=16386 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6732/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6732 AFFECTED FILES

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 updated this revision to Diff 16387. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=16293&id=16387 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734 AFFECTED FILES

D6732: localrepo: push manifestlog and changelog construction code into store

durin42 added a comment. Ping on this - can we get this landed to unblock my experimentation? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6732/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6732 To: durin42, #hg-reviewers, indygreg Cc: indy

D6522: tracing: add many more timedcm() calls throughout the codebase

durin42 updated this revision to Diff 16300. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6522?vs=16102&id=16300 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6522/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6522 AFFECTED FILES

D6527: dirstate: add counter events for work queue depth

durin42 updated this revision to Diff 16301. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6527?vs=15563&id=16301 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6527/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6527 AFFECTED FILES

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16293. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=16228&id=16293 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https:/

D6732: localrepo: push manifestlog and changelog construction code into store

durin42 added a comment. I think pushing it down into the store makes a reasonable amount of sense, since it's going to be pretty heavily tied to the revision storage mechanism... REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6732/new/ REVISION DETAI

D6747: hgit: fix some pyflakes and check-code warning

durin42 added a comment. Folded this and D6748 back into 6734, many thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6747/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6747 To: pulkit, #hg-reviewe

D6741: interfaces: create a new folder for interfaces and move repository.py in it

durin42 added a comment. In D6741#99023 , @pulkit wrote: > In D6741#98947 , @martinvonz wrote: > >>> I was trying to understand current interfaces and write new ones and I realized >>> we need t

D6733: setup: fix a sorting issue I noticed in package names

Closed by commit rHGf299555785c5: setup: fix a sorting issue I noticed in package names (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6733?vs=16227&id=16256

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is _extremely_ rough, but I feel like it's a worthwhile proof of concept to help us push interfaces in the direction required to just make this wo

D6732: localrepo: push manifestlog and changelog construction code into store

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This feels substantially more appropriate, as the store is actually the layer with knowledge of how to handle this storage. I didn't move the caching decorators

D6733: setup: fix a sorting issue I noticed in package names

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6733 AFFECTED FILES setup.py CHANGE DETAILS diff --git a/setup.py b/setup.py --- a/setup.py +++ b/set

D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1)

Closed by commit rHG55f59a25c593: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1) (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6729 AFFECTED FILES tests/test-merge-combination.t CHANGE DETAILS diff --git a/tests/test-merge-combi

D6709: config: add --registered flag to show all known configs

durin42 added a comment. durin42 accepted this revision as: durin42. Looks good to me, but I want someone else to put eyes on it before it gets pushed. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-s

D6725: tests: split joint repo/changelog fake into one for each type

Closed by commit rHG034b2bf377f0: tests: split joint repo/changelog fake into one for each type (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6725?vs=16182&id

D6479: shelve: first prototype of storing/restoring unresolved changes

durin42 added a comment. The only thing I'm curious about really is why we have extrastorage and usualstorge. Can we get away with only one of those choices instead of having more options? INLINE COMMENTS > shelve.py:432 > + > +def _storeunresolvedmerge(ui, repo, name=None, extra=None): > +

D6725: tests: split joint repo/changelog fake into one for each type

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm just not comfortable with fakes that get overloaded for multiple types: too often it gets out of hand and becomes difficult to trace. REPOSITORY rHG Mercuri

D6430: rust-discovery: using from Python code

durin42 added a comment. I'm not thrilled with this - it's a lot of code, and I think there are some simpler options that haven't been explored. For example, clients could use the logexchange infrastructure to prime the sampling process and do a lot better. That said, it seems "fine" and

D6517: rust-discovery: read the index from a repo passed at init

durin42 added inline comments. INLINE COMMENTS > test-rust-discovery.py:34 > > +class fakerepo(object): > +def __init__(self, idx): I'd rather we not have this one object that mocks both a repo and a changelog - it _will_ become confusing in the future. Make it two objects. REPOSITORY

D6718: repository: suppress typing errors on functions without arguments

durin42 added a comment. durin42 accepted this revision as: durin42. Seems fine, but probably file a bug against mypy on this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6718/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6718 To: indygreg

D6717: mypy: add a mypy.ini config file

durin42 added a comment. Did you run tests on this patch? IIRC there's a test that'll fail ;) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6717/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6717 To: indygreg, #hg-reviewers Cc: durin42, pulk

D6712: config: fix defaultvalue template keyword

durin42 added a comment. durin42 resigned from this revision. I agree with marmoute on all points. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6712/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6712 To: navaneeth.suresh, #hg-reviewers Cc:

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

durin42 added a comment. Queued with updated log message. Thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6440/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6440 To: hooper, #hg-reviewers Cc: martinvonz, durin42, mercurial-devel __

D6704: config: add defaultvalue template keyword

durin42 added a comment. I like the feature, I'll go ahead and queue it with the str/bytestr thing fixed in flight. Thanks! INLINE COMMENTS > commands.py:1875 > value = pycompat.bytestr(value) > +defaultvalue = str(ui.configdefault(section, name)) > if fm.isplain():

D6522: tracing: add many more timedcm() calls throughout the codebase

durin42 updated this revision to Diff 16102. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6522?vs=15601&id=16102 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6522/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6522 AFFECTED FILES

D6659: graft: split graft code into seperate functions

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. I agree with Martin's request for changes here. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6659/new/ REVISION DETAIL https://phab.

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. needs rebased REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6694/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6694 To: navan

D6681: debugcommands: add support for extensions adding their own debug info

Closed by commit rHG0c0478b71595: debugcommands: add support for extensions adding their own debug info (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6681?vs=

D6682: fsmonitor: add support for extra `hg debuginstall` data

Closed by commit rHG3358dc6e7c04: fsmonitor: add support for extra `hg debuginstall` data (authored by durin42). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6682?vs=16024&id=16035#toc REPOSITORY rHG Mercuri

D6680: fsmonitor: refactor watchmanclient.client to accept ui and repo path

Closed by commit rHGf3c594ddecb7: fsmonitor: refactor watchmanclient.client to accept ui and repo path (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6680?vs=1

D6681: debugcommands: add support for extensions adding their own debug info

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've had a couple of cases where it'd be handy at Google to add data to `hg debuginstall`'s output. We've kludged around that at various times, but it seems rea

D6682: fsmonitor: add support for extra `hg debuginstall` data

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This might make some things easier to debug, and for default bug report templates it'll help collect more data from users all at once. I don't actually

D6680: fsmonitor: refactor watchmanclient.client to accept ui and repo path

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will make my next patch simpler. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6680 AFFECTED FILES hgext/fsmonitor

D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines

Closed by commit rHGeb27d9eee2cc: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6658?vs

D6656: py3: another passing test

Closed by commit rHG513a97303bbc: py3: another passing test (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6656?vs=15970&id=15976 CHANGES SINCE LAST ACTION

D6657: cleanup: remove redundant import

Closed by commit rHG3acb3660a626: cleanup: remove redundant import (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6657?vs=15971&id=15975 CHANGES SINCE LAST AC

D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not clear why this behaves very slightly differently on Python 3, but I'm also not concerned about it. REPOSITORY rHG Mercurial REVISION DETAIL

D6657: cleanup: remove redundant import

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For some reason the import checker only caught this on py3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6657 AFFECTED FILES tes

D6656: py3: another passing test

durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6656 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

durin42 added a comment. I still think we should fix the cwd for fixers, but it seems Martin and I agree that repo-root is more consistent. Would you be willing to reroll with repo-root instead of cwd? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D64

D6655: continue: added support for graft

durin42 added a comment. I'm landing this, but in the future I suspect we should make sure we just have a mix of `hg graft --continue` and `hg graft` rather than run the whole test twice, as it'll severely bloat the already-slow testsuite to do that for many tests. REPOSITORY rHG Mercuria

D6612: tests: show the files fields of changelogs for many merges

durin42 added a comment. durin42 accepted this revision as: durin42. (Martin, this looks fine to me, if you've got no objections let's include it in 5.1) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6612/new/ REVISION DETAIL https://phab.mercurial

D6612: tests: show the files fields of changelogs for many merges

durin42 added a comment. durin42 added subscribers: martinvonz, durin42. I know @martinvonz has been looking at files in changelogs recently. Do you have an opinion on this? It looks fine to me. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6612/new/

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

durin42 added a comment. In D6597#97228 , @Alphare wrote: > In D6597#97177 , @durin42 wrote: > >> LGTM, but needs rebased (sorry for slow response) > > @durin42 I've rebased it on hg-committed,

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

durin42 added a comment. LGTM, but needs rebased (sorry for slow response) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6597/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6597 To: Alphare, #hg-reviewers, kevincox Cc: pulkit, durin42, kevinc

D6611: blackbox: disable extremely verbose logging (issue6110)

durin42 added inline comments. INLINE COMMENTS > blackbox.py:97 > self._trackedevents = set(ui.configlist('blackbox', 'track')) > +self._untrackedevents = {'chgserver', 'cmdserver', 'extension'} > self._maxfiles = ui.configint('blackbox', 'maxfiles') Let's make this con

D6573: prompt: add develwarn about last line of prompt >45 chars (issue6158)

durin42 added a comment. Per your note that this will probably make other localizations sad, let's just give up on this for now? Sigh. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6573/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6573

D6625: rust-cargo: reorder dependencies

durin42 added a comment. Why? Before it was sorted, and now it's not. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6625/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6625 To: Alphare, #hg-reviewers Cc: durin42, mercurial-devel _

D6616: extdata: avoid crashing inside subprocess when we get a revset parse error

Closed by commit rHGea6558db1011: extdata: avoid crashing inside subprocess when we get a revset parse error (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D661

D6615: extdata: demonstrate bad behavior when a subprocess emits garbage

Closed by commit rHGeec65b706caf: extdata: demonstrate bad behavior when a subprocess emits garbage (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6615?vs=1579

D6556: cleanup: use named constants for second arg to .seek()

Closed by commit rHG4eaf7197a740: cleanup: use named constants for second arg to .seek() (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6556?vs=15798&id=15816

D6616: extdata: avoid crashing inside subprocess when we get a revset parse error

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6616 AFFECTED FILES mercurial/scmutil.py tests/test-extdata.t CHANGE DETAILS diff --git a

D6615: extdata: demonstrate bad behavior when a subprocess emits garbage

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6615 AFFECTED FILES tests/test-extdata.t CHANGE DETAILS diff --git a/tests/test-extdata.t b

D6556: cleanup: use named constants for second arg to .seek()

durin42 updated this revision to Diff 15798. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6556?vs=15797&id=15798 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6556/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6556 AFFECTED FILES

D6556: cleanup: use named constants for second arg to .seek()

durin42 updated this revision to Diff 15797. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6556?vs=15619&id=15797 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6556/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6556 AFFECTED FILES

D6562: filemerge: make last line of prompts <40 english chars (issue6158)

durin42 added a comment. In D6562#95823 , @spectral wrote: > In D6562#95775 , @durin42 wrote: > >> I like this, but could I get you to add a patch 3 that introduces a develwarn for this? > > Do

D6562: filemerge: make last line of prompts <40 english chars (issue6158)

durin42 added a comment. I like this, but could I get you to add a patch 3 that introduces a develwarn for this? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6562/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6562 To: spectral, #hg-reviewe

D6554: cleanup: always `seek(0, io.SEEK_END)` after open in append mode before tell()

durin42 added a comment. Note that I mailed a version to the list for stable. This doesn't quite cleanly apply there, so I made the change twice so I could write the next change without waiting for a merge. REP

D6556: cleanup: use named constants for second arg to .seek()

durin42 created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6556 AFFECTED FILES hgext/fastannotate/revmap.py mercurial/revlog.

D6554: cleanup: always `seek(0, io.SEEK_END)` after open in append mode before tell()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Consider the program: #include int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("n

D6555: vfs: require use of .seek() or .write() before .tell() on append-mode files

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This prevents the bug in the previous change, but avoids an extraneous seek() call in the common case when it's not required. My preference was to ban .seek() an

D6550: tracing: add a couple of trace points on obsolete and repoview

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I was seeing weird stalls in some fast commands, and these trace events help explain them. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-sc

D6522: tracing: add many more timedcm() calls throughout the codebase

durin42 updated this revision to Diff 15601. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6522?vs=15562&id=15601 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6522/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6522 AFFECTED FILES

D6549: localrepo: split lookup of context from status call

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In my clone of hg, this call of repo.__getitem__ is taking 59ms. That's longer than walking the directory takes! REPOSITORY rHG Mercurial REVISION DETAIL htt

D6539: remotefilelog: tell runbgcommand to not block on child process startup

Closed by commit rHGdf1419c5756a: remotefilelog: tell runbgcommand to not block on child process startup (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6539?vs

D6537: procutil: allow callers of runbgcommand to assume the process starts

Closed by commit rHGca1014ad3de4: procutil: allow callers of runbgcommand to assume the process starts (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6537?vs=1

D6538: shallowrepo: remove backwards compat code that predates in-tree remotefilelog

Closed by commit rHG373aeede7352: shallowrepo: remove backwards compat code that predates in-tree remotefilelog (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D6537: procutil: allow callers of runbgcommand to assume the process starts

durin42 updated this revision to Diff 15575. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6537?vs=15572&id=15575 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6537/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6537 AFFECTED FILES

D6539: remotefilelog: tell runbgcommand to not block on child process startup

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These two invocations will always find a binary because they're re-running hg. As a result, we can skip waiting for the subprocess to start running and save a li

D6538: shallowrepo: remove backwards compat code that predates in-tree remotefilelog

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6538 AFFECTED FILES hgext/remotefilelog/shallowrepo.py CHANGE DETAILS diff --git a/hgext/remotefilelo

D6537: procutil: allow callers of runbgcommand to assume the process starts

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Experimentally starting the subprocess can take as much as 40ms, and for some of our use cases that's frivolous: we know the binary will start, and if it doesn't

D6522: tracing: add many more timedcm() calls throughout the codebase

durin42 updated this revision to Diff 15562. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6522?vs=15474&id=15562 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6522/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6522 AFFECTED FILES

D6527: dirstate: add counter events for work queue depth

durin42 updated this revision to Diff 15563. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6527?vs=15479&id=15563 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6527/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6527 AFFECTED FILES

D6526: tracing: add support for emitting counters

Closed by commit rHGe658ac39fe41: tracing: add support for emitting counters (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6526?vs=15478&id=15526 CHANGES SIN

D6525: tracing: extract tracing-active logic to separate function

Closed by commit rHGd0b8a3cfd732: tracing: extract tracing-active logic to separate function (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6525?vs=15477&id=15

D6524: catapipe: add support for COUNTER events

Closed by commit rHGff562d711919: catapipe: add support for COUNTER events (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6524?vs=15476&id=15524 CHANGES SINCE

D6523: demandimport: add tracing coverage for Python 3

Closed by commit rHGadb636392b3f: demandimport: add tracing coverage for Python 3 (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6523?vs=15475&id=15523 CHANGE

D6527: dirstate: add counter events for work queue depth

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6527 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git a/mercurial/dirstate.py b/mercuri

D6526: tracing: add support for emitting counters

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6526 AFFECTED FILES hgdemandimport/tracing.py CHANGE DETAILS diff --git a/hgdemandimport/tracing.py b

D6525: tracing: extract tracing-active logic to separate function

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm about to add support for counters, and want to avoid duplicating this logic. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D652

D6524: catapipe: add support for COUNTER events

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6524 AFFECTED FILES contrib/catapipe.py CHANGE DETAILS diff --git a/contrib/catapipe.py b/contrib/cat

D6522: tracing: add many more timedcm() calls throughout the codebase

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I've been trying to understand where time goes in `hg status` and this helped me get a sense of things. I'm happy to try and split this up if it's too

<    4   5   6   7   8   9   10   11   12   13   >