D7558: fuzz: fix an unused result on getcwd() in pyutil

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY clang was rightly complaining about this, so let's just fix it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7558 AFFECTED FILES

D7559: fuzz: remove debug prints from revlog_corpus.py

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7559 AFFECTED FILES contrib/fuzz/revlog_corpus.py CHANGE DETAILS diff --git

D7557: annotate: describe --skip as taking a revset

durin42 added a comment. It said `revision` before, so at a minimum we should add an `s`... (I don't know if we imply revset when we say revisions.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7557/new/ REVISION DETAIL

D7557: annotate: describe --skip as taking a revset

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's obvious to me, but probably wouldn't be obvious to a novice user. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7557

D7295: pytype: add a (very slow) test that executes pytype

durin42 added a comment. In D7295#110254 , @mharbison72 wrote: > In D7295#107482 , @indygreg wrote: > >> Since type checking is slow (but there are state files we can reuse to speed things

D7509: windows: further build fixes for the WiX installer

Closed by commit rHGe8373b215a67: windows: further build fixes for the WiX installer (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7509: windows: further build fixes for the WiX installer

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With these fixes in place, the .msi actually builds for me again. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7509 AFFECTED

D7472: cleanup: update references to /help/ that should now be /helptext/

Closed by commit rHG640bae94f2f3: cleanup: update references to /help/ that should now be /helptext/ (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7472: cleanup: update references to /help/ that should now be /helptext/

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I noticed this only because the WiX build was broken after 2e017696181f . I haven't

D7296: pycompat: kludge around pytype being confused by __new__

durin42 added a comment. In D7296#109672 , @dlax wrote: > Sorry, still not ok afaict :/ So, I tried fixing this and it actually made things worse? dagparser.py no longer typechecks if I correct the syntax? Try the pytype invocation from

D7296: pycompat: kludge around pytype being confused by __new__

durin42 updated this revision to Diff 18243. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18240=18243 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7296 AFFECTED FILES

D7295: pytype: add a (very slow) test that executes pytype

durin42 updated this revision to Diff 18242. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7295?vs=18104=18242 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7295/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7295 AFFECTED FILES

D7297: cleanup: remove now-obsolete wrong-arg-type annotations

durin42 updated this revision to Diff 18241. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7297?vs=18079=18241 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7297/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7297 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

durin42 edited the summary of this revision. durin42 updated this revision to Diff 18240. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18170=18240 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL

D7252: dirs: reject consecutive slashes in paths

durin42 added a comment. In D7252#109656 , @durin42 wrote: > In D7252#109627 , @Alphare wrote: > >> Sorry to necropost, but since this broke the Rust implementation, I was wondering what the

D7252: dirs: reject consecutive slashes in paths

durin42 added a comment. In D7252#109627 , @Alphare wrote: > Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this

D7407: debugcommands: add assertions to convince pytype peer is not None

Closed by commit rHG23ad4f0c1578: debugcommands: add assertions to convince pytype peer is not None (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7385: debugcommands: suppress import errors for pytype

Closed by commit rHGa9b14ef701d1: debugcommands: suppress import errors for pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7385?vs=18157=18226 CHANGES

D7410: extensions: suppress a pytype failure due to a typeshed bug

Closed by commit rHGda5ccc591cff: extensions: suppress a pytype failure due to a typeshed bug (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7409: dispatch: add some assertions to give pytype a helping hand

Closed by commit rHGac8fd215a776: dispatch: add some assertions to give pytype a helping hand (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7381: cmdutil: add a pytype annotation to help out some callsites

Closed by commit rHGa58d2361b231: cmdutil: add a pytype annotation to help out some callsites (authored by durin42). durin42 marked an inline comment as done. This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7408: extensions: hide two confusing import statements from pytype

Closed by commit rHG1ea33dff7841: extensions: hide two confusing import statements from pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7383: state: add a pytype annotation

Closed by commit rHG127d46468a45: state: add a pytype annotation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7383?vs=18070=18225 CHANGES SINCE LAST ACTION

D7382: logcmdutil: add a type annotation

Closed by commit rHGc9301ac73b95: logcmdutil: add a type annotation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7382?vs=18098=18224 CHANGES SINCE LAST

D7384: commands: necessary annotations and suppresssions to pass pytype

durin42 updated this revision to Diff 18171. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7384?vs=18162=18171 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

durin42 updated this revision to Diff 18170. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18163=18170 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7296 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

durin42 updated this revision to Diff 18163. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18161=18163 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7296 AFFECTED FILES

D7384: commands: necessary annotations and suppresssions to pass pytype

durin42 updated this revision to Diff 18162. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7384?vs=18099=18162 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

durin42 edited the summary of this revision. durin42 updated this revision to Diff 18161. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18066=18161 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL

D7406: scmutil: convert status data object from a tuple to an attrs (API)

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in scmutil.py:81-88 > What depends on this? It looked like many of the patches earlier in the > series tried to get rid of iteration. I started out trying to get rid of the iterator interface on this, and gave up because it's

D7384: commands: necessary annotations and suppresssions to pass pytype

durin42 added a comment. I still want to keep the annotations I added. :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 To: durin42, #hg-reviewers, dlax Cc: dlax, mercurial-devel

D7407: debugcommands: add assertions to convince pytype peer is not None

durin42 updated this revision to Diff 18158. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7407?vs=18100=18158 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7407/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7407 AFFECTED FILES

D7385: debugcommands: suppress import errors for pytype

durin42 updated this revision to Diff 18157. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7385?vs=18073=18157 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7385/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7385 AFFECTED FILES

D7410: extensions: suppress a pytype failure due to a typeshed bug

durin42 edited the summary of this revision. durin42 retitled this revision from "extensions: suppress a strange pytype failure" to "extensions: suppress a pytype failure due to a typeshed bug". durin42 updated this revision to Diff 18159. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7408: extensions: hide two confusing import statements from pytype

durin42 added a comment. In D7408#109174 , @dlax wrote: > Out of curiosity, where does this `__index__` value come from? Beats me. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7408/new/ REVISION

D7424: [RFC] pyoxidizer

durin42 added a comment. durin42 added a subscriber: mharbison72. also fyi @mharbison72 since it looks like the @ in the commit message didn't work? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7424/new/ REVISION DETAIL

D7424: [RFC] pyoxidizer

durin42 added a comment. durin42 added a subscriber: martinvonz. FYI @martinvonz REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7424/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7424 To: indygreg, #hg-reviewers Cc: martinvonz, durin42,

D7411: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies

Closed by commit rHG0796e266d26b: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies (authored by durin42). durin42 marked an inline comment as done. This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7405: perf: bool() elements of dirstate.status return instead of len()

Closed by commit rHG6186c2a53ea5: perf: bool() elements of dirstate.status return instead of len() (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7406: scmutil: convert status data object from a tuple to an attrs (API)

Closed by commit rHGc5548b0b6847: scmutil: convert status data object from a tuple to an attrs (API) (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7403: subrepo: use field names instead of field numbers on scmutil.status

Closed by commit rHGaeed2f106213: subrepo: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7404: tags: use field names instead of field numbers on scmutil.status

Closed by commit rHGba5c39b9324c: tags: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7402: revset: use field names instead of field numbers on scmutil.status

Closed by commit rHGd212d657ba0e: revset: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7401: patch: use field names instead of field numbers on scmutil.status

Closed by commit rHGd649de29f1ff: patch: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7398: commands: use field names instead of field numbers on scmutil.status

Closed by commit rHG1e1bad31b427: commands: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7399: context: use field names instead of field numbers on scmutil.status

Closed by commit rHGe035a8f71d52: context: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7400: logcmdutil: use field names instead of field numbers on scmutil.status

Closed by commit rHG4093fc1777c2: logcmdutil: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7397: cmdutil: convert terse status result back to an scmutil.status

Closed by commit rHG9cb7f855e2fc: cmdutil: convert terse status result back to an scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7396: cmdutil: use field names instead of field numbers on scmutil.status

Closed by commit rHGe01e0641f18a: cmdutil: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7392: mq: use field names instead of field numbers on scmutil.status

Closed by commit rHG2d5b991c2192: mq: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7395: uncommit: use field names instead of field numbers on scmutil.status

Closed by commit rHGd0310f21ee9e: uncommit: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7394: transplant: use field names instead of field numbers on scmutil.status

Closed by commit rHG96edd0c38740: transplant: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7378: debugcommands: don't shadow the error module

Closed by commit rHG72b454fae92e: debugcommands: dont shadow the error module (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7378?vs=18062=18115 CHANGES

D7393: split: use field names instead of field numbers on scmutil.status

Closed by commit rHG705738def50c: split: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7391: hgk: use field names instead of field numbers on scmutil.status

Closed by commit rHG52a73fb498a4: hgk: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7390: extdiff: use field names instead of field numbers on scmutil.status

Closed by commit rHG7415cd486696: extdiff: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7379: encoding: fix bad type annotation

Closed by commit rHG7edc07fb890c: encoding: fix bad type annotation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7379?vs=18064=18117 CHANGES SINCE LAST

D7389: branchmap: annotate constructor type for branchcache

Closed by commit rHG9c1eccdd7ed8: branchmap: annotate constructor type for branchcache (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7389?vs=18078=18116

D7289: branchmap: correctly set()-ify list argument

Closed by commit rHG43f57b9620d2: branchmap: correctly set()-ify list argument (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7289?vs=18077=18114 CHANGES

D7411: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies

durin42 added inline comments. durin42 marked an inline comment as done. INLINE COMMENTS > indygreg wrote in dirs.c:66 > What code calls this function? Do we have any good perf numbers for > introducing this loop? > > I ask because the diffing code is surprisingly impacted by the the "find >

D7411: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies

durin42 edited the summary of this revision. durin42 updated this revision to Diff 18112. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7411?vs=18106=18112 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7411/new/ REVISION

D7411: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems like 2048 directories ought to be enough for any reasonable use of Mercurial? .. bc: Mercurial will now defend against OOMs by refusing to

D7377: commands: log --line-range is incompatible with --copies

durin42 added a comment. durin42 abandoned this revision. @dlax seems to have fixed the underlying issue here. :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7377/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7377 To: durin42,

D7385: debugcommands: suppress import errors for pytype

durin42 added a comment. In D7385#108592 , @dlax wrote: > I wonder if using `importlib.import_module()` wouldn't help. Or is it something we avoid in Mercurial? We use it in other places. I have no idea the extent to which it'd help.

D7384: commands: necessary annotations and suppresssions to pass pytype

durin42 added inline comments. INLINE COMMENTS > dlax wrote in commands.py:1127 > This one is sad. I think this can be sorted out by replacing the > `try:/finally:` with a context manager. (Can send a patch, if it sounds good > to you.) By all means! REPOSITORY rHG Mercurial CHANGES SINCE

D7381: cmdutil: add a pytype annotation to help out some callsites

durin42 added inline comments. durin42 marked an inline comment as done. INLINE COMMENTS > dlax wrote in cmdutil.py:3970 > Wouldn't `-> Dict[bytes, List[bytes]]` be okay? (Not sure why "Any" you're > referering to in commit message, though I understand `Dict[bytes, Any]` comes > from

D7406: scmutil: convert status data object from a tuple to an attrs (API)

durin42 updated this revision to Diff 18105. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7406?vs=18096=18105 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7406/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7406 AFFECTED FILES

D7384: commands: necessary annotations and suppresssions to pass pytype

durin42 updated this revision to Diff 18099. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7384?vs=18071=18099 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 AFFECTED FILES

D7407: debugcommands: add assertions to convince pytype peer is not None

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This function is moderately annoyingly defined, and peer is set up iff we're not in raw-proto mode. That's fine, but it confuses pytype. Adding these assertions

D7295: pytype: add a (very slow) test that executes pytype

durin42 updated this revision to Diff 18104. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7295?vs=18072=18104 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7295/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7295 AFFECTED FILES

D7410: extensions: suppress a strange pytype failure

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I suspect a bug in pytype here, but I'll follow up with that later. We have good enough coverage on this that I'm happy to move on for now. REPOSITORY rHG

D7409: dispatch: add some assertions to give pytype a helping hand

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7409 AFFECTED FILES mercurial/dispatch.py CHANGE DETAILS diff --git a/mercurial/dispatch.py

D7381: cmdutil: add a pytype annotation to help out some callsites

durin42 updated this revision to Diff 18097. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7381?vs=18068=18097 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7381/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7381 AFFECTED FILES

D7408: extensions: hide two confusing import statements from pytype

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7408 AFFECTED FILES mercurial/extensions.py CHANGE DETAILS diff --git a/mercurial/extensions.py

D7405: perf: bool() elements of dirstate.status return instead of len()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm about to make scmutil.status no longer have a len(), so we need to do something else to "use" the results in this perf method. REPOSITORY rHG Mercurial

D7406: scmutil: convert status data object from a tuple to an attrs (API)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've been pushing towards the property names for a while, and the subclassing of the tuple confuses pytype. Rather than bend over backwards to try and annotate

D7382: logcmdutil: add a type annotation

durin42 updated this revision to Diff 18098. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7382?vs=18069=18098 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7382/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7382 AFFECTED FILES

D7404: tags: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7398: commands: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7402: revset: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7403: subrepo: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7401: patch: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7399: context: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7400: logcmdutil: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7397: cmdutil: convert terse status result back to an scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is also part of detupling scmutil.status. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7397 AFFECTED FILES

D7396: cmdutil: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7392: mq: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7297: cleanup: remove now-obsolete wrong-arg-type annotations

durin42 updated this revision to Diff 18079. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7297?vs=18067=18079 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7297/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7297 AFFECTED FILES

D7394: transplant: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7395: uncommit: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7393: split: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7391: hgk: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7390: extdiff: use field names instead of field numbers on scmutil.status

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION

D7389: branchmap: annotate constructor type for branchcache

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This type signature is...big. But it's correct as far as I can tell, and it detected a bug. REPOSITORY rHG Mercurial REVISION DETAIL

D7289: branchmap: correctly set()-ify list argument

durin42 edited the summary of this revision. durin42 retitled this revision from "branchmap: always copy closednodes to a set" to "branchmap: correctly set()-ify list argument". durin42 updated this revision to Diff 18077. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7380: encoding: define per-use identity functions only in typechecking mode

durin42 added a comment. Let's not land this for now: it's breaking a fair amount of typechecking. :( REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7380/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7380 To: durin42, #hg-reviewers Cc:

D7384: commands: necessary annotations and suppresssions to pass pytype

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As with other places, there are some places where our types are just too complicated for pytype, so we put some suppressions in place. REPOSITORY rHG Mercurial

D7385: debugcommands: suppress import errors for pytype

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7385 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

D7295: pytype: add a (very slow) test that executes pytype

durin42 updated this revision to Diff 18072. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7295?vs=17665=18072 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7295/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7295 AFFECTED FILES

D7381: cmdutil: add a pytype annotation to help out some callsites

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think we could constrain the values here more than Any, but this lets us move forward with typechecking commands.py. REPOSITORY rHG Mercurial REVISION

<    1   2   3   4   5   6   7   8   9   10   >