D6993: black: add a pyproject.toml that contains our black settings

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6993 AFFECTED FILES pyproject.toml tests/test-check-code.t CHANGE DETAILS diff --git

D6987: strip: move strip extension to core

durin42 added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in commands.py:5646 > i see. do i need to replace `strip` by `debugstrip` on every occurrence in > tests? otherwise, i would have to revert the changes in the tests and keep > the extension as it is. One or two is fine,

D6987: strip: move strip extension to core

This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > commands.py:5646 > > +@command("strip", > +[ debugstrip please (and put it in debugcommands) and Gregory points out we need a strip extension that

D6985: statprof: drop python #! and exec bit we don't use

Closed by commit rHG9a3be115fb78: statprof: drop python #! and exec bit we dont use (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6985?vs=16841=16847

D6984: cvsps: switch a file open to a with statement

Closed by commit rHG3b8a4587a456: cvsps: switch a file open to a with statement (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6984?vs=16840=16846 CHANGES

D6972: formatting: byteify all mercurial/ and hgext/ string literals

durin42 updated this revision to Diff 16845. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6972?vs=16843=16845 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6972/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6972 AFFECTED FILES

D6971: formatting: blacken the codebase

durin42 updated this revision to Diff 16844. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6971?vs=16842=16844 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6971 AFFECTED FILES

D6971: formatting: blacken the codebase

durin42 added inline comments. INLINE COMMENTS > indygreg wrote in __init__.py:1 > This is 3rd party code and shouldn't be formatted. I'm not sold, honestly: we've already substantially diverged from upstream on this, so I think we should just act like we own it for now. REPOSITORY rHG

D6971: formatting: blacken the codebase

durin42 added a comment. Now down to these failures: + doc/check-seclevel.py:50: + > ui.note('checking "%s"\n' % name) + missing _() in ui message (use () to hide false-positives) + doc/check-seclevel.py:73: + > ui.warn('gap of section level at

D6972: formatting: byteify all mercurial/ and hgext/ string literals

durin42 updated this revision to Diff 16843. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6972?vs=16832=16843 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6972/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6972 AFFECTED FILES

D6971: formatting: blacken the codebase

durin42 updated this revision to Diff 16842. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6971?vs=16831=16842 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6971 AFFECTED FILES

D6985: statprof: drop python #! and exec bit we don't use

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For some reason this wasn't flagged until I ran a reformatter on this file. I'm deeply confused by this, but since we don't execute this drop the support for

D6984: cvsps: switch a file open to a with statement

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For some reason this only showed up in check-code after running black. Puzzling. REPOSITORY rHG Mercurial REVISION DETAIL

D6971: formatting: blacken the codebase

durin42 added a comment. Current test failures: --- /usr/local/google/home/augie/hgtest/tests/test-check-code.t +++ /usr/local/google/home/augie/hgtest/tests/test-check-code.t.err @@ -27,9 +27,40 @@ Skipping contrib/packaging/hgpackaging/wix.py it has no-che?k-code (glob)

D6974: examples: include a sample of how to use black with fix

durin42 updated this revision to Diff 16834. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6974?vs=16821=16834 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6974/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6974 AFFECTED FILES

D6973: mangler: stop rewriting string constants to be bytes literals

durin42 updated this revision to Diff 16833. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6973?vs=16820=16833 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6973/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6973 AFFECTED FILES

D6972: formatting: byteify all mercurial/ and hgext/ string literals

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16832. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6972?vs=16819=16832 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6972/new/ REVISION DETAIL

D6971: formatting: blacken the codebase

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16831. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6971?vs=16830=16831 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL

D6971: formatting: blacken the codebase

durin42 added a comment. durin42 planned changes to this revision. This still causes check-code problems, but it's getting close. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6971 To:

D6971: formatting: blacken the codebase

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16830. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6971?vs=16818=16830 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL

D6342: style: run a patched black on a subset of mercurial

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16829. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6342?vs=16812=16829 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6342/new/ REVISION DETAIL

D6979: contrib: stop whining about whitespace around =

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was conflicting with black, so dump it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6979 AFFECTED FILES

D6978: contrib: black manages whitespace after Python keywords now

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6978 AFFECTED FILES contrib/check-code.py CHANGE DETAILS diff --git a/contrib/check-code.py

D6977: contrib: allow trailing commas in lists

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY black manages this for us, so we don't need to worry about this anymore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6977

D6976: contrib: remove check-code line length limit

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Both Python and C code are managed by formatters now, so relax this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6976 AFFECTED

D6970: transaction: re-wrap line to avoid a black bug

Closed by commit rHGa614f26d4897: transaction: re-wrap line to avoid a black bug (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6970?vs=16817=16823 CHANGES

D6969: discovery: re-wrap expression to avoid a black bug

Closed by commit rHG6e8582ccf76d: discovery: re-wrap expression to avoid a black bug (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6969?vs=16816=16822

D6974: examples: include a sample of how to use black with fix

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's commented out for now since my patch hasn't landed, but we can uncomment it when that lands. REPOSITORY rHG Mercurial REVISION DETAIL

D6973: mangler: stop rewriting string constants to be bytes literals

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've rewritten everything, so we no longer require this step. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6973 AFFECTED FILES

D6972: formatting: byteify all mercurial/ and hgext/ string literals

durin42 created this revision. Herald added a reviewer: indygreg. Herald added subscribers: mercurial-devel, Kwan, mjpieters. Herald added a reviewer: martinvonz. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Done with python3

D6971: formatting: blacken the codebase

durin42 created this revision. Herald added a reviewer: indygreg. Herald added subscribers: mercurial-devel, Kwan, mjpieters. Herald added a reviewer: martinvonz. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is using my patch to black

D6970: transaction: re-wrap line to avoid a black bug

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6970 AFFECTED FILES mercurial/transaction.py CHANGE DETAILS diff --git a/mercurial/transaction.py

D6969: discovery: re-wrap expression to avoid a black bug

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6969 AFFECTED FILES mercurial/discovery.py CHANGE DETAILS diff --git a/mercurial/discovery.py

D6342: style: run a patched black on a subset of mercurial

durin42 updated this revision to Diff 16812. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6342?vs=15040=16812 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6342/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6342 AFFECTED FILES

D6959: setup: switch to having setup.py generate an hg script

durin42 added a comment. durin42 planned changes to this revision. This currently breaks a bunch of stuff, I think because the installed hg isn't on $PATH? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6959/new/ REVISION DETAIL

D6959: setup: switch to having setup.py generate an hg script

durin42 updated this revision to Diff 16797. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6959?vs=16795=16797 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6959/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6959 AFFECTED FILES

D6959: setup: switch to having setup.py generate an hg script

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This gives us a more-standard entry_points setup and lets us skip the step of generating the interpreter shebang etc, easing some Python 3 work. REPOSITORY

D6957: rebase: unconditionally clear merge state when `--stop`ing a rebase

durin42 added a comment. In D6957#101985 , @martinvonz wrote: > In D6957#101984 , @marmoute wrote: > >> In D6957#101977 , @martinvonz wrote: >>

D6957: rebase: unconditionally clear merge state when `--stop`ing a rebase

durin42 created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I am NOT sure of the correctness of this change, but I've hit a point on a work repository where the needupdate function

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 updated this revision to Diff 16714. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=16704=16714 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734 AFFECTED FILES

D6887: upgrade: detect the side-data format variants

durin42 added inline comments. INLINE COMMENTS > test-lfs-serve.t:136 > + sidedata > + Unlock the ability to store extra data alongside a revision. > + how about: "Allows storage of extra data alongside a revision." REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16704. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=16622=16704 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL

D6884: bookmarks: remove changectx() method from bmstore (API)

Closed by commit rHGe3bb2a58af1e: bookmarks: remove changectx() method from bmstore (API) (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6884?vs=16624=16625

D6884: bookmarks: remove changectx() method from bmstore (API)

durin42 updated this revision to Diff 16624. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6884?vs=16623=16624 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6884/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6884 AFFECTED FILES

D6884: bookmarks: remove changectx() method from bmstore (API)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All the callsites of this method have access to the repo, and I'd rather not have to duplicate this across alternative bmstore implementations. Besides, it

D6882: histedit: sniff-test for untracked file conflicts before prompting for rules

Closed by commit rHG699102b10530: histedit: sniff-test for untracked file conflicts before prompting for rules (authored by durin42). durin42 marked 2 inline comments as done. This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed;

D6881: histedit: demonstrate breakage when `update` to a revision breaks

Closed by commit rHGf200bea8470b: histedit: demonstrate breakage when `update` to a revision breaks (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6882: histedit: sniff-test for untracked file conflicts before prompting for rules

durin42 added inline comments. durin42 marked 2 inline comments as done. INLINE COMMENTS > martinvonz wrote in histedit.py:1975-1978 > Does `None` (the default value for that argument) work? It seems like it > should. If it does, then that seems preferable. No, because that gives me the

D6882: histedit: sniff-test for untracked file conflicts before prompting for rules

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in histedit.py:1989 > could you pass these as keyword arguments? Maybe, but I'll do what happens at the other callsite. I also cleaned up the TODO, as I figured it out with print-debugging. REPOSITORY rHG Mercurial CHANGES

D6882: histedit: sniff-test for untracked file conflicts before prompting for rules

durin42 marked 4 inline comments as done. durin42 updated this revision to Diff 16618. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6882?vs=16617=16618 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6882/new/ REVISION DETAIL

D6882: histedit: sniff-test for untracked file conflicts before prompting for rules

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in histedit.py:1974-1993 > Won't they (correctly) cause a conflict with your approach too? They'll correctly cause a conflict, but I trust the merge code to efficiently figure out what paths to look up, rather than (eg)

D6882: histedit: sniff-test for untracked file conflicts before prompting for rules

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in histedit.py:1974-1993 > Would it be enough to check if any untracked file is in any of those commits? > That should be a lot simpler and cheaper. Maybe? The tricky bit would be if the user has a gazillion untracked or ignored

D6882: histedit: sniff-test for untracked file conflicts before prompting for rules

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This bug is as old as histedit, which is more than 10 years! I'm a little sad about the extra calculations here that we're just going to throw out, but I don't

D6881: histedit: demonstrate breakage when `update` to a revision breaks

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm honestly impressed that nobody has hit this in the over a decade that histedit has existed, but here we are. REPOSITORY rHG Mercurial REVISION DETAIL

D6879: merge: check argument value with if/raise instead of an assert

Closed by commit rHG71bb9363818c: merge: check argument value with if/raise instead of an assert (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6877: merge: replace magic strings with NAMED_CONSTANTS (API)

Closed by commit rHG1ad3ebb39c61: merge: replace magic strings with NAMED_CONSTANTS (API) (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6877?vs=16605=16610

D6878: hg: have `updatetotally` more thoroughly check updatecheck argument (API)

Closed by commit rHGee1ef76d7339: hg: have `updatetotally` more thoroughly check updatecheck argument (API) (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6879: merge: check argument value with if/raise instead of an assert

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This shouldn't make any difference for legal code, but it'll prevent the assertion from being optimized out if someone decides to do -O on our code. REPOSITORY

D6877: merge: replace magic strings with NAMED_CONSTANTS (API)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY .. api:: `mercurial.hg.update*` and `mercurial.merge.update` now expect a value from a set of NAMED_CONSTANTS (`merge.UPDATECHECK_*` constants)

D6878: hg: have `updatetotally` more thoroughly check updatecheck argument (API)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY .. api:: `mercurial.hg.updatetotally` is now more thorough about checking its `updatecheck` keyword argument. Previously invalid values would have

D6872: contrib: add new examples area and start it out with a config for `hg fix`

Closed by commit rHG5dfb57af1148: contrib: add new examples area and start it out with a config for `hg fix` (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6873: examples: add sample fix integration for `rustfmt`

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6873 AFFECTED FILES contrib/examples/fix.hgrc CHANGE DETAILS diff --git a/contrib/examples/fix.hgrc

D6872: contrib: add new examples area and start it out with a config for `hg fix`

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the configuration contributors should use for our C/C++ code. I expect to expand this file as we get more automated formatter oversight. REPOSITORY

D6859: rust-cpython: mark PySharedState as Sync so &'PySharedState can be Send (RFC)

durin42 added a comment. Also, since it's possible we could call back into Python code and *that* could release-and-reacquire the GIL, the GIL guarding is probably insufficient to make this a "safe lie". REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6859: rust-cpython: mark PySharedState as Sync so &'PySharedState can be Send (RFC)

durin42 added a comment. I asked some coworkers, and they said: > I do not believe this to be correct. An object is Sync if it is *inherently* thread-safe. This object is not -- the first thing borrow_mut does is a racy read of mutably_borrowed. so I'm now leaning towards this

D6522: tracing: add many more timedcm() calls throughout the codebase

durin42 updated this revision to Diff 16594. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6522?vs=16300=16594 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6522/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6522 AFFECTED FILES

D6527: dirstate: add counter events for work queue depth

durin42 updated this revision to Diff 16595. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6527?vs=16301=16595 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6527/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6527 AFFECTED FILES

D6522: tracing: add many more timedcm() calls throughout the codebase

durin42 added a comment. In D6522#99543 , @martinvonz wrote: >> I've been trying to understand where time goes in hg status and this helped >> me get a sense of things. > > Do you remember which of these were slow? You have instrumented

D6867: transaction: detect an attempt to truncate-to-extend on playback, raise error

durin42 added a comment. I feel like there's room for doing better, but it'll require very careful reasoning and may not be worthwhile. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6867/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6867

D6862: tests: clean up built binaries after running test-fuzz-targets.t

Closed by commit rHG39cab871e880: tests: clean up built binaries after running test-fuzz-targets.t (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6861: fastannotate: remove support for flock() locking

Closed by commit rHG0152a907f714: fastannotate: remove support for flock() locking (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6861?vs=16567=16572 CHANGES

D6860: remotefilelog: remove dead code for using flock() for locking

Closed by commit rHG5316f9ff3e48: remotefilelog: remove dead code for using flock() for locking (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6862: tests: clean up built binaries after running test-fuzz-targets.t

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Most users won't notice a change here because they won't have the fuzzer infra, but by good fortune my workstation has the required bits and keeps leaving the

D6861: fastannotate: remove support for flock() locking

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've seen enough weirdness in CI with flock for remotefilelog that I'm now of the opinion we should just stop using flock() everywhere until someone has a

D6860: remotefilelog: remove dead code for using flock() for locking

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6860 AFFECTED FILES hgext/remotefilelog/extutil.py CHANGE DETAILS diff --git

D6814: revlog: add a `sidedata` parameters to addrevision

This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > remotefilelog.py:132 > def addrevision(self, text, transaction, linknode, p1, p2, > cachedelta=None, > -node=None,

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16554. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=16525=16554 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL

D6836: interfaces: introduce an interface for dirstate implementations

Closed by commit rHGd459cd8ea42d: interfaces: introduce an interface for dirstate implementations (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6839: idirstate: group private methods and attrs that are in the interface

Closed by commit rHG97b79354e9f0: idirstate: group private methods and attrs that are in the interface (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6838: idirstate: remove now non-public _map attribute

Closed by commit rHGbbd154627a72: idirstate: remove now non-public _map attribute (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6838?vs=16506=16538 CHANGES

D6776: bookmarks: validate changes on push (issue6193) (BC)

durin42 added a comment. In D6776#100487 , @valentin.gatienbaron wrote: > I showed in D6847 the same change but implemented in exchange._processcompared. Tests pass. > I think it'd make for a simpler

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16525. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=16387=16525 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL

D6837: cleanup: fix leakage of dirstate._map to client code

Closed by commit rHG34ed651ba7e4: cleanup: fix leakage of dirstate._map to client code (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6837?vs=16505=16521

D6776: bookmarks: validate changes on push (issue6193) (BC)

durin42 added a comment. We're really close. I've uploaded my rebase of this to the latest dev hg (along with some minor test fixes). There's now only one failure: --- /Users/augie/Programming/hg/crew/tests/test-bookmarks-pushpull.t +++

D6776: bookmarks: validate changes on push (issue6193) (BC)

durin42 updated this revision to Diff 16519. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6776?vs=16518=16519 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6776/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6776 AFFECTED FILES

D4664: mergecommit: add a new extension to merge in-memory and create a commit

durin42 added a comment. Neat. I assume you normally check these out later? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D4664/new/ REVISION DETAIL https://phab.mercurial-scm.org/D4664 To: pulkit, #hg-reviewers Cc: durin42, marcink,

D6659: graft: split graft code into seperate functions

This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > cmdutil.py:3497 > + > +def updateopts(repo, graftstate, opts): > +"""updates opts and nodes from graftstate in case graft This function is still

D6735: update: added support for --abort flag(issue4404)

durin42 added a comment. durin42 accepted this revision as: durin42. This looks good to me. Does anyone else have comments? @mharbison72 are you happy with the subrepo test coverage? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6735/new/ REVISION

D6709: config: add --registered flag to show all known configs

durin42 added a comment. durin42 accepted this revision. I'm okay with this as-is. Barring an objection in a week or so I'll queue it. (It's also possible I've missed something important when I read through the extensive review history here. Apologies if true, but please restate your

D6776: bookmarks: validate changes on push (issue6193) (BC)

durin42 edited the summary of this revision. durin42 retitled this revision from "bookmarks: validate changes on push" to "bookmarks: validate changes on push (issue6193) (BC)". durin42 updated this revision to Diff 16515. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6776: bookmarks: validate changes on push

durin42 added a comment. I get a fair number of test failures with this, eg `test-bookmarks-corner-case.t`: --- /usr/local/google/home/augie/hgtest/tests/test-bookmarks-corner-case.t +++ /usr/local/google/home/augie/hgtest/tests/test-bookmarks-corner-case.t.err @@ -178,11

D6776: bookmarks: validate changes on push

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. Queued this with lots of content added to the commit message. Thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6776/new/ REVISION DETAIL

D6837: cleanup: fix leakage of dirstate._map to client code

durin42 added a comment. In D6837#100331 , @mharbison72 wrote: >> 2. In lfs, where we deal with standins and mutating status. > > s/lfs/largefiles/? Good catch, fixed. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6837: cleanup: fix leakage of dirstate._map to client code

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We already had proper accessors for most of the behavior of dirstate._map that callers cared about exposed in the actual dirstate class as public methods. Sigh.

D6839: idirstate: group private methods and attrs that are in the interface

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes it a little more obvious at a glance what work is left. Fortunately there's not a whole lot left. I suspect the ignore logic is going to be the

D6836: interfaces: introduce an interface for dirstate implementations

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As usual with adding interface definitions, this describes the way things are, not the way we'd like things to be. There are some clear problems in the

D6838: idirstate: remove now non-public _map attribute

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6838 AFFECTED FILES mercurial/interfaces/dirstate.py CHANGE DETAILS diff --git

D6808: revlog: introduce a `sidedata` method

durin42 added a comment. FWIW I'm +0.5 on this because it seems like a reasonable abstraction and could serve a variety of purposes. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6808/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6808 To:

D6821: flagprocessors: directly duplicate the deprecated layer back into revlog

durin42 added inline comments. INLINE COMMENTS > remotefilelog.py:311 > +"""deprecated entry point to access flag processors""" > +msg = ('_processflag(...) use the specialized variant') > +util.nouideprecwarn(msg, '5.2', stacklevel=2) I'm not sure what this is telling

D6814: revlog: add a `sidedata` parameters to addrevision

This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > marmoute wrote in remotefilelog.py:133 > because it can be iterated over as a noop. I agree with Greg: if your intent is "optional iterable of data", the

<    3   4   5   6   7   8   9   10   11   12   >