D3964: macosx: fixing macOS version generation after db9d1dd01bf0

2018-07-18 Thread glandium (Mike Hommey)
glandium added a comment. This is python code, why is it parsing the version file instead of importing it? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3964 To: rdamazio, #hg-reviewers Cc: glandium, mercurial-devel

D3958: Allow to run setup.py with python 3 without a mercurial checkout

2018-07-16 Thread glandium (Mike Hommey)
glandium created this revision. glandium added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some people may want to test mercurial in a python 3 environment through e.g. pip, in which case setup.py doesn't run in a

D2057: rust implementation of hg status

2018-03-07 Thread glandium (Mike Hommey)
glandium added a comment. Doesn't mononoke have code to read revlogs already? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2057 To: Ivzhh, #hg-reviewers Cc: glandium, krbullock, indygreg, durin42, kevincox, mercurial-devel

D1846: rust: avoid redundant 'static lifetime

2018-01-11 Thread glandium (Mike Hommey)
glandium added a comment. > but it's okay to depend on backports or rustup to /build/ packages The only exception where it's okay is, essentially, Firefox. With a backport of the rust compiler landing in stable about once a year, and even then it won't replace the version in stable. See

D1846: rust: avoid redundant 'static lifetime

2018-01-11 Thread glandium (Mike Hommey)
glandium added a comment. > To my understanding, as long as we're only using the stable channel, we should be fine for the binaries we're building being packageable even on slower-moving distros like Debian. Slow-moving distros like Debian don't update the rust compiler. Debian stable

D329: setup: Fix installing in a mingw environment

2017-08-12 Thread glandium (Mike Hommey)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7686cbb0ba41: setup: fix installing in a mingw environment (authored by glandium). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D329?vs=751=828 REVISION DETAIL

D329: setup: Fix installing in a mingw environment

2017-08-11 Thread glandium (Mike Hommey)
glandium added a comment. 4.3.1 can't currently be installed with MINGW64 python currently because of this, so I'd say yes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D329 To: glandium, #hg-reviewers, quark Cc: durin42, mercurial-devel

D330: Backed out changeset c34532365b38

2017-08-10 Thread glandium (Mike Hommey)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1814ca418b30: branchmap: revert c34532365b38 for Python 2.7 compatibility (authored by glandium). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D330?vs=752=755

D330: Backed out changeset c34532365b38

2017-08-10 Thread glandium (Mike Hommey)
glandium created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Old versions of python 2.7 don't like that the second argument to struct.unpack_from is a bytearray, so the change removing the util.buffer around that

D328: setup: Fix installing in a mingw environment

2017-08-10 Thread glandium (Mike Hommey)
glandium added a comment. Sorry, I rebased to stable, and that created a new differential: https://phab.mercurial-scm.org/D329, even though I updated the local tag. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D328 To: glandium, #hg-reviewers, quark Cc:

D329: setup: Fix installing in a mingw environment

2017-08-10 Thread glandium (Mike Hommey)
glandium created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The addition, in https://phab.mercurial-scm.org/rHG9a4adc76c88a1a217983f051766b3009c0bca3aa, of a hack for the MSVC compiler class was overwriting the original

D328: setup: Fix installing in a mingw environment

2017-08-10 Thread glandium (Mike Hommey)
glandium created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The addition, in https://phab.mercurial-scm.org/rHG9a4adc76c88a1a217983f051766b3009c0bca3aa, of a hack for the MSVC compiler class was overwriting the original