D1683: sshpeer: allow for additional environment passing to ssh exe

This revision was automatically updated to reflect the committed changes. Closed by commit rHG47921dafb44b: sshpeer: allow for additional environment passing to ssh exe (authored by ikostia, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D16

D1683: sshpeer: allow for additional environment passing to ssh exe

ikostia created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We already have the ability to customize the ssh command line arguments, let's add the ability to customize its environment as well. Example use-case is ssh.e

D1667: tests_: fix test-lfs.t on OSX where find does not have quotes

ikostia abandoned this revision. ikostia added a comment. @quark: thanks for the `tests` note. abandoning this as an equivalent change is already landed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1667 To: ikostia, #hg-reviewers, quark, akushner Cc: dur

D1667: tests_: fix test-lfs.t on OSX where find does not have quotes

ikostia created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. TEST PLAN - run test-lfs.t REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D1667 AFFECTED FILES tests/test-lfs.t CHANGE DETAILS d

D1564: worker: make windows workers daemons

ikostia accepted this revision. ikostia added a comment. This *looks* reasonable to me, but I am afraid I could be missing something important. Anyway, since we can turn it off via a config, I'd say it's good to be in the hotfixes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.m

D865: obsmarker: fix crash when metadata fields are >255 bytes (issue5681)

ikostia accepted this revision. ikostia added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D865 To: swhitaker, #hg-reviewers, ikostia Cc: pulkit, ikostia, mercurial-devel ___ Mercurial-devel mailing li

D865: obsmarker: fix crash when metadata fields are >255 bytes (issue5681)

ikostia added a comment. That is why we raise `ProgrammingError`, not some sort of `UserError`. If your extension writes metadata longer than 255 chars, it is a bad extension. Your proposal is weird, because it is quietly modifying things, IMO this is much worse. I'd rather be forced to chan

D865: obsmarker: fix crash when metadata fields are >255 bytes

ikostia requested changes to this revision. ikostia added a comment. This revision now requires changes to proceed. I would rather see this thing do `raise error.ProrgrammingError('metadata cannot be longer than 255 bytes')` (or some other message). REPOSITORY rHG Mercurial REVISION DETAI

D680: scmutil: handle conflicting files and dirs in origbackuppath

ikostia added a comment. Just as an FYI: I revoke my previous comments, as stuff started working for non-prefixed paths and I no longer intend to land anything related to this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D680 To: mbthomas, ryanmce, #hg-review

D680: scmutil: handle conflicting files and dirs in origbackuppath

ikostia added a comment. Here's a patch: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-September/104837.html REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D680 To: mbthomas, ryanmce, #hg-reviewers, durham, yuja, ikostia Cc: ikostia, yuja, durham,

D680: scmutil: handle conflicting files and dirs in origbackuppath

ikostia requested changes to this revision. ikostia added a comment. This revision now requires changes to proceed. Please wait until the `util.finddirs()` is tweaked and remove `normpath` call. INLINE COMMENTS > yuja wrote in scmutil.py:570 > That's probably okay now. > > I'm not sure if it