D7542: mail: don't complain about a multi-word email.method

2022-04-12 Thread jcristau (Julien Cristau)
Closed by commit rHG1d6c6ad645e1: mail: don't complain about a multi-word email.method (authored by jcristau). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7542?vs=33000&id=33015

D7542: mail: don't complain about a multi-word email.method

2022-04-11 Thread jcristau (Julien Cristau)
Herald added a subscriber: mercurial-patches. jcristau updated this revision to Diff 33000. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7542?vs=18420&id=33000 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7542/new/ REVIS

D12493: test: deal with changed error message on python 3.10

2022-04-11 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12493 AFFECTED FILES tests/test-parseindex.t CHANGE DETAILS diff --git a/tests/t

D12492: test: accept another error message on lack of TLS client certificate

2022-04-09 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12492 AFFECTED FILES tests/test-https.t CHANGE DETAILS diff --git a/tests/test-h

D12491: sslutil: treat TLSV1_ALERT_PROTOCOL_VERSION error the same as UNSUPPORTED_PROTOCOL

2022-04-09 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It looks like python 3.10 returns a different reason code on protocol version mismatch. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https:/

D12490: test: override default cipher selection when connecting to TLS 1.0/1.1 servers

2022-04-09 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The default set of ciphers on python 3.10 is incompatible with old TLS versions. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.m

D12489: sslutil: be less strict about which ciphers are allowed when using --insecure

2022-04-09 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Python 3.10 restricted which ciphers are enabled by default, leading to no available ciphers for TLS < 1.2. When using the --insecure flag we allow old TLS,

D12488: sslutil: avoid deprecation warnings from python 3.10's ssl module

2022-04-09 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Use ssl.PROTOCOL_TLS_{CLIENT,SERVER} and SSLContext.{min,max}imum_version when supported (3.7+). And, catch deprecation warnings when the user asks for dep

D12487: zeroconf: fix deprecation warning with python 3.10

2022-04-09 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY threading.condition.notifyAll → threading.condition.notify_all REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12

D12377: test: update test-clone-stream.t to pass on bigendian

2022-03-15 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Fixes: a3cf460a6b1b ("stream-clone: also filter the requirement we put in the bundl

D12376: revlog: fix index_fast_rank (wip)

2022-03-15 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As far as I can tell, rank is stored as a 32-bit big endian value, I'm not sure how grabbing the first byte can possibly work. I assume there's no test cover

D12374: revlog: fix wrong type of rank_unknown variable

2022-03-14 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We treat "rank" as an int everywhere, but declare rank_unknown as a char. On architectures where char is signed, that works out ok, but when char is unsigned

D11335: revlog: fix more type confusion in index_replace_sidedata_info (issue6580)

2021-08-24 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We were telling python that "rev" was a Py_ssize_t (via the "n" format), but it was actually an int. REPOSITORY rHG Mercurial BRANCH stable REVISION DETA

D11334: revlog: fix type confusion with sidedata_comp_len (issue 6580)

2021-08-24 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The format string uses "i" (int) for sidedata_comp_len, so we shouldn't be passing a pointer to Py_ssize_t to PyArg_ParseTuple. On 64-bit big-endian, this wo

D8664: test: redirect stderr so warning messages don't cause changed output (issue6237)

2020-06-25 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY clone and commit race for the lock, and if commit has to wait more than a second it prints a warning to stderr. Since this is somewhat expected here, silence

D8571: test: make test-doctest.py not assume it's run from a mercurial repo

2020-05-19 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This assumption fails when building and running tests from a source tarball, e.g. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.

D8092: hghave: cache the result of gethgversion

2020-02-07 Thread jcristau (Julien Cristau)
Closed by commit rHG8607dc2aa686: hghave: cache the result of gethgversion (authored by jcristau). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8092?vs=19985&id=19998 CHANGES SINC

D8092: hghave: cache the result of gethgversion

2020-02-07 Thread jcristau (Julien Cristau)
jcristau added a comment. It fixes a longstanding issue in tests, it's not particularly urgent IMO. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8092/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8092 To: jcristau, #hg-reviewers, marmoute C

D8092: hghave: cache the result of gethgversion

2020-02-07 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY hghave --test-features calls it 90 times, each one calling hg --version which takes a tenth of a second on my workstation, adding up to about 10s win on test-hg

D7541: mail: use procutil.shellsplit instead of bytes.split to parse command

2019-12-10 Thread jcristau (Julien Cristau)
Closed by commit rHG8f26dd09aa78: mail: use procutil.shellsplit instead of bytes.split to parse command (authored by jcristau). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7541?vs

D7556: tests: remove hardcoded errno values

2019-12-06 Thread jcristau (Julien Cristau)
jcristau added a comment. I think default is good enough. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7556/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7556 To: jcristau, #hg-reviewers, pulkit Cc: mercurial-devel ___

D7556: tests: remove hardcoded errno values

2019-12-06 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fixes test failures on hurd-i386 Ref: https://bugs.debian.org/946178 REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-sc

D7542: mail: don't complain about a multi-word email.method

2019-12-03 Thread jcristau (Julien Cristau)
jcristau added a comment. jcristau planned changes to this revision. doh. Right you are. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7542/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7542 To: jcristau, #hg-reviewers Cc: yuja, mercurial-d

D7542: mail: don't complain about a multi-word email.method

2019-12-02 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I want to be able to set email.method to "ssh relay /usr/sbin/sendmail" without needing an extra trivial shell script. This works fine since we pass the full co

D7541: mail: use procutil.shellsplit instead of bytes.split to parse command

2019-12-02 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7541 AFFECTED FILES mercurial/mail.py CHANGE DETAILS diff --git a/mercurial/mail.py b/mercurial/mail

D7302: zeroconf: improve the extension's documentation

2019-11-07 Thread jcristau (Julien Cristau)
jcristau added a comment. FWIW Debian's been carrying this patch for 10 years. Submitting it now as suggested by Augie, so I can drop it downstream whether it's accepted or not. :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7302/new/ REVISION DET

D7302: zeroconf: improve the extension's documentation

2019-11-07 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7302 AFFECTED FILES hgext/zeroconf/__init__.py CHANGE DETAILS diff --git a/hgext/zeroconf/__init__.p

D6787: test: allow different result for zstd compression (issue6188)

2019-09-07 Thread jcristau (Julien Cristau)
Closed by commit rHGda2c360899c9: test: allow different result for zstd compression (issue6188) (authored by jcristau). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6787?vs=16390&i

D6787: test: allow different result for zstd compression (issue6188)

2019-09-06 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY test-repo-compengines fails on big-endian due to different file size, but the repo doesn't seem broken, so allow both sizes. REPOSITORY rHG Mercurial REVISION

D5934: phabricator: make user searches case-insensitive

2019-02-15 Thread jcristau (Julien Cristau)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG570e62f1dcf2: phabricator: make user searches case-insensitive (authored by jcristau, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5934?vs=14030

D5934: phabricator: make user searches case-insensitive

2019-02-11 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY User names in conduit are case insensitive, but when looking for "FOO" it would return "foo" instead and we'd think the user didn't exist. So lower case both t

D5412: test: fix test-http-bad-server with current python 2.7

2018-12-12 Thread jcristau (Julien Cristau)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG21f5810df848: test: fix test-http-bad-server with current python 2.7 (authored by jcristau, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5412?vs

D5412: test: fix test-http-bad-server with current python 2.7

2018-12-11 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://github.com/python/cpython/pull/2825 changed the exception message for empty http status line. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.

D3538: bdiff: fix yet more fallout from xdiff long/int64 conversion (issue5885)

2018-05-13 Thread jcristau (Julien Cristau)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG273ea09f6550: bdiff: fix yet more fallout from xdiff long/int64 conversion (issue5885) (authored by jcristau, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercuria

D3538: bdiff: fix yet more fallout from xdiff long/int64 conversion (issue5885)

2018-05-12 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY "l" in Py_BuildValue's format string means long, so passing int64_t instead results in fireworks on 32bit architectures. REPOSITORY rHG Mercurial REVISION DET