This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbfd65b5e070b: help: clarify overlap of revlog header and
first revlog entry (authored by ngoldbaum, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad55a0a5894f: help: include subtopic in error message if
passed (authored by ngoldbaum, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6442?vs=152
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa84564b1a0b1: help: check if a subtopic exists and raise an
error if it doesn't (issue6145) (authored by ngoldbaum, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.me
ngoldbaum created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6449
AFFECTED FILES
mercurial/help/internals/revlogs.txt
CHANGE DETAILS
diff --git a/mercurial/help
ngoldbaum updated this revision to Diff 15269.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6442?vs=15259&id=15269
REVISION DETAIL
https://phab.mercurial-scm.org/D6442
AFFECTED FILES
mercurial/help.py
tests/test-help.t
CHANGE DETAILS
diff --git
ngoldbaum updated this revision to Diff 15268.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6441?vs=15258&id=15268
REVISION DETAIL
https://phab.mercurial-scm.org/D6441
AFFECTED FILES
mercurial/help.py
CHANGE DETAILS
diff --git a/mercurial/help.py
ngoldbaum added inline comments.
INLINE COMMENTS
> martinvonz wrote in help.py:689-695
> I avoid for-else for the same reason, but how about this:
>
> if not any(subtopic in names for names, header, doc in subtopics[name]):
> raise error.UnknownCommand(name)
OK, I agree that's clearer.
ngoldbaum updated this revision to Diff 15259.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6442?vs=15253&id=15259
REVISION DETAIL
https://phab.mercurial-scm.org/D6442
AFFECTED FILES
mercurial/help.py
tests/test-help.t
CHANGE DETAILS
diff --git
ngoldbaum updated this revision to Diff 15258.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6441?vs=15246&id=15258
REVISION DETAIL
https://phab.mercurial-scm.org/D6441
AFFECTED FILES
mercurial/help.py
CHANGE DETAILS
diff --git a/mercurial/help.py
ngoldbaum added inline comments.
INLINE COMMENTS
> av6 wrote in help.py:689-695
> This made me remember that for-else statement exists.
I left this as-is because I find for-else statements hard to read (I never
remember what it means!) and find this to be clearer even if there's a bit more
boi
ngoldbaum updated this revision to Diff 15253.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6442?vs=15247&id=15253
REVISION DETAIL
https://phab.mercurial-scm.org/D6442
AFFECTED FILES
mercurial/help.py
tests/test-help.t
CHANGE DETAILS
diff --git
ngoldbaum added inline comments.
INLINE COMMENTS
> av6 wrote in help.py:826
> Concatenating things is not the best option when it comes to i18n, but even
> if it were, I think it would make sense to only show here the subtopic, if
> it's provided. If people are curious about internals.foobar (o
ngoldbaum created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6442
AFFECTED FILES
mercurial/help.py
tests/test-help.t
CHANGE DETAILS
diff --git a/tests/test-he
ngoldbaum created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6441
AFFECTED FILES
mercurial/help.py
CHANGE DETAILS
diff --git a/mercurial/help.py b/mercurial/hel
14 matches
Mail list logo