D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 updated this revision to Diff 6324. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2394?vs=6008&id=6324 REVISION DETAIL https://phab.mercurial-scm.org/D2394 AFFECTED FILES hgext/histedit.py tests/test-histedit-arguments.t CHANGE DETAILS

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4de15c54e59f: clone: updates the help text for hg clone -{r,b} (issue5654) (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2095?vs=5371&id=6401#toc REP

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. added the tests @krbullock REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel ___ Mercurial

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The earlier functionality used to ignore the all but last -m flag's value. It used to store the arguments information in a state dict and then overwrites each

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 added a comment. I am not sure why are those things convert to bytes literal in the "test-commit.t" file. I didn't do that :/ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2588 To: sangeet259, #hg-reviewers Cc: jeffpc, mercurial-devel __

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 updated this revision to Diff 6536. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2588?vs=6438&id=6536 REVISION DETAIL https://phab.mercurial-scm.org/D2588 AFFECTED FILES mercurial/fancyopts.py tests/test-commit.t CHANGE DETAILS diff -

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 added a comment. @jeffpc That means two new line. Shall I edit this then? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2588 To: sangeet259, #hg-reviewers Cc: jeffpc, mercurial-devel ___ Mercurial-devel mai

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 updated this revision to Diff 6537. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2588?vs=6536&id=6537 REVISION DETAIL https://phab.mercurial-scm.org/D2588 AFFECTED FILES mercurial/fancyopts.py tests/test-commit.t CHANGE DETAILS diff -

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Even I thought of this construct before as it appears more elegant. But it is failing some tests! Specifically, the error messages are changed in this one. Failed test-histedit-arguments.t: output changed Failed test-histedit-edit.t: output ch

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 added a comment. @pulkit Yeah, this rather a not so elegant hack. How can it be parsed in hg commit? As the first message passed is overwritten by the second one at this step only. :/ @yuja I think maybe subclassing the customopt may be a fair choice. REPOSITORY rHG Mer

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Here is the output! https://bpaste.net/show/7ccf4a9fea50 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel _

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Should I make any changes? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel ___

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 added a comment. Since the current code just overwrites message each time with the newer. What can be done to avoid losing the earlier message values? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2588 To: sangeet259, #hg-reviewers Cc: durin42, tom.

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @pulkit It is not failing as of now. It's failing on the changes proposed by @durin42, which he assumed wont fail, but that's not the case! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers C

D2938: grep: make grep search on working directory by default

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The earlier behaviour of grep was quite counter intuitive as it searches history by default. It throws up matches from files which have been deleted and commi

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7262. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7261&id=7262 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7266. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7262&id=7266 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.p

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7267. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7266&id=7267 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.p

D2394: histedit: make histedit's commands accept revsets (issue5746)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d3cff1f6bde: histedit: make histedit's commands accept revsets (issue5746) (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7280. sangeet259 marked 7 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7267&id=7280 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.py

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @yuja Can you please clarify this a bit more? > Perhaps we can start with adding an experimental option to grep files > including unchanged ones?" INLINE COMMENTS > yuja wrote in commands.py:2474 > Better to test if ctx is a workingctx (i.e. `ctx.rev() is N

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7289. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7280&id=7289 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If grep is passed a revset in forwards order via -r , say -r 0:tip Then the output is errorneous. This patch fixes that. The ouput was wrong because we delet

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 added a comment. Since it required some explanation I have written a post on it. http://sangeetmishra.me/2018/03/26/demonstrating-the-problem-with-forward-ordered-grep-all-in-mercurial.html REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2943 To: sa

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 added a comment. Currently, I am not sure what tests I should add, the tests in test-grep.t are passing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2943 To: sangeet259, #hg-reviewers Cc: mercurial-devel ___

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 updated this revision to Diff 7321. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2943?vs=7290&id=7321 REVISION DETAIL https://phab.mercurial-scm.org/D2943 AFFECTED FILES mercurial/commands.p

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 added a comment. @yuja rebase it on which revision? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2943 To: sangeet259, #hg-reviewers, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercuria

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 updated this revision to Diff 7342. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2943?vs=7321&id=7342 REVISION DETAIL https://phab.mercurial-scm.org/D2943 AFFECTED FILES mercurial/commands.p

D3031: histedit: make errror message translatable

sangeet259 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a follow up patch to https://phab.mercurial-scm.org/D2394 As suggested by Yuya, this patch makes the error message tra

D3031: histedit: make errror message translatable

This revision was automatically updated to reflect the committed changes. Closed by commit rHGffa79073e4ca: histedit: make errror message translatable (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3031?vs=7532&id=7

D2938: grep: make grep search on working directory by default

sangeet259 marked 2 inline comments as done. sangeet259 added a comment. @yuja > fix grep -r 'wdir()' What exactly do you mean by fixing 'grep -r wdir()' ? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2938 To: sangeet259, #hg-reviewers Cc: av6, yuja,

D2095: updates the help text for hg clone -r (issue5654) on bugzilla

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2095 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py b/merc

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

sangeet259 updated this revision to Diff 5370. sangeet259 retitled this revision from "updates the help text for hg clone -r (issue5654) on bugzilla" to "clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

sangeet259 updated this revision to Diff 5371. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2095?vs=5370&id=5371 REVISION DETAIL https://phab.mercurial-scm.org/D2095 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/comman

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

sangeet259 added a comment. @dlax Yes, but the short summary didn't say what it does! It just says "include the specified changeset". REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2095 To: sangeet259, #hg-reviewers Cc: dlax, mercurial-devel ___

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

sangeet259 added a comment. In https://phab.mercurial-scm.org/D2095#35494, @joerg.sonnenberger wrote: > There was a longish discussion on IRC about this. The problem is that the flags by themselves do not document the interaction of -r and -b or multiple instances of either at all. The c

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

sangeet259 added a comment. Oh! Thanks for letting me know! I will keep that in mind. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2095 To: sangeet259, #hg-reviewers, durin42 Cc: pulkit, durin42, joerg.sonnenberger, dlax, mercurial-devel

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 updated this revision to Diff 6008. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2394?vs=6007&id=6008 REVISION DETAIL https://phab.mercurial-scm.org/D2394 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git a/hgext/histedit.py b/

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. **What I did**: @durin42 suggested in the issue page that the error was in the `verify` function of the `histedit.py` file. But when I ran through debugger using a revision number, the code was throwing the error

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. Oh, I forgot adding tests as @durin42 told. Doing that right away! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: mercurial-devel ___ Mercuria

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @yuja So I was working on it, but the way I tried to correct "wdir()" is by handling it as a special case, so introducing an "if" block again similar to this. But you were asking to eliminate the if/else block altogether, I wonder if there is way ? REPOSITOR

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. > Perhaps, we'll have to catch WdirUnsupported error to fall back to the filectx API. This seems a good idea. Trying it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2938 To: sangeet259, #hg-reviewers Cc: av6, yuja, pulkit,

D3673: grep: enables passing wdir as a revision in grep

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When you pass wdir() to the -r flag, it catches the WdirUnsupported error and fall back to and alternate path REPOSITORY rHG Mercurial REVISION DETAIL htt

D3673: grep: enables passing wdir as a revision in grep

sangeet259 updated this revision to Diff 8951. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3673?vs=8930&id=8951 REVISION DETAIL https://phab.mercurial-scm.org/D3673 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3673: grep: enables passing wdir as a revision in grep

This revision was automatically updated to reflect the committed changes. Closed by commit rHG16f93a3b8b05: grep: enable passing wdir as a revision (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3673?vs=8951&id=8954#toc REPOSITORY rHG Mercuri

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. Hey @yuja Can you explain why you did this ? > - slowpath = match.anypats() or (not match.always() and opts.get('removed')) +slowpath = True REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2938 To: sangeet259, #hg-reviewer

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @yuja I am adding an --unmodified flag to change to change the mode to grep on the unmodified files as well. What I am trying to do is :: def fns_generator(): if --unmodified: for f in ctx: for f in ctx:

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @martinvonz, thanks for the reviews, but @yuja has asked me to break this patch into three patches. So I guess this is not going to be merged anyway. Currently, I am trying to add a flag like `--all_files` or `--unmodified` which will enable one to grep all th

D3728: grep: adds unmodified mode

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY adds an unmodified flag that lets you grep on all files in the revision and not just the one that were modified in that changeset REPOSITORY rHG Mercurial R

D3728: grep: adds unmodified mode

sangeet259 added a comment. I am updating the tests REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3728 To: sangeet259, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.o

D3728: grep: adds unmodified mode

sangeet259 updated this revision to Diff 9049. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9041&id=9049 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t CH

D3728: grep: adds unmodified mode

sangeet259 updated this revision to Diff 9050. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9049&id=9050 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t CH

D3728: grep: adds unmodified mode

sangeet259 updated this revision to Diff 9092. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9050&id=9092 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t CH

D3728: grep: adds unmodified mode

sangeet259 updated this revision to Diff 9107. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9092&id=9107 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t CH

D3728: grep: adds allfiles mode

sangeet259 added a comment. @yuja Sorry I didn't run the tests after this edit . REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3728 To: sangeet259, #hg-reviewers Cc: pulkit, yuja, mharbison72, mercurial-devel ___ Merc

D3728: grep: adds allfiles mode

sangeet259 updated this revision to Diff 9121. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9107&id=9121 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t CH

D3728: grep: adds allfiles mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb8f45fc27370: grep: adds allfiles mode (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3728?vs=9121&id=9123#toc REPOSITORY rHG Mercurial CHANGES SIN

D3763: grep: add `--diff` flag

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY adds a diff flag, which works exactly same as all, infact since -all searches diffs, there diff is a better name for it. The all flag is still here for backwa

D3763: grep: add `--diff` flag

sangeet259 updated this revision to Diff 9217. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3763?vs=9125&id=9217 REVISION DETAIL https://phab.mercurial-scm.org/D3763 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3763: grep: add `--diff` flag

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7fbb5d76c555: grep: add --diff flag (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3763?vs=9217&id=9245#toc REPOSITORY rHG Mercurial CHANGES SINCE

D3825: grep: deprecates `--all` flag

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As the name "all" is a misnomer for an option that searches on diffs of revisions, we are moving to `diff` flag from `all`, deprecating it in the process. REP

D3826: grep : change default behaviour of grep

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY with this patch grep searches on the working directory by default and looks for all files tracked by the working directory and greps on them REPOSITORY rHG M

D3826: grep : change default behaviour of grep

sangeet259 updated this revision to Diff 9252. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9251&id=9252 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3826: grep: change default behaviour of grep

sangeet259 added a comment. I need some help with the tests failing here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3826 To: sangeet259, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial

D3825: grep: deprecates `--all` flag

sangeet259 updated this revision to Diff 9339. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9250&id=9339 REVISION DETAIL https://phab.mercurial-scm.org/D3825 AFFECTED FILES mercurial/commands.p

D3825: grep: deprecates `--all` flag

sangeet259 updated this revision to Diff 9340. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9339&id=9340 REVISION DETAIL https://phab.mercurial-scm.org/D3825 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/comman

D3825: grep: deprecates `--all` flag

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d9d0d30cfcc: grep: deprecates `--all` flag (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9340&id=9341 REVISION

D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use

sangeet259 updated this revision to Diff 9403. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2015?vs=9229&id=9403 REVISION DETAIL https://phab.mercurial-scm.org/D2015 AFFECTED FILES tests/test-split.t CHANGE DETAILS diff --git a/tests/test-split.t

D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use

sangeet259 added a comment. I am sorry I accidentally pushed here :/ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2015 To: spectral, #hg-reviewers, martinvonz Cc: sangeet259, martinvonz, mercurial-devel ___ Mercurial

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9461. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9252&id=9461 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9462. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9461&id=9462 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9470. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9462&id=9470 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9472. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9470&id=9472 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.p

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9473. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9472&id=9473 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.p

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9474. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9473&id=9474 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9480. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9474&id=9480 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.p

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9481. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9480&id=9481 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9482. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9481&id=9482 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9492. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9482&id=9492 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --gi

D3826: grep: change default behaviour of grep

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9ef10437bb88: grep: change default behaviour to search working directory files (BC) (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3826?vs=9492&id=9500

D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

sangeet259 added a comment. So what is the way around this, does this mean grep can't be changed at all ? Also can't we update hglib to work accordingly. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3919 To: yuja, #hg-reviewers, sangeet259, pulkit Cc: merc

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py tests/test-grep.t CHANGE DETAILS diff --git a/tests/tes

D3981: grep: add MULTIREV support to --all-files flag

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3981 AFFECTED FILES mercurial/cmdutil.py tests/test-grep.t CHANGE DETAILS diff --git a/tests/tes

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 updated this revision to Diff 9663. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=9657&id=9663 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py

D3981: grep: add MULTIREV support to --all-files flag

sangeet259 abandoned this revision. sangeet259 added a comment. I created a new revision instead of updating the https://phab.mercurial-scm.org/D3976, ignore this one. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3981 To: sangeet259, #hg-reviewers Cc: mercuri

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 updated this revision to Diff 9664. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=9663&id=9664 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py tests/test-grep.t CHANGE DETAILS diff --git

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a subscriber: yuja. sangeet259 added a comment. @yuja can you review this one REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3976 To: sangeet259, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-d

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a comment. > I don't think we should omit files that were seen in earlier revisions If I don't skip that would mean the same file in the same state being searched across all the revisions, and getting repetitive and redundant hits. One way I think to circumvent this

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a comment. > Keeping all ctx objects might use too much memory. True I will change it to `files[f] = True` REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3976 To: sangeet259, #hg-reviewers Cc: yuja, mercurial-devel _

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a comment. > I also expect hg grep --all-files -r0+1 foo will show matches from both rev 0 and 1. Suppose there are ten hits in 0 and the same 10 hits in 1, do you mean we print out all the 20 results, What purpose that would serve? REPOSITORY rHG Mercurial REVISIO

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a comment. @yuja Cool, sending the option C now, will try out option D and send a patch if something comes up. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3976 To: sangeet259, #hg-reviewers Cc: yuja, mercurial-devel _

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 updated this revision to Diff 9937. sangeet259 edited the summary of this revision. sangeet259 retitled this revision from "grep: add MULTIREV support to --all-files flag" to "grep: add MULTIREV support to --allfiles flag". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https:

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 updated this revision to Diff 10057. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=9937&id=10057 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 updated this revision to Diff 10058. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=10057&id=10058 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 updated this revision to Diff 10059. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=10058&id=10059 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 added a comment. In https://phab.mercurial-scm.org/D3976#64274, @yuja wrote: > Queued with minor cleanup, thanks. > > As a follow up, can you fix `hg grep --all-files -rREVS FILE` to scan > unchanged revisions? Sure REPOSITORY rHG Mercurial REVISION DETAIL h

D3976: grep: add MULTIREV support to --allfiles flag

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf3f109971359: grep: add MULTIREV support to --allfiles flag (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=10059&

D4157: grep: search all commits in allfiles mode

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All the commits are added to the 'wanted' set when allfiles mode is enabled. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4157

D4157: grep: search all commits in allfiles mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd99468d2b09a: grep: search all commits in allfiles mode (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4157?vs=10077&id=1

  1   2   >