Hello there, Can I get a little review on this :)
On Tue, Feb 27, 2018 at 1:58 AM, khanchi97 (Sushil khanchi) <
phabrica...@mercurial-scm.org> wrote:
> khanchi97 updated this revision to Diff 6132.
>
> REPOSITORY
> rHG Mercurial
>
> CHANGES SINCE LAST UPDATE
> htt
# HG changeset patch
# User Sushil khanchi
# Date 1520665399 -19800
# Sat Mar 10 12:33:19 2018 +0530
# Node ID 430c6b5123ee72d3a209882495302e43b26cc988
# Parent 4c71a26a4009d88590c9ae3d64a5912fd556d82e
forget: add --dry-run mode
diff -r 4c71a26a4009 -r 430c6b5123ee mercurial/cmdutil.py
# HG changeset patch
# User Sushil khanchi
# Date 1520665399 -19800
# Sat Mar 10 12:33:19 2018 +0530
# Node ID a1be8989c0158abc69ebd97ca8a0cc7dc3801be9
# Parent 4c71a26a4009d88590c9ae3d64a5912fd556d82e
forget: add --dry-run mode
diff -r 4c71a26a4009 -r a1be8989c015 mercurial/cmdutil.py
# HG changeset patch
# User Sushil khanchi
# Date 1520665399 -19800
# Sat Mar 10 12:33:19 2018 +0530
# Node ID 759f15ef30ea56f6cb190415e8eaa16dcd95c1a8
# Parent 4c71a26a4009d88590c9ae3d64a5912fd556d82e
forget: add --dry-run mode
diff -r 4c71a26a4009 -r 759f15ef30ea mercurial/cmdutil.py
# HG changeset patch
# User Sushil khanchi
# Date 1520665399 -19800
# Sat Mar 10 12:33:19 2018 +0530
# Node ID 4134d1f103d8e72e80920cd89cf3d3f576e6a2b5
# Parent 4c71a26a4009d88590c9ae3d64a5912fd556d82e
forget: add --dry-run mode
diff -r 4c71a26a4009 -r 4134d1f103d8 mercurial/cmdutil.py
# HG changeset patch
# User Sushil khanchi
# Date 1520665399 -19800
# Sat Mar 10 12:33:19 2018 +0530
# Node ID 349b51e3bb04862ff7e516f57509ccd974e1b6a2
# Parent 4c71a26a4009d88590c9ae3d64a5912fd556d82e
forget: add --dry-run mode
diff -r 4c71a26a4009 -r 349b51e3bb04 mercurial/cmdutil.py
Shall I remove --dry-run from context layer now?
On Tue, Mar 13, 2018 at 7:55 PM, Yuya Nishihara wrote:
> On Mon, 12 Mar 2018 18:27:13 -0400, Matt Harbison wrote:
> > On Sun, 11 Mar 2018 05:49:26 -0400, Sushil khanchi
> > wrote:
> >
> > > # HG changeset pat
# HG changeset patch
# User Sushil khanchi
# Date 1520665399 -19800
# Sat Mar 10 12:33:19 2018 +0530
# Node ID bd9d29c4c929d0495e874d0c35d96cae29f5ff72
# Parent 4c71a26a4009d88590c9ae3d64a5912fd556d82e
forget: add --dry-run mode
diff -r 4c71a26a4009 -r bd9d29c4c929 mercurial/cmdutil.py
# HG changeset patch
# User Sushil khanchi
# Date 1521655571 -19800
# Wed Mar 21 23:36:11 2018 +0530
# Node ID 35c57ba0cf288af7c232d0bf17ea8dcb01644d09
# Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd
remove: add dry-run functionality
diff -r b6a4881cec19 -r 35c57ba0cf28 mercurial
# HG changeset patch
# User Sushil khanchi
# Date 1521655571 -19800
# Wed Mar 21 23:36:11 2018 +0530
# Node ID 9f9650a25f12b4e2472c3d315e51c8df41948e24
# Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd
remove: add dry-run functionality
diff -r b6a4881cec19 -r 9f9650a25f12 mercurial
# HG changeset patch
# User Sushil khanchi
# Date 1521655571 -19800
# Wed Mar 21 23:36:11 2018 +0530
# Node ID d63af67f326c7478e062d55fd508012beb164a6e
# Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd
remove: add dry-run functionality
diff -r b6a4881cec19 -r d63af67f326c hgext/largefiles
okay, I will take care of that.
On Fri, Mar 23, 2018 at 7:27 PM, Yuya Nishihara wrote:
> On Thu, 22 Mar 2018 21:54:00 +0530, Sushil khanchi wrote:
> > # HG changeset patch
> > # User Sushil khanchi
> > # Date 1521655571 -19800
> > # Wed Mar 21 23:36:
yeah, It's not working with largefiles. I am trying to solve this issue.
On Sat, Mar 24, 2018 at 8:19 AM, Yuya Nishihara wrote:
> On Sat, 24 Mar 2018 01:32:13 +0530, Sushil khanchi wrote:
> > # HG changeset patch
> > # User Sushil khanchi
> > # Date 1521655571 -1980
# HG changeset patch
# User Sushil khanchi
# Date 1521655571 -19800
# Wed Mar 21 23:36:11 2018 +0530
# Node ID 4d0b9cc7615ad6bbe505819534a93978d9533461
# Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd
remove: add dry-run functionality
diff -r b6a4881cec19 -r 4d0b9cc7615a hgext/largefiles
# HG changeset patch
# User Sushil khanchi
# Date 1521655571 -19800
# Wed Mar 21 23:36:11 2018 +0530
# Node ID d4a3c5969df336e556463a1b0b49132dc907f536
# Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd
remove: add dry-run functionality
diff -r b6a4881cec19 -r d4a3c5969df3 hgext/largefiles
# HG changeset patch
# User Sushil khanchi
# Date 1521655571 -19800
# Wed Mar 21 23:36:11 2018 +0530
# Node ID a041e00e5d8978decf09c6f40fd54bbaf8933f97
# Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd
remove: add dry-run functionality
diff -r b6a4881cec19 -r a041e00e5d89 hgext/largefiles
Shall I send a new patch which will remove opts from scmutil.addremove() ?
Perhaps opts should be removed from scmutil.addremove(), but that's out
> of the scope of this patch.
>
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://
okay, so I have sent another revision which removes `dry_run` and
`similarity` from scmutil.addremove
On Sun, Apr 1, 2018 at 7:27 AM, yuja (Yuya Nishihara) <
phabrica...@mercurial-scm.org> wrote:
> yuja requested changes to this revision.
> yuja added a comment.
> This revision now requires chang
>>
>> This year we have two students selected for Google Summer of Code.
>>
>> * Sangeet Kumar Mishra
>>
>> He will be working the GrepPlan, fixing the behavior of `hg grep`.
>> JordiGH will be primary mentor for him.
>>
>> * Sushil Khanchi
>>
okay, I think following the key rule of VCS would be better. Shall I update
the comment instead?
On Mon, Jun 18, 2018 at 8:50 AM, durin42 (Augie Fackler) <
phabrica...@mercurial-scm.org> wrote:
> durin42 added a comment.
>
>
> In https://phab.mercurial-scm.org/D3756#58937, @indygreg wrote:
>
>
@pulkit I have added a new argument in _prepareabortorcontinue. Now I think
there is no need to split that patch, if I am not wrong. We can leave this
patch here.
Thanks :)
On Fri, Jun 22, 2018 at 7:48 PM, pulkit (Pulkit Goyal) <
phabrica...@mercurial-scm.org> wrote:
> pulkit added inline comment
If we pass that indicator flag for dryrun then we don't have pass that
`leaveunfinished` flag too.
On Mon, Jun 25, 2018 at 6:18 PM, khanchi97 (Sushil khanchi) <
phabrica...@mercurial-scm.org> wrote:
> khanchi97 added a comment.
>
>
> In https://phab.mercurial-scm.org/D
@yuja Is there any command left which we can consider to add
'history-editing-backup' config option?
On Fri, Aug 3, 2018 at 7:14 PM khanchi97 (Sushil khanchi) <
phabrica...@mercurial-scm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
@yuja Thanks.
On Wed, Aug 8, 2018 at 5:34 PM Yuya Nishihara wrote:
> > @yuja Is there any command left which we can consider to add
> > 'history-editing-backup' config option?
>
> Maybe some of these?
>
Right. IIUC, For commands like uncommit, unamend we can't add this config
as they require `ev
.
On Fri, Apr 26, 2019 at 8:29 PM Pierre-Yves David <
pierre-yves.da...@ens-lyon.org> wrote:
>
>
> On 4/19/19 9:49 AM, khanchi97 (Sushil khanchi) wrote:
> > khanchi97 created this revision.
> > Herald added a subscriber: mercurial-devel.
> > Hera
.
On Wed, May 1, 2019 at 5:14 PM Pierre-Yves David <
pierre-yves.da...@ens-lyon.org> wrote:
>
>
> On 5/1/19 1:14 PM, Sushil Khanchi wrote:
> > .
> >
> > On Fri, Apr 26, 2019 at 8:29 PM Pierre-Yves David
> > mailto:pierre-yves.da...@ens-lyon.org>>
>
.
On Wed, May 1, 2019 at 9:22 PM Pierre-Yves David <
pierre-yves.da...@ens-lyon.org> wrote:
> .
>
> On 5/1/19 2:14 PM, Sushil Khanchi wrote:
> > .
> >
> > On Wed, May 1, 2019 at 5:14 PM Pierre-Yves David
> > mailto:pierre-yves.da...@ens-lyon.org>>
&g
Congratulations Taapas and Navaneeth,
I am very excited to work with you and hoping for great summers ahead.
Let's get started :-)
On Thu, May 9, 2019 at 6:15 PM Pulkit Goyal <7895pul...@gmail.com> wrote:
> Hi everyone,
>
> Hope you are doing well.
>
> The results for summer of code are out. We
Thu, May 9, 2019 at 8:53 AM Matt Harbison wrote:
> On Sun, 05 May 2019 14:13:16 -0400, Pierre-Yves David
> wrote:
>
> >
> >
> > On 5/1/19 11:18 PM, Sushil Khanchi wrote:
> >> .
> >> On Wed, May 1, 2019 at 9:22 PM Pierre-Yves David
> >&
I liked this post very much, it gave me a lot of information about
Mercurial.
Thanks for writing it up :)
I wish if I could help in achieving this goal of a new wire protocol.
On Sat, Sep 1, 2018 at 4:17 AM Gregory Szorc
wrote:
> This is a long post and I apologize in advance for that. I've been
LGTM :)
On Sun, Oct 21, 2018 at 12:05 AM martinvonz (Martin von Zweigbergk) <
phabrica...@mercurial-scm.org> wrote:
> martinvonz created this revision.
> Herald added a subscriber: mercurial-devel.
> Herald added a reviewer: hg-reviewers.
>
> REVISION SUMMARY
> manifest.matches() can avoid walk
Oh, yes. It is extension specific configuration.
Abandoning this one.
On Mon, Dec 24, 2018 at 8:41 AM yuja (Yuya Nishihara) <
phabrica...@mercurial-scm.org> wrote:
> yuja added a comment.
>
>
> > +coreconfigitem('experimental', 'evolution.stackaliases',
> > +default=True,
> > +)
>
>
Ready for review.
On Sun 23 Dec, 2018, 6:19 PM khanchi97 (Sushil khanchi) <
phabrica...@mercurial-scm.org wrote:
> khanchi97 updated this revision to Diff 12962.
>
> REPOSITORY
> rHG Mercurial
>
> CHANGES SINCE LAST UPDATE
> https://phab.mercurial-scm.org/D5474?vs=129
Hi,
As I was Google Summer of Code student last year I know how much important
it is for a student to have a mentor who will review the patches or provide
pointer to the right person for a particular topic. I would love to work
with a student and happy to see a new contributor in mercurial communi
@martinvonz I have moved the tests in `test-copies.t`
On Mon, Feb 25, 2019 at 10:58 PM martinvonz (Martin von Zweigbergk) <
phabrica...@mercurial-scm.org> wrote:
> martinvonz added inline comments.
>
> INLINE COMMENTS
>
> > test-copytrace-heuristics.t:724-728
> > + $ cat >> $HGRCPATH << EOF
> >
@martinvonz updated this one too.
On Mon, Feb 25, 2019 at 11:01 PM martinvonz (Martin von Zweigbergk) <
phabrica...@mercurial-scm.org> wrote:
> martinvonz added inline comments.
>
> INLINE COMMENTS
>
> > test-copytrace-heuristics.t:931-980
> > + $ hg graft -r 6 --base c9241b0f2d5b --hidden
> > +
That's totally fine, reviews it when you have time. Thanks :)
On Thu 28 Feb, 2019, 6:08 AM martinvonz (Martin von Zweigbergk) <
phabrica...@mercurial-scm.org wrote:
> martinvonz added a comment.
>
>
> In https://phab.mercurial-scm.org/D5961#87961, @khanchi97 wrote:
>
> > @martinvonz I have mo
Please remove unnecessary blank lines added/removed in your patch. Your
patch should contain the changed related to the issue only. You can always
look at the changes a patch contains using `hg log -p -r rev`.
On Thu, Mar 14, 2019 at 1:44 AM akshjain.jain74 (Akshit Jain) <
phabrica...@mercurial-sc
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
AFFECTED FILES
mercurial/commands.py
tests/test-graft.t
CHANGE DETAILS
diff --git a/tests/te
khanchi97 added a comment.
Hello Pulkit,
After spending some time with graft implementation, I hope now I have a good
understanding of how graft is working.
Let me tell you what I have understood and how I want to implement
`--no-commit` mode. So when we hit a merge conflict what we do is
khanchi97 updated this revision to Diff 6132.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2409?vs=6028&id=6132
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
AFFECTED FILES
mercurial/commands.py
tests/test-graft.t
CHANGE DETAILS
diff --gi
khanchi97 updated this revision to Diff 6325.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2409?vs=6132&id=6325
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
AFFECTED FILES
mercurial/commands.py
tests/test-graft.t
CHANGE DETAILS
diff --gi
khanchi97 added a comment.
What I did to store `--no-commit` flag in `graftstate` is:
Add a flag `True/False` in 1st line of `graftstate` and keep it updated from
previous value in `graftstate` for every iteration in `revs`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercuri
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2579
AFFECTED FILES
hgext/mq.py
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py b/hge
khanchi97 added a comment.
I don't know if this is the right way to catch `unshelve` run because it is
breaking so many things. May be there is some other way to catch a `unshelve`
run so that I can disable those checks. Although it is working for the case
mentioned in the issue.
REPOSITORY
khanchi97 updated this revision to Diff 6538.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2409?vs=6325&id=6538
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
AFFECTED FILES
mercurial/commands.py
tests/test-graft.t
CHANGE DETAILS
diff --gi
khanchi97 added a comment.
I have added tests to show the behavior of --no-commit with other flags.
INLINE COMMENTS
> pulkit wrote in commands.py:2309
> To be honest I am not fan of storing data in such format, but that's how we
> store data right now. I have finally a series in review where
khanchi97 added a comment.
pulkit: Can you please review it? I have made the requested changes.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
To: khanchi97, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Also added confirmopts in cmdutil.py
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2934
AFFECTED FILES
mercurial/cmdutil.py
m
khanchi97 updated this revision to Diff 7254.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2934?vs=7252&id=7254
REVISION DETAIL
https://phab.mercurial-scm.org/D2934
AFFECTED FILES
mercurial/cmdutil.py
mercurial/commands.py
tests/test-add.t
tes
khanchi97 updated this revision to Diff 7285.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2934?vs=7254&id=7285
REVISION DETAIL
https://phab.mercurial-scm.org/D2934
AFFECTED FILES
mercurial/cmdutil.py
mercurial/commands.py
tests/test-add.t
tes
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3000
AFFECTED FILES
contrib/perf.py
hgext/largefiles/overrides.py
mercurial/cmdutil.py
mercuria
khanchi97 added a subscriber: yuja.
khanchi97 added a comment.
I ran all the tests those are related to addremove and they are passing.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3000
To: khanchi97, #hg-reviewers
Cc: yuja, mercurial-devel
___
khanchi97 added a comment.
I have made the requested changes. Now --confirm will prompt per file and
also added all/skip option which will either include all the remaining files or
skip all the remaining files according the user input.
INLINE COMMENTS
> av6 wrote in cmdutil.py:2007
> "canno
khanchi97 updated this revision to Diff 7500.
khanchi97 retitled this revision from "addremove: remove opts from
scmutil.addremove" to "addremove: remove dry_run, similarity from
scmutil.addremove".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3000?vs=7
khanchi97 updated this revision to Diff 7523.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3000?vs=7500&id=7523
REVISION DETAIL
https://phab.mercurial-scm.org/D3000
AFFECTED FILES
contrib/perf.py
hgext/largefiles/overrides.py
mercurial/commands.
khanchi97 updated this revision to Diff 7524.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3000?vs=7523&id=7524
REVISION DETAIL
https://phab.mercurial-scm.org/D3000
AFFECTED FILES
contrib/perf.py
hgext/largefiles/overrides.py
mercurial/commands.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG14cd5290c4e6: addremove: remove dry_run, similarity from
scmutil.addremove (API) (authored by khanchi97, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D3000?vs=7524&id=7535#toc
khanchi97 created this revision.
khanchi97 added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Added the logic to count the number of csets whose phases will be changed,
for now it just prints the same stats as we get wi
khanchi97 updated this revision to Diff 7874.
khanchi97 retitled this revision from "phase: Add dry-run functionality" to
"phase: add dry-run functionality".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3187?vs=7873&id=7874
REVISION DETAIL
https://pha
khanchi97 updated this revision to Diff 7877.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3187?vs=7874&id=7877
REVISION DETAIL
https://phab.mercurial-scm.org/D3187
AFFECTED FILES
mercurial/commands.py
tests/test-completion.t
tests/test-phases.t
khanchi97 added a comment.
@pulkit Can you please review it?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3187
To: khanchi97, pulkit, #hg-reviewers
Cc: av6, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe7bf5a73e4e1: forget: add --confirm option (authored by
khanchi97, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2934?vs=7285&id=8362#toc
REPOSITORY
rHG Mercurial
CHANGES
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
So I have added some code to check how my
patch will be look like.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2276
AFFECTED
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2278
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py b/mercu
khanchi97 updated this revision to Diff 5778.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2278?vs=5760&id=5778
REVISION DETAIL
https://phab.mercurial-scm.org/D2278
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/command
khanchi97 updated this revision to Diff 5794.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2278?vs=5778&id=5794
REVISION DETAIL
https://phab.mercurial-scm.org/D2278
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/command
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGff36116f30f3: bundle: updates the help text for hg bundle
(issue5744) (authored by khanchi97, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2278?vs=5794&id=5809#toc
REPOSITOR
khanchi97 added a comment.
Okay, I will take care of that.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2278
To: khanchi97, #hg-reviewers, yuja
Cc: pulkit, yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercu
khanchi97 added a comment.
In https://phab.mercurial-scm.org/D2934#54295, @pulkit wrote:
> In https://phab.mercurial-scm.org/D2934#54256, @yuja wrote:
>
> > The change looks good, but new behavior sounds more like `--interactive`
> > than `--confirm`.
>
>
> I agree. @khanchi97
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3405
AFFECTED FILES
hgext/largefiles/overrides.py
mercurial/cmdutil.py
mercurial/commands.py
me
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf10cb49951e1: forget: rename --confirm to --interactive
(authored by khanchi97, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D3405?vs=8379&id=8381#toc
REPOSITORY
rHG Mercur
khanchi97 added a comment.
In https://phab.mercurial-scm.org/D2409#44682, @pulkit wrote:
> In https://phab.mercurial-scm.org/D2409#43891, @khanchi97 wrote:
>
> > pulkit: Can you please review it? I have made the requested changes.
>
>
> I am sorry but I will like this to wait bef
khanchi97 added a comment.
okay, but I have some queries like
1. How about showing revision no. instead of cset id?
2. And in this https://pastebin.com/raw/kWcr9xVK example if I change revision
2 phase to --secret then how it should print the range, I mean now we have
branches in this
khanchi97 updated this revision to Diff 8896.
khanchi97 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3187?vs=7877&id=8896
REVISION DETAIL
https://phab.mercurial-scm.org/D3187
AFFECTED FILES
mercurial/commands.py
khanchi97 added a comment.
@pulkit Now I moved the logic for finding revs (those phase will change) to
advanceboundry and retractboundry function and for now it shows all nodes. I am
working to show range instead. Take a look at this when you are free :)
REPOSITORY
rHG Mercurial
REVISION
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Added logic to find those csets whose phase will be changed (when
running without --dryrun) while advancing boundary. And make it return
rejected and changed c
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Added the logic to find those csets whose phase will be changed
without dry-run while retracting boundary and return those csets.
REPOSITORY
rHG Mercurial
RE
khanchi97 added inline comments.
INLINE COMMENTS
> pulkit wrote in phases.py:369
> why are we maintaining this rejected list?
rejected list will contain those csets which will be rejected during advancing
boundary and then return this list so that we can report for rejected csets
during dry_ru
khanchi97 added inline comments.
INLINE COMMENTS
> khanchi97 wrote in phases.py:371
> I thought we would calculate `rejected` only when we are in dryrun mode.
okay its fine. I will remove this unnecessary condition. Because I think
`rejected` value can also be used in `phase` method of `mercuri
khanchi97 updated this revision to Diff 8940.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3671?vs=8928&id=8940
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
AFFECTED FILES
mercurial/phases.py
CHANGE DETAILS
diff --git a/mercurial/phases.py
khanchi97 updated this revision to Diff 8947.
khanchi97 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3671?vs=8940&id=8947
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
AFFECTED FILES
mercurial/phases.py
C
khanchi97 updated this revision to Diff 8948.
khanchi97 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3672?vs=8929&id=8948
REVISION DETAIL
https://phab.mercurial-scm.org/D3672
AFFECTED FILES
mercurial/phases.py
C
khanchi97 updated this revision to Diff 8949.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3671?vs=8947&id=8949
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
AFFECTED FILES
mercurial/phases.py
CHANGE DETAILS
diff --git a/mercurial/phases.py
khanchi97 updated this revision to Diff 8950.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3671?vs=8949&id=8950
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
AFFECTED FILES
mercurial/phases.py
CHANGE DETAILS
diff --git a/mercurial/phases.py
khanchi97 added inline comments.
INLINE COMMENTS
> pulkit wrote in phases.py:395
> Add documentation about dry-run and the return value.
okay
> pulkit wrote in phases.py:417
> Why are we not using this affected set here to find the changesets whose
> phase is changed?
Because I think this aff
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now options --user and --date can be reapplied after we hit a conflict.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3678
AFFECT
khanchi97 updated this revision to Diff 8953.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2409?vs=6538&id=8953
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
AFFECTED FILES
mercurial/commands.py
tests/test-graft.t
CHANGE DETAILS
diff --gi
khanchi97 added a comment.
In https://phab.mercurial-scm.org/D2409#57814, @pulkit wrote:
> In https://phab.mercurial-scm.org/D2409#56200, @khanchi97 wrote:
>
> > @pulkit do we have new state format pushed in?
>
>
> Yep, you can go ahead and rebase this patch to make it use the ne
khanchi97 updated this revision to Diff 8955.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2409?vs=8953&id=8955
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
AFFECTED FILES
mercurial/commands.py
tests/test-graft.t
CHANGE DETAILS
diff --gi
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG36ba5dba372d: advanceboundary: add dryrun parameter
(authored by khanchi97, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D3671?vs=8950&id=8957#toc
REPOSITORY
rHG Mercurial
khanchi97 updated this revision to Diff 8958.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2409?vs=8955&id=8958
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
AFFECTED FILES
mercurial/commands.py
tests/test-graft.t
CHANGE DETAILS
diff --gi
khanchi97 updated this revision to Diff 8959.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3672?vs=8948&id=8959
REVISION DETAIL
https://phab.mercurial-scm.org/D3672
AFFECTED FILES
mercurial/phases.py
CHANGE DETAILS
diff --git a/mercurial/phases.py
khanchi97 updated this revision to Diff 8960.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3672?vs=8959&id=8960
REVISION DETAIL
https://phab.mercurial-scm.org/D3672
AFFECTED FILES
mercurial/phases.py
CHANGE DETAILS
diff --git a/mercurial/phases.py
khanchi97 updated this revision to Diff 8961.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2409?vs=8958&id=8961
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
AFFECTED FILES
mercurial/commands.py
tests/test-completion.t
tests/test-graft.t
khanchi97 updated this revision to Diff 8962.
khanchi97 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3187?vs=8896&id=8962
REVISION DETAIL
https://phab.mercurial-scm.org/D3187
AFFECTED FILES
mercurial/commands.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad50f0399e1e: graft: correct documentation about options
can be reapplied (authored by khanchi97, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3
khanchi97 added a comment.
In https://phab.mercurial-scm.org/D3678#57907, @yuja wrote:
> Queued per review, thanks.
>
> > The -c/--continue option does not reapply earlier options, except
> >
> > - for --force. + for --force, --user and --date.
>
> Does it mean --curre
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
For now, it just notify that if we will hit a conflict or not, but
we can improve this like making it a --confirm flag or by showing the
graph that would resul
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3756
AFFECTED FILES
hgext/rebase.py
tests/test-rebase-abort.t
CHANGE DETAILS
diff --git a/tests/t
1 - 100 of 383 matches
Mail list logo
