D12579: chg: make `chg --cwd $anything -R $relativepath` behave better

2022-04-27 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We're seeing this kind of issue: $ (cd repo1; chg --cwd ../repo2 -R .) + chg: abort: too many redirections. + Please make sure $path/h

D12427: dispatch: stop sometimes generating silly blackbox entries

2022-04-01 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When hg is interrupted, it creates ui.log like this: 1970/01/01 00:00:00 user @ (62488)> killed! exit

D12402: streamclone: avoid some obscure error in a corner case

2022-03-24 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I don't really know how, but I ran into this error: $ hg clone --stream ssh://user@dummy/empty-repo local-empty-repo streaming all changes

D12155: sparse: rework debugsparse's interface

2022-02-08 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY hg debugsparse supports arguments like --include, similar to `hg tracked --addinclude` or `hg log --include`. But in `hg debugsparse`, the pattern

D12006: blackbox: change year in logs to ISO 8601 format

2022-01-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY AFAIK, year/month/day is not a format than anyone uses. It seems more sensible to me to use ISO 8601, as that's standard and unambiguously year-mo

D12005: blackbox: add milliseconds to blackbox logs by default

2022-01-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The current second granularity is often not specific enough to determine whether an hg command is happening before or after some other event.

D12004: blackbox: correct date format doc

2022-01-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12004 AFFECTED FILES hgext/blackbox.py CHANGE DETAILS diff --git a/h

D11750: commit: prevent possible race that results in bad dirstate

2021-11-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'm getting reports of wrongly clean hg status, that get fixed by running hg debugrebuilddirstate, which I suspect is the issue below. And if it's

D11749: test: add test of a race resulting in bad dirstate

2021-11-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Specifically, the size stored in the dirstate is wrong. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.or

D11490: bookmarks: add an option to make pull mirror local bookmarks

2021-09-22 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For backups for instance. Merging bookmarks is not a useful behavior in that case. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11400: narrow: fix commits of empty files

2021-09-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The problem is that when committing a new file with empty contents (or in general empty file with filelog p1 = -1)

D11399: narrow: show repo corruption when commiting empty files

2021-09-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11399 AFFECTED FILES tests/test-narr

D11361: tests: normalize the way some debug output it matched

2021-08-27 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11361 AFFECTED FILES tests/test-debugcommands.t tests/test-ssh-proto

D11265: debugrebuildfncache: add a cheaper option to rebuild the fncache

2021-08-06 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY On my repository, debugrebuildfncache takes 5-10min with the lock. With the flag added in this commit, it takes 10s. The tradeoff is that it on

D11264: test: reduce noise, so the important bits stand out

2021-08-06 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11264 AFFECTED FILES tests/test-transaction-rollback-on-revlog-split.t

D11248: store: return just one filename in walk functions

2021-08-04 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Various walk functions return `(revlog_type, decoded, encoded)` where decoded

D11245: tests: rely on dummyssh being the default

2021-08-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This commit is exactly the result of running this command: sed -i -e 's! *\(-e \|--ssh \|--config ui.ssh=\)[ \"]*$PYTHON[ \"]*$\(RUN\|\)TESTDIR/

D11246: tests: manual cleanup now that dummyssh usage is implied

2021-08-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11246 AFFECTED FILES tests/library-infinitepush.sh tests/narrow-libr

D11247: tests: drop hgrc bits that have become the default

2021-08-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11247 AFFECTED FILES tests/test-bookmarks-corner-case.t CHANGE DETAIL

D11244: tests: setup dummyssh as the default ssh

2021-08-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY To significantly reduce boilerplate in tests. One test is updated to show that it works, I expect to do the rest in follow up commits. REPOSITORY

D11243: remotefilelog: fix what looks like a wrong refactoring

2021-08-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY when various store functions started returning a revlog type as the first element of the tuple. REPOSITORY rHG Mercurial BRANCH default REVIS

D11237: tests: rename test-clone-uncompressed.t

2021-08-01 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY as clone --uncompressed is deprecated in favor of --stream REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm

D11236: streamclone: ensure the server sends the right amount of data

2021-08-01 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Otherwise, the client would fail with some confusing error. I have seen an error which I think is this, perhaps due to a concurrent revlog split,

D11212: wireprotov1peer: update all rpcs to use the new batchable scheme

2021-07-25 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If desired, we could keep the future class and the function that upgrades an old style rpc instead of a new style, for extensions. REPOSITORY rHG

D11211: wireprotov1peer: simplify the way batchable rpcs are defined

2021-07-25 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The scheme with futures/generator is confusing due to the way communication is done by side effects, especially with two different "future" object

D10757: test: remove some unnecessary dependency on repo format

2021-05-20 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10757 AFFECTED FILES tests/test-transaction-rollback-on-sigpipe.t CHA

D10715: revlog: make transaction handle revlog splits better (issue6423)

2021-05-16 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Currently, any transaction that includes a revlog split and does not successfully commit prevents any further wri

D10713: revlog: fix the the computation of indexes on revlog split

2021-05-16 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It probably got broken in 63edc384d3b7

D10714: transaction: trivial refactoring

2021-05-16 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10714 AFFECTED FILES mercurial/transaction.py CHANGE DETAILS diff --

D10712: tests: show that hg fails to rollback transaction on revlog split

2021-05-16 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10712 AFFECTED FILES mercurial/transaction.py tests/test-transaction

D10318: revlog: fix error about unknown compression format in py3

2021-04-06 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY In py2, the error is something like: abort: unknown compression type 'x'! In py3, we get the following unhel

D10293: blackbox: fix type error on log rotation on read-only filesystem

2021-03-31 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Grepping around, the code uses either encoding.strtolocal or stringutil.forcebytestr in this situation. No idea which is best. REPOSITORY rHG Mer

D10074: wireprotov1peer: don't raise internal errors in some cases

2021-02-25 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Specifically, when the peer is closed in the middle of a batch of rpcs. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.

D10073: sshpeer: don't fail forwarding output from closed connections

2021-02-25 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The test still shows an internal error, but one that happens further along. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https:/

D10072: test: show internal exception with batchable rpcs over ssh

2021-02-25 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10072 AFFECTED FILES tests/test-ssh-batch.t CHANGE DETAILS diff --gi

D9999: sshpeer: enable+fix warning about sshpeers not being closed explicitly

2021-02-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I recommend looking at this with a diff that ignores indentation. The test

D9998: sshpeer: add a develwarning if an sshpeer is not closed explicitly

2021-02-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The warning is disabled until the next commit, because fixing it results in a noisy diff due to indentation changes. REPOSITORY rHG Mercurial BR

D9996: sshpeer: add a method to check if a doublepipe is closed

2021-02-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY So we can tell in a next commit if we're trying to close an already closed connection or not (in which case, we may warn). REPOSITORY rHG Mercuri

D9997: remotefilelog: rework workaround for sshpeer deadlocks

2021-02-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The wrapping of `sshpeer.cleanup` silently broke when `cleanup` was renamed to `_cleanup`, a couple of years ago. I don't know what `orig.im_se

D9995: sshpeer: make sshpeer.close() close the underlying connection

2021-02-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY So the connection can be closed eagerly in future commits, instead of relying on __del__. REPOSITORY rHG Mercurial BRANCH default REVISION DE

D9285: strip: move into core

2020-11-08 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As discussed at the 5.2 sprint, replace strip extension by a core command, debugstrip. Obviously, the extension stays for backwards compatibility

D9284: purge: move extension into core mercurial

2020-11-08 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The motivation is simple: it's nicer to avoid gating basic functionality. To reduce the risk of people shooting themselves in the feet, `hg p

D9021: fsmonitor: increase the threshold before we recommend it, when using rust

2020-09-14 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY 50k files works just fine with the rust status, and it's annoying to get told "consider using fsmonitor" when we have another solution to the stat

D9020: sshpeer: avoid having a destructor that can block forks forever

2020-09-14 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is solution 2. that was described in the previous commit. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial

D9019: procutil: avoid using os.fork() to implement runbgcommand

2020-09-14 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY NB: this only works with py3. I'm hoping that maybe it won't be necessary to support py2 in a couple of months? We ran into the following deadl

D9006: chg: make is possible to call by default an hg binary located next to chg

2020-09-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When a single version of hg is in use and it's in the PATH, using chg is just a matter of calling chg. But when there are multiple installation

D8603: rust: add a pointer for profiling to the README

2020-05-30 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As figuring out how to get useful profiles is not obvious. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm

D8604: relnotes: advertize the possibility to use rust

2020-05-30 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I think the rust work may have been mentioned in the release notes, but if so only in passing, and not as an invitation to try it out. I think

D8602: rust: update the mention of hgcli in rust/README.rst

2020-05-30 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This may not be exactly right, but it's better than before. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-sc

D8601: rust: remove one more occurrence of re2

2020-05-30 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8601 AFFECTED FILES rust/README.rst CHANGE DETAILS diff --git a/rust

D8600: scmutil: clarify getuipathfn comment

2020-05-30 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8600 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a

D8586: files: speed up `hg files` when no flags change display

2020-05-26 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It's not the first time I see slowness from this command slow down tools built on top of hg. The majority of the time is spent merely printing

D8585: scmutil: speed up relativization of paths when it's a no-op

2020-05-26 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Running commands from the root is commmon, in particular for automation. Running `hg files > /tmp/a` from the root of mozilla-central on linux:

D8584: sshpeer: make client print (likely) server errors on stderr

2020-05-26 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY so `hg clone -q` or `hg pull -q` don't print `abort: no suitable response from remote hg!` with no indication of what went wrong. There are oth

D8583: sshpeer: add test showing that -q silences remote errors

2020-05-26 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8583 AFFECTED FILES tests/test-ssh.t CHANGE DETAILS diff --git a/tes

D8582: grep: reduce the cost of pathauditor checks when grepping working copy

2020-05-25 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Running `time hg grep zxczxczxczxczxc -l` on mozilla-central: before: real0m20,000s user0m15,796s sys 0m4,189s

D8581: grep: test that paths get audited

2020-05-25 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8581 AFFECTED FILES tests/test-grep.t CHANGE DETAILS diff --git a/te

D8580: grep: add test coverage of behavior on symlinks

2020-05-25 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8580 AFFECTED FILES tests/test-grep.t CHANGE DETAILS diff --git a/te

D8545: grep: grep the working copy faster

2020-05-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY `hg grep ` in the mercurial repo: before: 0,859s after: 0,233s `hg grep somethingwithnomatch` in mozilla-central: before: 51s after:

D8544: grep: stop computing information for --diff when unnecessary

2020-05-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is one reason why `hg grep pattern` essentially does `hg cat -r . 'set:**'` inside. There is no speed improvement in this commit, because the

D8543: grep: don't go in an infinite loop when given empty regex

2020-05-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8543 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE

D8542: grep: improve test coverage

2020-05-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8542 AFFECTED FILES tests/test-grep.t CHANGE DETAILS diff --git a/te

D8538: rust: fix warning about unnecessary mut

2020-05-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If there's a reason to use mut (like compability with older compilers), then we should stick `#[allow(unused_mut)]` on the declaration. REPOSITOR

D8537: setup: stop asking cargo to spam

2020-05-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It prints this kind of stuff by default: Compiling regex v1.3.6 Compiling rand v0.7.3 Compiling crossbeam-deque v0.7.3 which is wa

D8523: py3: fix exception in pull when several things happen to a bookmark

2020-05-14 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Specifically, when `changes` is: [(b'@upstream-committed', None, , b'updating bookmark @upstream-committed\n'), (b'@upstream-committed',

D8423: graft: exit 1 on conflicts, like merge

2020-04-16 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG16c361152133: graft: exit 1 on conflicts, like merge (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8423?vs=21088&id=21142 CH

D8423: graft: exit 1 on conflicts, like merge

2020-04-14 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's more consistent, and makes it nicer to script around hg if you don't have to ignore exit code 255, which is the error code for basically everyt

D8203: logtoprocess: avoid traceback when running long commands

2020-03-03 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG69392460f7b1: logtoprocess: avoid traceback when running long commands (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8204: update: simplify slightly

2020-03-03 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG1e508097f570: update: simplify slightly (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8204?vs=20416&id=20418 CHANGES SINCE L

D8204: update: simplify slightly

2020-03-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8204 AFFECTED FILES mercurial/commands.py tests/test-update-branches.t

D8203: logtoprocess: avoid traceback when running long commands

2020-03-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron updated this revision to Diff 20415. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8203?vs=20414&id=20415 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8203/new/ REVISION DETAIL https://phab.mercuria

D8203: logtoprocess: avoid traceback when running long commands

2020-03-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY $ hg log -r "present($(yes | tr -d '\n' | head -c 13))" "$(yes | tr -d '\n' | head -c 5000)" --config extensions.logtoprocess= --config logtoproce

D8201: help: clarify behavior of server.concurrent-push-mode

2020-03-02 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHGc85d5fd1a5d9: help: clarify behavior of server.concurrent-push-mode (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8201?vs=204

D8201: help: clarify behavior of server.concurrent-push-mode

2020-03-01 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY So it doesn't seemingly say that old clients cannot talk to server configured with concurrent-push-mode=check-related. They can, they just don't get

D8151: relnotes: move entry to the right spot

2020-02-27 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHGefd73cdcfbac: relnotes: move entry to the right spot (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8151?vs=20316&id=20352 CH

D8151: relnotes: move entry to the right spot

2020-02-26 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It appears a conflict resolution went wrong. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8151 AFFE

D8127: graft: always allow hg graft --base . (issue6248)

2020-02-26 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG2e534a710b15: graft: always allow hg graft --base . (issue6248) (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mer

D8116: bookmarks: refactor in preparation for next commit

2020-02-21 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron added a comment. Sorry, I had tried installing black, but it was not the right version. After looking some more, `pip3 install black` is what was needed I think. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8116/new/ REVISION DE

D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote)

2020-02-21 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG8407031f195f: bookmarks: prevent pushes of divergent bookmarks (foo@remote) (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D8117?vs=20246&id=20272#toc REPOS

D8116: bookmarks: refactor in preparation for next commit

2020-02-21 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG0275000564c4: bookmarks: refactor in preparation for next commit (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D8116?vs=20210&id=20271#toc REPOSITORY rHG

D8124: bookmarks: avoid traceback when two pushes race to delete the same bookmark

2020-02-21 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHGedaae3616ba3: bookmarks: avoid traceback when two pushes race to delete the same bookmark (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercuria

D8123: relnotes: add entry about previous `hg recover` change

2020-02-21 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG815c63526d1d: relnotes: add entry about previous `hg recover` change (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8123?vs=20

D8127: graft: always allow hg graft --base . (issue6248)

2020-02-17 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `hg graft --base . -r abc` is rejected before this change with a "nothing to merge" error, if `abc` does not descend from `.`. This looks like an

D8124: bookmarks: avoid traceback when two pushes race to delete the same bookmark

2020-02-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `hg push -f -B remote-only-bookmark` can raise server-side in `bookmarks._del` (specifically in `self._refmap.pop(mark)`), if the remote-only bookma

D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote)

2020-02-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron updated this revision to Diff 20246. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8117?vs=20211&id=20246 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8117/new/ REVISION DETAIL https://phab.mercuria

D8123: relnotes: add entry about previous `hg recover` change

2020-02-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8123 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git a/relnotes

D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote)

2020-02-13 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this change, such bookmarks are write-only: a client can push them but not pull/read them. And because these bookmark can't be read, even pus

D8116: bookmarks: refactor in preparation for next commit

2020-02-13 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8116 AFFECTED FILES mercurial/bookmarks.py CHANGE DETAILS diff --git a

D7972: recover: don't verify by default

2020-02-12 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG7a4e1d245f19: recover: don't verify by default (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7972?vs=19520&id=20168 CHANGES

D7972: recover: don't verify by default

2020-02-11 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron added a comment. > I _think_ it's just paranoia. As long as the bundle wasn't woefully corrupt, it shouldn't be a problem. I _think_ if we set some of the [server]-section bundle validation options (which should be cheap enough) we could ditch this completely safely. >

D8101: help: when possible, indicate flags implied by tweakdefaults

2020-02-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG5830efce522b: help: when possible, indicate flags implied by tweakdefaults (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITOR

D8100: help: add a mechanism to change flags' help depending on config

2020-02-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG142d2a4cb69a: help: add a mechanism to change flags' help depending on config (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8

D8093: tags: add a debug command to display .hg/cache/hgtagsfnodes1

2020-02-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHGd8b53385b1bc: tags: add a debug command to display .hg/cache/hgtagsfnodes1 (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8093

D8096: purge: add -i flag to delete ignored files instead of untracked files

2020-02-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG9f8eddd2723f: purge: add -i flag to delete ignored files instead of untracked files (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.

D8095: tags: behave better if a tags cache entry is partially written

2020-02-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHGf5a7cf0adb12: tags: behave better if a tags cache entry is partially written (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D80

D8094: tags: show how hg behaves if a tags cache entry is truncated

2020-02-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG89d44cfcdeeb: tags: show how hg behaves if a tags cache entry is truncated (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8094

D8096: purge: add -i flag to delete ignored files instead of untracked files

2020-02-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron added a comment. I thought it was generally preferred to have the `False` in the code, for extensions that want to call the function? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8096/new/ REVISION DETAIL https://phab.mercuria

D8096: purge: add -i flag to delete ignored files instead of untracked files

2020-02-10 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron updated this revision to Diff 20050. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8096?vs=20031&id=20050 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8096/new/ REVISION DETAIL https://phab.mercuria

D8101: help: when possible, indicate flags implied by tweakdefaults

2020-02-09 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8101 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py CHANGE

D8100: help: add a mechanism to change flags' help depending on config

2020-02-09 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems reasonable to have a similar mechanism for the rest of the help, but no such thing is implemented. The goal is to make the help of comma

  1   2   3   >