https://bz.mercurial-scm.org/show_bug.cgi?id=6045

            Bug ID: 6045
           Summary: phabsend can leave orphaned children
           Product: Mercurial
           Version: 4.8.1
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: feature
          Priority: wish
         Component: Mercurial
          Assignee: bugzi...@mercurial-scm.org
          Reporter: matt_harbi...@yahoo.com
                CC: mercurial-devel@mercurial-scm.org

It's a corner case, and I'm not sure if there's a lot of value to submitting
non-contiguous commits (maybe to skip a large binary artifact?).  In any event,
this simple graph...

@  changeset:   48128:d6805464fb32
|  tag:         tip
|  user:        Matt Harbison <matt_harbi...@yahoo.com>
|  date:        Sun Dec 30 22:46:54 2018 -0500
|  summary:     exthelper: switch to using the registrar merging method
|
o  changeset:   48127:94d4ffb62049
|  parent:      48125:a567c612e909
|  user:        Matt Harbison <matt_harbi...@yahoo.com>
|  date:        Sun Dec 30 21:52:26 2018 -0500
|  summary:     registrar: add a method to merge registrar instances
|
o  changeset:   48125:a567c612e909
|  parent:      48123:88d813cd9acd
|  user:        Matt Harbison <matt_harbi...@yahoo.com>
|  date:        Sat Dec 29 01:51:02 2018 -0500
|  summary:     phabricator: ensure that the return of urlopener.open() is
closed
|
o  changeset:   48123:88d813cd9acd
|  bookmark:    @
~  user:        Boris Feld <boris.f...@octobus.net>
   date:        Thu Dec 20 09:59:16 2018 +0100
   summary:     revlog: fix pure python slicing test when chain contains
nullrev

... becomes this:

@  changeset:   48130:6b6598c10048
|  tag:         tip
|  parent:      48127:94d4ffb62049
|  user:        Matt Harbison <matt_harbi...@yahoo.com>
|  date:        Sun Dec 30 22:46:54 2018 -0500
|  instability: orphan
|  summary:     exthelper: switch to using the registrar merging method
|
| o  changeset:   48129:85ed6e9bdd42
| |  parent:      48123:88d813cd9acd
| |  user:        Matt Harbison <matt_harbi...@yahoo.com>
| |  date:        Sat Dec 29 01:51:02 2018 -0500
| |  summary:     phabricator: ensure that the return of urlopener.open() is
closed
| |
* |  changeset:   48127:94d4ffb62049
| |  parent:      48125:a567c612e909
| |  user:        Matt Harbison <matt_harbi...@yahoo.com>
| |  date:        Sun Dec 30 21:52:26 2018 -0500
| |  instability: orphan
| |  summary:     registrar: add a method to merge registrar instances
| |
x |  changeset:   48125:a567c612e909
|/   parent:      48123:88d813cd9acd
|    user:        Matt Harbison <matt_harbi...@yahoo.com>
|    date:        Sat Dec 29 01:51:02 2018 -0500
|    obsolete:    reworded using phabsend as 48129:85ed6e9bdd42
|    summary:     phabricator: ensure that the return of urlopener.open() is
closed
|
o  changeset:   48123:88d813cd9acd
|  bookmark:    @
|  user:        Boris Feld <boris.f...@octobus.net>
|  date:        Thu Dec 20 09:59:16 2018 +0100
|  summary:     revlog: fix pure python slicing test when chain contains
nullrev

when submitting 48125+48128.

I was going to suggest disallowing gaps if we don't want to handle this case,
but it looks like a similar result occurs when running phabsend on any non
head.  Since the stack would auto-stabilize if the selection is contiguous, I'm
not sure if the feature should be to always auto-stabilize the range (or maybe
start to head?) in phabricator, or if this is an evolve feature.  (Think auto
rewrite the stack after meta-editing a commit message several commits deep.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to