[Differential] [Commented On] D57: match: write forceincludematcher using unionmatcher

2017-07-12 Thread dsp (David Soria Parra)
dsp added a comment. I am slightly -1 on this, as it removes `__repr__` for forceincludematcher. This would lead to remove information from `hg debugwalk`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D57 EMAIL PREFERENCES https://phab.mercurial-scm.org/sett

[Differential] [Commented On] D57: match: write forceincludematcher using unionmatcher

2017-07-12 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D57#731, @dsp wrote: > I am slightly -1 on this, as it removes `__repr__` for forceincludematcher. This would lead to remove information from `hg debugwalk`. What arguments do you pass to "hg debugwalk" to get a forcein

[Differential] [Commented On] D57: match: write forceincludematcher using unionmatcher

2017-07-12 Thread durham (Durham Goode)
durham added a comment. makeittso Might be nice to have unit tests for matchers, now that they're getting some complications. REPOSITORY rHG Mercurial REVISION DETAIL https

[Differential] [Commented On] D57: match: write forceincludematcher using unionmatcher

2017-07-12 Thread dsp (David Soria Parra)
dsp added a comment. In https://phab.mercurial-scm.org/D57#735, @martinvonz wrote: > What arguments do you pass to "hg debugwalk" to get a forceincludematcher? You are right, as we don't use forceincludematcher inside match() it never gets into debugwalk. Your patch seems fine. R