[Differential] [Commented On] D62: rebase: add config to move rebase into a single transaction

durham added a comment. In https://phab.mercurial-scm.org/D62#790, @phillco wrote: > Though, it's interesting, it looks like I have the ability to accept as `hg`. I presume I'll need to keep unchecking that so I don't accidentally pretend to be a core reviewer. Anyone can accept

[Differential] [Commented On] D62: rebase: add config to move rebase into a single transaction

durham added inline comments. INLINE COMMENTS > martinvonz wrote in rebase.py:721 > Won't this and tr's context manager together double-close the transaction? The context manage will only call tr.release(),since it's an exception exit path. REPOSITORY rHG Mercurial REVISION DETAIL https:/

[Differential] [Commented On] D62: rebase: add config to move rebase into a single transaction

martinvonz added inline comments. INLINE COMMENTS > rebase.py:721 > +except error.InterventionRequired: > +tr.close() > +raise Won't this and tr's context manager together double-close the transaction? REPOSITORY rHG Mercurial REVISION DETAIL htt

[Differential] [Commented On] D62: rebase: add config to move rebase into a single transaction

phillco added a comment. lgtm INLINE COMMENTS > util.py:592-594 > +class nullcontextmanager(object): > +"""A no-op context manager. > +""" Thanks, I was looking for something like this on one of my branches! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.or