martinvonz added inline comments.

INLINE COMMENTS

> durham wrote in rebase.py:721
> The context manage will only call tr.release(),since it's an exception exit 
> path.

Ah, right.

Anyway, once https://phab.mercurial-scm.org/D66 is in, you should be able to 
simplify this to:

  tr = None
  if singletr = ui.configbool('rebase', 'singletransaction'):
      tr = repo.transaction('rebase')
  with util.acceptintervention(tr):
      rbsrt._performrebase(tr)

So it seems best to wait for that to land.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D62

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: durham, #hg, martinvonz, phillco
Cc: phillco, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to