Re: [PATCH] committablectx: extra is already normalized

2017-06-02 Thread Martin von Zweigbergk via Mercurial-devel
On Fri, Jun 2, 2017 at 7:35 PM, Yuya Nishihara wrote: > On Wed, 31 May 2017 17:11:57 -0700, Jun Wu wrote: >> Looks good to me. I'd mention extra is normalized by "changelog.add" in >> commit message. > > Perhaps this should say "normalized by committablectx.__init__". changelog.py > normalizes ext

Re: [PATCH] committablectx: extra is already normalized

2017-06-02 Thread Yuya Nishihara
On Wed, 31 May 2017 17:11:57 -0700, Jun Wu wrote: > Looks good to me. I'd mention extra is normalized by "changelog.add" in > commit message. Perhaps this should say "normalized by committablectx.__init__". changelog.py normalizes extra in inverse direction. > Excerpts from Sean Farley's message

Re: [PATCH] committablectx: extra is already normalized

2017-06-01 Thread Augie Fackler
On Wed, May 31, 2017 at 03:54:24PM -0700, Sean Farley wrote: > # HG changeset patch > # User Sean Farley > # Date 1494535870 25200 > # Thu May 11 13:51:10 2017 -0700 > # Branch wctxds > # Node ID 60b3e8946da728c377a3a6aadb785ae308084614 > # Parent 5313d98089f569efffaca25de60e73be04156713 > c

Re: [PATCH] committablectx: extra is already normalized

2017-05-31 Thread Sean Farley
Jun Wu writes: > Looks good to me. I'd mention extra is normalized by "changelog.add" in > commit message. Sounds like a good idea; could a reviewer add that? Or should I send a V2? signature.asc Description: PGP signature ___ Mercurial-devel mailing

Re: [PATCH] committablectx: extra is already normalized

2017-05-31 Thread Jun Wu
Looks good to me. I'd mention extra is normalized by "changelog.add" in commit message. Excerpts from Sean Farley's message of 2017-05-31 15:54:24 -0700: > # HG changeset patch > # User Sean Farley > # Date 1494535870 25200 > # Thu May 11 13:51:10 2017 -0700 > # Branch wctxds > # Node ID 60b

[PATCH] committablectx: extra is already normalized

2017-05-31 Thread Sean Farley
# HG changeset patch # User Sean Farley # Date 1494535870 25200 # Thu May 11 13:51:10 2017 -0700 # Branch wctxds # Node ID 60b3e8946da728c377a3a6aadb785ae308084614 # Parent 5313d98089f569efffaca25de60e73be04156713 committablectx: extra is already normalized Avoid doing the same work again.