[PATCH] obscache: use _readmarkers() from core with correct signature

2017-08-22 Thread Martin von Zweigbergk via Mercurial-devel
# HG changeset patch # User Martin von Zweigbergk # Date 1503424759 25200 # Tue Aug 22 10:59:19 2017 -0700 # Node ID efc4b69aecfb3b407ca362cff31805e9672c # Parent 95470e817c00b03fcf99e486412cc7d7f0116681 obscache: use _readmarkers() from core with correct signature The copied _readmarke

Re: [PATCH] obscache: use _readmarkers() from core with correct signature

2017-08-23 Thread Boris Feld
The patch seems fine. Could you move the _readmarkers function definition inside the if/else, flake8 and pyflakes are complaining: +  hgext3rd/evolve/obscache.py:133:5: F811 redefinition of unused '_readmarkers' from line 115 How did you detect it? Did you call _readmarkers from another extension

Re: [PATCH] obscache: use _readmarkers() from core with correct signature

2017-08-23 Thread Martin von Zweigbergk via Mercurial-devel
On Aug 23, 2017 1:36 AM, "Boris Feld" wrote: The patch seems fine. Could you move the _readmarkers function definition inside the if/else, flake8 and pyflakes are complaining: + hgext3rd/evolve/obscache.py:133:5: F811 redefinition of unused '_readmarkers' from line 115 Ok, will do. How did

Re: [PATCH] obscache: use _readmarkers() from core with correct signature

2017-08-23 Thread Boris Feld
On Wed, 2017-08-23 at 06:06 -0700, Martin von Zweigbergk wrote: > On Aug 23, 2017 1:36 AM, "Boris Feld" wrote: > The patch seems fine. Could you move the _readmarkers function > > definition inside the if/else, flake8 and pyflakes are complaining: > > > > +  hgext3rd/evolve/obscache.py:133:5: