On 11/27/16, 9:10 AM, "Mercurial-devel on behalf of Yuya Nishihara"
wrote:
On Sat, 26 Nov 2016 09:14:46 -0800, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc
> # Date 1480180481 28800
> # Sat Nov 26 09:14:41 2016 -0800
> # Node ID ace32ef8bb5a166
On Sat, 26 Nov 2016 09:14:46 -0800, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc
> # Date 1480180481 28800
> # Sat Nov 26 09:14:41 2016 -0800
> # Node ID ace32ef8bb5a16683e0312d38e4ff5aa9abfc911
> # Parent 906a7d8e969552536fffe0df7a5e63bf5d79b34b
> ui: use try..finally
Looks good to me. Thanks for the cleanup! (I was thinking about adding a
review comment only to find it was pushed).
Excerpts from Gregory Szorc's message of 2016-11-26 09:14:46 -0800:
> # HG changeset patch
> # User Gregory Szorc
> # Date 1480180481 28800
> # Sat Nov 26 09:14:41 2016 -0800
# HG changeset patch
# User Gregory Szorc
# Date 1480180481 28800
# Sat Nov 26 09:14:41 2016 -0800
# Node ID ace32ef8bb5a16683e0312d38e4ff5aa9abfc911
# Parent 906a7d8e969552536fffe0df7a5e63bf5d79b34b
ui: use try..finally in configoverride
@contextmanager almost always have their "yield" ins