Re: [PATCH] xdiff: fix a hard crash on Windows

2018-03-13 Thread Yuya Nishihara
On Mon, 12 Mar 2018 18:55:26 -0700, Jun Wu wrote: > Looks good. Thanks for fixing this! > > Excerpts from Matt Harbison's message of 2018-03-12 21:53:12 -0400: > > # HG changeset patch > > # User Matt Harbison > > # Date 1520905818 14400 > > # Mon Mar 12 21:50:18 2018 -0400 > > # Node ID 60b

Re: [PATCH] xdiff: fix a hard crash on Windows

2018-03-12 Thread Matt Harbison
On Mon, 12 Mar 2018 21:55:26 -0400, Jun Wu wrote: Looks good. Thanks for fixing this! Do you think it's worth changing the few other instances of long over to uint64? If nothing else, it will be unconditionally 64 bit ops. But I'm not sure what else you have pending. (I think I saw you

Re: [PATCH] xdiff: fix a hard crash on Windows

2018-03-12 Thread Jun Wu
Looks good. Thanks for fixing this! Excerpts from Matt Harbison's message of 2018-03-12 21:53:12 -0400: > # HG changeset patch > # User Matt Harbison > # Date 1520905818 14400 > # Mon Mar 12 21:50:18 2018 -0400 > # Node ID 60bb2f7dd9ba313f96374470e8419bf1a20454a1 > # Parent aed445748c788548

[PATCH] xdiff: fix a hard crash on Windows

2018-03-12 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1520905818 14400 # Mon Mar 12 21:50:18 2018 -0400 # Node ID 60bb2f7dd9ba313f96374470e8419bf1a20454a1 # Parent aed445748c7885482cd90e56e81f57a13d4ac95c xdiff: fix a hard crash on Windows The xdiff case of test-diff-antipatience.t started crash