Re: [PATCH] xdiff: fix trivial build warnings on Windows

2018-03-09 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2018-03-08 21:33:42 +0900: > On Tue, 6 Mar 2018 19:12:26 -0800, Jun Wu wrote: > > Yeah, xdiff needs a migration from using "long", "int"s to "size_t" etc. > > The git community has chosen to disallow diff >1GB files because of the > > overflow concern [1].

Re: [PATCH] xdiff: fix trivial build warnings on Windows

2018-03-08 Thread Matt Harbison
> On Mar 8, 2018, at 7:33 AM, Yuya Nishihara wrote: > >> On Tue, 6 Mar 2018 19:12:26 -0800, Jun Wu wrote: >> Yeah, xdiff needs a migration from using "long", "int"s to "size_t" etc. >> The git community has chosen to disallow diff >1GB files because of the >> overflow concern

Re: [PATCH] xdiff: fix trivial build warnings on Windows

2018-03-08 Thread Yuya Nishihara
On Tue, 6 Mar 2018 19:12:26 -0800, Jun Wu wrote: > Yeah, xdiff needs a migration from using "long", "int"s to "size_t" etc. > The git community has chosen to disallow diff >1GB files because of the > overflow concern [1]. > > [1]: >

Re: [PATCH] xdiff: fix trivial build warnings on Windows

2018-03-06 Thread Jun Wu
Yeah, xdiff needs a migration from using "long", "int"s to "size_t" etc. The git community has chosen to disallow diff >1GB files because of the overflow concern [1]. [1]: https://github.com/git/git/commit/dcd1742e56ebb944c4ff62346da4548e1e3be675 Excerpts from Matt Harbison's message of

Re: [PATCH] xdiff: fix trivial build warnings on Windows

2018-03-04 Thread Matt Harbison
On Sun, 04 Mar 2018 16:45:28 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1520197662 18000 # Sun Mar 04 16:07:42 2018 -0500 # Node ID c4a6b599a46f93070f5492c9e68566e6be570d2f # Parent

[PATCH] xdiff: fix trivial build warnings on Windows

2018-03-04 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1520197662 18000 # Sun Mar 04 16:07:42 2018 -0500 # Node ID c4a6b599a46f93070f5492c9e68566e6be570d2f # Parent 1f9bbd1d6b8ae4f7ea5d9f4310269a3b0242e7b0 xdiff: fix trivial build warnings on Windows These are mostly