Re: [PATCH 08 of 10 py3] localrepo: ensure transaction id is fully bytes on py3

2017-03-20 Thread Augie Fackler
> On Mar 20, 2017, at 21:18, Yuya Nishihara wrote: > >> Maybe. In this case a sha1 wrapper likely makes more sense. > > or it could be node.hex(sha1(idbase).digest()). Wow. I can't believe I missed that. Patch on the way momentarily. ___ Mercurial-de

Re: [PATCH 08 of 10 py3] localrepo: ensure transaction id is fully bytes on py3

2017-03-20 Thread Yuya Nishihara
On Mon, 20 Mar 2017 20:15:31 -0400, Augie Fackler wrote: > On Mar 20, 2017 19:52, "Martin von Zweigbergk" > wrote: > On Sun, Mar 19, 2017 at 11:26 AM, Augie Fackler wrote: > > +if pycompat.ispy3: > > +ha = ha.encode('latin1') > > Every time I see "if pycompat.ispy3:", I feel

Re: [PATCH 08 of 10 py3] localrepo: ensure transaction id is fully bytes on py3

2017-03-20 Thread Augie Fackler
On Mar 20, 2017 19:52, "Martin von Zweigbergk" wrote: On Sun, Mar 19, 2017 at 11:26 AM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1489900139 14400 > # Sun Mar 19 01:08:59 2017 -0400 > # Node ID 9e6b585465b7ec033160326a4eb049329a2f83a9 > # Parent d5e20f704

Re: [PATCH 08 of 10 py3] localrepo: ensure transaction id is fully bytes on py3

2017-03-20 Thread Martin von Zweigbergk via Mercurial-devel
On Sun, Mar 19, 2017 at 11:26 AM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1489900139 14400 > # Sun Mar 19 01:08:59 2017 -0400 > # Node ID 9e6b585465b7ec033160326a4eb049329a2f83a9 > # Parent d5e20f704fd722dbf8b0a011b3c9ab7437b4ac82 > localrepo: ensure tran

[PATCH 08 of 10 py3] localrepo: ensure transaction id is fully bytes on py3

2017-03-19 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1489900139 14400 # Sun Mar 19 01:08:59 2017 -0400 # Node ID 9e6b585465b7ec033160326a4eb049329a2f83a9 # Parent d5e20f704fd722dbf8b0a011b3c9ab7437b4ac82 localrepo: ensure transaction id is fully bytes on py3 diff --git a/mercurial/localrepo.py