Re: [PATCH 2 of 2] run-tests: use context managers for file descriptors

2017-12-18 Thread Yuya Nishihara
On Mon, 18 Dec 2017 10:44:31 +0100, Boris Feld wrote: > The patches looks good to me, but I'm not an expert in the Windows > world. > > On Sun, 2017-12-17 at 17:25 -0500, Matt Harbison wrote: > > # HG changeset patch > > # User Matt Harbison > > # Date 1513537609 18000 > > #  Sun Dec 17 14:06

Re: [PATCH 2 of 2] run-tests: use context managers for file descriptors

2017-12-18 Thread Boris Feld
The patches looks good to me, but I'm not an expert in the Windows world. On Sun, 2017-12-17 at 17:25 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1513537609 18000 > #  Sun Dec 17 14:06:49 2017 -0500 > # Node ID f59e9334c838da4834a043d109ddfad1f7bfa8ea >

[PATCH 2 of 2] run-tests: use context managers for file descriptors

2017-12-17 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1513537609 18000 # Sun Dec 17 14:06:49 2017 -0500 # Node ID f59e9334c838da4834a043d109ddfad1f7bfa8ea # Parent 5185939f98c5c5e4383eebfa9694a522e6279648 run-tests: use context managers for file descriptors I've seen the following error a few ti