Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

Patch here: https://phab.mercurial-scm.org/D1699 On Thu, Dec 14, 2017 at 10:02 PM, Martin von Zweigbergk wrote: > On Thu, Dec 14, 2017 at 8:57 PM, Kevin Bullock > wrote: >>> On Dec 14, 2017, at 22:55, Martin von Zweigbergk

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

On Thu, Dec 14, 2017 at 8:57 PM, Kevin Bullock wrote: >> On Dec 14, 2017, at 22:55, Martin von Zweigbergk >> wrote: >> >> Could you point me to the build output? > >

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

> On Dec 14, 2017, at 22:55, Martin von Zweigbergk > wrote: > > Could you point me to the build output? https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1361/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio > Do you also know which shell is used by it?

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

Could you point me to the build output? Do you also know which shell is used by it? On Thu, Dec 14, 2017 at 8:50 PM, Kevin Bullock wrote: >> On Dec 13, 2017, at 12:28, Martin von Zweigbergk via Mercurial-devel >> wrote: >> >>

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

> On Dec 13, 2017, at 12:28, Martin von Zweigbergk via Mercurial-devel > wrote: > > I think the problem is in this line from the test (that you changed): > > $ echo " saved backup bundle to \$TESTTMP\foo.hg" >> test-failure.t > > The '\' there probably

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

I think the problem is in this line from the test (that you changed): $ echo " saved backup bundle to \$TESTTMP\foo.hg" >> test-failure.t The '\' there probably just needs to be escaped. It seems like at least dash and tcsh otherwise interpret it (but bash treats it literally). Proof: $ dash

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

> On Dec 13, 2017, at 12:40 AM, Martin von Zweigbergk > wrote: > > Is it this patch that broke test-run-tests.t? See > https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1357/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio. > I haven't even tried to

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

Is it this patch that broke test-run-tests.t? See https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1357/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio. I haven't even tried to verify, but Matt and I were both on the blame list for the broken build and it didn't seem related to

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

> On Dec 11, 2017, at 00:24, Matt Harbison wrote: > > On Sun, 10 Dec 2017 18:28:03 -0500, Augie Fackler wrote: > >> >>> On Dec 10, 2017, at 5:39 PM, Matt Harbison wrote: >>> >>> On Sun, 10 Dec 2017 16:48:26 -0500, Augie

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

On Sun, 10 Dec 2017 18:28:03 -0500, Augie Fackler wrote: On Dec 10, 2017, at 5:39 PM, Matt Harbison wrote: On Sun, 10 Dec 2017 16:48:26 -0500, Augie Fackler wrote: On Dec 10, 2017, at 3:47 PM, Matt Harbison

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

> On Dec 10, 2017, at 5:39 PM, Matt Harbison wrote: > > On Sun, 10 Dec 2017 16:48:26 -0500, Augie Fackler wrote: > >> >>> On Dec 10, 2017, at 3:47 PM, Matt Harbison wrote: >>> >>> # HG changeset patch >>> # User Matt Harbison

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

On Sun, 10 Dec 2017 16:48:26 -0500, Augie Fackler wrote: On Dec 10, 2017, at 3:47 PM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1512882971 18000 # Sun Dec 10 00:16:11 2017 -0500 # Node ID

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

> On Dec 10, 2017, at 3:47 PM, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date 1512882971 18000 > # Sun Dec 10 00:16:11 2017 -0500 > # Node ID ebc7a05d9389989fc2e81d30fa1c10dd01be9a76 > # Parent

[PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

# HG changeset patch # User Matt Harbison # Date 1512882971 18000 # Sun Dec 10 00:16:11 2017 -0500 # Node ID ebc7a05d9389989fc2e81d30fa1c10dd01be9a76 # Parent e1119050f15e2169ac766e6a69eeab70729e9e40 run-tests: accept '\' vs '/' path differences without '(glob)'