# HG changeset patch
# User Jun Wu
# Date 1481900282 0
# Fri Dec 16 14:58:02 2016 +
# Node ID 8fe60192f17f6ae99fa66c6bce1ec306772e31df
# Parent eb3017f14d56dfdc9870b06a684ef9bcf7a030e6
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https://bitbucket.org/qu
On Fri, 16 Dec 2016 15:01:21 +, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu
> # Date 1481900282 0
> # Fri Dec 16 14:58:02 2016 +
> # Node ID 8fe60192f17f6ae99fa66c6bce1ec306772e31df
> # Parent eb3017f14d56dfdc9870b06a684ef9bcf7a030e6
> # Available At https://bitbucket.org/qu
Excerpts from Yuya Nishihara's message of 2016-12-18 17:30:31 +0900:
> On Fri, 16 Dec 2016 15:01:21 +, Jun Wu wrote:
> > # HG changeset patch
> > # User Jun Wu
> > # Date 1481900282 0
> > # Fri Dec 16 14:58:02 2016 +
> > # Node ID 8fe60192f17f6ae99fa66c6bce1ec306772e31df
> > # Parent
On Sun, 18 Dec 2016 18:24:45 +, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2016-12-18 17:30:31 +0900:
> > On Fri, 16 Dec 2016 15:01:21 +, Jun Wu wrote:
> > > # HG changeset patch
> > > # User Jun Wu
> > > # Date 1481900282 0
> > > # Fri Dec 16 14:58:02 2016 +
> > >
Excerpts from Yuya Nishihara's message of 2016-12-19 23:46:26 +0900:
> On Sun, 18 Dec 2016 18:24:45 +, Jun Wu wrote:
> > The direction is to eventually lose control on "ui" used in runcommand, and
> > let dispatch construct a "ui" object on its own.
>
> I got it.
>
> > And we then use a speci
On Mon, 19 Dec 2016 16:32:16 +, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2016-12-19 23:46:26 +0900:
> > On Sun, 18 Dec 2016 18:24:45 +, Jun Wu wrote:
> > > The direction is to eventually lose control on "ui" used in runcommand,
> > > and
> > > let dispatch construct a "ui"
Excerpts from Yuya Nishihara's message of 2016-12-20 21:47:23 +0900:
> On Mon, 19 Dec 2016 16:32:16 +, Jun Wu wrote:
> > Excerpts from Yuya Nishihara's message of 2016-12-19 23:46:26 +0900:
> > > On Sun, 18 Dec 2016 18:24:45 +, Jun Wu wrote:
> > > > The direction is to eventually lose contr
On Tue, 20 Dec 2016 14:03:04 +, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2016-12-20 21:47:23 +0900:
> > BTW, is there any reason we have to delay the uisetup() call? I think we can
> > just set req.ui in place of req.uisetup:
> >
> > class chgui(uimod.ui):
> > ...
> >
Excerpts from Yuya Nishihara's message of 2016-12-20 23:29:17 +0900:
> On Tue, 20 Dec 2016 14:03:04 +, Jun Wu wrote:
> > Excerpts from Yuya Nishihara's message of 2016-12-20 21:47:23 +0900:
> > > BTW, is there any reason we have to delay the uisetup() call? I think we
> > > can
> > > just set
On Tue, 20 Dec 2016 16:46:38 +, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2016-12-20 23:29:17 +0900:
> > On Tue, 20 Dec 2016 14:03:04 +, Jun Wu wrote:
> > > Excerpts from Yuya Nishihara's message of 2016-12-20 21:47:23 +0900:
> > > > BTW, is there any reason we have to delay
On Tue, 20 Dec 2016 14:03:04 +, Jun Wu wrote:
> So uisetup is still necessary to wrap _runpager. The _wrapui change is
> unnecessary if we use your proposal. In that case, both Patch 2 and 4 can be
> dropped and Patch 1 and 3 are useful.
I've queued 1 and 3, thanks.
___
Excerpts from Yuya Nishihara's message of 2016-12-21 23:15:28 +0900:
> On Tue, 20 Dec 2016 14:03:04 +, Jun Wu wrote:
> > So uisetup is still necessary to wrap _runpager. The _wrapui change is
> > unnecessary if we use your proposal. In that case, both Patch 2 and 4 can be
> > dropped and Patch
On Wed, 21 Dec 2016 15:39:05 +, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2016-12-21 23:15:28 +0900:
> > On Tue, 20 Dec 2016 14:03:04 +, Jun Wu wrote:
> > > So uisetup is still necessary to wrap _runpager. The _wrapui change is
> > > unnecessary if we use your proposal. In t
> On Dec 20, 2016, at 11:46, Jun Wu wrote:
>
> The pager API has 2 levels:
>
> - high-level (pagecmd): decide the command of the pager, call low-level
> - low-level (_runpager): accept a command and run it unconditionally
>
> I think ui.pager() should be high-level, and chg only wants to rep
14 matches
Mail list logo
