Re: [PATCH 6 of 6 V2] py3: add test to show `hg update` and `hg identify` works on Python 3

2017-06-02 Thread Yuya Nishihara
On Fri, 02 Jun 2017 12:33:14 +0200, Boris Feld wrote: > I read the serie, it looks good! > > I love the idea about the dict.update to avoid gc churns. > > On Fri, 2017-06-02 at 14:16 +0530, Pulkit Goyal wrote: > > # HG changeset patch > > # User Pulkit Goyal <7895pul...@gmail.com> > > # Date 1496

Re: [PATCH 6 of 6 V2] py3: add test to show `hg update` and `hg identify` works on Python 3

2017-06-02 Thread Boris Feld
I read the serie, it looks good! I love the idea about the dict.update to avoid gc churns. On Fri, 2017-06-02 at 14:16 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1496265079 -19800 > #  Thu Jun 01 02:41:19 2017 +0530 > # Node ID 3331

[PATCH 6 of 6 V2] py3: add test to show `hg update` and `hg identify` works on Python 3

2017-06-02 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1496265079 -19800 # Thu Jun 01 02:41:19 2017 +0530 # Node ID 33317f49a756894824ccc799efa0e7473aeb275c # Parent f6a8bfcf09665b66f0698c0a0f40d48212da9458 py3: add test to show `hg update` and `hg identify` works on Python 3