Re: [PATCH 7 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

2019-10-13 Thread Georges Racinet
On 10/13/19 2:37 PM, Yuya Nishihara wrote: > On Sun, 13 Oct 2019 14:08:24 +0200, Georges Racinet wrote: >>> +py_capsule_fn!( >>> +from mercurial.cext.parsers import index_get_parents_CAPI >>> +as get_parents_capi >>> +signature ( >>> +index: *mut python_sys::PyObject

Re: [PATCH 7 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

2019-10-13 Thread Yuya Nishihara
On Sun, 13 Oct 2019 14:08:24 +0200, Georges Racinet wrote: > > +py_capsule_fn!( > > +from mercurial.cext.parsers import index_get_parents_CAPI > > +as get_parents_capi > > +signature ( > > +index: *mut python_sys::PyObject, > > Here you can directly use RawPyObject:

Re: [PATCH 7 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

2019-10-13 Thread Georges Racinet
Hi, I don't have time for a formal review right now, but I did skim over the series, and I think it can be simplified and pushed further, removing the whole sys_python dependency (see the inline comment below) Actually I have a series of my own in the works to the same effect, i.e., leveraging th

[PATCH 7 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

2019-10-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1570954064 -32400 # Sun Oct 13 17:07:44 2019 +0900 # Node ID 6c8410bd4ce786ceca53986514a1fbda5f097f2d # Parent 2d7671cc1d717f3ed3890e47324e4ed479529466 rust-cpython: leverage upstreamed py_capsule_fn!() macro diff --git a/rust/hg-cpython/src