Re: [PATCH 7 of 7 v2] bdiff: give slight preference to removing trailing lines

2016-11-27 Thread Jun Wu
I think that's "shift_boundaries" in GNU diffutils' "src/analyze.c": /* Adjust inserts/deletes of identical lines to join changes as much as possible. static void shift_boundaries (struct file_data filevec[]) Git's xdiffi.c does something similar. Excerpts from Mike Hommey's

Re: [PATCH 7 of 7 v2] bdiff: give slight preference to removing trailing lines

2016-11-25 Thread Jun Wu
Excerpts from Mads Kiilerich's message of 2016-11-25 15:58:28 +0100: > On 11/24/2016 06:52 PM, Jun Wu wrote: > > Excerpts from Augie Fackler's message of 2016-11-17 12:42:26 -0500: > >> My own cursory perfbdiff runs suggest this is a perf wash (using > >> `perfbdiff -m 3041e4d59df2` in the mozilla

Re: [PATCH 7 of 7 v2] bdiff: give slight preference to removing trailing lines

2016-11-25 Thread Mads Kiilerich
On 11/24/2016 06:52 PM, Jun Wu wrote: Excerpts from Augie Fackler's message of 2016-11-17 12:42:26 -0500: My own cursory perfbdiff runs suggest this is a perf wash (using `perfbdiff -m 3041e4d59df2` in the mozilla repo). Queued. Thanks! I'd mention this series changes the behavior of the diff o

Re: [PATCH 7 of 7 v2] bdiff: give slight preference to removing trailing lines

2016-11-24 Thread Mike Hommey
On Thu, Nov 24, 2016 at 05:52:29PM +, Jun Wu wrote: > Excerpts from Augie Fackler's message of 2016-11-17 12:42:26 -0500: > > My own cursory perfbdiff runs suggest this is a perf wash (using > > `perfbdiff -m 3041e4d59df2` in the mozilla repo). Queued. Thanks! > > I'd mention this series chang

Re: [PATCH 7 of 7 v2] bdiff: give slight preference to removing trailing lines

2016-11-24 Thread Gregory Szorc
On Thu, Nov 24, 2016 at 9:52 AM, Jun Wu wrote: > Excerpts from Augie Fackler's message of 2016-11-17 12:42:26 -0500: > > My own cursory perfbdiff runs suggest this is a perf wash (using > > `perfbdiff -m 3041e4d59df2` in the mozilla repo). Queued. Thanks! > > I'd mention this series changes the b

Re: [PATCH 7 of 7 v2] bdiff: give slight preference to removing trailing lines

2016-11-24 Thread Jun Wu
Excerpts from Augie Fackler's message of 2016-11-17 12:42:26 -0500: > My own cursory perfbdiff runs suggest this is a perf wash (using > `perfbdiff -m 3041e4d59df2` in the mozilla repo). Queued. Thanks! I'd mention this series changes the behavior of the diff output. The difference was caught by f

Re: [PATCH 7 of 7 v2] bdiff: give slight preference to removing trailing lines

2016-11-17 Thread Augie Fackler
On Tue, Nov 15, 2016 at 09:57:08PM +0100, Mads Kiilerich wrote: > # HG changeset patch > # User Mads Kiilerich > # Date 1479243409 -3600 > # Tue Nov 15 21:56:49 2016 +0100 > # Node ID efa30442953a6e1f096f8833c4ee8047375600d6 > # Parent e022e995415bd48ffe6d4d03dc97b99dd547cde1 > bdiff: give s

[PATCH 7 of 7 v2] bdiff: give slight preference to removing trailing lines

2016-11-15 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1479243409 -3600 # Tue Nov 15 21:56:49 2016 +0100 # Node ID efa30442953a6e1f096f8833c4ee8047375600d6 # Parent e022e995415bd48ffe6d4d03dc97b99dd547cde1 bdiff: give slight preference to removing trailing lines [This change could be folded into