Re: [PATCH V2] perf: add asv benchmarks

2016-11-15 Thread Philippe Pepiot
On 11/14/2016 11:02 AM, Jun Wu wrote: Generally looks good to me. Some inline comments about small issues. I wonder if it is possible to get rid of the dependencies on virtualenv and hglib as installing them could be troublesome in some environments. I think "virtualenv" could be replaced by ju

Re: [PATCH V2] perf: add asv benchmarks

2016-11-14 Thread Jun Wu
Generally looks good to me. Some inline comments about small issues. I wonder if it is possible to get rid of the dependencies on virtualenv and hglib as installing them could be troublesome in some environments. I think "virtualenv" could be replaced by just copying the checked out files to somew

Re: [PATCH V2] perf: add asv benchmarks

2016-11-03 Thread Philippe Pepiot
On 11/03/2016 04:58 PM, Philippe Pepiot wrote: # HG changeset patch # User Philippe Pepiot # Date 1475136994 -7200 # Thu Sep 29 10:16:34 2016 +0200 # Node ID 67e096cea548a37ba80ddf04e62a1cc1d50e9c96 # Parent b032a7b676c6637b2ac6f3ef29431013b15a08f9 perf: add asv benchmarks Here is my ow

[PATCH V2] perf: add asv benchmarks

2016-11-03 Thread Philippe Pepiot
# HG changeset patch # User Philippe Pepiot # Date 1475136994 -7200 # Thu Sep 29 10:16:34 2016 +0200 # Node ID 67e096cea548a37ba80ddf04e62a1cc1d50e9c96 # Parent b032a7b676c6637b2ac6f3ef29431013b15a08f9 perf: add asv benchmarks Airspeed velocity (ASV) is a python framework for benchmarking P