ryanmce added a comment.
queued
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1016
To: pulkit, #hg-reviewers, ryanmce
Cc: ryanmce, dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG586645e0589c: repoview: remove incorrect documentation of
the function (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1016?vs
pulkit requested review of this revision.
pulkit added a comment.
In https://phab.mercurial-scm.org/D1016#17086, @ryanmce wrote:
> I agree that removing is better than leaving bad docs, so I'm +1 on this,
but as @dlax suggests, improving it would be even better.
>
> If you don't have
ryanmce requested changes to this revision.
ryanmce added a comment.
This revision now requires changes to proceed.
I agree that removing is better than leaving bad docs, so I'm +1 on this, but
as @dlax suggests, improving it would be even better.
If you don't have ideas on how to improve
dlax added inline comments.
INLINE COMMENTS
> repoview.py:104
> -
> -Secret and hidden changeset should not pretend to be here."""
> assert not repo.changelog.filteredrevs
Maybe update the docstring instead of removing?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercuri
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In repoview.py, computeunserved() and computemutable() functions had the same
documentation. The documentation of computemutable() is wrong. I was unable to
write
