D1019: logtoprocess: do not use platform.system()

2017-10-13 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG68ed3b4f86ef: logtoprocess: do not use platform.system() (authored by quark, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D1019?vs=2606=2678#toc REPOSITORY rHG Mercurial

D1019: logtoprocess: do not use platform.system()

2017-10-12 Thread quark (Jun Wu)
quark requested review of this revision. quark added a comment. It's changed by https://phab.mercurial-scm.org/D1034. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1019 To: quark, #hg-reviewers, ryanmce Cc: ryanmce, mercurial-devel

D1019: logtoprocess: do not use platform.system()

2017-10-12 Thread ryanmce (Ryan McElroy)
ryanmce requested changes to this revision. ryanmce added a comment. This revision now requires changes to proceed. I'm +1 on this direction but think we shouldn't `have == 'nt'` as the "is this windows?" check here. INLINE COMMENTS > logtoprocess.py:55 > def uisetup(ui): > -if

D1019: logtoprocess: do not use platform.system()

2017-10-11 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY See the previous patch for the reason. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1019 AFFECTED FILES hgext/logtoprocess.py