D1021: check-code: forbid platform.system()

2017-10-13 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa679aa582d8d: check-code: forbid platform.system() (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1021?vs=2634=2680 REVISION

D1021: check-code: forbid platform.system()

2017-10-12 Thread quark (Jun Wu)
quark updated this revision to Diff 2634. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1021?vs=2608=2634 REVISION DETAIL https://phab.mercurial-scm.org/D1021 AFFECTED FILES contrib/check-code.py CHANGE DETAILS diff --git a/contrib/check-code.py

D1021: check-code: forbid platform.system()

2017-10-12 Thread ryanmce (Ryan McElroy)
ryanmce added a comment. +1 to this change, happy to land this once my comments on the series are addressed REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1021 To: quark, #hg-reviewers, lothiraldan Cc: ryanmce, lothiraldan, mercurial-devel

D1021: check-code: forbid platform.system()

2017-10-12 Thread lothiraldan (Boris Feld)
lothiraldan accepted this revision. lothiraldan added a comment. LGTM but I can't validate the Mac OS and Windows tests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1021 To: quark, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel

D1021: check-code: forbid platform.system()

2017-10-11 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY See the previous patches for the reason. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1021 AFFECTED FILES contrib/check-code.py