D1117: config: simplify aliasing commands.update.check

2017-10-17 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc4a0480d1951: config: simplify aliasing commands.update.check (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1117?vs=289

D1117: config: simplify aliasing commands.update.check

2017-10-17 Thread ryanmce (Ryan McElroy)
ryanmce added a comment. queued REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1117 To: lothiraldan, #hg-reviewers, durin42, ryanmce Cc: ryanmce, durin42, mercurial-devel ___ Mercurial-devel mailing list Mercurial-deve

D1117: config: simplify aliasing commands.update.check

2017-10-17 Thread ryanmce (Ryan McElroy)
ryanmce accepted this revision. ryanmce added a comment. I agree with @lothiraldan that there's no pressing need to remove aliases, and we should have a mechanism to work before we do this for sure. This seems like exactly one of the reasons the config registration system was built in t

D1117: config: simplify aliasing commands.update.check

2017-10-17 Thread lothiraldan (Boris Feld)
lothiraldan marked an inline comment as done. lothiraldan added a comment. I've added the comment, but I think we should keep the alias until we have a way to warn people they use deprecated config aliases. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1117 To

D1117: config: simplify aliasing commands.update.check

2017-10-17 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 2898. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1117?vs=2826&id=2898 REVISION DETAIL https://phab.mercurial-scm.org/D1117 AFFECTED FILES mercurial/configitems.py mercurial/hg.py CHANGE DETAILS diff --

D1117: config: simplify aliasing commands.update.check

2017-10-16 Thread durin42 (Augie Fackler)
durin42 requested changes to this revision. durin42 added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > configitems.py:184 > default=None, > +alias=[('experimental', 'updatecheck')] > ) Please add the comment that this alias should be discarded post-

D1117: config: simplify aliasing commands.update.check

2017-10-16 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY experimental.updatecheck was renamed into commands.update.check, use the config system to provides the fallback on the old config name instead of adding more