D1191: obsfate: makes successorsetverb takes the markers as argument

2017-10-19 Thread krbullock (Kevin Bullock)
krbullock added a comment. Deferring this until after 4.4, because the added `markers` argument isn't used yet. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1191 To: lothiraldan, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D1191: obsfate: makes successorsetverb takes the markers as argument

2017-10-19 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > krbullock wrote in templater.py:1011 > Needs an update to the `@templatefunc(...)` decoration above too. Done REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1191 To: lothiraldan, #hg-reviewers, krbullock Cc:

D1191: obsfate: makes successorsetverb takes the markers as argument

2017-10-19 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 3042. lothiraldan marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1191?vs=3027=3042 REVISION DETAIL https://phab.mercurial-scm.org/D1191 AFFECTED FILES mercurial/obsutil.py

D1191: obsfate: makes successorsetverb takes the markers as argument

2017-10-19 Thread krbullock (Kevin Bullock)
krbullock requested changes to this revision. krbullock added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > templater.py:1011 > """Compute obsfate related information based on successors > (EXPERIMENTAL)""" > -if len(args) != 1: > +if len(args)

D1191: obsfate: makes successorsetverb takes the markers as argument

2017-10-19 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Right now, successorsetverb only needs successors to compute the verb. But we will want use additional information (effect-flags and operation) in the near